- 15 Apr, 2020 40 commits
-
-
Etienne Pierre-doray authored
This CL implements NativeUnwinderAndroid & tests for android unwinding support. It also enables StackSamplingProfilerTest on Android. A new target source_set is added, native_unwinder_android that contains NativeUnwinderAndroid. StackSamplingProfilerTest depends on it for android. Bug: 989102 Change-Id: Ie38fd99ca5fb053e1881d0977924b70a6fbc1e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055743 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#759283}
-
Rayan Kanso authored
Bug: 1037427, 1066031 Change-Id: I522622a907938c8b4a7ada8091b2ed4dfd1d6535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148739 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#759282}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dc0359178572..e6e3bfad73cf git log dc0359178572..e6e3bfad73cf --date=short --first-parent --format='%ad %ae %s' 2020-04-15 sigurds@chromium.org [devtools] Refactor issue displaying 2020-04-15 tvanderlippe@chromium.org Fix ES module import linter for module entrypoints Created with: gclient setdep -r src/third_party/devtools-frontend/src@e6e3bfad73cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1ce00f1873e61ab2ad61dc3a4c96e559b11c14e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150611Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759281}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2cc24537de78..60af4efbe0e2 git log 2cc24537de78..60af4efbe0e2 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 lalitm@google.com tp: move module code to importers 2020-04-15 lalitm@google.com tp: add importers build file and create common target 2020-04-15 lalitm@google.com Merge "tp: move util related sources to util build file" 2020-04-15 lalitm@google.com Merge "tp: move descriptor pool, proto conv and status macros -> util" 2020-04-15 fmayer@google.com Merge "Move /proc/self/stat parser to function." 2020-04-15 lalitm@google.com Merge "tp: move event, clock, hprofile and slice trackers -> importers/common" 2020-04-15 lalitm@google.com Merge "tp: move metadata, perf sample and stack trackers to improters/proto" 2020-04-15 lalitm@google.com Merge "tp: move remaining custom sqlite tables to sqlite/" 2020-04-15 ilkos@google.com Merge "Parse OOM reaper kills" Created with: gclient setdep -r src/third_party/perfetto@60af4efbe0e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7f678ce1f40141b7f01209789904eddcc8e163e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150614Reviewed-by:
-
edchin authored
This CL simply replaces about a dozen uses of @"bookmark_context_menu" with a constant accessibility identifier in bookmark_ui_constants.h. Change-Id: Ibbfb86930cb09035ff271f83e5971dbc35f1c717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146288Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759279}
-
George Steel authored
Refactor the two methods in ComputedStyleUtils for serializing transformation matrix values (ValueforMatrixTransform and part of ValueForTransformOperation) into a single method ValueForTransformationMatrix which takes a parameter controlling whether to force matrix3d serialization. This method uses the implementation from ValueForTransformOperation verbatim. Start a unit test suite for ComputedStyleUtils with tests for ValueForTransformationMatrix testing the zoom and force_matrix3d parameters. As such ComputedStyleUtils has been made CORE_EXPORT so that unit tests can link to it. This causes no behavioral change. Change-Id: If1c0727dc80caff77b77d9611bdeb613a96601ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133366Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#759278}
-
Hans Wennborg authored
Bug: 1071058, 1031540 Change-Id: I9a8e9abed41a65e5571acc1b86f30adfd3e35c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150593 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#759277}
-
Becca Hughes authored
Add method to check media feed items against safesearch and store the result. BUG=1066643 Change-Id: I9779c7fdde6916f47afd60f4d5efd379853f03cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135875Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#759276}
-
Alex Ilin authored
This reverts commit 4fdc53d7. Reason for revert: EntitySuggestionProcessorUnitTest.DecorationTest* crashing on android-pie-x86-rel https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/b8882995499559718496 Original change's description: > Convert omnibox/suggestions from String URLs to GURL > > Converting String URLs to GURL also required moving some tests from > junit to native java unittests, as GURL requires the native library to > be loaded. > > Bug: 783819 > Change-Id: Id574a15715effe1845d2cfa50f698461b83bb5b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071376 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759074} TBR=palmer@chromium.org,mthiesse@chromium.org,jdonnelly@chromium.org,tedchoc@chromium.org Change-Id: Ia5f91b532a787816ef55bb7d62dd3bb44898564c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783819, 1071092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150705Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759275}
-
Maksim Moskvitin authored
Corresponding investigation is completed. This CL marks histogram as obsolete and removes instrumentation code. Bug: 1053169 Change-Id: Id0d9495ff7da2364967afdb5adb50f1aa54748b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141923Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#759274}
-
Sami Kyostila authored
This patch makes WebScopedVirtualTimePauser avoid emitting trace events if virtual time is disabled. Bug: 1069603 Change-Id: I14bfe21bcd67f325018ffeec1d17e01fe2f1dde0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144143 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#759273}
-
Abhijeet Kandalkar authored
Migrate this test out of t_p/blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749, 767015 Change-Id: I45374678b3f35b7f41d99e94445a372d5e90d232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145529 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#759272}
-
Ian Kilpatrick authored
Previously we considered any legacy layout root as potentially having %-dependent descendants. This typically wasn't an issue for when we first rolled out LayoutNG as it was relatively common for *something* to stop the propagation of this bit up the tree. With FlexNG however, we run into far more cases due to the "definiteness" potentially changing. This patch treats images, svgs, etc has having no children for the purposes of this calculation. Bug: 845235 Change-Id: I98648b8182fd549d6e6bee1167cd8ae89d55687b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148216 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759271}
-
Alice Wang authored
This CL inlines the rarely used method AccountManagerFacade.hasAccountForName to simplify the AccountManagerFacade API. Bug: 1057040 Change-Id: I6f1e37f1fde574bc561db9efe16e134924191118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146551Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759270}
-
Yuki Shiino authored
Firefox, Safari, and Chrome agree the behavior of history.state === popStateEvent.state so update the test case accordingly. IIUC, HTML also requires this behavior. https://html.spec.whatwg.org/C/#history-traversal:dom-history-state step 13. Set history.state to state. step 16.1. If state changed is true, then fire an event named popstate at the Document object's relevant global object, using PopStateEvent, with the state attribute initialized to state. where |state| is the result of StructuredDeserialize, so it's expected that history.state === popStateEvent.state. Bug: 1070938 Change-Id: I161e415ce986be56031080e1538a0d4ac4fbf133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147169Reviewed-by:Domenic Denicola <domenic@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#759269}
-
Wez authored
The test's failure-mode is to timeout, but because it repeatedly ran new RunLoops for each DumpLogs() call, it would take ~6 minutes to timeout, and then be terminated by the TestLauncher. Fix the test to use a single RunLoop, so that it will timeout within ~10 seconds in case of failure. Bug: 1070686 Change-Id: I054a6b6142835122b2a5f1fee18a189a78392a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146902 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#759268}
-
Vasilii Sukhanov authored
Mocks: https://docs.google.com/presentation/d/1yWuZO-fjXhdRp64nWRbnHEyzpFd1KOMS3u1_1XMdGuA/edit#slide=id.g7c9229dfe2_22_49 Bug: 1049200 Change-Id: Ifa3e6e0211fb9ed9c4f81ec77d460c6970f5ee97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144017 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#759267}
-
Majid Valipour authored
Implement basic element-based offset calculation taking edge and threshold into account. Test: external/wpt/scroll-animations/element-based-offset.html Bug: 1023375 Change-Id: I38caf32e775e6827a9b7d8763bb7cf9c86fc29c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100887Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#759266}
-
Adam Langley authored
This reverts commit 72d0f390. Path to BLEHandler_jni.h in cablev2_authenticator_android.cc wasn't updated to remove 'internal', but the old generated file was still on disk for nearly all the builders. Original change's description: > Revert "Move caBLE v2 authenticator to a dynamic module." > > This reverts commit e7ea3e9e. > > Reason for revert: causing compile failure > https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/10837? > > Original change's description: > > Move caBLE v2 authenticator to a dynamic module. > > > > By moving the authenticator code to a dynamic module we eliminate > > code-size concerns in the base module for a feature that is flag > > protected and, for a while at the very least, will be used by a tiny > > fraction of users. > > > > BUG=1002262 > > > > Change-Id: I9418d7873091741e189629755033842023166ed6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145759 > > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > > Reviewed-by: Ilya Sherman <isherman@chromium.org> > > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > > Commit-Queue: Adam Langley <agl@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#758880} > > TBR=agl@chromium.org,isherman@chromium.org,martinkr@google.com,fhorschig@chromium.org,tiborg@chromium.org > > Change-Id: I535fa461c641edd4ba2a41d94f2fccf828cecb71 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1002262 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148818 > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758913} TBR=xhwang@chromium.org,agl@chromium.org,isherman@chromium.org,martinkr@google.com,fhorschig@chromium.org,tiborg@chromium.org Change-Id: Id338c6f8c63bd9a52ea781b56f4bf69d5ab46a06 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149694Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#759265}
-
Kent Tamura authored
- Make LayoutNGMixin<LayoutRubyRun> a friend of LayoutRubyRun because LayoutNGMixin<LayoutRubyRun> accesses some private functions. - Add an Element* argument to LayoutRubyRun. LayoutNGMixin assumes that the constructor of its base class has an Element* argument. - The layout behavior of LayoutRubyRun is not implemented yet in LayoutNGRubyRun. This CL has no behavior changes because changes are behind a runtime flag. Bug: 1069817 Change-Id: I3b3d99e1d0b8648305ecea1b07460a893ee9e5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149737 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759264}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/43245c56b086..4a5bce96e8c2 git log 43245c56b086..4a5bce96e8c2 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 brandtr@webrtc.org Change to more idiomatic map erase. 2020-04-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 72d0f390..a775f4ae (758913:759199) Created with: gclient setdep -r src/third_party/webrtc@4a5bce96e8c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I49861aefbbeae3a273a6212f0028ae6e922fa538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150607Reviewed-by:
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. Bug: 1068194 Change-Id: I1c4778678db95002f8af57d24b4863f4daa595fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150034 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#759262}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/55adbeb1..0e4f9cf5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2fc01b971da160d29e854b53140e4f2bbb5b5104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143839Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759261}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eb1d5a2e233c..68626439f360 git log eb1d5a2e233c..68626439f360 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 bsalomon@google.com Revert "GaussianConvolutionFragmentProcessor uses GrTextureEffect." 2020-04-15 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 dee4d7a54e44..6e0d718a48d8 (10 commits) 2020-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 8ab26431..cddb357f (417 commits) 2020-04-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 711867566999..81e08df29531 (9 commits) 2020-04-15 mtklein@google.com clean up SK_SUPPORT_LEGACY_COLORFILTER_NO_SHADER 2020-04-15 herb@google.com Fix to change reject behavior back to original 2020-04-14 mtklein@google.com MSAN fix for interpreter 2020-04-14 bsalomon@google.com GaussianConvolutionFragmentProcessor uses GrTextureEffect. 2020-04-14 bsalomon@google.com Pass description of GrSurface to GrSurfaceProxy lazy callbacks. 2020-04-14 egdaniel@google.com Only call glFlush in submit when it is required. 2020-04-14 herb@google.com Remove scheduler instruction dump 2020-04-14 herb@google.com Instruction dumper with extra notations 2020-04-14 robertphillips@google.com Add render task type to flush-time op spew 2020-04-14 tdenniston@google.com [svg] Implement currentColor for gradient stops 2020-04-14 jvanverth@google.com Some D3D cleanup. 2020-04-14 reed@google.com SkCamera.h is deprecated 2020-04-14 ethannicholas@google.com Add sample(child, matrix) to SkSL. 2020-04-14 westont@google.com Move Pixelbook build jobs to Docker Debian9. Created with: gclient setdep -r src/third_party/skia@68626439f360 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058517,chromium:1070474 Tbr: kjlubick@google.com Change-Id: I30497f840a14e1f26c209889969d1f983e91a776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150606Reviewed-by:
-
John Chen authored
Add document on types of threads that execute inside ChromeDriver, and how these threads interact with each other. Notry: true Change-Id: Ib88095005062efe6189ffc9d2a6e391be8ffe1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146929Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#759259}
-
Max Li authored
It was previously being logged as an integer, but the value is a long so it wouldn't obviously correspond to the actual value. Change-Id: I79fde8d7f86cf929af36d400e2d7df84e1136b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150296 Auto-Submit: Max Li <themaxli@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#759258}
-
Rohit Rao authored
These files were inadvertently missing ARC guards and were not being compiled with ARC. BUG=1070852,1070933 Change-Id: I1005d41c26233d858aaee3670d3ce8b69ab561a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150300 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#759257}
-
Chunbo Hua authored
Ban use of ComPtr::GetAddressOf() according to http://crbug.com/914910. Bug: 914910 Change-Id: I4287f7acd6969d7f236f4dc64fb6a1c76a8d5c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148673 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
Image Doodles: Before, image doodles were only given a max width of 500x. This CL increases this to the width of the window since that is what the local NTP does. Additionally, the doodle share button is now placed relative to the top left corner of the doodle instead of the previously fixed-size image doodle container. Interactive Doodles: This CL uses the initial iframe size provided in the doodle response instead of a fixed initial size of 500x230px. Fixed: 1039910 Change-Id: Ibaa23976a02c9215e80f3cc55fa2a5fcbc4781e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150007 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#759255}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/22287060ed91..3994d83c6bc2 Created with: gclient setdep -r src-internal@3994d83c6bc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: I73c19f0e7468f7a06f0a03d3534abb8552c0e75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150608Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759254}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/aa333ac7985f..2cc24537de78 git log aa333ac7985f..2cc24537de78 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 lalitm@google.com Merge changes Ice9239a7,I92fe8218,I2df6401e 2020-04-15 fmayer@google.com Merge "Allow to specify output dir for heap_profile." 2020-04-15 treehugger-gerrit@google.com Merge "traced_perf: optional periodic unwinder cache clearing" 2020-04-15 treehugger-gerrit@google.com Merge "traced_perf: support incremental state clears" Created with: gclient setdep -r src/third_party/perfetto@2cc24537de78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I979fd65d2967f4cae2b78dd486c2676d83733bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150424Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5e7ef660be4a..2aa42d8b508b git log 5e7ef660be4a..2aa42d8b508b --date=short --first-parent --format='%ad %ae %s' 2020-04-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 711867566999..81e08df29531 (9 commits) 2020-04-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src ae0f0ead3a56..1be434141625 (1 commits) 2020-04-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src e70d25f6fa5d..c018fc6ae667 (9 commits) 2020-04-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src bb8be13e3ffe..3f7e3cbf33a7 (9 commits) Created with: gclient setdep -r src/third_party/angle@2aa42d8b508b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I3975cf00941f7fe7f6401c257188a276a66555c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150423Reviewed-by:
-
Peng Huang authored
wrapped_sk_image()->GetSkSurface() may return nullptr if the deive is lost, so we need to check the result before using it to avoid crash. This CL also improves SharedImageAHB to recreate SkSurface, if surface properties are changed. And it also resets the canvas when write access is done. Bug: None Change-Id: Ic9a7a966ac7063a74f650c1b04c2ee6ba475d918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145467 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759251}
-
François Degros authored
BUG=chromium:1058685 Change-Id: Ifa778623b50c373ac179e6e440f68f89d6b23abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148981Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#759250}
-
Alex Ilin authored
StartSurfaceLayoutPerfTest#testTabToGridFromLiveTabWith10TabsWithoutThumbnail is flaky on an Android O builder as well [1], disabling it for all Android versions. [1] https://ci.chromium.org/p/chrome/builders/ci/test-o-phone/5910 TBR=wychen@chromium.org Bug: 1045938 Change-Id: I40e38d36623add441be0c7e13db7d0b3561165d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144088Reviewed-by:
-
Sigurd Schneider authored
This CL adds a missing enum case which resulted in a triggering a DCHECK. As a drive-by, it fixes a wrong enum case. Bug: chromium:1070234 Change-Id: Ie7f3776d517e43bc93cb93dba0dd9e3d02be253c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146546 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#759248}
-
Charlie Hu authored
Previously Document was an instance of ExecutionContext. |document_| not null is equivalent to ExecutionContext not null. However, after recent migration of ExecutionContext to DomWindow, this assumption no longer holds. This CL adds null-check on |document_->GetExecutionContext()| to avoid deref nullptr. Bug: 1069848 Change-Id: Ifadc47b889bf5cd5fc3975b511c92d1dda7d4205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149317Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#759247}
-
Gabriel Charette authored
Design doc: https://bit.ly/chrome-io-jank-metric R=olivierli@chromium.org Bug: 1064645 Change-Id: If0b1ccf43303a6dcd2d77a0fd4b0bcb3d6dd99c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120288Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#759246}
-
Mark Cogan authored
This CL updates the SendTabToSelf feature architecturally in several respects. It: - Removes use of the deprecated TabModelList class. - Prepares SendTabToSelf for multi-window by factoring the keyed service (which is scoped to the whole app) into a BrowserAgent (which is scoped to a single window). - Moves the CreateNewEntry() utility method into the BrowserAgent class as SendCurrentTabToDevice(). - Factors away the SendTabToSelf command, since its UI functionality is just a combination of existing commands, and it's invoked from a single location. This removes a responsibility from the BVC. - Adds unit tests to the new browser agent. While this CL *prepares* SendTabToSelf for multi-window, it doesn't add multi-window support -- currently every window will display an infobar when a tab is remotely added to the model. crbug.com/1068482 tracks "full" multi-window support for this feature. Bug: 1056199, 1046378 Change-Id: I1434cf6463b2f96a994345c465be1b952ec58c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137444 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#759245}
-
Saurabh Nijhara authored
onBeforeShow() of checking-downloading-update element is not being called due to which the oobe dialogs contained inside it are not being rendered because these dialogs use lazy rendering in OnBeforeShow() of the oobe dialog. This creates a situation with no UI element on the screen but the update process running in the background. Now, calling onbeforeShow() for this element from the defaultControl() of update required screen. This CL also adds a test to avoid such case in future. It tests the update process along with the verification of the UI actually being displayed. Bug: 1048607 Change-Id: Ib1ac1c8d935ec059e62202095e7009f89e98a900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146901Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#759244}
-
