GitLab

Bug: 865834
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: If4c9293870035e62828bfa44714a8dec2df673e2
Reviewed-on: https://chromium-review.googlesource.com/1191285Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586693}

This CL uses ScopedBlockingCall to mark blocking calls in /components/drive.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=fukino@chromium.org

Bug: 874080
Change-Id: I9e76b6bb5afde0889cd1b894e36b3f7cd02c484f
Reviewed-on: https://chromium-review.googlesource.com/1191139Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586692}

This CL uses ScopedBlockingCall to mark blocking calls in /components/web_restrictions.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=bauerb@chromium.org

Bug: 874080
Change-Id: Ib372aaeeb4db8096b4de5a9d8372cc2c6601d865
Reviewed-on: https://chromium-review.googlesource.com/1191224Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586691}

Bug: 877493
Change-Id: Iba8ba4941c2751fc6a77edc258e066cfc8ecb5ca
Reviewed-on: https://chromium-review.googlesource.com/1191248
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586690}

We're now running against the entire HttpArchive corpus of pages instead
of just the top X sites. We then select the top 1000 rules from the result.

Bug: 877148

Change-Id: I4a19e416592e9f1be12b2371feb6805746d4aee9
Reviewed-on: https://chromium-review.googlesource.com/1191902Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586689}

Use C++11 syntax to avoid having overloads for the method
CheckEvents (using std::initializer_list).

Bug: none
Change-Id: I99bb6f8b6e24df618fb6faa3d5a9e29e57512043
Reviewed-on: https://chromium-review.googlesource.com/1188663
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586688}

Using wpt-import in Chromium dfc32c00.
With Chromium commits locally applied on WPT:
fbb650b3 "Add WPT serialization tests for wasm modules"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23541

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I631d125a33da8f5b568fbb6b2bd71372cbeb1cd0
Reviewed-on: https://chromium-review.googlesource.com/1193744
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586687}

Added error strings for edit and delete custom links.

Bug: 877290
Change-Id: I6bee0b8804f34cf4760338c4b02ad440c2b4eb9f
Reviewed-on: https://chromium-review.googlesource.com/1188600
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586686}

This adds HandlerStarter to encapsulate logic around how the handler
process is started on linux-ish platforms. Follow-up CLs will add
support for launching the handler when it is not available to execv
from the filesystem.

Change-Id: I4c3f311f32971a315d8e675f36e051fc83db66c4
Reviewed-on: https://chromium-review.googlesource.com/1188873Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586685}

This is duplicate and unnecessary code. Removing for chromecast.

Test: Build
Bug: None
Change-Id: I1e0096254a60c55d636d9fdf32a4d530d7791a95
Reviewed-on: https://chromium-review.googlesource.com/1191022Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586684}

This relands commit 0a12bc8f, which was
reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1186781.

This is identical to 0a12bc8f but adds
disable_variants = true to all chrome_cleaner mojo interfaces to prevent
the blink and non-C++ variants from being built.

Original change's description:
> Add chrome_cleaner sandboxed engine Mojo interfaces
>
> R=wfh
>
> Bug: 830892
> Change-Id: I0a4b25b2ba04b65a80e2c03e9151b5ef55912432
> Reviewed-on: https://chromium-review.googlesource.com/1171737
> Commit-Queue: Joe Mason <joenotcharles@chromium.org>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585025}

Bug: 830892
Change-Id: Ib476d03e0c3aba44c55bb0b4b26b6c38369e6b12
Reviewed-on: https://chromium-review.googlesource.com/1187004Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586683}

When there are more than six tabs in the tab grid, the animation when
entering the grid will sometimes be missing one or more snapshots. They
will appear a moment after the animation completes, which doesn't look
great.

The reason this happens is that the in-memory cache for snapshots is
capped at six objects. Requests for snapshots that are in the cache
return synchronously, but requests for uncached snapshots (which are
read from the filesystem) return in the next runloop. All of the layout
for the animation is done in the same runloop, so any uncached snapshots
aren't available.

The easiest solution is to increase the size of the snapshot cache, but
the number of snapshots that are needed is quite high in some cases (more
than 30 on a 12" iPad pro).

Instead, this CL implements a "prepare for appearance" mechanism for the
tab grid. This is triggered by a new ApplicationCommand that is sent when
the user touches *down* on a tab grid control. That leaves at least one
event loop for fetching cached resources.

The tab grid image data source (that is, the tab grid mediator) is ulti-
mately responsible for pre-loading the snapshots that might be needed. The
simple heuristic is to fetch the snapshots for each tab whose index is
within |N| of the active tab's index, where |N| is the maximum number of
tabs that will be visible in the grid. This is aggressive, but these pre-
fetched images are discarded as soon as the grid transition is completed,
and it's not as aggressive as just fetching all of the snapshots for the
open tabs.

Bug: 867980
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie00e599af50cd01ba002139b017ba2c2ec864db7
Reviewed-on: https://chromium-review.googlesource.com/1190203Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586682}

This reverts commit 7dd4e161.

Reason for revert: Leak tests on Linux are failing since

https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/23587

Original change's description:
> Make NGPaintFragment ref-counted
> 
> This patch change |NGPaintFragmet| ref-counted instead of managed by
> |std::unique_ptr<T>| to resolve life time issue between |LayoutText|
> and |NGPaintFragment|.
> 
> Before this patch, paint fragment can live longer than |LayoutText|
> and causes heap-use-after tree in |NGAbstractTextBox::WillDestroy()|.
> 
> 
> Bug: 874588
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Id2b59d9d8b257e7cf67ad841cd2fe5ad312951b0
> Reviewed-on: https://chromium-review.googlesource.com/1190625
> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586658}

TBR=yosin@chromium.org,kojii@chromium.org

Change-Id: I2eb89ec4cf7aaf773189437dfe76d76ef49544b9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 874588
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1193864Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: Markus Heintz <markusheintz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586681}

This CL extracts CreateSurface() and SurfaceReady() into a new
interface: DecodeSurfaceHandler.  This extraction reduces the
coupling surface (always good) and allows e.g. easier testing in
subsequent CLs.

VaapiVideoDecodeAccelerator is made to implement the said
templatised interface and teaches the Vaapi*Accelerator classes
to use it (instead of the whole VaVDA).

Partial diagram before: https://goo.gl/LBxH3h, after: https://goo.gl/E6sDrc.

Test: v_d_a_unittests and simplechrome on nautilus
Bug: 875005
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id376a6a25e664b0b6669b202062ebd7179346c50
Reviewed-on: https://chromium-review.googlesource.com/1178340
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586680}

Validation messages are used for form controls when an invalid value is
entered. For historical reasons, these were integrated outside the
blink lifecycle update but they can be moved into blink entirely now.
This patch moves validation messages into blink and removes the
CORE_EXPORT on ValidationMessageClientImpl.

Bug: 870422

Change-Id: Ieb3fc83b3a5f1c636320e3044a0c5b6c83da11d1
Reviewed-on: https://chromium-review.googlesource.com/1191802Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586679}

This makes sure WidgetTest.WidgetDestroyedItselfDoesNotCrash test does NOT
crash with use-after-free ASan error in ChromeOS and Mac. Test was added in
https://chromium-review.googlesource.com/c/chromium/src/+/1145261/ and only
covered Windows and Linux.

Bug: 878314

Change-Id: Ifde7f402955bd34bfd0618e4f67c52feeb333624
Reviewed-on: https://chromium-review.googlesource.com/1193283
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586678}

On the way to adding saved passwords search in settings.

Bug: 826094
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5fcbd2dcbe7ea0378b963d1948c782499f691dae
Reviewed-on: https://chromium-review.googlesource.com/1186413Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586677}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b7291443..0ead0e0e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I88b32c565984d0f0386c93cbc6c2113e40ebf6ce
Reviewed-on: https://chromium-review.googlesource.com/1193542Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586676}

The IdentityChooser shouldn't be presented on the ConsentBump as the
identity cannot be changed.

Bug: 878365
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Icb77657acf922dbd8ad3166e5d7fa32fa93b7e63
Reviewed-on: https://chromium-review.googlesource.com/1193782Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586675}

https://chromium.googlesource.com/catapult.git/+log/5d0291214a16..44e5893116c6


git log 5d0291214a16..44e5893116c6 --date=short --no-merges --format='%ad %ae %s'
2018-08-28 anthonyalridge@google.com Create API for callbacks to be called when user clicks on the graph.


Created with:
  gclient setdep -r src/third_party/catapult@44e5893116c6

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:866423
TBR=sullivan@chromium.org

Change-Id: Ic6c62d7b25e131369caca88a6d72175e8acfbf6c
Reviewed-on: https://chromium-review.googlesource.com/1193583Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586674}

This CL adds tests for the BottomToolbar and LongPress InProduct helps,
making sure they are correctly displayed.

Bug: 868332
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0ff7a90ae832f32acc9fcc3e66b09594892ee51b
Reviewed-on: https://chromium-review.googlesource.com/1186414Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586673}

Bug: 877493
Change-Id: Ifd6be6e313729738546f51164de91febe792281d
Reviewed-on: https://chromium-review.googlesource.com/1191282Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586672}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I3bbb87d0f80824efe34d1aa44e1c4d556e78e8ca
Reviewed-on: https://chromium-review.googlesource.com/1193743
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586671}

Also use checked_cast where appropriate.

Bug: None
Change-Id: I17f5a7af7a1c3d4b31f4a1304780d6f462dbb358
Reviewed-on: https://chromium-review.googlesource.com/1192684Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586670}

Future commits will need it, as installing web apps from their URL will
need to know whether or not those web apps (and their underlying
extensions) are already installed.

Based on nigeltao's https://crrev.com/c/1179115

But rebased on top of latest CLs and added testing.

TBR=rdevlin.cronin@chromium.org

Bug: 876577
Change-Id: Ic3e837efe8fb2f79e30a2ffb044f6e02e988d20b
Reviewed-on: https://chromium-review.googlesource.com/1192462Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586669}

This CL makes sure extension background page is kept alive when a
video in background page is in Picture-in-Picture mode.

Bug: 870609
Change-Id: Ifa3c8fc9a4a049ac60e3bde9ca64353b6f1c6569
Reviewed-on: https://chromium-review.googlesource.com/1161805
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586668}

https://webrtc.googlesource.com/src.git/+log/69b03e960ed6..a911eaf79bce


git log 69b03e960ed6..a911eaf79bce --date=short --no-merges --format='%ad %ae %s'
2018-08-28 brandtr@webrtc.org MediaCodecVideoEncoder: Fall back to SW when simulcast is requested.
2018-08-28 devicentepena@webrtc.org AEC3: Improving and optimizing the reverberation decay estimator.
2018-08-28 henrika@webrtc.org Adds support for real audio devices in video_quality_test.


Created with:
  gclient setdep -r src/third_party/webrtc@a911eaf79bce

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I2d340298dc07a74abaa071e70f21e15738dc4cb9
Reviewed-on: https://chromium-review.googlesource.com/1193582Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586667}

The bug is caused by the dismissing and reshowing keyboard on rotation,
which is triggered by dismissing and reshowing find-in-page bar. Use AutoLayout
for find-in-page bar so that we don't need to dismiss and reshow it to
ensure it's in right position.

Bug: 859996
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icc05f510180d9bc525c35c1bd80fa2363cfee67f
Reviewed-on: https://chromium-review.googlesource.com/1186730Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586666}

TBR=dgozman@chromium.org

Bug: v8:8092
Change-Id: Ic6dc50d754669d3e320af97636dc848b9635651b
Reviewed-on: https://chromium-review.googlesource.com/1193742Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586665}

Also make a few gentle updates to the code.

BUG=none
TBR=isherman@chromium.org,pmonette@chromium.org,csharp@chromium.org,garykac@chromium.org

Change-Id: I328d6859024cbdc88c001920a9fe21cbfbb42cc8
Reviewed-on: https://chromium-review.googlesource.com/1189562
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586664}

Bug: 867919
Change-Id: I39368fd24237987d59d6ce6b8102fd67b3856e1f
Reviewed-on: https://chromium-review.googlesource.com/1190762Reviewed-by: Yue Li <updowndota@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Markus Heintz <markusheintz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586663}

No need to query the layout object at all.

Bug: 878309
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I7fc86696321f305c5dfee8b98aacef7b20a7a267
Reviewed-on: https://chromium-review.googlesource.com/1193364Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586662}

Using wpt-import in Chromium eb0dd58a.
With Chromium commits locally applied on WPT:
fbb650b3 "Add WPT serialization tests for wasm modules"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23540

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I3eeaca518b2bb65cff6b8403c3d03876e643bde9
Reviewed-on: https://chromium-review.googlesource.com/1192988
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586661}

The settings UI in "Sync and Google services" is hidden from the
previous places.
List of UI hidden:
 + Settings => Bandwidth
 + Settings => Privacy => Search and Site Suggestions
 + Settings => Privacy => Send Usage Data
 + Settings => Account => Sync
 + Settings => Account => Google Activity Controls

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I59abbc50628e57d50bb99492f92e6fcaddeceb00
Reviewed-on: https://chromium-review.googlesource.com/1188473
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586660}

before: https://drive.google.com/open?id=1natWwIoGMyCLwlqUoXbTBsoKIL88asqJ
after: https://drive.google.com/open?id=1X6JtCXQdnN6zfMUdpCEYHvwzKA2FVHn3

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0f78d494b461fda6243f3cdcb6e811801c84ecd2
Bug: 868116
Reviewed-on: https://chromium-review.googlesource.com/1186468
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586659}

This patch change |NGPaintFragmet| ref-counted instead of managed by
|std::unique_ptr<T>| to resolve life time issue between |LayoutText|
and |NGPaintFragment|.

Before this patch, paint fragment can live longer than |LayoutText|
and causes heap-use-after tree in |NGAbstractTextBox::WillDestroy()|.


Bug: 874588
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id2b59d9d8b257e7cf67ad841cd2fe5ad312951b0
Reviewed-on: https://chromium-review.googlesource.com/1190625
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586658}

This change disallows implicit conversions from dynamic containers to
static spans. This conversion can cause CHECK failures, and thus should
be done carefully. Requiring explicit construction makes it more obvious
when this happens. To aid usability, appropriate base::make_span<size_t>
overloads are added.

Bug: 877931
Change-Id: Id9f526bc57bfd30a52d14df827b0445ca087381d
Reviewed-on: https://chromium-review.googlesource.com/1189985Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586657}

Bug: 832676
Change-Id: I6b4358838170781d13f54c76b4d34715471757e6
Reviewed-on: https://chromium-review.googlesource.com/1185202Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586656}

This patch cleans up how NGBlockNode sets/clears cached
results and paint fragments, reducing an "if" and avoiding
to clear paint fragment if we're going to update.

No behavior changes.

Bug: 714962
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I462a8d1632cb2bd6b2cef2fa4cb71493a97b4160
Reviewed-on: https://chromium-review.googlesource.com/1175749Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586655}

FetchCodeCache needs to call callbacks even on error. The resource
loader waits for the response from code cache hence it is required
to inform of errors as well.

Bug: chromium:812168
Change-Id: Icd7e4713cd9151bf06a28958711bc9fbc8c5386f
Reviewed-on: https://chromium-review.googlesource.com/1188677Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586654}