- 30 Oct, 2017 27 commits
-
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/52d748d48b4d..c0775e4e6ac1 $ git log 52d748d48..c0775e4e6 --date=short --no-merges --format='%ad %ae %s' 2017-10-26 benjhayden Fix add_reserved_diagnostics Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie438aca3bd6ffbe81b2ff50181f97821f4d36ac8 Reviewed-on: https://chromium-review.googlesource.com/742246 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512451}
-
Owen Lin authored
BUG=755889 TEST=None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1780b6b54fa6de50594c995170724d888abc64ae Reviewed-on: https://chromium-review.googlesource.com/720737 Commit-Queue: Owen Lin <owenlin@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#512450}
-
Yoshifumi Inoue authored
This patch introduces |RepeatString()| to make a string with repeated string, e.g. RepeatString(3, "abc") returns "abcabcabc". This patch is a preparation of the patch[1]. [1] http://crrev.com/c/741303 Move text-security CSS property handling to TextIterator Bug: 778507 Change-Id: I6324914fe228252ad611005be8b413b635edaa11 Reviewed-on: https://chromium-review.googlesource.com/741210Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#512449}
-
Darren Shen authored
This patch adds the new CSSMathValue subclasses CSSMathNegate and CSSMathInvert. Note that we only implement the constructor and attributes. More complicated things like typing or arithmetic will be done in a later patch. Spec: https://drafts.css-houdini.org/css-typed-om-1/#complex-numeric Bug: 776173 Change-Id: I7183df9c269db6eb799f93d39c0d8b1e541f7991 Reviewed-on: https://chromium-review.googlesource.com/743201 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#512448}
-
Hidehiko Abe authored
Along with the change, now PowerManagerClient starts to report error to its callers, instead of ignoring errors. Instead, callers starts to handle errors. BUG=739622 TEST=Build/Ran bots. Change-Id: Ib59431b1ca2136b10f06382f97801fe7cba33e5d Reviewed-on: https://chromium-review.googlesource.com/735281Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#512447}
-
Siddhartha authored
debug: :StackTrace is used in line 664. Change-Id: If061f891d3ef4454aad07fc3135d93830ee781db Reviewed-on: https://chromium-review.googlesource.com/740261 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Keigo Oka <oka@chromium.org> Cr-Commit-Position: refs/heads/master@{#512446}
-
Owen Lin authored
BUG=755889 TEST=None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib5a80303c67429b9cc7d69d7e8fd917bc775a903 Reviewed-on: https://chromium-review.googlesource.com/720736 Commit-Queue: Owen Lin <owenlin@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#512445}
-
Hidehiko Abe authored
BUG=739622 TEST=Build. Change-Id: Ia4de1be02605f55ab9de874ce438092173139015 Reviewed-on: https://chromium-review.googlesource.com/737671Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#512444}
-
Eddy Mead authored
I think this should fix the non-deterministic build issues Bug: 779001,779033 Change-Id: I0779b54d38a3fc8db2c71206fdafbcd2dc428dac Reviewed-on: https://chromium-review.googlesource.com/743163 Commit-Queue: meade_UTC10 <meade@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#512443}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9048063d. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/4246 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=qyearsley@chromium.org No-Export: true Change-Id: If98d89964f87dbbb80b2ad09b64cab3cd620586d Reviewed-on: https://chromium-review.googlesource.com/742528 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512442}
-
Yoshifumi Inoue authored
This patch introduces |EmitsSmallXForTextSecurity| behavior to |TextIteratorBehavior| to get "x" characters for |Text| node having CSS property "-webkit-text-security" other than "none" from |TextIterator|. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/741303 Move text-security CSS property handling to TextIterator Bug: 778507 Change-Id: I1a7699bf5806d3746ed0917879d7a8ee4f7b41dc Reviewed-on: https://chromium-review.googlesource.com/740926Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#512441}
-
Darren Shen authored
Currently, when given a list value, CSSStyleValue.parse returns null, but the spec says to take the first entry: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssstylevalue-parse Bug: 779422 Change-Id: I9f80d1876b9390f1d2684c271d3db3ef4192ddd3 Reviewed-on: https://chromium-review.googlesource.com/743101Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#512440}
-
shinyak authored
We'd like to have a goma canary builder which always use cl.exe. I'll convrt CrWin7Goma(clbr) to CrWinClexeGoma. Let me add mb config for CrWinClexeGoma first. It is the same as CrWin7Goma(clbr) + no_clang. Bug: 777705 Change-Id: I4584c92597765f72b2d8681568c7f3aaa37c217b Reviewed-on: https://chromium-review.googlesource.com/734342Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> Cr-Commit-Position: refs/heads/master@{#512439}
-
Darren Shen authored
Currently we return null when calling CSSStyleValue.parse with an invalid cssText. The spec says to throw a SyntaxError: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssstylevalue-parse Bug: 775806 Change-Id: Iab99af48ce162fa1810ac678e63475e1660d9d95 Reviewed-on: https://chromium-review.googlesource.com/743082Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#512438}
-
Yoichi Osato authored
It just calls SelectionTemplate<Strategy>::ShowTreeForThis(). Bug: Change-Id: I46190e5a51cfc77c101ac255c9606d165552746d Reviewed-on: https://chromium-review.googlesource.com/741284 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#512437}
-
Christopher Lam authored
This CL adds a HostedAppButtonContainer which currently houses a menu button which launches the app menu. This menu will later be tailored to hosted apps and the container will also show content setting indicators. Bug: 762401 Change-Id: I2cde2d0208e7afefd0508ffdf1ab8261f82c1f17 Reviewed-on: https://chromium-review.googlesource.com/701857 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#512436}
-
Zhenyao Mo authored
Otherwise event observer like SystemInfoHandler could be stuck and time out. BUG=778680,744658 TEST=bots, perf tests TBR=piman@chromium.org,kbr@chromium.org,nednguyen@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I35dbc51f83ff1f1592e46152ec4a5c47f8b4376a Reviewed-on: https://chromium-review.googlesource.com/743041 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#512435}
-
Raymes Khoury authored
Currently we check the feature policy for midi in the PermissionService. This means that we can't easily return a specific error message for denial due to FP. Also, several permission features do not use the PermissionService codepath and need to be checked individually anyway, so it seems more appropriate to do this for all permissions. This CL adds these checks to NavigatorWebMIDI.cpp. It also logs a console warning when the feature is disabled to help inform developers. Furthermore, a UseCounter counts how many times the feature has been blocked due to Feature Policy. This CL was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/739882 because it broke layout tests on the site isolation bots. This issue has been worked around, see crbug.com/779433. Bug: 689802 Change-Id: I3ce66d6dc7dec644d8c11f23001ca73558970bf0 Tbr: timloh@chromium.org, toyoshim@chromium.org Reviewed-on: https://chromium-review.googlesource.com/743142Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#512434}
-
junweifu authored
Load com base functions dynamically at runtime with core_winrt_util. Request face detection failed if it's not supported. Add unittest and make sure work in win10 bots with using win10_chromium_x64_rel_ng in PRESUBMIT.py . Link Face Detection demo[2] here. Split original large CL[1] up in smaller subpatches including this CL. [1] https://chromium-review.googlesource.com/c/chromium/src/+/708336 [2] https://codepen.io/miguelao/pen/PmJWro BUG=767021 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ice003ac398379b60e0668c14a7cec75195be0441 Reviewed-on: https://chromium-review.googlesource.com/724745 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#512433}
-
Bugs Nash authored
Since methods change between header files, blank lines between methods were adding excessive whitespace. Diff of generated files: https://gist.github.com/BugsNash/132e77773a10adc029123fa39b630e1a/revisions NB generated diff for ComputedStyleBase.cpp should be ignored, these are not due to this patch but are the result of a non deterministic bug Bug: 545324 Change-Id: Icc402d76690ea0c4ac5a424e2beb8f017df884f5 Reviewed-on: https://chromium-review.googlesource.com/743161Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#512432}
-
John Z Wu authored
Nothing will be compiled yet. Bug: 763797 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2fd69181b3bbb36bcb913dd540bcc9e8ef37454d Reviewed-on: https://chromium-review.googlesource.com/741091Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#512431}
-
Darren Shen authored
CSSParserObserverWrapper was used as an interface between CSSParserObserver and CSSParserTokenRanges for inspector parsing. Since we no longer use CSSParserTokenRanges for inspector parsing, we can delete this class and use CSSParserObserver directly. Bug: 661854 Change-Id: I099e2db34437ce666274508396f1e6eb9915382c Reviewed-on: https://chromium-review.googlesource.com/688974 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#512430}
-
Yuzhu Shen authored
BUG=777028 Change-Id: I7b77f86990dc65998927a264bd8165570b7d04fa Reviewed-on: https://chromium-review.googlesource.com/734209Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#512429}
-
Raymes Khoury authored
Currently we show deprecation warnings for mic/camera when they are disabled by feature policy in cross-origin iframes. However, once we enable Feature Policy for mic/camera an error will automatically be logged at the point where permission is requested. This is more accurate as currently it's possible to show the warning even when the feature policy has no impact on the function call (for example when the user is using getUserMedia for desktop capture). Although we remove the warning, we add some use counters to count the cases where mic/camera are requested while feature policy is disabled. Bug: 689802 Change-Id: I2a1ddc5b1a77357cde222352ad0d0268c32d447f Reviewed-on: https://chromium-review.googlesource.com/725004 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#512428}
-
Jon Napper authored
This patch adds missing well-known conflicting language codes. It also changes the lookup from a linear search to a binary search to improve performance (a previous version caused a performance regression). Bug: 765006 Change-Id: I0271eb620d0f412f168b4767de584e4896f86693 Reviewed-on: https://chromium-review.googlesource.com/727779 Commit-Queue: Jon Napper <napper@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#512427}
-
Joel Einbinder authored
Bug: 775261 Change-Id: I33e5131e8b922868881d44da864931ae80b4700f Reviewed-on: https://chromium-review.googlesource.com/727019Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#512426}
-
marcin authored
Bug: Change-Id: If2a9409b0f1db115e67cb63d7adea4634ab574e9 Reviewed-on: https://chromium-review.googlesource.com/736729 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#512425}
-
- 29 Oct, 2017 12 commits
-
-
Trent Apted authored
Under MD, the close button takes up more vertical space than the dialog title, so it dominates the title insets. Make the test work for both by removing the close buttons from the layout. Bug: 713030 Change-Id: Ibead5d002dcbe36d6fda65a3a9a8e01695e4f1a8 Reviewed-on: https://chromium-review.googlesource.com/741381 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#512424}
-
dpapad authored
Bug: 775479 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I94f5f9d189edcf81f2087f60e5a118824874fad4 Reviewed-on: https://chromium-review.googlesource.com/742650Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#512423}
-
Matt Menke authored
In particular, switch them to using the EmbeddedTestServer from URLRequestFilter, which required them to be in the same process as the network stack. Bug: 776589 Change-Id: I4fd64fa427adedfd383dee8f86c21c4955d7f3eb Reviewed-on: https://chromium-review.googlesource.com/731523 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#512422}
-
Mark Mentovai authored
fbc365fa9ed5 GCC 7.2 support (-Wnoexcept-type) 2f481590112b Make crashpad_util_test build without warnings with clang- cl on Windows b96b9f627ee7 win: Use test::ErrorMessage() in test::ChildLauncher 52d766400da1 linux: ProcessReader can own ProcessMemoryLinux without unique_ptr 9bc5989125b8 crashpad_util_test warning fixes for clang-cl, 64-bit edition 34699d378b82 Create client data structures for typed Annotations 5e9ed4cb9f69 win: Dynamically disable WoW64 tests absent explicit 32-bit build output cb3aa9c4d8f3 DumpAndCrash in extended handler test in favor of debug break c49da9caef30 win: Expect uneven symbolic link support 1dae919b7e5a #include "base/logging.h" in client/annotation.h for DCHECK() ef262d1ee3c2 #include "build/build_config.h" where needed 672c87258912 Upstream crashpad_util_test-in-Chromium changes 692488a254c4 Un-disable WinMultiprocess-based tests in Chromium 3fae8ff07c09 win: Fix -Wsign-compare warnings produced by clang Change-Id: I4b1355afce8be5571af3582f7dd0057b5018d70f Bug: crashpad:204, crashpad:205 Reviewed-on: https://chromium-review.googlesource.com/742284 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#512421}
-
Weidong Guo authored
Changes: Move caps lock key handling from accelerator controller to event_rewriter_chromeos.cc. As an accelerator key, caps lock is always consumed before it is sent to web app (e.g. CRD) or browser tab (keyboard event viewer). So we handle it in event rewriter and do not stop propagating it. BUG=775743 Change-Id: Ib3eb29cb4be023142b0d402d7c56015a7197bc14 Reviewed-on: https://chromium-review.googlesource.com/740090Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#512420}
-
Philip Rogers authored
This patch rebaselines 11 passing tests. These baselines now match the non-RLS path. The updated expectations were generated by copying the non-RLS expectation and adjusting for the scrolling layer differences. Change-Id: Ib2893dc3a16562306cd95ab34ca761a314edab02 Reviewed-on: https://chromium-review.googlesource.com/742455 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#512419}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ed6ae56e0ee8..2d8d196318a6 $ git log ed6ae56e0..2d8d19631 --date=short --no-merges --format='%ad %ae %s' 2017-10-29 update-skps Update SKP version Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: If9bb4e65bbc2dbfa81b416c4ff4365cc6ba66c09 Reviewed-on: https://chromium-review.googlesource.com/742367Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512418}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/c7b18fef19ff..6bfac0383f34 $ git log c7b18fef1..6bfac0383 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7148eabccc784c9ae22a35a070870cfc0206c432 Reviewed-on: https://chromium-review.googlesource.com/742213Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#512417}
-
chrome-release-bot authored
TBR=amineer@chromium.org Change-Id: I054ccd393fa6bc7bbe9609f76b6b1d33ca42bd99 Reviewed-on: https://chromium-review.googlesource.com/742477Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#512416}
-
Kinuko Yasuda authored
ServiceWorker wants to pass several params for subresource-loader setup in the renderer that are not URLLoaderFactory, because it needs to create URLLoaderFactory in the renderer. Currently we pass them via a separate Mojo call but it causes racy situation and makes tests flaky. This change introduces SubresourceLoaderParams struct (that has URLLoaderFactoryInfo as a member) and pass it along from navigation request handlers instead of URLLoaderFactoryInfo. This CL also slightly changes how WebUI subresource loader factory is passed; to make it share more code with AppCache etc. Bug: 778898 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Iafe0e2f7bd8f6c500c91bde3c46dff3d4d7dd8c8 Reviewed-on: https://chromium-review.googlesource.com/739621Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#512415}
-
Weidong Guo authored
BUG=777029 Change-Id: I691c4ea2e59f39645bb9725d6b59ee90809ae076 Reviewed-on: https://chromium-review.googlesource.com/742207Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#512414}
-
Lei Tian authored
Add return value for CustomTabBottomBarDelegate.showRemoteViews() so that client can know CCT bottom bar population fails. Bug: 729134 Change-Id: Ie0e8f3522d3ad96a2cf21f30c76579e5bb5a7979 Reviewed-on: https://chromium-review.googlesource.com/707737Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Lei Tian <ltian@google.com> Cr-Commit-Position: refs/heads/master@{#512413}
-
- 28 Oct, 2017 1 commit
-
-
Vaclav Brozek authored
This CL adds a reauthentication step before the user is asked to even select a file for exporting passwords to. Bug: 700003 Change-Id: Ie89529a27ce86ed74b0b3c98bf56abefb1a52899 Reviewed-on: https://chromium-review.googlesource.com/739661Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#512412}
-