GitLab

Since the close() operation is asynchronous, there is a window where
close() can be called a second time before the session is actually
closed. Changes allow the second close() to succeed if it is called
while the first close() is being processed.

BUG=668312
TEST=new test passes

Review-Url: https://codereview.chromium.org/2545083004
Cr-Commit-Position: refs/heads/master@{#438591}

This CL adds an UMA histogram recording the delta between each timestamp
received via a secure time service query and the previous one. This
should give us an idea of how often users in various experimental groups
make secure time queries.

BUG=589700

Review-Url: https://codereview.chromium.org/2565173006
Cr-Commit-Position: refs/heads/master@{#438590}

webViewContainingBlockedImage will be used in various SSL tests and
passing image_size to every call is unnecessary and simply clutters the
tests.

BUG=673520

Review-Url: https://codereview.chromium.org/2569103002
Cr-Commit-Position: refs/heads/master@{#438589}

Add the ability to register a custom hook from JS. This is the next step
towards being able to use our many, many custom_bindings.js files for
existing APIs.

Add a test for the same.

BUG=653596

Review-Url: https://codereview.chromium.org/2563093002
Cr-Commit-Position: refs/heads/master@{#438588}

Also fixes some missed nits in https://codereview.chromium.org/2562733002/

BUG=671302

Review-Url: https://codereview.chromium.org/2571713006
Cr-Commit-Position: refs/heads/master@{#438587}

Revert of Disable flaky test org.chromium.chrome.browser.webapps.WebApkUpdateManagerTest#testCanonicalUrlsDif… (patchset #1 id:1 of https://codereview.chromium.org/2571773002/ )

Reason for revert:
reenabling, see bug

Original issue's description:
> Disable flaky test org.chromium.chrome.browser.webapps.WebApkUpdateManagerTest#testCanonicalUrlsDifferentShouldUpgrade.
>
> TBR=miguelg@chromium.org
>
> BUG=673385
>
> Committed: https://crrev.com/44ff0871ca857e221a227306f7c256bf5e66659a
> Cr-Commit-Position: refs/heads/master@{#438120}

TBR=miguelg@chromium.org,grunell@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=673385

Review-Url: https://codereview.chromium.org/2574583004
Cr-Commit-Position: refs/heads/master@{#438586}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1d6a302d..3ca06164

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2575833002
Cr-Commit-Position: refs/heads/master@{#438585}

The Safe Browsing Subresource Filter used to reactivate in response to
same-page navigations, which resulted in spurious histogram samples being
recorded. In some edge cases, a same-page navigation in the main-frame also
resulted in no activation in subsequently created child frames.

This CL makes sure that the logic on both browser and renderer sides is
agnostic of in-page navigations.

BUG=637415

Review-Url: https://codereview.chromium.org/2574193002
Cr-Commit-Position: refs/heads/master@{#438584}

Waiting until mousemove DOM event is received is important, because
otherwise (because of lag introduced by forwarding events between
renderers) button-less mousemove event can arrive at the target frame
*after* mousedown event (confusing the renderer whether mouse button is
held down or not and therefore preventing dragstart from happening).

This CL seems to fix the flakiness that used to be locally reproducible
with --site-per-process.  Right now we consistently pass 20 repetitions
of CrossSiteSubframe/DragAndDropBrowserTest.DragImageBetweenFrames/0.

BUG=671445

Review-Url: https://codereview.chromium.org/2577553002
Cr-Commit-Position: refs/heads/master@{#438583}

service.

Remove |FaceDetectorOptions| from FaceDetection mojo interface so Blink
doesn't need to send it every time detect() is called.

BUG=646083
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2564163003
Cr-Commit-Position: refs/heads/master@{#438582}

BUG=chromium:602688
BUG=chromium:665518
BUG=angleproject:1523
BUG=angleproject:1635
BUG=angleproject:1639
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2577723002
Cr-Commit-Position: refs/heads/master@{#438581}

Make boilerplate.py add newline to the end of generated .cc and .mm
files.

Review-Url: https://codereview.chromium.org/2570193003
Cr-Commit-Position: refs/heads/master@{#438580}

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an |OnError| type and
an |onError| virtual method (differing by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |OnError| being the name of both the type and the method (with both
living in the same namespace). Similar situation happens for onSuccess /
OnSuccess names.

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=673480

Review-Url: https://codereview.chromium.org/2570193002
Cr-Commit-Position: refs/heads/master@{#438579}

The Logging uses "." as a separator so the histogram_suffixes in histograms.xml should use the same.

BUG=673413

Review-Url: https://codereview.chromium.org/2568243002
Cr-Commit-Position: refs/heads/master@{#438578}

We not only need to declare it prior to the 10.12 SDK due to the typedef
being missing but, because of -Wpartial-availability, we need to
redeclare it even on the 10.12 SDK until the minimum version is 10.12 or
later.

BUG=none

Review-Url: https://codereview.chromium.org/2572113002
Cr-Commit-Position: refs/heads/master@{#438577}

The flag currently doesn't clear savings on Android because of an early
return. Since the map of pref lists isn't populated for pref writing
writing with zero delay, ClearDataSavingStatistics needs to also clear the
prefs using the pref service.

BUG=673932

Review-Url: https://codereview.chromium.org/2570203002
Cr-Commit-Position: refs/heads/master@{#438576}

 * Don't cache ERR_ICANN_NAME_COLLISION under task-based resolver (to
   match proc-based resolver)

 * Save an empty address list in cache for ERR_ICANN_NAME_COLLISION
   entries (rather than the address list originally resolved).

BUG=670093

Review-Url: https://codereview.chromium.org/2577503003
Cr-Commit-Position: refs/heads/master@{#438575}

Adds networking.onc permission, which guards the introduced
networking.onc alias - for now, the permission is bound to dev channel
and available to the same whitelist as networkingPrivate API.

To avoid duplicating whitelist for the two permissions, the whitelist
is moved to behavior features and the behavior feature is added as a
dependency for both of them.

Refactors networking private API tests to enable parameterizing the
networking API to be used in the test and adds tests that exercise
alias - networking.onc code path.
Also groups some sub tests (which were all run in a separate browser
test) together in order to reduce total overhead of starting browser
for browser tests.

This is the first step towards renaming networkingPrivate API to
networking.onc (which will be made available to kiosk sessions).

BUG=672186

Review-Url: https://codereview.chromium.org/2470193002
Cr-Commit-Position: refs/heads/master@{#438574}

Switches BackgroundSyncLauncher to the thread pool executor and add
comments explaining why AsyncTask is necessary.

BUG=601053

Review-Url: https://codereview.chromium.org/2562643004
Cr-Commit-Position: refs/heads/master@{#438573}

AXTreeCombiner is used to combine accessibility trees from multiple frames
in order to create a single accessibility tree, used to provide information
about a web page to the Android assist API, used by features like Now-on-Tap.

Prior to change https://codereview.chromium.org/2217363002, only the root
frame of an accessibility tree was allowed to have a transformation matrix.
So in order to combine frames, AXTreeCombiner had to apply transformation
matrices manually, and make all coordinates global, otherwise the downstream
consumer of the accessibility tree wouldn't apply transformation matrices
from subframes.

That worked, but then in change 2217363002, we made all accessibility
coordinates relative, by allowing transformation matrices anywhere in the
tree. This eliminated the need for AXTreeCombiner to make all
coordinates global, but AXTreeCombiner was improperly updated in
this change, and in many circumstances it was pretending to return
global coordinates but not actually fully implement the new local-to-global
protocol as documented in ax_relative_bounds.h.

The proper fix is to simplify AXTreeCombiner. It's no longer necessary for it
to modify coordinates and apply transformation matrices at all. Just leaving
the coordinates alone now works correctly.

More end-to-end testing is needed. ax_tree_combiner_unittest only tests the
tree combining, and now that coordinates are passed through unmodified, there's
nothing really to test. We need a test of
Java_WebContentsImpl_onAccessibilitySnapshot that tests the resulting
coordinates passed to Java.

BUG=673935

Review-Url: https://codereview.chromium.org/2572923002
Cr-Commit-Position: refs/heads/master@{#438572}

The partition allocation unittests fails with a CHECK(!ret) in
setSystemPagesInaccessible when the mprotect call returns
with EINVAL.

BUG=None

Review-Url: https://codereview.chromium.org/2572143002
Cr-Commit-Position: refs/heads/master@{#438571}

https://skia.googlesource.com/skia.git/+log/60c05f98aa22..7a1cc6766d07

$ git log 60c05f98a..7a1cc6766 --date=short --no-merges --format='%ad %ae %s'
2016-12-14 msarett SkPngCodec: Add support for 16-bit pngs (step 1)
2016-12-14 caryclark more simplify bugs
2016-12-14 brianosman Move, rename, and document Visual Studio GN helper script
2016-12-14 msarett Prefer F16 in SkAndroidCodec for high precision images

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2575903002
Cr-Commit-Position: refs/heads/master@{#438570}

This CL is adding GetAllManifests() to query all payment app manifests
in Chrome layer. So, just rename existing PaymentAppContext in
content/browser/payments to PaymentAppContextImpl and then add a new
PaymentAppContext interface in content/public to expose some APIs to
Chrome layer.

This CL doesn't include actual impelementation now and it will be
completed in follow-up CL.

BUG=661608

Review-Url: https://codereview.chromium.org/2575583003
Cr-Commit-Position: refs/heads/master@{#438569}

Spec: https://html.spec.whatwg.org/multipage/webappapis.html#plugins-2

BUG=662005

Review-Url: https://codereview.chromium.org/2575893002
Cr-Commit-Position: refs/heads/master@{#438568}

BUG=674123
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2568133009
Cr-Commit-Position: refs/heads/master@{#438567}

This CL is a mechanical refactor to transition
OffscreenCanvasCompositorFrameSink to use CompositorFrameSinkSupport,
enabling it to share code today with Mus and Exo.

BUG=664547

Review-Url: https://codereview.chromium.org/2569923004
Cr-Commit-Position: refs/heads/master@{#438566}

https://chromium.googlesource.com/angle/angle.git/+log/c31b741..d967122

BUG=chromium:672380

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2577693002
Cr-Commit-Position: refs/heads/master@{#438565}

Test is flaking frequently because the period of the vsync is outside
the 10% tolerance expected.

BUG=674129

Review-Url: https://codereview.chromium.org/2573083003
Cr-Commit-Position: refs/heads/master@{#438564}

Currently, the use of chrome.tabs.update to navigate defaults to using
the selected tab. If another tab is selected before the navigation is
performed, this other tab will be navigated instead of the PDF viewer's
tab.

We pass the viewer's tabId to chrome.tabs.update to ensure the correct
tab is navigated.

BUG=672563
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2568903002
Cr-Commit-Position: refs/heads/master@{#438563}

Fixes a regression from https://codereview.chromium.org/2056043002

It is possible that we get into mainAxisLengthIsDefinite outside of layout,
especially via mainSizeForPercentageResolution. But in that case we do not want
to cache the value we compute because we have no way to invalidate it
correctly. So this patch introduces a m_inLayout variable to store this
correctly. (An alternative would be to set m_hasDefiniteHeight at the beginning
of layout and otherwise just read from it, but then we would need to always
compute it even if it turns out to be unneeded. Let me know if you prefer that
though.)

BUG=669714
R=eae@chromium.org

Review-Url: https://codereview.chromium.org/2571893002
Cr-Commit-Position: refs/heads/master@{#438562}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c78686903901..4c2a679b9012

$ git log c78686903..4c2a679b9 --date=short --no-merges --format='%ad %ae %s'
2016-12-14 eakuefner [Telemetry] Use better URLs for linking to HTML results

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2571243002
Cr-Commit-Position: refs/heads/master@{#438561}

BUG=674174
Test=Connect to a VPN network.
     Verify that connected network has "Connected" text indicator.

Review-Url: https://codereview.chromium.org/2571943002
Cr-Commit-Position: refs/heads/master@{#438560}

https://pdfium.googlesource.com/pdfium.git/+log/a9caab94c1f1..603f57b85c06

$ git log a9caab94c..603f57b85 --date=short --no-merges --format='%ad %ae %s'
2016-12-14 dsinclair Update CFWL_ListBox to return instead of using out params.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2571863004
Cr-Commit-Position: refs/heads/master@{#438559}

Ran `tools/clang/scripts/upload_revision.py 289575`.

This is similar to https://codereview.chromium.org/2564983002/
but should have a fix for that arm64/iOS miscompile.

BUG=673495
TBR=hans

Review-Url: https://codereview.chromium.org/2577523002
Cr-Commit-Position: refs/heads/master@{#438558}

Required by the standard, and, apparently, MSVC2017.

Also remove redundant `inline`s (methods defined within a class body
are implicit inilne already), and use the iterator typedefs more.

BUG=none

Review-Url: https://codereview.chromium.org/2570343002
Cr-Commit-Position: refs/heads/master@{#438557}

We only use kIntersect in practice, no need to paramaterize.

R=reed@google.com,chrishtr@chromium.org
TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2575583002
Cr-Commit-Position: refs/heads/master@{#438556}

Revert of Removing trace_data from our chrome telemetry build dependency list. (patchset #3 id:40001 of https://codereview.chromium.org/2556193002/ )

Reason for revert:
Was only for testing purposes

Original issue's description:
> Removing trace_data from our chrome telemetry build dependency list.
>
> BUG=chromium:670284
>
> Committed: https://crrev.com/7ff018563d1f7b78d5906e7478858f8931724693
> Cr-Commit-Position: refs/heads/master@{#437896}

TBR=eakuefner@chromium.org,nednguyen@google.com,sullivan@chromium.org,aiolos@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:670284

Review-Url: https://codereview.chromium.org/2569763005
Cr-Commit-Position: refs/heads/master@{#438555}

EVP_PKEY operations are Windows-style with an in/out length parameter.
It must be initialized to the size of the buffer.

BUG=674179

Review-Url: https://codereview.chromium.org/2575683003
Cr-Commit-Position: refs/heads/master@{#438554}

We are launching security chips/verbose security states to stable in
M55, and thus removing the Finch experiments and command-line flags.

The behavior we are launching is show-all and animate-nonsecure-only
(security verbose states are shown for all states but animated for
non-secure only).

BUG=647762

Review-Url: https://codereview.chromium.org/2560203003
Cr-Commit-Position: refs/heads/master@{#438553}

BUG=674161

Review-Url: https://codereview.chromium.org/2569233006
Cr-Commit-Position: refs/heads/master@{#438552}