- 18 Nov, 2020 40 commits
-
-
Ahmed Fakhry authored
This is a follow-up CL to handle requests made on the recording service CL (https://crrev.com/c/2404145): - The Record*() APIs of the service should provide the needed client, video capturer, and audio stream factory, instead of exposing APIs in the client so that anyone can bind to those capturers. - The service is launched to handle video recording, and terminated once recording ends, and all the chunks have been sent. - A GPU crash is handled by ending the recording. BUG=1126586, 1147989, 1143411 TEST=Manually, existing tests. Change-Id: I235cb1f9ee81dbbc42e21d0a222d32bcafa7a0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536030Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#828574}
-
Dale Curtis authored
Now that we're building with the official SDK these aren't needed anymore. Bug: 1105187, 1115294 Test: Bots are okay, manually confirmed VP9 hardware decoding on Big Sur. Change-Id: I9d190989a23266a5615cb149b4a958ad46d39611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545880 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828573}
-
Darren Shen authored
Use ScopedObservation and fix up some style. Bug: 1148157 Change-Id: I56ec7fe2db2ab768c7af37c85fff76670db03c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537254 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828572}
-
Ryan Harrison authored
https://dawn.googlesource.com/tint.git/+log/8f26453c7db4..88091d3d17e1 $ git log 8f26453c7..88091d3d1 --date=short --no-merges --format='%ad %ae %s' 2020-11-17 rharrison [transform] Add calling type determiner in manager 2020-11-17 dneto spirv-reader: Add (handle) Usage abstraction 2020-11-17 dneto spirv-reader: add GetMemoryObjectDeclarationForHandle 2020-11-17 bclayton writer/spirv: Refactor builder constructor tests Created with: roll-dep src/third_party/tint/src Change-Id: Iae2e6852363f5fce8037b5fff71157985f068ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545485 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#828571}
-
Matt Falkenhagen authored
Now that the core thread is the UI thread, it's not needed. Bug: 1138155 Change-Id: Iaf115e152c403650b3fce99a77c0673d1cdfed37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536575 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828570}
-
Lloyd Pique authored
Introduce TestArcOverlayManager which creates FakeArcOverlayControllers. This allows other unit tests to create a test overlay manager without requiring that they actually set up a window hierarchy. Test: payments unittests pass Bug: b:172592701 Change-Id: I1d614ed1021628adf789bb483140c1c11f2acea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538139 Commit-Queue: Lloyd Pique <lpique@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#828569}
-
Anand K Mistry authored
On destruction of AssistantAudioDecoder, the first member to be destroyed is the WeakPtrFactory, which happens before the media thread. However, if the media thread is currently running a task, that task's could call WeakPtrFactory::GetWeakPtr() on an already destroyed WeakPtrFactory. In general, WeakPtrs should only be bound/dereferenced on the same thread, although an existing WeakPtr can be copied on any thread. Bug: None Change-Id: I182292e8a51bf1e91934fbce237245bcf58be177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542932 Commit-Queue: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#828568}
-
Gyuyoung Kim authored
This CL migrates ExtensionMsg_Unloaded to extensions.mojom.Renderer interface. Additionally, this CL renames the name of the parameter from |id| to |extension_id| to be aligned with other functions. Bug: 1146099 Change-Id: I9c5463a6331ed4a87e39996f72dabb4b0ac40931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536669Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#828567}
-
Jiewei Qian authored
This reverts commit 8d720de8. Reason for revert: Compile failure on ios-device 'components/password_manager/core/browser/password_store_signin_notifier_impl.h' file not found https://ci.chromium.org/p/chromium/builders/ci/ios-device/172358 Original change's description: > [ios][PhishGuard] Port code to ios_chrome_password_store_factory > > Design doc: go/bling-phishguard > > The password_store_factory had already been forked between > //chrome and //ios. This CL ports password reuse detection code > from //chrome into the //ios implementation. > > Runtime changes are behind the kPasswordReuseDetectionEnabled > feature flag. > > Bug: 1147962 > Change-Id: Iaa5c31759383870753ab94aac14f798ab6634cfe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544748 > Commit-Queue: edchin <edchin@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828562} TBR=vasilii@chromium.org,edchin@chromium.org Change-Id: I2286176790447a0dc192c01a6f4a888699f77c70 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1147962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546302Reviewed-by:
Jiewei Qian <qjw@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#828566}
-
Ahmed Mehfooz authored
Bug: 1055265 Change-Id: I252dc8300457046dfdbc49d438adc821b6069243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545272Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#828565}
-
Xiaoqian Dai authored
Fullscreen, window, region capture mode now all require change mouse cursor. This CL put mouse cursor setting logic in a central place and auto decide which cursor to use based on the current event location. It unified the cursor behavior on the capture bar and button, and also fixed a few bugs in the original implementation, like the mouse cursor can be disappear after clamshell->tablet->clamshell transition. Bug: 1142937 Change-Id: I982e3be0fd9c513f108a8dd7cfe4e8aea60905e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537939 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#828564}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605571148-cd63329ec540ae538404ceac5db1a609fe603f55.profdata to chrome-win32-master-1605625046-c4965d9d21c1b70d5de168d81c9caa876a4c61e1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic292d296ee33771cde64dbd2c9ad927b00f0556c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545604Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828563}
-
edchin authored
Design doc: go/bling-phishguard The password_store_factory had already been forked between //chrome and //ios. This CL ports password reuse detection code from //chrome into the //ios implementation. Runtime changes are behind the kPasswordReuseDetectionEnabled feature flag. Bug: 1147962 Change-Id: Iaa5c31759383870753ab94aac14f798ab6634cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544748 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#828562}
-
Yu-Hsuan Hsu authored
Support GetGroupIDInput/Output, which is modified from the same function in audio_manager_chromeos.cc BUG=b:173113548 Change-Id: I3a00ebabd5e14f1ca087cab491d6747baaa7eb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536663 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#828561}
-
Pavel Yatsuk authored
Getter methods are needed for feature code unittests. BUG=1123947 R=twellington@chromium.org Change-Id: I853a337a92f04c99e27e7c5d3205b13a3ed46c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540942 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#828560}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605635959-3de00f504d9de3eba6702b2e7e69c522ca7d3882.profdata to chrome-linux-master-1605657601-ef8205b17022e19a0e2738465ae8904490a43974.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5336a1ddcf3bd0f47b7954c568cfd69967b5cd4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545434Reviewed-by:
-
Mitsuru Oshima authored
This allow the menu to resize, which in turn will enable scrolling so that a user can use all menu options. I'll work on a wrap around behavior in a separate CL. Bug: 1099880 Change-Id: If2f92894fb25684f12dd0f232758f9b968c8e0ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542854 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#828558}
-
Paul Moy authored
Add unit tests to cover the following cases: * Successfully cancel an existing scan * Try to cancel a scan when no scan jobs exist * Try to cancel a scan when multiple scan jobs exist * Get various bad responses back from a cancel scan job request Bug: b:169573779 Change-Id: I55970709ef8c37963b6ffce20b40061026f80db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533423Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#828557}
-
Matthew Mourgos authored
Bug: 1149846 Change-Id: I2c762685413412a440c958e5d81ba8f75c36cd5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543479Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#828556}
-
Yu-Hsuan Hsu authored
Make lacros-chrome able to query the id of an active device. BUG=b:173113548 Change-Id: I0169592ddf95d8cadca6806ac1a671eb06bc87fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536662 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
-
Jiewei Qian authored
This reverts commit 92eb6fc1. Reason for revert: Consistent failure on Fuchsia ARM64 See https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20ARM64/110721 Original change's description: > [fuchsia] Enable AccessibilityBridgeTest.PerformScrollToMakeVisible > > This test was disabled due to a change in the accessibility internals. > The change necessary to get this test to work was included in CL > https://crrev.com/c/2314758. > > Bug: 1122806 > Change-Id: I71045e0e432d07b259fc56ed31abedc2316a0b2d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544746 > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Sharon Yang <yangsharon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828509} TBR=sergeyu@chromium.org,yangsharon@chromium.org Change-Id: Ica0aef476af02c55b48dca2b2a2974bfa58bbf08 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1122806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545850Reviewed-by:
-
Harvey Yang authored
This commit replaces base::Singleton with base::NoDestructor. It helps to determine the lifetime of AccelerometerReader and avoid usages of it on invalid threads. BUG=b:171446270 TEST=run on nightfury(with iioservice) and helios(without iioservice) Change-Id: I55686e712a381c860054db14a1df00346b16ce6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543171Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#828553}
-
Maggie Chen authored
All GPU watchdog finch kGpuWatchdogV2NewTimeout is no longer needed. The finch code, the fideldtrial config and the histograms are removed. GPU.WatchdogThread.WaitTime GPU.WatchdogThread.WaitTime.Foregrounded GPU.WatchdogThread.WaitTime.Normal GPU.WatchdogThread.WaitTime.ProgressAfterWait GPU.WatchdogThread.WaitTime.NumOfUsers GPU.WatchdogThread.WaitTime.Init GPU.WatchdogThread.WaitTime.PowerResume Bug: 1144789, 949839 Change-Id: I5ba56966c9b865dbdd24a6154d6e8d91f85e2dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544004 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#828552}
-
Mustafa Camurcu authored
Implements an UMA metric to trace time spent from app launch to first frame, detected by first commit to exo surface. Bug= b:171066921 Test= Launch PlayStore and other apps from launcher and check chrome://histograms. Also launch apps from PlayStore and make sure nothing breaks and the values make sense. Change-Id: I924f70c10f95bd916dd39fcc7a78f442c4900700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494061 Auto-Submit: Mustafa Camurcu <camurcu@chromium.org> Commit-Queue: Mustafa Camurcu <camurcu@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#828551}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f921f2e5070..30e311332350 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC qjw@google.com,mek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1127088,chromium:912681 Tbr: qjw@google.com,mek@google.com Change-Id: I75f38b56fda106fde61a92670f9e37b7ce5caecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545607Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828550}
-
Peter Boström authored
Adds DialogModelCheckbox::Params with SetIsChecked(). Bug: 1106422, 1150027 Change-Id: Ia981f12b6d67250e3898c687ba9312b669ba2c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545769 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Add a minimal scripting.insertCSS() function. This currently only allows taking in a css string, targeting the main frame of the tab (optionally including subframes). Follow-ups will address these (and other) expansions. Adds browser tests for the same. Bug: 1148488 Change-Id: I9edea4196d5056f30a2d847e8ad3baa00b292199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535395 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Sharon Yang authored
Tear down the Frame by posting a task instead of in the AccessibilityBridge, by adding OnAccessibilityError. Bug: 1128954 Change-Id: Iba40229d7e11eb61534ef45fc16326b10814e59a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545575 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828547}
-
Jasmine Chen authored
Generates the token for cros_camera_test for it to be used for RegisterClientWithToken. Bug: b/170075468 Test: Build, deploy simplechrome, and verify the client token is generated. Change-Id: I4dade5863868aa0d1af003a6d81067b338cb6780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536653 Commit-Queue: Jasmine Chen <lnishan@google.com> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#828546}
-
Nico Weber authored
No callers still pass this. Bug: 1147839 Change-Id: Ie4600fbba9c13c84527ed7315fa3a4af22788d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545096 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#828545}
-
Dave Tapuska authored
Pass the knowledge of these properties down as booleans into the base class. BUG=1097816 Change-Id: I94cd0ee6e212be0fe7d321118392f1a834513756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540747 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#828544}
-
Weblayer Skew Tests Version Updates authored
Skew tests are being added for the following versions: 1, 87.0.4280.66 R=rmhasan@google.com Bug: 1041619 Change-Id: Iefca6a8f5beae82025a1499cdfb4d8d96d67b9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545828 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#828543}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/70f0ab5795d6..28de54004087 2020-11-17 andoli@chromium.org [ts] Typecheck elements/ElementsTreeOutline.js with TypeScript 2020-11-17 changhaohan@chromium.org TypeScriptify StylesSidebarPane.js: final part 2020-11-17 vidorteg@microsoft.com [Loc] Migrate layers to Loc V2 2020-11-17 peary2@gmail.com Changed to WheelEvent instead of non-standard MouseWheelEvent 2020-11-17 chrche@microsoft.com [Loc] Migrate webauthn to localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093296,chromium:1136655,chromium:1145518 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9b325924a4b3f345df8dc2c32a141f16ae0434d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545094Reviewed-by:
-
Matt Menke authored
These TODOs suggest adding tests where the two origins in NetworkIsolationKey are different to various tests in net/. It turns out that when the NetworkIsolationKey is usaed as an opaque key, these cases aren't too interesting. Bug: 950069 Change-Id: Ie1160b88278503ba81365f86122f04c6de595ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545483Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#828541}
-
Dave Tapuska authored
Remove the virtual and collapse the implementation into the call site. BUG=1097816 Change-Id: Iae31c2e778b72d18cc2a526ab2acb03e93e55e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536782 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Tomasz Wiszkowski authored
Bug: 1138587 Change-Id: Iabd37a0b822fd00095b9c64bf3b1a7759d56df97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542810 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#828539}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/4eb2d0b58ecc..93d5bf907aec $ git log 4eb2d0b58..93d5bf907 --date=short --no-merges --format='%ad %ae %s' 2020-11-17 jdrago avifDecoderNthImageMaxExtent(): Remove includeDependentFrameExtents argument, as it only added confusion, and the use-case with it set to false isn't useful 2020-11-17 wtc Replace firstExtent in avifDecoderItemMaxExtent 2020-11-17 wtc Fix bugs in MaxExtent and ExtentMerge 2020-11-17 wtc Miscellaneous cleanup in read.c 2020-11-17 wtc Clean up comments related to idat fox for an item 2020-11-17 wtc Use correct abbreviated function name in printf 2020-11-17 jdrago Reword comments for clarity 2020-11-17 jdrago avifGuessFileFormat() now guesses by header magic instead, if the file can be read 2020-11-13 jdrago Explicitly mark helper functions with a note about avifDecoderParse() returning OK first 2020-11-13 jdrago Expose avifDecoderItemExtent as avifExtent, and add avifDecoderNthImageMaxExtent() streaming helper function 2020-11-13 jdrago Reintroduce validity comment lost by the Ready revert 2020-11-13 jdrago Fix all offsets to be uint64_t and all sizes to be size_t in avifDecoderItemExtent and avifDecoderItem 2020-11-13 jdrago Revert "Add avifDecoderNthImageReady() avifIO helper function" 2020-11-05 jdrago Read/write one of each type of colr box, as allowed in HEIF 6.5.5.1 (Amemendment 3) Created with: roll-dep src/third_party/libavif/src In blink::AVIFImageDecoder::FrameIsReceivedAtIndex(), replace avifDecoderNthImageReady() with avifDecoderNthImageMaxExtent(). R=dalecurtis@chromium.org,pkasting@chromium.org Bug: 1136922 Change-Id: I17c60ddcd16bb4f8037c439552ba4260d85be8d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545583 Commit-Queue: Wan-Teh Chang <wtc@google.com> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#828538}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cca2a004..0b81ac61 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic3ec4720ec01867b16350b2a5db92f4dca8b8a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545296Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828537}
-
Sophie Chang authored
This makes it easier to add support for the model file path that we are supporting in the near future for TFLite models Bug: 1146151 Change-Id: Ib63e2c68f3e5a227cca8db9d73db9765de41bb16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545872Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#828536}
-
Miguel Casas authored
Original CL (crrev.com/c/2344526) broke the newly added unit tests on some devices, concretely where there's a normal-encoding and a low power encoding variants: VaapiWrapper will try to use the low power version (maybe: IsLowPowerEncSupported()), which confused the test. The solution is to just try VaapiWrapper's preferred entrypoint (and not all of them), see crrev.com/c/2544368/1..5 has the delta. (Verified on Atlas which was one of the broken ones) Original CL description ----------------------------------------------- This CL queries the driver for the encoding quality range and, if available and the device is considered "low power" (celeron, pentium and Core -Y devices), sets it to its maximum value, for highest speed and lowest power consumption, albeit at lower encoding quality. The quality difference should not be noticeable for video conference scenarios. I followed the code in both of Intel's VA backends. For the legacy i965: - VP8 supports values 1-2 [1]. (ENCODER_LOW_QUALITY is 2 so at least this CL can supersede the patch in [2] which is what it was set off to do). - AVC1 and VP9 support 1-7 [3,4], ENCODER_QUALITY_RANGE_(AVC,VP9) == 7 see [5], but this only on Gen9 [6a, 6b] (VP9 encoding is only available in Gen9+ FTR). For the modern intel-media-driver iHD, values are configured with names, 1 being TARGETUSAGE_BEST_QUALITY ([7] and its following lines). By default, the TARGETUSAGE_RT_SPEED == 4 is used, and 7 would be TARGETUSAGE_BEST_SPEED. Improvements depend on the input content. I measured kohaku with EncodeAccelPerf.h264_1080p_i420 and when ToT is ~204fps, 4.75W, with this CL I see ~220 fps, 4.42W. [1] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1151 [2] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/third_party/chromiumos-overlay/x11-libs/libva-intel-driver/files/vp8-encoder-Workaround-to-force-perforamce-mode-enco.patch;l=36 [3] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1142 [4] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1149 [5] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_drv_video.h#L76 [6a] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_encoder.c#L1599 [6b] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_encoder.c#L1653 [7] https://github.com/intel/media-driver/blob/105f0341a21324ae3bc458cfa6c25c7df0517f3a/media_driver/agnostic/common/codec/shared/codec_def_common.h#L333 Bug: b:141147405 Change-Id: I231f043edacc79cadd87b9f992505977e5802cda Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Sreerenj Balachandran <sreerenj.balachandran@intel.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544368 Cr-Commit-Position: refs/heads/master@{#828535}
-
