- 01 Dec, 2011 40 commits
-
-
piman@chromium.org authored
2 parts: - not all RenderWidgetHosts are RenderViewHosts - correctly set window/viewport size regardless of order of RenderWidgetFullscreenPepper::OnResize vs RenderWidgetFullscreenPepper::CreateContext BUG=101848 TEST=Pepper Flash on Youtube, go fullscreen Review URL: http://codereview.chromium.org/8758017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112503 0039d316-1c4b-4281-b951-d872f2087c98
-
varunjain@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/8764005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112502 0039d316-1c4b-4281-b951-d872f2087c98
-
kgr@chromium.org authored
BUG=103949 TEST=manual Review URL: http://codereview.chromium.org/8729042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112501 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Make TaskManager not use ChildProcessInfo. After this change, I will make BrowserChildProcessHost not derive from ChildProcessInfo, and just remove that struct completely. BUG=98716 Review URL: http://codereview.chromium.org/8764021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112500 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
The previous attempt read values from the valuator without properly checking if the valuator is set or not. This resulted in incorrect location at times (when X or Y didn't change). So this change makes sure the valuator is set correctly before reading from it. BUG=103981 TEST=manually (on desktop and device) Review URL: http://codereview.chromium.org/8634009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112499 0039d316-1c4b-4281-b951-d872f2087c98
-
robert.bradford@intel.com authored
New API used: gtk_widget_get_window - replaces direct access gtk_widget_get_allocation - added in 2.18 - replaces direct access gdk_window_get_width / gdk_window_get_height added in 2.24 - replaces deprecated gdk_window_get_size so is added to ui/base/gtk/gtk_compat.h With these changes the file can be compiled with sealed structures and deprecated API disabled with the exception of the deprecated function gdk_bitmap_create_from_data used in the cursor creation. That will come in a separate change. BUG=79722 TEST=Compiles and chrome runs Review URL: http://codereview.chromium.org/8635018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112498 0039d316-1c4b-4281-b951-d872f2087c98
-
erikwright@chromium.org authored
You are asked to review this as you have OWNERS for these files. BUG=None TEST=Compiles R=tim@chromium.org Review URL: http://codereview.chromium.org/8699011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112497 0039d316-1c4b-4281-b951-d872f2087c98
-
sail@chromium.org authored
TBR=cbentzel@chromium.org BUG=106010 TEST=none Review URL: http://codereview.chromium.org/8758019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112496 0039d316-1c4b-4281-b951-d872f2087c98
-
noelallen@google.com authored
Reapply of http://codereview.chromium.org/8632023/ CLs 8710002 and 8671004 should fix various build issues related to CrOS and other builders. Remove include of untrusted.gypi in normal ppapi gyp files to prevent WebKit from depending on NaCl. Refactor PPAPI gyp files to pull out source lists which are shared between trusted and untrusted targets. Fix scons hack which pulls list of sources from GYP so that we can build with scons. This CL should allow us to revert the DEPS change: http://trac.webkit.org/changeset/101011 on the webkit side Submitting tbr to avoid more build change collisions. TBR= bradnelson@chromium.org Please review the scons interaction with ppapi_sources.gypi Review URL: http://codereview.chromium.org/8727029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112495 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112494 0039d316-1c4b-4281-b951-d872f2087c98
-
scheib@chromium.org authored
This reverts commit 389f3285de9ce81ef8931b27b7a01af40d199efa. Review URL: http://codereview.chromium.org/8772010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112493 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Dispatch the Windows font caching IPCs in one filter. This avoids having the code that calls those functions be duplicated and also makes the chrome service code not know about internal content IPCs. It also cleans up ChildProcessHost a bit, which will be useful when it gets an interface around it for the Content API. BUG=98716 Review URL: http://codereview.chromium.org/8759013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112492 0039d316-1c4b-4281-b951-d872f2087c98
-
venkataramana@google.com authored
BUG=105792 TEST=NONE Review URL: http://codereview.chromium.org/8774009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112491 0039d316-1c4b-4281-b951-d872f2087c98
-
adamk@chromium.org authored
This code only needs to access a few static fontconfig-related methods, so use the minimal WebKit::initializeWithoutV8() instead of the full initialize() (the same call is used by the browser's in_process_webkit). Review URL: http://codereview.chromium.org/8748015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112490 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112489 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
BUG=61619 Review URL: http://codereview.chromium.org/8770009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112488 0039d316-1c4b-4281-b951-d872f2087c98
-
scheib@chromium.org authored
TBR=adamk, rogerta, bradnelson, tbroch, rcui, kochi BUG= TEST= Review URL: http://codereview.chromium.org/8775016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112487 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
BUG=105958 TEST=manually, double clicked title bar of a window in aura_shell. The window maximized. Review URL: http://codereview.chromium.org/8763020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112486 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitbm@chromium.org authored
Review URL: http://codereview.chromium.org/8760022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112485 0039d316-1c4b-4281-b951-d872f2087c98
-
enal@chromium.org authored
Before, we were "feeding" the driver in the callback when OS returned audio buffer to us. MSDN disallows that, but We were avoiding deadlock when stopping the stream by using some clever tricks. Unfortunately, exactly the same deadlock happens when Windows were draining audio stream when switching the device, and our tricks did not help, as we were not controlling exact timing. Fix is to separate receiving freed buffer and "feeding" audio driver. Now we are using CALLBACK_EVENT wave out mode in which Windows signal event when buffer runs out of data, and using RegisterWaitForSingleObject() so our callback is called by one of thread pool threads. Stopping of playback became slower because now it is synchronous. If that ever become a problem we can use singleton that keeps track of the playing audio streams, than stopping can become instaneous, at a cost of more complex checks in the callback. Unfortunately, no automatic test, as there is no documented way to programmatically switch default audio device on Windows. People were able to figure it out (see http://www.daveamenta.com/2011-05/programmatically-or-command-line-change-the-default-sound-playback-device-in-windows-7/), but there is no guarantee it will continue to work in Win8, or even in next Service Pack for Win7. BUG=41036 TEST=Play any HTML5 audio/video on Windows and change default audio device TEST=using "Control Panel | Sound". There should be no hang, you should hear TEST=audio from the newly chosen device. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112147 Review URL: http://codereview.chromium.org/8591028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112484 0039d316-1c4b-4281-b951-d872f2087c98
-
rnk@chromium.org authored
TBR=sail@chromium.org BUG=106041 TEST=Heapcheck bot 2 Review URL: http://codereview.chromium.org/8769014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112483 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
Fixes r112376. BUG=105999 TEST= Review URL: http://codereview.chromium.org/8773012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112482 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
-r/--revision: desired revision. Use DEPS if not given. -b/--branch: branch where to create gclient. Use origin/master if not given. -t/--tarball: Use tarball (http://src.chromium.org/svn/releases/) DEPS instead of src/DEPS. BUG=none TEST= ./tools/sync-webkit-git.py -r 97678 ./tools/sync-webkit-git.py -t 16.0.912.41 -b origin/svn_912 Review URL: http://codereview.chromium.org/8769001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112481 0039d316-1c4b-4281-b951-d872f2087c98
-
saintlou@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/8763011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112480 0039d316-1c4b-4281-b951-d872f2087c98
-
mnaganov@chromium.org authored
BUG=105537 TEST=none yet Review URL: http://codereview.chromium.org/8747015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112479 0039d316-1c4b-4281-b951-d872f2087c98
-
rnk@chromium.org authored
TBR=sail@chromium.org BUG=106041 TEST=CrOS valgrind bot 7 Review URL: http://codereview.chromium.org/8771009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112478 0039d316-1c4b-4281-b951-d872f2087c98
-
backer@chromium.org authored
BUG=none TEST=compile against WebKit gclient and master Review URL: http://codereview.chromium.org/8771008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112475 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Make sure the aura::Desktop is destroyed with the message-loop. This is done by adding a DestroyMessagePump notification to MessagePumpObserver. Also remove some views_unittests that were added to test NativeWidgetViews (which aren't used anymore), and do proper cleanup in AccessibilityEventRouter unittest. TBR=darin@chromium.org BUG=104559, 105613 TEST=unit_tests Review URL: http://codereview.chromium.org/8566037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112474 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@chromium.org authored
The API consists of the following parts: * DevToolsManager routes messages between devtools agents and clients * DevToolsAgentHost provides an abstract interface to the debuggee, currently it is either RenderViewHost or Shared Worker. Client can obtain DevToolsAgentHost from DevToolsAgentHostRegistry. * DevToolsClientHost is an API that should be implemented by DevTools front-end. There is a default Chromium implementation living in chrome/ and a remote debugging server which also implements this interface. Clients can extend it in order to provide custom front-end. There is a default DevTools front-end implementation and content/ provides a way for creating corresponding DevToolsClientHost by means of DevToolsClientHost::CreateDevToolsFrontendHost. The embedder just needs to provide a concrete delegate. * This patch also removes DevToolsHost_ForwardToAgent and DevToolsHost_ForwardToClient IPC messages which were used to forward only one message. DevTools IPC messages are now hidden behind the devtools content API. BUG=104625 TEST=Existing tests Review URL: http://codereview.chromium.org/8549022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112473 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
BUG=chromium-os:23124 TEST=compiles and passes tests, no observable changes. Review URL: http://codereview.chromium.org/8728030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112472 0039d316-1c4b-4281-b951-d872f2087c98
-
grt@chromium.org authored
Alias Australian, Canadian, New Zealand and South African English to British English, and explicitly alias "es-es" to "es" so it doesn't become "es-419" by way of the wildcard match. BUG=none TEST=covered by installer_util_unittests.exe --gtest_filter=*LanguageSelectorAliasTest* Review URL: http://codereview.chromium.org/8488006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112471 0039d316-1c4b-4281-b951-d872f2087c98
-
kaznacheev@chromium.org authored
BUG=chromium-os:23608,chromium-os:23609 TEST= Review URL: http://codereview.chromium.org/8773008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112470 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=104039 R=ben@chromium.org TBR=stevenjb@chromium.org Review URL: http://codereview.chromium.org/8771006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112469 0039d316-1c4b-4281-b951-d872f2087c98
-
rnk@chromium.org authored
TBR=timurrrr@chromium.org BUG=106036 TEST=bots Review URL: http://codereview.chromium.org/8775012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112468 0039d316-1c4b-4281-b951-d872f2087c98
-
backer@chromium.org authored
When the threaded compositor is enabled (via CompositorCC::Initialize(true) in desktop.cc), the GL context is created on one thread and ownership transferred to another. It's important to release the context before the transfer of ownership occurs, so that the context is not current on multiple threads. BUG=none TEST=build GYP_DEFINES="use_aura=1 use_webkit_compositor=1" with the change described above Review URL: http://codereview.chromium.org/8725041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112467 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
This way it should be processed by the gtest_command log parser (looks like it doesn't look into stderr...) TBR=bruening Review URL: http://codereview.chromium.org/8770007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112464 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
Implements GeolocationConfirmInfoBarDelegate::ShouldExpire so the infobar is removed when the back navigation is committed. BUG=106025 TEST=unit_tests: new GeolocationPermissionContextTests.InfoBarUsesCommittedEntry. Review URL: http://codereview.chromium.org/8775004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112463 0039d316-1c4b-4281-b951-d872f2087c98
-
dgozman@chromium.org authored
BUG=chromium-os:23434,chromium-os:23435 TEST=See bug. Review URL: http://codereview.chromium.org/8745013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112462 0039d316-1c4b-4281-b951-d872f2087c98
-
joaodasilva@chromium.org authored
LockScreen and UnlockScreen became overloaded names in TestingAutomationProvider after http://codereview.chromium.org/8664014 Missing virtual after adding OVERRIDE in http://codereview.chromium.org/8761010 TBR=sque@chromium.org, alicet@chromium.org Review URL: http://codereview.chromium.org/8774004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112461 0039d316-1c4b-4281-b951-d872f2087c98
-
dgozman@chromium.org authored
BUG=chromium-os:22812 TEST=See bug. Review URL: http://codereview.chromium.org/8776003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112460 0039d316-1c4b-4281-b951-d872f2087c98
-