GitLab

Adds side-shadow assets to the Overlay in the new layout that already
has rounded corners.  These assets just add a shadow, so there are
no dark versions needed, and we just have one side (using code to
flip it for the other side).

Binary-Size: +2K for the side shadow assets.

BUG=1005975

Change-Id: I31ebf657b2e9f49822c5aeb525b655c91d9b81aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895924
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713660}

This is now in a good enough shape to turn on. The remaining work is to
add tracking to ensure that we open the most-recently-used profile on
launch.

Bug: 982024
Change-Id: Ib6b922a1ebca043a6c8f8eb2ded2cd3c837cc80d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902866
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713659}

Since ContentVideoView has been removed for a long time, kUseContentVideoView
is no longer used. The CL removes it and related codes, replaces the
switch::kUseAndroidOverlay by the switch::kOverlayFullscreenVideo everywhere.

Bug: None
Change-Id: I95e9d6ec33fd8027914770cd5224163018fd6399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890510Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com>
Cr-Commit-Position: refs/heads/master@{#713658}

This CL adds a featureparam for experimental updates of radius
polynomial - and adds a parser for the string value.

The parser is tested both via the factory and as a standalone - which
is why it's placed in a separated namespace rather than the natural
anonymous namespace.

Bug: 1009290
Change-Id: I8d9edcd9c8267f6d85026f79bd30dc22cacefbc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903108Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713657}

An earlier CL of mine made each run parse the input string twice, which
slowed things down enough to make libfuzzer (which already runs each
input through the fuzzer twice) sad.

Bug: 1019151
Change-Id: Iee963f40c9bf30a24a77961be4cef8ca64b3c20f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903964Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713656}

Bug: 904383
Test: manual (follow repro steps on bug, and observe expected behaviour)
Change-Id: Ia60c2ec1a0891ca4c42a5b1ff79aff17aad06fb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903175Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sara Kato <sarakato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713655}

Bug: 987646
Change-Id: Ibdb5b6b7393fbdc3593c498d52f4d595872a3647
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903839Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713654}

Remove unsigned int typecasts.

Bug: 1012072
Change-Id: I05a38c48f3c5415b209d89c396ed3a25545d88f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902566
Commit-Queue: George Zhang <zhanggeorge@google.com>
Reviewed-by: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713653}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4e10964bf967..a942a9f9a235

git log 4e10964bf967..a942a9f9a235 --date=short --no-merges --format='%ad %ae %s'
2019-11-07 vapier@chromium.org patch: drop chromeos/cbuildbot/git/fetch_count metric

Created with:
  gclient setdep -r src/third_party/chromite@a942a9f9a235

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I945abc5926b4e4fb85143fb2fbe19713d67609d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904622Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713652}

We changed the focus ring on eject button activation to be hidden.
This ensures consistency with other button behavior within the files
app. We swapped the original eject button (<button>) for a cr-button,
a polymer element. This simplifies the eject button implementation by
removing a nested HTMLElement since the ripple effect is contained
within the polymer element (<cr-button>).

Bug: 1006198
Change-Id: I5fc60a28db9bbd8166420fe50ef89bd88facdc1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830218Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713651}

There was a blank space before each test name when copying plain text
report.

Before:
` css3/flexbox/flex-flow-auto-margins.html`
` external/wpt/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html`

Now:
`css3/flexbox/flex-flow-auto-margins.html`
`external/wpt/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html`


Change-Id: I4195af5f95347754bcfabefed04c9ce3cd387993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904351Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713650}

GLHelper assumes that the texture used in readback with it is always
GL_TEXTURE_2D which is not the case for resources creates for canvas2d
elements on mac using GL_TEXTURE_RECTANGLE_ARB.

R=ericrk@chromium.org, guidou@chromium.org

Bug: 1020796
Change-Id: Ic5a4b8e0ba5a0d61a8af43251438f5323b911fd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902506
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713649}

Bug: None
Change-Id: I41bf85b61e1cf79dfe9e048da8d1a13c96f0f144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903618
Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713648}

When both the search engine logo and the identity disc are enabled, the
urlbar placeholder text is clipped. This change removes the end padding
of the location bar to prevent that clipping.

Bug: 1019019
Change-Id: Ie02ef36f784a13a06e978cd7b8210c7ffbd36ab6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885556
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713647}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ic027fcccdc59257500b38649fceb4d6f656f766e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904610Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713646}

This will also cause the extensions button to highlight while a bubble is anchored.

Bug: 987312
Change-Id: Id2b3e831dcceeb5ac47b929078f51ac3ebaecf12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904492Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713645}

This updates the FileHandling API to be more in line with the explainer:
https://github.com/WICG/file-handling/blob/master/explainer.md#example

This means that sites can attach their launch handler whenever they
like, and are guaranteed to handle each launch.

Functionally, this replaces window.launchParams with window.launchQueue.
In order to access launchParams, sites must now provide a launch
consumer, which will be invoked with launchParams as the site receives
them.

Old: console.log(window.launchParams.files);
New: window
  .launchQueue
  .setConsumer(launchParams => console.log(launchParams.files));

Note: This feature is behind the NativeFileSystemAPI and
FileHandlingAPI flags, so this change doesn't effect live web APIs.

Bug: 829689
Change-Id: I461bc68eef44283c54bd237cae7b550e2e3b2909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875891Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713644}

Since the baseLatency value is fixed after construction, compute the
value when the AudioContext is constructed and cache the value so that
any queries just return the value from the slot.

Bug: 1005150
Change-Id: I0a4b8c4fb42deb5721f0ecdce5a8bc3b3c4cb26e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903750Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713643}

See details:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWwsSBUZsYWtlIlBjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFBhc3N3b3JkTWFuYWdlckJyb3dzZXJUZXN0LkZpbGxXaGVuRm9ybVdpdGhIaWRkZW5Vc2VybmFtZQw

TBR=dvadym@chromium.org

Bug: 1022531
Change-Id: I6886d88aa677c1791510babfeefe605fb2bedd42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904547Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Auto-Submit: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713642}

BUG=1018148
TEST=none

Change-Id: Icb07328be04799cd4d7c87d4f07b47976aa33982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904501Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713641}

It is no longer needed, now that WebVR is gone.

Change-Id: I7bfca2156c06a447439c42b08673e5d422daf628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893526Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713640}

This allows client code to type-check JS with (e.g.)

js_type_check("closure_compile") {
  closure_flags = default_closure_args + [
                    "jscomp_error=strictCheckTypes",
                    "jscomp_error=reportUnknownTypes",
                  ]
  ...
}

for picking up a wide class of type errors that otherwise slip through.

Note the maintenance cost of actually _landing_ a rule with `reportUnknownTypes`
is probably too high. The purpose of this CL is to at least allow developers
to temporarily add reportUnknownTypes to validate their own type coverage accurately
in a chrome developer checkout.

Suppresses:

../../ui/webui/resources/js/assert.js:**: ERROR - [JSC_UNKNOWN_EXPR_TYPE] could not determine the type of this expression
20:   if (!condition) {
           ^^^^^^^^^
26:     const global = function() {
                       ^^^^^^^^^^^^
27:       const thisOrSelf = this || self;
                             ^^^^
29:       thisOrSelf.traceAssertionsForTesting;
          ^^^^^^^^^^
30:       return thisOrSelf;
                 ^^^^^^^^^^
32:     if (global.traceAssertionsForTesting) {
            ^^^^^^
37:  return condition;
            ^^^^^^^^^

Bug: 1000989
Change-Id: I73564b17688df1b08d2a2eb6f78177dcde39faa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902182Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713639}

Bug: 1009122
Change-Id: Ibb162f7a9766083be5cdd17f40f88d6a049eb351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904611Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713638}

Bug: 1022173
Change-Id: Ifa07c62fda098ba0cbdf7f62f50cf9a98b29876a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902475
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Peter Kvitek <kvitekp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713637}

Updates the ownership model of CastWebView so that users "borrow" the
CastWebView, returning ownership to CastWebService when the user goes
out of scope. Web page lifetime can be extended beyond the lifetime of
the user, facilitating smooth transitions between pages (no intermediate
black screen) and simplifying logic for extended shutdown.

Merge-With: eureka-internal/313200

Bug: internal b/77879457
Bug: internal b/130320237
Test: Start multiple apps in sequence, verify successful transition with
      no crashes.

Change-Id: Ic03217ed6d3abb8a74d012c9d6b11bd1a8d92c68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895504
Commit-Queue: Sean Topping <seantopping@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713636}

Temporary fix that creates an exception for 'no access' URLs like
chrome-native://history. These URLs can cause a origin mismatch in the
commit code because of slight differences between how url::Origin and
blink::SecurityOrigin handle 'no access' URLs. This is intended as a
low risk change that can be easily merged to the M79 branch.

Bug: 1016711, 923144
Change-Id: I8ab833744f45ebfbc489118313c59d7bbfdaff78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900358
Auto-Submit: Aaron Colwell <acolwell@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713635}

This CL adds the plumbing necessary in WMPI to initiate and complete
a requestAnimationFrame call.

For the moment, WebMediaPlayerClient doesn't do anything with the
frame returned, but this will be updated in upcoming CLs.

Bug:1012063

Change-Id: I99c951bf0d6317bb81986166e57ec250d47dc1cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900350
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713634}

https://android.googlesource.com/platform/external/perfetto.git/+log/5d41eaf0f6ae..f0d1100a7149

git log 5d41eaf0f6ae..f0d1100a7149 --date=short --no-merges --format='%ad %ae %s'
2019-11-07 lalitm@google.com Merge "trace_processor: fix test failure and swap around counter <-> counter_values"

Created with:
  gclient setdep -r src/third_party/perfetto@f0d1100a7149

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Ic8f4cc210e52d8a7de8af66fc67f61bbde32e63f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904455Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713633}

This reverts commit e6093e9b.

Reason for revert:
The CL causes memory corruptions on linux-trusty-rel and msan bots,
which triggers crash in random places (mostly in cc::Animation::DetachElement somehow).

See https://crbug.com/1021553

Original change's description:
> Reland "Fix emission of AtkValue property change signal"
> 
> This version adds protected memory support to handle calling ATK methods
> dynamically on the CFI bot.
> 
> Original change's description:
> > Reland "Fix emission of AtkValue property change signal"
> >
> > This version checks at runtime for atk_value_set_value during testing.
> > This should allow the change to work on bots running trusty.
> >
> > Original commit message:
> >
> > > The introduction of text-change signals for the omnibox included a
> > > regression that prevented the emission of AtkValue property change
> > > signals. Fix this error and also add an implementation of
> > > atk_value_set_value. The implementation is used in a test to verify the
> > > correct behavior.
> > >
> > > The fix is that we correct the misuse of a logical operator and now
> > > always try to emit AtkValue property change events when receiving the
> > > kValueChanged event in AXPlatformNodeAuraLinux.
> 
> Bug: 1015387
> Bug: 1017177
> Bug: 1017548
> 
> Change-Id: Iadaea4569944ad0a1be0e1211bbce4ed2c4f6935
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879255
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com>
> Commit-Queue: Martin Robinson <mrobinson@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#710699}

TBR=mrobinson@igalia.com,tikuta@chromium.org,jdiggs@igalia.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1015387, 1017177, 1017548, 1021553
Change-Id: Ie661eeb75dd42ddff34e2ff04623bf2b9af30cbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904504Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713632}

BUG=1016906

Change-Id: I601f1c1cc3f23c5598d5bedf3b22ad6fbf810cfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904306Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713631}

When ScrollableShelf is enabled, the shelf icon under drag is actually
the proxy icon created by ScrollableShelfView while the original shelf
icon is transparent. However, when dragging an icon which is already
pinned on Shelf from AppsGridView, if the drag gets canceled, the
original shelf icon fails to show. This CL fixes such an issue. A
unit test is created for this scenario.

Bug: 1021768
Change-Id: Ibfce9ae3c59c21ac7d7e515b3a3a733e453fe5b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902511Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713630}

IIFE is "Immediately Invoked Function Expression". It wraps the compiled
output like (function () { <compiled code> }).call(this);.

This is the recommendation given at
http://go/js-practices/build-rules#use-isolation-modeiife-or-equivalent

Without it, closure-compiled symbols pollute the global JS context and
can prevent mojo bindings being used in a regular/standalone
closure-compiled app. E.g., errors like,

JS ERROR: '[..:ERROR:CONSOLE(1)] "Uncaught SyntaxError: Identifier 'ra' has already been declared"

Bug: 996088
Change-Id: Icef1a1c0d14a3f2b8cefbce12e08348a8c63b9c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903228Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713629}

See details in:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVycgsSBUZsYWtlImdjaHJvbWl1bUBjb250ZW50X3NoZWxsX3Rlc3RfYXBrQG9yZy5jaHJvbWl1bS5jb250ZW50LmJyb3dzZXIuSW50ZXJzdGl0aWFsUGFnZVRlc3QjdGVzdENsb3NlSW50ZXJzdGl0aWFsDA


TBR=jinsukkim@chromium.org

Bug: 1022324
Change-Id: I36eb261d9f8c0f33884b2c40ee5d6f92aaeae494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903541Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Auto-Submit: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713628}

The metrics provider class is going to be almost completely rewritten
for the framework. It will make future CLs cleaner to start at a blank
slate.

Bug: 1016655
Change-Id: Ib0e02d7632df11b01167a566db4eac4cbda6acab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903107Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713627}

The reason for the flaky Mojo connection of ContentSettingsManager
was that |content_settings_manager_| tried to connect to its
receiver via BrowserInterfaceBroker in ContentSettingsAgentImpl
ctor once, but BrowserInterfaceBroker could be reset before
|content_settings_manager_| was connected.
This CL ensures its connection to retry in DidCommitProvisionalLoad
if it is not connected.

Bug: 936482
Change-Id: I29db1ea13e2fa4de49f431d07ac249ed6e318d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897576Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#713626}

rsleevi pointed out this didn't need to be thread-affine. (I've long
since lost track of what all our random PostTask hooks do...)

Bug: none
Change-Id: I6d7dc61684202383787012853bb55fab8376d42c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904123
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713625}

QuicChromiumPacketReader when processing probing result (aka probing reader),
may gets deleted by the QuicChromiumClientSession while the connection
stays open. This change grabs a weak_ptr before calling up to session (visitor)
and stops future reads if the reader is invalid.

Bug: 1014092
Change-Id: I4a1ccc437692b9845c2cb8bf0c6bcc1feb1b7610
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904526Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713624}

Polish WebView crash UI layout:
- Use android material theme and support dark theme.
- Use an expandable list to show crashes where we show the important
  info (package name and crash capture time in the header) and show
  variation keys, upload status, report button in the expanded body.
- Use a more descriptive string for the reporting button
  "File bug report" instead of "Provide more info".
- For better visualization, show app icon next to package name to
  be easy to find by eye.
- Use ListViewAdapter#notifyDataSetChanged() instead of creating
  new adapter to optimize crash list updates.
- Update MainActivity to use the new two_line_list_item layout.

Bug: 948923
Test: Manually inspect the UI on SystemWebView on Android P and Android Q with dark mode switched on/off.
Change-Id: Ic9d4fffc6f24a409f06927b91b160280c5781e7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899371
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713623}

This CL adds support for dbus "AmbientColorTemperatureChanged" signal.
A new method AmbientColorChanged is added to PowerManagerClient
and it will be called every time powerd emits a new ambient color
temperature.

A prototpe using the new signal can be found here: crrev.com/c/1883289

Bug: b/138731765
Test: chromeos_unittests --gtest_filter=PowerManagerClientTest.ChangeAmbientColorTemperature

Change-Id: Idf6462e90f4c378cd03dfd131434e045748deaf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900432
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713622}

This CL changes the tracker's trace object to a stringstream, allowing
the logging of more types of data. This CL also takes advantage of said
feature to log |begin_main_frame_data_.previous_sequence| and
|args.sequence_number| in ReportBeginMainFrame() and
ReportMainFrameCausedNoDamage().

Bug: 1017291
Change-Id: I81330b10fa2347658587ee1f9e320fb185ae35cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903609Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713621}