GitLab

m_haveVisibleTextTrack is just used in the function
configureTextTrackDisplay, so use a local variable instead

Review URL: https://codereview.chromium.org/1686063002

Cr-Commit-Position: refs/heads/master@{#374659}

It's apparent that the field is never null in this method, and if it were, we'd have to change much more. So make the code a little more clear and remove the test.

BUG=

Review URL: https://codereview.chromium.org/1617243004

Cr-Commit-Position: refs/heads/master@{#374658}

It's not clear that all error suggestions should be shown on mobile, since some
of them are irrelevant (e.g., disabling an extension).

BUG=568415

Review URL: https://codereview.chromium.org/1673593002

Cr-Commit-Position: refs/heads/master@{#374657}

Correctly format.
Convert raw pointers to scoped_ptr.
NULL -> nullptr
Remove some unnecessary std::set<> creation.

Review URL: https://codereview.chromium.org/1665023002

Cr-Commit-Position: refs/heads/master@{#374656}

WebRTC 11523:11548
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/4def420..608b2be

Libjingle 11522:11545
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/01cbe5b..bb467ca

Updated libjingle GYP+GN for talk/app/webrtc move that happened in
https://codereview.webrtc.org/1610243002/

TBR=tommi@chromium.org, sergeyu@chromium.org
BUG=webrtc:5418

Review URL: https://codereview.chromium.org/1615433002

Cr-Commit-Position: refs/heads/master@{#374655}

The logic for when to include the linux dbus implementation
falls into three cases: chromeos, non-chromeos linux with
dbus, and non-chromeos linux without dbus.

By using just the is_chromeos, is_linux and use_dbus
variables, this code will also build successfully on
embedded linux targets.

Review URL: https://codereview.chromium.org/1674233002

Cr-Commit-Position: refs/heads/master@{#374654}

The default device is always authorized, so the check is unnecessary and
in some cases results in a crash.

BUG=585075

Review URL: https://codereview.chromium.org/1689593002

Cr-Commit-Position: refs/heads/master@{#374653}

Updated the function findNextFocusableRadioButtonInGroup to
take into consideration the computedTextDirection for
deciding which radio button to move the focus on.

BUG=556677

Review URL: https://codereview.chromium.org/1633553002

Cr-Commit-Position: refs/heads/master@{#374652}

This CL removes the is_loading_ field from WebContents, in favor of only
tracking the loading state through the FrameTree. Currently the loading state
is tracked in both, leading to more complexity in the code.

BUG=571887, 298193
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1545973002

Cr-Commit-Position: refs/heads/master@{#374651}

This patch adds a new command line flag to disable user gesture checks
for testing purposes. Before, a presentation session can only be started
only when triggered by a user gesture.

BUG=585404

Review URL: https://codereview.chromium.org/1660193007

Cr-Commit-Position: refs/heads/master@{#374650}

This is behind a runtime flag for two reasons:
* The implementation is incomplete.
* We're still evaluating the API design.

Intent to Implement and Ship: Notification Action Icons
https://groups.google.com/a/chromium.org/d/msg/blink-dev/IM0HxOP7HOA/y8tu6iq1CgAJ

BUG=581336

Review URL: https://codereview.chromium.org/1644573002

Cr-Commit-Position: refs/heads/master@{#374649}

FontDescription.h includes FontFamilyNames.h, which is a generated header. The
"make_platform_generated" target that generates FontFamilyNames.h correctly
specifies itself as a hard dependency, and the "blink_platform" target that
builds FontDescription.* correctly depends on the former target. However,
FontDescription.h is itself included in other blink_platform headers that
are themselves included by files built as part of other targets (specifically,
the "blink_platform_test_support" target). The blink_platform target thus needs
to export the hard dependency on make_platform_generated onto its own
dependents in order to avoid those dependents potentially being built before
FontFamilyNames.h is generated.

BUG=585386

Review URL: https://codereview.chromium.org/1682373003

Cr-Commit-Position: refs/heads/master@{#374648}

See https://chromiumcodereview.appspot.com/1676693004/ for fyi example.

The CL to remove these build-side is https://codereview.chromium.org/1679703004.

BUG=525873

Review URL: https://codereview.chromium.org/1672263002

Cr-Commit-Position: refs/heads/master@{#374647}

This will be used from https://codereview.chromium.org/1589953005/.

BUG=424866

Review URL: https://codereview.chromium.org/1689563002

Cr-Commit-Position: refs/heads/master@{#374646}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9f61ad391dd0..9ff889060a5d

$ git log 9f61ad391..9ff889060 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1686053002

Cr-Commit-Position: refs/heads/master@{#374645}

BUG=585538
TEST=manually run e2e tests and tried sending an app message with a string message.

Review URL: https://codereview.chromium.org/1686723002

Cr-Commit-Position: refs/heads/master@{#374644}

Child processes are in the best position to determine which files
to use, therefore it is simplest just to provide both 32 and 64
bit versions from the parent.

BUG=581409,455699

Committed: https://crrev.com/c560d75783aca05249092dd11503b53f7b631be1
Cr-Commit-Position: refs/heads/master@{#374371}

Review URL: https://codereview.chromium.org/1665513002

Cr-Commit-Position: refs/heads/master@{#374643}

Revert of [Contextual Search] Re-landing the CL: https://codereview.chromium.org/1669983003/ (patchset #3 id:40001 of https://codereview.chromium.org/1685763003/ )

Reason for revert:
Test crashes flakily (e.g., https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/24765). I would attach a snippet of output from the crash, but there is no useful output that I can see.

Original issue's description:
> [Contextual Search] Re-landing the CL: https://codereview.chromium.org/1669983003/
>
> Fixes and re-enables
> ContextualSearchManagerTest#testChainedSearchLoadsCorrectSearchTerm.
>
> Sometimes, the test tries to check the search term before
> the URL has started loading, which ends up resulting in
> failing to match the search term. The empty URL could also
> cause a crash when running the test, so this CL fixes the
> problem by waiting for the URL to match the search term,
> and also checks if the URL is null to prevent crashes.
>
> BUG=551711
>
> Committed: https://crrev.com/9be717a273fb91fc5e2f1217fd42baabd92025fe
> Cr-Commit-Position: refs/heads/master@{#374531}

TBR=mdjones@chromium.org,pedrosimonetti@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=551711

Review URL: https://codereview.chromium.org/1683083002

Cr-Commit-Position: refs/heads/master@{#374642}

It is useful when we write a template function/class which takes
a IDL dictionary as a template parameter. We can avoid passing both T and V8T.

Review URL: https://codereview.chromium.org/1686033002

Cr-Commit-Position: refs/heads/master@{#374641}

Splitting interactive_test_utils_mac.mm to
mac specific part - interactive_test_utils_mac.mm
and cocoa-views part - interactive_test_utils_cocoa.mm.

Splitting interactive_test_utils_views.cc to
interactive_test_utils_common_views.cc that can be used in mac tests
and interactive_test_utils_views.cc that used only in toolkit-views tests.

Disabled 3 tests files that are not ready for mac_views.

BUG=575036
COLLABORATOR=kirr@yandex-team.ru
Also reviewed in http://crrev.com/1669793002/

Review URL: https://codereview.chromium.org/1678163002

Cr-Commit-Position: refs/heads/master@{#374640}

BUG=
TEST=blink_platform_unittests --gtest_filter="UserGestureIndicatorTest*"

Review URL: https://codereview.chromium.org/1684023003

Cr-Commit-Position: refs/heads/master@{#374639}

Custom tabs cannot be foregrounded so we can't create an intent in that
case.

BUG=585402

Review URL: https://codereview.chromium.org/1677273003

Cr-Commit-Position: refs/heads/master@{#374638}

Revert of Disable memory.top_10_mobile on linux (patchset #1 id:1 of https://codereview.chromium.org/1680613003/ )

Reason for revert:
CL causing the issue is reverted at crrev.com/1683003002

Original issue's description:
> Disable memory.top_10_mobile on linux
>
> BUG=585161
> TBR=nednguyen@google.com
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
>
> Committed: https://crrev.com/9868f92cc339d6a4b1fb38a3740932fd154cc6f8
> Cr-Commit-Position: refs/heads/master@{#374189}

TBR=nednguyen@google.com,zhenw@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=585161

Review URL: https://codereview.chromium.org/1690433002

Cr-Commit-Position: refs/heads/master@{#374637}

Revert of Disable v8.infinite_scroll on linux (patchset #1 id:1 of https://codereview.chromium.org/1680773002/ )

Reason for revert:
CL causing the issue is reverted at crrev.com/1683003002

Original issue's description:
> Disable v8.infinite_scroll on linux
>
> BUG=584634
> TBR=nednguyen@google.com
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
>
> Committed: https://crrev.com/50380ff34e7490c14fb9f1d94c75ee34d968b1ae
> Cr-Commit-Position: refs/heads/master@{#374199}

TBR=nednguyen@google.com,zhenw@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=584634

Review URL: https://codereview.chromium.org/1681333004

Cr-Commit-Position: refs/heads/master@{#374636}

Prepare for passing more information along, specifically whether
intrinsic sizes are specified, when computing intrinsic sizing
information. Do this by introducing a struct carrying the relevant
information. No functional change expected.

Factor out a part of computeAspectRatioInformationForLayoutBox (now
named computeIntrinsicSizingInfoForLayoutBox) and put in a separate
function constrainIntrinsicSizeToMinMax. In the process remove a FIXME
about moving code back to some undefined previous state that's
confusing now that the code has moved around even more.

BUG=585467

Review URL: https://codereview.chromium.org/1687503002

Cr-Commit-Position: refs/heads/master@{#374635}

Editing: Pass failure information of CompositeEditCommand::deleteSelection() to TypingCommand::doApply().

Passing EditingState through the following path in order to abort the command
gracefully:
 - CompositeEditCommand::deleteSelection()
 - TypingCommand::deleteKeyPressed()
 - TypingCommand::doApply()

This is necessary in the following case.  It removes <body> from the document
during Delete command.

<iframe id=tCF5 src="javascript:onunload = function() {
  if (!top.container) {
    top.container = document.createElement('div');
    top.container.appendChild(frameElement.parentNode);
  }
}">M!?+Bvi9SO[
</iframe><script>
document.designMode = 'on';
rr746 = document.createRange();
rr746.selectNodeContents(tCF5)
window.getSelection().addRange(rr746);
document.execCommand("Delete")
</script>

BUG=570869

Review URL: https://codereview.chromium.org/1684733003

Cr-Commit-Position: refs/heads/master@{#374634}

Revert of Reland Fix leak PaintLayerReflectionInfo (patchset #2 id:20001 of https://codereview.chromium.org/1681663003/ )

Reason for revert:
I suspect this broke webkit_unit_tests on Mac Asan (https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/11738/steps/webkit_unit_tests/logs/All_ParameterizedWebFrameTest.CompositedSelectionBoundsCleared_1). Will reland if not the culprit.

Failure snippet:

[ RUN      ] All/ParameterizedWebFrameTest.CompositedSelectionBoundsCleared/1
=================================================================
==37555==ERROR: AddressSanitizer: heap-use-after-free on address 0x610000001b50 at pc 0x00010b1599b5 bp 0x7fff5bb669d0 sp 0x7fff5bb669c8
READ of size 8 at 0x610000001b50 thread T0
    #0 0x10b1599b4 in blink::PaintLayerScrollableArea::scrollbarsCanBeActive() const (in webkit_unit_tests) + 420
    #1 0x105dd885b in blink::ScrollAnimatorMac::updateScrollerStyle() (in webkit_unit_tests) + 283

Original issue's description:
> Reland Fix leak PaintLayerReflectionInfo
>
> NOT FOR COMMIT, YET
>
> Originally https://codereview.chromium.org/1657883002/
> Patch by wangxianzhu@
>
> Previously PaintLayerReflectionInfo required destroy() to be called
> before destruction, but we missed the call in
> PaintLayer::updateReflectionInfo(), causing leak of the reflection
> layout object and the layer for the reflection.
>
> Delete PaintLayerReflectionInfo::destroy(). Use destructor instead.
>
> BUG=582717
> TEST=PaintLayerTest.ReflectionLeak
>
> Committed: https://crrev.com/6137b72d44c0391a39e2a8f9cad9efb4706880e9
> Cr-Commit-Position: refs/heads/master@{#374556}

TBR=pdr@chromium.org,chrishtr@chromium.org,rnk@chromium.org,hans@chromium.org,schenney@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=582717

Review URL: https://codereview.chromium.org/1685073002

Cr-Commit-Position: refs/heads/master@{#374633}

The strings are componentized to be shared with the iOS build.

TBR=pkasting

Review URL: https://codereview.chromium.org/1682033002

Cr-Commit-Position: refs/heads/master@{#374632}

All users are on the new EDK now. This wipes out third_party/mojo,
updates all dependencies, and removes the use-new-edk flag.

BUG=None

Review URL: https://codereview.chromium.org/1676913002

Cr-Commit-Position: refs/heads/master@{#374631}

BUG=579040

Review URL: https://codereview.chromium.org/1665163002

Cr-Commit-Position: refs/heads/master@{#374630}

Nodes which need style recalculations after being distributed to new
insertion points, new positions within insertion points, or simply not
distributed anymore, are being reattached in
InsertionPoint::setDistributionNodes().

R=hayato@chromium.org,kochi@chromium.org,esprehn@chromium.org
TEST=fast/dom/shadow,fast/css
BUG=584177

Review URL: https://codereview.chromium.org/1677463002

Cr-Commit-Position: refs/heads/master@{#374629}

As 'mode' is a required parameter in the spec, omission should
throw an exception.

BUG=531990
TEST=imported/web-platform-tests/shadow-dom/Element-interface-attachShadow-expected.txt

Review URL: https://codereview.chromium.org/1685063002

Cr-Commit-Position: refs/heads/master@{#374628}

This is done in preparation to changes to error messages for
JSON.parse in V8.

R=machenbach@chromium.org
BUG=chromium:585724
NOTRY=true

Review URL: https://codereview.chromium.org/1690553002

Cr-Commit-Position: refs/heads/master@{#374627}

Split from https://codereview.chromium.org/1264453002

BUG=none
R=hiroshige,japhet

Review URL: https://codereview.chromium.org/1656673003

Cr-Commit-Position: refs/heads/master@{#374626}

Cr-Commit-Position: refs/heads/master@{#374625}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d7cce437eb1f..9f61ad391dd0

$ git log d7cce437e..9f61ad391 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1688643002

Cr-Commit-Position: refs/heads/master@{#374624}

The bug for which it was disabled is now fixed.

BUG=582472
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1682883002

Cr-Commit-Position: refs/heads/master@{#374623}

Passing EditingState through the following path in order to abort the command
gracefully:
 - RemoveNodeCommand::doApply()
 - CompositeEditCommand::applyCommandToComposite()
 - CompositeEditCommand::removeNode()
 - DeleteSelectionCommand::removeNode()
 - DeleteSelectionCommand::handleGeneralDelete()
 - DeleteSelectionCommand::doApply()
 - CompositeEditCommand::applyCommandToComposite()
 - CompositeEditCommand::deleteSelection()
 - ReplaceSelectionCommand::doApply()

This is necessary in the following case.  It removes <body> from the document
during InsertHTML command.

<iframe src="javascript:onunload = function() {
  if (!top.container) {
    top.container = document.createElement('div');
    top.container.appendChild(frameElement.parentNode);
  }
}">
</iframe>
<iframe onload="
  document.counter = 1;
  if (document.counter &lt;= 16) {
    document.designMode = 'on';
    document.execCommand('selectall');
    document.execCommand('inserthtml', false);
}">

BUG=541002, 529929

Review URL: https://codereview.chromium.org/1690513002

Cr-Commit-Position: refs/heads/master@{#374622}

Record blink.user_timing.{firstPaint, firstContentfulPaint} as
process-wide instant trace-events, in order to make them easier to find
in trace viewer.

BUG=546448

Review URL: https://codereview.chromium.org/1690533002

Cr-Commit-Position: refs/heads/master@{#374621}

TBR=rockot@chromium.org
R=tsepez@chromium.org

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1684783002

Cr-Commit-Position: refs/heads/master@{#374620}