- 13 Apr, 2020 40 commits
-
-
Devlin Cronin authored
Replace GetBrowserActionCommand() and GetPageActionCommand() in CommandService with GetExtensionActionCommand(), which takes an ActionInfo::Type to specify the type to look for. This reduces the complexity of many callsites (like ExtensionActionViewController and ExtensionInstalledBubbleModel) and reduces the dependency on specific types of actions, which will make it easier to support a generic "action". Bug: 893373 Change-Id: I9f566669f77256092676ccdea4e6aeb7b5054bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145157 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#758644}
-
Dan Harrington authored
Bug: 1044139 Change-Id: Ibb7e853d80bcb251822f5105bd672c58ec364646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145756 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#758643}
-
Maggie Chen authored
The timeout limit for finch will be changed from 60 seconds to 50 seconds Bug: 949839,1069938 Change-Id: I067009fe71d38fb95a10c13c3267b06355967f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146208Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758642}
-
Jinsuk Kim authored
ChromeActionModeHandler adds an observer for init-web-contents event of TabWebContentsObserver for each tab in order to register ChromeActionModeCallback to its WebContents, therefore enabling floating/toolbar action mode menu. For newly created tab, there was a bug this registration of the callback not working (ok for the tab already created and swapping into foreground). It's because init-web-contents event occurs before adding an observer(mInitWebContentsObserver) to TabWebContentsObserver, missing the chance to register the callback. This CL manually triggers the mInitWebContentsObserver for all the newly created tab to fix the bug. Previously it was applied to only the very first tab being added, but now extended to all those the newly created and added. Bug: 1067524 Change-Id: I511f15363e1e77f13347c5358aaf6eb3874a1a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136569Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#758641}
-
David Tseng authored
Whenever an extension has "incognito": "split" and is running in an incognito context (e.g. login screen), the extension system will start two instances of the extension. One is running in the incognito context, and the other in the non-incognito context. ChromeVox has never handled this split well and it has mostly been harmless except for some unexplicable bugs. One of these is double processing some touch gestures (e.g. double tap). This recently became much clearer because the non-incognito context has no range (receiving no automation events). However, it still gets the double tap gesture event. It now speaks "No focus" on double tap. Though this is likely due to the source broadcasting events to all contexts, ChromeVox should simply not be running at all in the non-incognito context. We can detect this very specific state by checking both the manifest's incognito value and the result of chrome.extension.inIncognitocontext. This change also fixes loading sounds for the cases where we run incognito split and likely other cases yet to be discovered. Test: manual Bug: 1046430 RELNOTES: n/a Makes more commands available when ChromeVox has no range RELNOTES: Some ChromeVox commands can now be used when there's no focus e.g. speaking the battery status or opening the ChromeVox menus. Change-Id: I4ce624d226b42311a446fb3cf6bcac0b927c973f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147679Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#758640}
-
Kurt Horimoto authored
Calling [self class] from class selectors is unnecessary since |self| is already a class. Bug: none Change-Id: I76f72c489a48ae1f17dda7eac7b67ecbba8f3e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148061 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#758639}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ee7525af4712..32457326e052 git log ee7525af4712..32457326e052 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 tobine@google.com Vulkan: Roll Headers and VVL repos Created with: gclient setdep -r src/third_party/angle@32457326e052 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ib115c942c0453aa1714ec1b5f75e5d194b55c4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758638}
-
Chromium WPT Sync authored
Using wpt-import in Chromium aa51882f. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 380347e7 "[css-masking] Migrate clip-path-columns-svg-clippath-usou.html to WPT" 2f3bb77d "[device-orientation] Upstream web tests to WPT" 1992b7fe "Do not set integrity metadata in preload scanner for <link rel=preload as=image>" 9e22b2c7 "[css-flexbox] Move negative-flex-rounding-assert.html to WPT" 67963d34 "[css-flexbox] Move negative-margins-assert.html to WPT" d53acfce "[css-grid] Migrate positioned-grid-items-crash.html to WPT" 5ec29e3e "[css-grid] Migrate grid-tracks-stretched-with-different-flex-factors-sum.html to WPT" 03a85d57 "[client hints]: Properly apply persisted accept-CH policy in 3P context" 0ef2cae6 "Revert "Treat any HTML element with a tabindex attribute as interactive content"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I6da084a71e70a7f5735a18c8baa6dacc2d7f36d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147954Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758637}
-
Stephen Roe authored
This is a reland of e2eb7388 System log collection is enabled by specifying a --enable-fuchsia-system-log argument which causes the test runner scripts to write the fuchsia system log to the test system_log file instead of writing the fuchsia kernel log file. Original change's description: > [fuchsia] Collect Fuchsia system logs from Chrome-Fuchsia tests. > > The Fuchsia system logs contain more detailed information than the Fuchsia kernel logs. > > Currently only Fuchsia kernel logs are collected. The kernel logs are: > - written to the swarming task output log along with the actual test output > - optionally written to a "system_log" file in the test isolate output > > This CL will: > - optionally write the Fuchsia system log to a "log_listener_log" in the test isolate output > > The Fuchsia system log will be written if the kernel log is written. > > The Fuchsia system log is written to "log_listener_log". The name "log_listener_log" was used because the Fuchsia kernel log contents are already saved in "system_log". > > Bug: 1042512 > Change-Id: I900b5dfe9f6587f1901c19612060b979fae4da99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130679 > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Commit-Queue: Stephen Roe <steveroe@google.com> > Cr-Commit-Position: refs/heads/master@{#756118} Bug: 1042512 Change-Id: I9edf2991e697e09b81b7c206cce0de04ca42b500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136143 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#758636}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1070295 Change-Id: I2fd3ed9e12abe360d7e79739d0a06d9d61ff6a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145251 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#758635}
-
Alex Turner authored
The test is flaky. Bug: 1069346 Change-Id: Ib6707d6b3ea59faddf424abcb214e78da5f3f578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147832Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#758634}
-
Bo Liu authored
Add it where weblayer_browsertests current runs, except Android. Note this does not add weblayer_unittests_apk that's analogous to weblayer_browsertest_apk. Bug: 1065585 Change-Id: I9d6911ec7ebe55f85fb85103dc238834cdc578fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146919Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758633}
-
Daniel McArdle authored
Design doc: https://docs.google.com/document/d/14eCqVyT_3MSj7ydqNFl1Yl0yg1fs6g24qmYUUdi5V-k/edit?usp=sharing Bug: 1052476 Change-Id: Ifcf91084f6e105de68873b5731a62ce3b0acfd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144233 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#758632}
-
David Van Cleve authored
This CL adds logic to TrustTokenRequestHelperFactory to vend appropriately parameterized TrustTokenRequestSigningHelpers when requests bear Trust Tokens parameters with OperationType==kSigning. This requires that the request's Trust Tokens issuer be a suitable Trust Tokens origin. R=csharrison constructing a signing helper fails with an unsuitable issuer. Test: Expand TrustTokenRequestHelperFactory's unit tests to verify that Change-Id: Iadbfe160415c97afb68f17a05d98ca71d5bdfbcb Fixes: 1068676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140176 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Move GetOverrideChannelForActionType() from extension_test_util to action_info_test_util. The latter is more targeted for action-related test utilities. Update callers accordingly. Bug: None Change-Id: Ie7979b1db8b254d2ccf3622a1a6d2ef7e1f136b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133553Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1d21ad03..e5287caf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I54fdf78c443c3f38a9fb89306b3fb419f8d21788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147191Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758629}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3953d04a0b8..ed4e52c379b6 git log f3953d04a0b8..ed4e52c379b6 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 egdaniel@google.com Fill in the rest of the d3d pipeline besides shaders and root descriptor. 2020-04-13 mtklein@google.com remove i16x2 ops 2020-04-13 mtklein@google.com impl uniform16 2020-04-13 mtklein@google.com remove some integer comparison ops 2020-04-13 mtklein@google.com skvm unit test cleanup Created with: gclient setdep -r src/third_party/skia@ed4e52c379b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I6f197ea72193b8917ddde6a80d130071cd173b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147908Reviewed-by:
-
Chris Thompson authored
U+2800 (BRAILLE PATTERN BLANK) isn't in the WSpace or Formatting/Invisibles sets, but should be treated like a space for purposes of unescaping. Bug: 1068531 Change-Id: I151f7c803898bc86d81570a93fbe682daf1cca86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147477Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#758627}
-
Xiaohan Wang authored
This reverts commit 02f002af. Reason for revert: test failure. see https://crbug.com/1070388 Original change's description: > [Upboarding]: Add a tile group proto. > > Bug: 1068368 > Change-Id: I1a2da9a32a71537abb3fd3626ef2614dcd24e0ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145703 > Commit-Queue: Hesen Zhang <hesen@chromium.org> > Reviewed-by: Hesen Zhang <hesen@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758600} TBR=shaktisahu@chromium.org,xingliu@chromium.org,hesen@chromium.org Change-Id: Iaadf0809f227e401b42d28d69dc6518c564a87e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1068368, 1070388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148069Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#758626}
-
Allen Bauer authored
TBR=thomasanderson@chromium.org, atwilson@chromium.org Bug: 1056944 Change-Id: I2fa2aa79634a85db72472067d2faeb9be5b26ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134703Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#758625}
-
Hirokazu Honda authored
The new tests to check VaapiVEA::Initialize() returns false with a temporal layer and spatial layer configuration. Bug: 1030199 Test: media_unittests on eve and on CQ Change-Id: I161409a992eb20531174f61fb4cfa14b43337903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141501 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#758624}
-
Bruce Dawson authored
When testing whether a system's status is clean or not it is possible to not have enough events to be able to make a determination. In this case we are in a state of not-success but not-failure. Given that this state is known to happen we need to not fail the test. The cause of insufficient events is well understood (running browser_tests generates enough events to flush out all older events) and Microsoft's recommendation is to ignore the DCOM events that cause this flushing so that is what this effectively change does. Reference: https://support.microsoft.com/en-us/help/4022522/dcom-event-id-10016-is-logged-in-windows Bug: 968440,1070362 Change-Id: Ie5e2e10289da02b306419cdbcccc707774f55001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147795 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#758623}
-
Xinghui Lu authored
According to b/150472142#comment28, header is not needed when oauth token is empty. Bug: 1041912 Change-Id: Ia2301ca017777319449f4e07bbdd185f8d871dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147040 Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#758622}
-
Joshua Peraza authored
Crashpad began using ScopedClearErrno in https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2119645 but chromium's ScopedClearErrno was replaced with ScopedClearLastError. mini_chromium was updated to mirror chromium's ScopedClearLastError in https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/2141050 Change-Id: I562e25c4033a3c892a6982e3a827a9ee821d8d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142144 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#758621}
-
Torne (Richard Coles) authored
Background/persistent window types are only used by Chrome extensions/apps and can't be created by web pages or service workers. Resolve the TODO by commenting to this effect. Fixed: 1019923 Change-Id: I584288997b2942f05460b725dedc68e2c4f09653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148033 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#758620}
-
chrome://interstitialsKurt Horimoto authored
This CL adds support for the chrome://interstitials WebUI, which contains links for dummy interstitials. Currently only a subset of the available links are implemented for iOS. Bug: 1064803 Change-Id: Ie8fed45623f18319ff1c8a9de5108108a796b2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145154 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
The test has been flaky. See Bug for details. Bug: 1070344 Tbr: kelvinjiang@chromium.org Change-Id: I106784d25661a04c6cf7340d349e3d8a8785f212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146299Reviewed-by:
-
Carlos IL authored
The test in this file checks the SB reporting API is called when an SSL interstitial is shown or clicked through, but checks the non committed interstitials code (and has been disabled for a long time). For committed interstitials this is better checked with a browser test and one already exists (SSLUITest.TestExtensionEvents). Bug: 1026557 Change-Id: I696e628a66341a377130bbc201db9cc25a98a064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145871Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
This reverts commit f5bc3fb9. Reason for revert: causing compile failure, see crbug.com/1070377, or https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome/5772 Original change's description: > Reland "Uprev LibAssistant to 1.46s" > > This is a reland of e3f29527 > > Original change's description: > > Uprev LibAssistant to 1.46s > > > > The current LibAssistant branch (1.42c) is no longer maintained, > > and also does not contain the latest features. > > > > * This will only be landed after M83 branches > > * This depends on the internal changes to land first > > > > Note: > > Bug: b/152777569 > > Change-Id: Ic34b6ca3ba1d793c719ebb58ab9766e943fc5ec6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134617 > > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > > Reviewed-by: Tao Wu <wutao@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#758408} > > Bug: b/152777569 > Change-Id: I2aa720f229708d8ccfac7656a5d5d41606a13b37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147808 > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > Cr-Commit-Position: refs/heads/master@{#758603} TBR=xiaohuic@chromium.org,wutao@chromium.org,jeroendh@google.com Change-Id: I7a080b04ea9cc03391564ae7c215d72b7ffc2eb1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/152777569, 1070377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145707Reviewed-by:
-
Sreerenj Balachandran authored
If the Video Encode hardware accelerator has support for VP9Profile0 and VP9Profile1, RTCVideoEncoderFactory creates a pipeline for Profile1 which is not supported by blink or webrtc. Moreover, it will mess up the h/w encoder by sending an illegal combination of chroma-subsampling 4:2:0 raw input and a Profile1 config. This patch is trying to address two issues: a) make sure that CreateVideoEncoder return successfully once there is a match found with SdpVideoFormat, otherwise a video-encoder will get created for each supported format and override the previous one. b) Ensure that VEAtoWEBRTCFormat doesn't return a legit profile id for VP9 profile1 otherwise, SupportedFormats will get populated with wrong sdp_formats against VideoCodecProfile. Webrtc supports profile0 & profile2. BUG = b:153680337 TEST = Run https://appr.tc/?debug=loopback&vrc=vp9&vsc=vp9 on a platform that has more than one profile encode support for VP9. H/W encode will fail and fall back to the software encoding. Change-Id: Ic779375d98fb56d9a1509e042faedfa002f9bf29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146173Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Cr-Commit-Position: refs/heads/master@{#758615}
-
Katie D authored
Updates colors, fonts, sizes to match new Live Caption spec. Adds a title per spec which is shown when the caption is only one line high. Sets the max width of the bubble, but does not yet dynamically resize. Note that the bubble is still too tall because it shows a close button. Per spec we will probably move this close button out later, but leaving it in for functionality during testing. Bug: 1055150 Change-Id: I5f4a3fa0b218f5c8a4b50fb0fedb8d4a1547f44e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144813Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#758614}
-
Xianzhu Wang authored
We should do this regardless of the box's scrollability, because we create a scroll node for the root scroller even it's not scrollable. Previously a root scroller without ScrollHitTest caused mistaken main thread scrolling because the scroll node for the root scroller didn't have a corresponding cc::Layer [1]. [1] https://source.chromium.org/chromium/chromium/src/+/master:cc/trees/layer_tree_host_impl.cc;drc=3acc95496c515d8c58aa6fff63ac7da5455e9eb5;l=3723 Bug: 1041322 Change-Id: Idd6841b87f3e0a101746d0dca15e5eba19cc77a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143511 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#758613}
-
Hirokazu Honda authored
Temporal and spatial layer encoding configuration has been refused in RtcVideoEncoder (VEAClient for webrtc). crrev.com/c/2131444 starts to propagate the configuration to VEA so that each VEA judges if they are supported. As VaapiVEA and V4L2VEA support neither temporal nor spatial layer encoding currently, this CL modified their Initialize() to fail if such mode is requested via the Config parameters. Bug: 1030199 Test: HW decoder and encoder is used in appr.tc on shyvana Bug: vea test on shyvana Bug: media_unittests --gtest_filter=VaapiVEA* on shyvana Change-Id: Ic5501230e1d1f82bb20901915c264d1c67691061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132007Reviewed-by:
-
Philip Rogers authored
Backdrop-filter should create a containing block for fixed and absolute position except for the root[1]. Will-change: backdrop-filter should do the same[2]. [1] https://drafts.fxtf.org/filter-effects-2/#BackdropFilterProperty [2] https://drafts.csswg.org/css-will-change/#will-change Bug: 960953 Change-Id: Icaddd0ad44cc64a146233ed6e793ea2b295c3b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147510Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#758611}
-
Mohit Hotwani authored
Reboot shared library needs to be initialized before using. Bug: internal b/153597183 Change-Id: I8cf6b28a85aec274e3561367a2d7d0aafe1d5f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146074Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Mohit Hotwani <hmohit@chromium.org> Cr-Commit-Position: refs/heads/master@{#758610}
-
dpapad authored
GetRawDataResource assumes that underlying files are not compressed, whereas LoadDataResourceString automatically decompresses if necessary. This is one of many CLs, in preparation of compressing all HTML, JS, CSS, SVG files by default (meaning without requiring compress="gzip" to be specified). Bug: 1068407 Change-Id: I9e7d8857b9606ee5db57e22482a3557ea2343f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147549 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#758609}
-
Nate Fischer authored
This always shows the icon on L-M (because "report a bug" is still useful), and just hides the "switch WebView provider" menu option. Bug: 1070306 Test: Manual - launch on L-M and verify menu has "report bug" option Change-Id: I6baf14fcaa39d1f76decdb3214d2414d779b0750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147871Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#758608}
-
dpapad authored
Fixed: 1064234 Change-Id: I608d1b2a0b824bde5c430bc85df3323dd42ece49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147848 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#758607}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I6d394f94447293853f2ea2f4bdc116f2bf7a5802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147793Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#758606}
-
Mohit Hotwani authored
The crash uploader applies a rate limit to handling crash reports. If the upload fails, it retries the upload, and the rate-limiter treats the retry as another crash. This stops it from treating a retry as another crash. dumps so that the crash uploader can't read them. Bug: internal b/153742798 Test: cause upload failures by changing the permissions of the crash Change-Id: I4d09b90e97b9ff24cc68308219049faf6aa3371d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147801Reviewed-by:
-
