GitLab

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/de34936..8ca446a

TBR=yosin@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/946613003

Cr-Commit-Position: refs/heads/master@{#317382}

Revert of Test that visual state callbacks do not deadlock. (patchset #6 id:100001 of https://codereview.chromium.org/939673002/)

Reason for revert:
Timing out on Blink waterfall. See https://code.google.com/p/chromium/issues/detail?id=458577#c10 .

Original issue's description:
> Test that visual state callbacks do not deadlock.
>
> Visual state callbacks should always be received,
> even if there are no pending commits. We add
> a test for that. See crbug/458577 for more details.
>
> BUG=458577
>
> Committed: https://crrev.com/dcc18cb569b31bc07c97d49573e695ec8b1f80c0
> Cr-Commit-Position: refs/heads/master@{#317306}

TBR=piman@chromium.org,sievers@chromium.org,skyostil@chromium.org,igsolla@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=458577

Review URL: https://codereview.chromium.org/942973002

Cr-Commit-Position: refs/heads/master@{#317381}

BUG=452592

Review URL: https://codereview.chromium.org/945723003

Cr-Commit-Position: refs/heads/master@{#317380}

There have been several user complaints regarding extra announcements coming most likely from background tabs. Especially with many tabs open, this can become an issue. We should reexamine some other way to surface this type of functionality in ChromeVox Next.

The original cl was commited pre-Chrome migrated ChromeVox.

TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/944063002

Cr-Commit-Position: refs/heads/master@{#317379}

For studies where there is a single group with 100%
probability, avoid doing more expensive random entropy
computation, since it's not needed to know the final
result.

BUG=460481

Review URL: https://codereview.chromium.org/947493002

Cr-Commit-Position: refs/heads/master@{#317378}

Work around exceptions when the 'high' value for a histogram is not present. This happens when the histogram hits the max value.

BUG=455349

Review URL: https://codereview.chromium.org/941803002

Cr-Commit-Position: refs/heads/master@{#317377}

Java-based WebContentsObservers can be relatively expensive, incurring
JNI overhead, including necessary object conversions, for each callback.
As AccessibilityInjector only relies on 2 observer methods, instead use
ContentViewCore's observer to signal the necessary events.

BUG=457748,440134

Review URL: https://codereview.chromium.org/941353002

Cr-Commit-Position: refs/heads/master@{#317376}

Invalid baked-in configs would be leaked (in FromJSON) and then crash
due to a null deref (in AddContext).

This change also makes two minor improvements:
- pass scoped_refptrs by const ref
- use a StringPiece rather than a std::string when parsing bake-in configs

BUG=460483
R=ttuttle@chromium.org

Review URL: https://codereview.chromium.org/945923002

Cr-Commit-Position: refs/heads/master@{#317375}

Fix what looks like a copy-paste error in the assignment of
|was_alternate_protocol_available|.

Review URL: https://codereview.chromium.org/941973004

Cr-Commit-Position: refs/heads/master@{#317374}

Reland:Refactored pixel format resize operations in media/video/capture into a function called VideoCaptureFormat::GetSizeForVideoPixelFormat().

Relanding Issue https://codereview.chromium.org/897483002.

Refactored pixel format resize operations in  media/video/capture into a function called VideoCaptureFormat::GetSizeForVideoPixelFormat().

TEST=VideoCaptureDeviceTest.* in media_unittests pass.

Committed: https://crrev.com/79288ba0b63021e8731e0401b8a4a9055d33fa10
Cr-Commit-Position: refs/heads/master@{#315175}

Review URL: https://codereview.chromium.org/907113002

Cr-Commit-Position: refs/heads/master@{#317373}

This patch implements the estimation of (dis)chargingTime on devices
running Android L (and above). Android L supports new properties in
BatteryManager which can be used to provide such estimates.

BUG=401553
TEST=http://jsbin.com/battery-status-test

Review URL: https://codereview.chromium.org/874713003

Cr-Commit-Position: refs/heads/master@{#317372}

This is the first of three CLs to add synthetic gesture commands to the DevTools Input domain. The changes need to be split up so that the code generated from protocol.json has some stub functions to call.

1. crrev.com/846113004
2. crrev.com/841013002
3. crrev.com/792883007

BUG=448182

Review URL: https://codereview.chromium.org/846113004

Cr-Commit-Position: refs/heads/master@{#317371}

d:\src\cr2\src\net\quic\crypto\cert_compressor.cc(198): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\quic\crypto\cert_compressor.cc(198): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr2\src\net\quic\crypto\cert_compressor.cc(189): note: see declaration of 'i'

d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(668): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(668): warning C4456: declaration of 'client_hello_serialized' hides previous local declaration
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(652): note: see declaration of 'client_hello_serialized'
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1336): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1292): note: see declaration of 'i'
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1481): warning C4457: declaration of 'token' hides function parameter
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1472): note: see declaration of 'token'
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1493): warning C4457: declaration of 'token' hides function parameter
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1472): note: see declaration of 'token'

d:\src\cr2\src\net\quic\crypto\strike_register.cc(498): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\quic\crypto\strike_register.cc(498): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr2\src\net\quic\crypto\strike_register.cc(453): note: see declaration of 'i'
c:\program files (x86)\microsoft visual studio 14.0\vc\include\utility(151): note: while compiling class template member function 'std::pair<uint32,uint32>::pair<uint32,uint32,void>(std::pair<uint32,uint32> &&) noexcept'
d:\src\cr2\src\net\quic\crypto\strike_register.cc(502): warning C4456: declaration of 'bit' hides previous local declaration
d:\src\cr2\src\net\quic\crypto\strike_register.cc(454): note: see declaration of 'bit'
ninja: build stopped: subcommand failed.

d:\src\cr2\src\net\quic\quic_framer.cc(1350): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\quic\quic_framer.cc(1350): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr2\src\net\quic\quic_framer.cc(1338): note: see declaration of 'i'
d:\src\cr2\src\net\quic\quic_framer.cc(2102): warning C4456: declaration of 'time_delta_us' hides previous local declaration
d:\src\cr2\src\net\quic\quic_framer.cc(2080): note: see declaration of 'time_delta_us'
ninja: build stopped: subcommand failed.

BUG=440500
R=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/941933002

Cr-Commit-Position: refs/heads/master@{#317370}

Adding knobs on HQP provider. Having an option of experimenting with topicality score and changing final relevance score ranges from omnibox bundled params.

1. Option to suppress the URLs with topicality score lower than the given threshold. This way we can control the URLs with high popularity and low topicality scoring.

2. Changing the final-relevance score buckets to linearly interpolate with in-certain ranges. This will help to control the score ranges.

With above options one can set the bundled params. Ex:

HQPExperimentalScoringEnabled="true"
HQPExperimentalScoringTopicalityThreshold="0.8"
HQPExperimentalScoringBuckets="0.0:400,1.5:600,12.0:1300,20.0:1399"

More details can be found in the bug: crbug/306198

BUG=306198
TEST=ScoredHistoryMatchTest.GetFinalRelevancyScore

Review URL: https://codereview.chromium.org/905023003

Cr-Commit-Position: refs/heads/master@{#317369}

Infobar which allows user to choose Credentials.
Infobar is triggered via Credentials Manager API.

R=vabr@chromium.org,brettw@chromium.org,newt@chromium.org
BUG=454815

Review URL: https://codereview.chromium.org/861103002

Cr-Commit-Position: refs/heads/master@{#317368}

The test was not resilient against arbitrary pipeline depths and encode
delays. It was possible for the encode request to keep overwriting
keframe_requested_at_ faster than the deadline check by which we would've
failed if no keyframe was provided. Thus it was possible for the test to
always pass, even without getting any keyframes.

Simplify this by just checking that each keyframe arrives before
every keyframe_period_ + kMaxKeyframeDelay.

Also, some cleanup for fake encoder validator creation.

BUG=None
TEST=veatest --gtest_filter=ForceKeyframes*

Review URL: https://codereview.chromium.org/942693003

Cr-Commit-Position: refs/heads/master@{#317367}

The ProcUtil tests HasOpenDirectory HasOpenDirectoryWithFD use
/dev to test HasOpenDirectory. /dev fails to open on Android
due to SELinux. This change picks /proc/self instead, which
will work on all linux platforms.

BUG=459360
TEST=sandbox_linux_unittests

Review URL: https://codereview.chromium.org/939723003

Cr-Commit-Position: refs/heads/master@{#317366}

Update //third_party/usb_ids/usb.ids to version 2015.02.03, released
2015-02-03 at 20:34:06.

This file was fetched from http://www.linux-usb.org/usb.ids and
includes vendor and product IDs for new USB devices and updates to
existing entries.

BUG=

Review URL: https://codereview.chromium.org/938203003

Cr-Commit-Position: refs/heads/master@{#317365}

BUG=454198
R=ellyjones@chromium.org

Review URL: https://codereview.chromium.org/935073003

Cr-Commit-Position: refs/heads/master@{#317364}

BUG=453471

Review URL: https://codereview.chromium.org/922293004

Cr-Commit-Position: refs/heads/master@{#317363}

This requirement is only a requirement on the Manifest content. It is
then up to the ManifestIconSelector to pick the best icon which might
be a smaller one.

BUG=457399

Review URL: https://codereview.chromium.org/946573002

Cr-Commit-Position: refs/heads/master@{#317362}

Feature is implemented in cl https://codereview.chromium.org/944533002/.
Checking in user visible string separately so that it is in time for translation.

BUG=456247

Review URL: https://codereview.chromium.org/939393002

Cr-Commit-Position: refs/heads/master@{#317361}

This moves EXPECT_CALL invocations into separate method, reducing
code duplicaton and increasing readability.

Also moves passphrase setting and state checks to separate methods,
also reducing code duplication.

BUG=

Review URL: https://codereview.chromium.org/937183002

Cr-Commit-Position: refs/heads/master@{#317360}

This will allow custom media renderers to instantiate
default renderer factory, which expects media log.

BUG=457959

Review URL: https://codereview.chromium.org/943903002

Cr-Commit-Position: refs/heads/master@{#317359}

This patch fixes an exception thrown while running ChromiumLinkerTest
which was caused by null Context. The solution is to make
ChromeLinkerTestApplication be a subclass of BaseChromiumApplication
because it automatically calls ApplicationStatus.initialize() in
onCreate().

BUG=459669

Review URL: https://codereview.chromium.org/941953003

Cr-Commit-Position: refs/heads/master@{#317358}

patch from issue 937933002 at patchset 1 (http://crrev.com/937933002#ps1)

BUG=

Review URL: https://codereview.chromium.org/942843002

Cr-Commit-Position: refs/heads/master@{#317357}

Revert of Revert of Revert of Now that the cq runs tests on rel, the compile-only bug should be dbg. (patchset #1 id:1 of https://codereview.chromium.org/941363002/)

Reason for revert:
`findbugs` is running and failing. Undo this again while I figure that out.

Original issue's description:
> Revert of Revert of Now that the cq runs tests on rel, the compile-only bug should be dbg. (patchset #1 id:1 of https://codereview.chromium.org/914023007/)
>
> Reason for revert:
> The regular android dbg bots also do static buils, so trying this again. I'm watching the bot.
>
> Original issue's description:
> > Revert of Now that the cq runs tests on rel, the compile-only bug should be dbg. (patchset #1 id:1 of https://codereview.chromium.org/937853002/)
> >
> > Reason for revert:
> > Too many red builds on the dbg not, need to investigate tomorrow. Also, it does a static build for some reason.
> >
> > Original issue's description:
> > > Now that the cq runs tests on rel, the compile-only bug should be dbg.
> > >
> > > Depends on https://codereview.chromium.org/913223007
> > >
> > > BUG=456396
> > > TBR=sergiyb@chromium.org
> > >
> > > Committed: https://crrev.com/3d0efdf9afa56e55b8d8c62fd883a1992f35cf45
> > > Cr-Commit-Position: refs/heads/master@{#316998}
> >
> > TBR=jam@chromium.org,sergiyb@chromium.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=456396
> >
> > Committed: https://crrev.com/f3a85349d2da16aa306f1fdc43ea3b5d21a9f956
> > Cr-Commit-Position: refs/heads/master@{#316999}
>
> TBR=jam@chromium.org,sergiyb@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=456396
>
> Committed: https://crrev.com/89f83d5a826c0bfdee8a8cafea307e84d8958df3
> Cr-Commit-Position: refs/heads/master@{#317341}

TBR=jam@chromium.org,sergiyb@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=456396

Review URL: https://codereview.chromium.org/947513002

Cr-Commit-Position: refs/heads/master@{#317356}

BUG=423481

Review URL: https://codereview.chromium.org/937203002

Cr-Commit-Position: refs/heads/master@{#317355}

This pulls in the following Native Client changes:

33b6a18: (yusukes@chromium.org) Implement faster NaClSysFutex functions for NACL_LINUX
0eec380: (yusukes@chromium.org) Revert "Implement faster NaClSysFutex functions for NACL_LINUX"
8dfb438: (bradnelson@google.com) Adding android opt bot to the default trybot list.
c5b278d: (mseaborn@chromium.org) irt.h: Add a comment to document that futexes are process-private
62b6f76: (bradnelson@google.com) Pull in new llvm rev, drop old build flag.
43b8d01: (shyamsundarr@chromium.org) use objdump instead of validator's disassembler in proofs.
10c2124: (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
456d6e4: (yusukes@chromium.org) Implement faster NaClSysFutex functions for NACL_LINUX

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/942033003

Cr-Commit-Position: refs/heads/master@{#317354}

Currently the automatic option of "Enable touch events" flag cannot
send the touch events to the pages, because the touch screen for
Linux is considered as an attach-slave device, the render thread sets
the "touchEnable" to false in this case. We now take consider both
floating-salve device and attach-slave device in order to send the
touch events to render.

BUG=443667

Review URL: https://codereview.chromium.org/914393002

Cr-Commit-Position: refs/heads/master@{#317353}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/87fa631..792c80f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/945913002

Cr-Commit-Position: refs/heads/master@{#317352}

BUG=452193

Review URL: https://codereview.chromium.org/941033002

Cr-Commit-Position: refs/heads/master@{#317351}

There was a typo that caused the class to confuse megabytes and kilobytes.

BUG=442546

Review URL: https://codereview.chromium.org/939283002

Cr-Commit-Position: refs/heads/master@{#317350}

Previously WebURLLoaderImpl would keep track of cancelling the request by reseting bridge_. Now that we use request_id_ there instead, we need to do the same and reset its value.

BUG=460335,338338

Review URL: https://codereview.chromium.org/941223002

Cr-Commit-Position: refs/heads/master@{#317349}

The bubble isn't instantiated yet and the new code is probably completely removed by linker.
See the screenshots in the bug tracker.

BUG=400674

Review URL: https://codereview.chromium.org/943933004

Cr-Commit-Position: refs/heads/master@{#317348}

BUG=

Review URL: https://codereview.chromium.org/936553002

Cr-Commit-Position: refs/heads/master@{#317347}

Use GetPreferredDataTypes rather than GetActiveDataTypes when performing sync check for chrome suggestions. This ensure we do not clear Chrome Suggestions when the sync service is starting up and not yet active, unless the user explicitely indicated he didn't want to sync history.

BUG=459729

Review URL: https://codereview.chromium.org/940043002

Cr-Commit-Position: refs/heads/master@{#317346}

BUG=395700

Review URL: https://codereview.chromium.org/942893002

Cr-Commit-Position: refs/heads/master@{#317345}

When frame size changes VideoDecoderShim is supposed to dismiss all
textures with the old size, but it wasn't doing it properly.

BUG=460280

Review URL: https://codereview.chromium.org/937413002

Cr-Commit-Position: refs/heads/master@{#317344}

This CL updates the documentation for vpnProvider interface to
reflect the behavior of the API.

BUG=459609
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/941343002

Cr-Commit-Position: refs/heads/master@{#317343}