- 30 Nov, 2019 16 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/fd12e1b746bd..969df2b3a21c git log fd12e1b746bd..969df2b3a21c --date=short --first-parent --format='%ad %ae %s' 2019-11-30 yunchao.he@intel.com Fix a typo in viewport test Created with: gclient setdep -r src/third_party/dawn@969df2b3a21c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I92c14c83ba3a101e9cb4cec47e3b548d07b5f926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944752Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720318}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f1472e5260e..0fdba28172fd Created with: gclient setdep -r src-internal@0fdba28172fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ib8ffc7646289951e3e1fe16c31f47543ecef66e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944748Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720317}
-
Koji Ishii authored
Following bot results are included. 467 469 471 472 473 474 475 476 694 lines were removed and 86 lines were deflaked by consecutive results since 455. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I8a0c85da76ac71124ea930e2c6942e26f8be541c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943074Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720316}
-
Mason Freed authored
Prior to this CL, the following code: <svg></p></svg> parsed to this innerHTML: <svg><p></p></svg> This is in contrast to this code: <svg><p></svg> which parses to <svg></svg><p></p> The fact that the </p> is left inside the <svg> allowed sanitizer bypasses as detailed in [1]. Please also see [2] for the spec discussion. With this CL, </p> and </br> within a foreign context now cause the closing of the foreign context. [1] https://research.securitum.com/dompurify-bypass-using-mxss/ [2] https://github.com/whatwg/html/issues/5113 Bug: 1005713 Change-Id: Ic07ee50de4eb1ef19b73a075bd83785c99f4f891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940722Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#720315}
-
Abhijeet Kandalkar authored
This CL has goal to use DynamicTo<SVGFEFuncRElement> as new downcast helper Bug: 891908 Change-Id: Iff93cc32f1f3052db517a13bd93d621448cedf80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936581Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#720314}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d9aad5a2c4f..1f1472e5260e Created with: gclient setdep -r src-internal@1f1472e5260e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I8288e5e6148e086ca61d48a0f309708ac306a03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944615Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to use DynamicTo<SVGFEImageElement> as new downcast helper Bug: 891908 Change-Id: Ie98c73604c13c6e3171ae1b050453326b8b1ec1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936582Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I351d9b0151e5bf8eb3101d5849e1852fa7a510b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944634Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720311}
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<SVGRectElement>(element) in place of IsSVGRectElement(element) Bug: 891908 Change-Id: I859dd6a2b6255c5ca8644b97c019a6eaf85fb3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936618Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#720310}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/81e835172bdb..4d9aad5a2c4f Created with: gclient setdep -r src-internal@4d9aad5a2c4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I9d0660a29d98ee6ef7120d836a350ad84bf9c98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943342Reviewed-by:
-
Koji Ishii authored
Fixes DCHECK failures when NGFragmenttItem is enabled for: virtual/layout_ng_block_frag/external/wpt/css/css-break/widows-orphans-005.html There are 120 other DCHECK failures at the same stack, probably fixes them too. Bug: 829028, 982194 Change-Id: I1ed7257d72cd43ddc5a1f3901f5ff89189a247ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942596Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720308}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/bf0fe874a27b..5395345ca4f0 This rolls to the parent of 20b5b8ecc7a81d23b4716e22a2b35fd53379c8c6, which introduces a static_assert checking that the first parameter of an INSTANTIATE_TEST_SUITE_P macro is non-empty. This check fails in Chrome, and rolling past this commit will require some work. $ git log bf0fe874a..5395345ca --date=short --no-merges --format='%ad %ae %s' 2019-10-07 joshdcannon Use FormatFileLocation for streaming file and line 2019-10-05 soap Add documentation for pkg-config in cross-compilation settings 2019-10-05 soap Revert "Use pcfiledir for prefix in pkgconfig file" 2019-10-03 misterg Googletest export 2019-10-03 absl-team Googletest export 2019-10-02 absl-team Googletest export 2019-09-29 misterg Googletest export 2019-10-01 ant35rookie Fix typo in documents 2019-09-29 misterg Googletest export 2019-09-27 misterg Googletest export 2019-09-25 absl-team Googletest export 2019-09-25 absl-team Googletest export 2019-08-16 pbarker Add many missing override keywords 2019-09-16 krystian.kuzniarek square away the stuff that hasn't been merged in a manual review 2019-09-07 krystian.kuzniarek square away the stuff that hasn't been merged in a manual review Created with: roll-dep src/third_party/googletest/src Tbr: jsbell Bug: 1009553 Change-Id: Ica69ab44f8ea61420a44ebe2f6554dddf8f9029c Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943389Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#720307}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I0ae629366a8db4d5944ab3645e97b86d18f71fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943755Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720306}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a75cf40b2371..81e835172bdb Created with: gclient setdep -r src-internal@81e835172bdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Id88d9cea3eb6529bc5204aeae9efae743659abfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943340Reviewed-by:
-
Victor Costan authored
https://chromium.googlesource.com/external/leveldb.git/+log/53e280b56866..2c9c80bd539c $ git log 53e280b56..2c9c80bd5 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 costan Move CI to Visual Studio 2019. 2019-11-10 costan Allow different C/C++ standards when this is used as a subproject. 2019-11-07 costan Align CMake configuration with related projects. 2019-11-05 costan Remove redundant PROJECT_SOURCE_DIR usage from CMake config. 2019-11-04 costan Fix installed target definition. 2019-11-03 costan Test CMake installation on Travis. 2019-10-28 cmumford Renamed local variable in DBImpl::Write. 2019-10-02 cmumford Added return in Version::Get::State::Match to quiet warning. 2019-10-01 cmumford Using CMake's check_cxx_compiler_flag to check support for -Wthread-safety. 2019-09-29 costan Update Travis CI configuration. 2019-09-10 sanjay Fix tsan problem in env_test. 2019-08-28 13126959424 drop fileds in State that are duplicates of fileds in Saver and fix typo 2019-06-12 13126959424 cache Saver in State object 2019-06-12 13126959424 fix bug(uninitialized options pointer in State) 2019-06-11 13126959424 remove TODO in Version::ForEachOverlapping 2019-06-11 13126959424 format 2019-06-11 13126959424 fix bug 2019-06-11 13126959424 use ForEachOverlapping to impl Get Created with: roll-dep src/third_party/leveldatabase/src Tbr: cmumford Change-Id: I8bc46032fdfe5a5988f52b1621c045d6f83a193f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943311Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/39000a4a1c2c..a75cf40b2371 Created with: gclient setdep -r src-internal@a75cf40b2371 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I8a003a11f735924e077cb96a9135464f0d9a69c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944318Reviewed-by:
-
- 29 Nov, 2019 24 commits
-
-
Morten Stenshorne authored
Bug: 829028 Change-Id: I252901109502256f14bc68e64d4303006db50a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944350 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720302}
-
Rune Lillesveen authored
If BlockHTMLParserOnStyleSheets is enabled, style sheets block the parser and are never render blocking. That is, HaveRenderBlockingResourcesLoaded() always return true. The test FragmentNavChangesFocusWhileRenderingBlocked is relying on render blocking to be a concept. Only run that with the runtime flag off. Bug: 891767 Change-Id: I30b439d5dfd39dcdf1f33dd966c2d8a622799922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942654Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#720301}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/076c46198fe1..bf0fe874a27b This CL rolls to the commit that introduced a change in the temporary file paths used by death tests on Android. This CL introduces a workaround that replaces the googletest implementation of the troublesome code with a proposed update that fixes the problem. This workaround will allow us to resume rolling googletest. The workaround will be removed after we have a solution landed in upstream googletest, and are able to roll to that solution's commit. $ git log 076c46198..bf0fe874a --date=short --no-merges --format='%ad %ae %s' 2019-09-24 absl-team Googletest export Created with: roll-dep src/third_party/googletest/src Bug: 1009553 Tbr: jsbell Change-Id: I1a86520d25e7bc96ac5484b093cb51019c9b02a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920025Reviewed-by:
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/core/style as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. Additionally, this CL adds explicit keyword when a constructor only has an argument. Bug: 939691 Change-Id: I013cabc242273e7c535d7abd2b52a8f18e8fd159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943628Reviewed-by:
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/core/input as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. Bug: 939691 Change-Id: I8d392effb5089f4a7025e38c5c83061652d2a9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942890Reviewed-by:
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/core/fetch as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. Bug: 939691 Change-Id: Ic63636e929814baf92cbe618a89a41b4cd25ae1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943710Reviewed-by:
-
Andres Calderon Jaramillo authored
This CL expands the raster task scheduling delay UMA to count raster work that depends on decodes that could be hardware accelerated (regardless of the status of the hardware decode acceleration feature flags). This is useful to measure the benefit of hardware decode acceleration on raster work that would be directly affected by it. Bug: 995155 Test: Added test coverage for the UMA expansion. Change-Id: Ic70443558f026308e8334061829dd05813fbe9fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794064 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#720296}
-
Yuly Novikov authored
Already suppressed in WebGL2 suite, expanding the suppression to webgl_conformance_gl_passthrough_tests. TBR=bsheedy Bug: 1026468 Change-Id: If7d27f5137597129141253261e10a3653c9e9ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943622Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#720295}
-
Michael Spang authored
In GYP we used to add all sources and then remove the unneeded ones. Switch to addition which requires only listing the sources in one place. Bug: 1026406 Change-Id: Ib085e35b59d3141e85b3265a0e849092adb9d1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943369Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#720294}
-
Kevin Ellis authored
Reason: Test flake on Linux. Bug: 1029541 Change-Id: I190d3cbe266b3e0f5288ec81556c2846d1a6ad96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944314 Commit-Queue: Kevin Ellis <kevers@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#720293}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6e994097607..39000a4a1c2c Created with: gclient setdep -r src-internal@39000a4a1c2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ia6ebf794f61f0b64bf956dc710262995f4694cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943525Reviewed-by:
-
Greg Thompson authored
Tasks in the ThreadPool must be run to allow DB cleanup tasks to run before deleting the temp dir in which the DBs reside. BUG=546640 R=pwnall@chromium.org Change-Id: I3ab31f7d9af5b8c0768bad8f24c2e8622a5e0f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943180 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d5f19e18. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." 9e056276 "Fix play controls for composited animations." 89b38e70 "Add ref tests for web-animation play controls" 4f49fdca "Port mask-image-interpolation to wpt/expernal" d5f19e18 "Remove cross fade from backgrounds" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ib6052ce71dd889c7c79fc56f369beafb2f93adc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944376Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720290}
-
danakj authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. TBR=clamy@chromium.org Bug: 1007760 Change-Id: Ib3ad0192ccbaecf6b1f931b81dbadfdcc7650ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943337Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#720289}
-
weiliangc authored
Update skia_renderer_gl_blink_web_tests expectations to allow flaky media/video-controls-visibility-multimodal-mouse-after-touch.html TBR=backer@chromium.org BUG: 1027772 Change-Id: I29355c70b07f7d54d618a5b518ab371417907127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943526Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#720288}
-
Eric Stevenson authored
Currently, the junit_binary template only supports running tests listed in its own java_files. This CL changes Junit test listing to search the classpath for tests. Tests can now be added by adding a dep on a Java target (similar to instrumentation tests). Tbr: agrieve@chromium.org # already approved. Bug: 1025364 Change-Id: Ia004843abaae3367f6eccc6355094fe20268da1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942413Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#720287}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ieb9d5a02ad88a7a712aca0345c51aac6a911db65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944650Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#720286}
-
Abhijeet Kandalkar authored
This CL has goal to use DynamicTo<SVGFEFuncBElement> as new downcast helper Bug: 891908 Change-Id: I8a374d96a16c68707a06ae96f1cb1f1353213b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936578Reviewed-by:
-
Jan Scheffler authored
This cl prepares for crrev.com/c/1944331 Fixed: 1029489 Change-Id: Iea69f54e975e586ff35dcc29349a227a52c90343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944491 Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#720284}
-
Lucas Furukawa Gadani authored
inserted into a disconnected node. Bug: 1029508 Change-Id: I8d90a488198b0772baa2bd41a16c6a330fc792fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943310Reviewed-by:
-
Jiaqi Han authored
CastWindowManager are used in chromecast code with the assumption that it outlives the browser process code, meanwhile CastWindowManager is reset before CastBrowserProcess, causing lifetime issues. Since CastWindowManager is owned by CastBrowserMainPart and is created before CastBrowserProcess, the reasonable fix is to swap the order to reset CastWindowManager after CastBrowserProcess. Because CastScreen is used by WindowManager during tear down, its ownership is moved to CastBrowserMainPart. This fixes cast_shell_browsertests. Bug: b/144778077, b/131312670 Test: CQ Change-Id: Iee03600138c3d7d9324ba3971d1aad816239115b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928897Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Jiaqi Han <jiaqih@google.com> Cr-Commit-Position: refs/heads/master@{#720282}
-
danakj authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. TBR=clamy@chromium.org Bug: 1007760 Change-Id: I1139e3b0a99d045070bf27421aa41fc5a8061b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943336Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I942736af12e892f234a6a4382d09cf79c5aa5d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944375Reviewed-by:
-
Juanmi Huertas authored
In this CL there is some clean up of enum to convert them to enum class, and remove a boolean merging it into the enum. Bug: 1021287 Change-Id: I732226e3e6d536cfe2c96049cf12b6a182f1886d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929520 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
-
