- 20 May, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fc311e53e3ef..e4f5cbe5d994 Created with: gclient setdep -r src-internal@e4f5cbe5d994 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mbarowsky@google.com,sidereal@google.com Change-Id: I0fdac631b4cf5d7c9ae6e3d38786017916ba743e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618596Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661382}
-
Mitsuru Oshima authored
The reason why it was flaky was that it label animation was going while rotating. Wait until label is shown so that we rotate the screen including label. I'll file a separae bug to cancel the label animation. Bug: 952885 Change-Id: Ic2af278d44182ba87e3e934e58fe872d5bc3e83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619423 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#661381}
-
Morten Stenshorne authored
It's wrong to walk all the way to the root and look for something with a fixed block size just to determine whether we can collapse through the block or not. It only matters what the actual block size of the containing block is. This bug triggered DCHECK failures, because the cached state of self-collapsing got out of sync with reality, because some ancestor went from auto-height to fixed-height, a change that shouldn't affect the descendant at all. Bug: 962175 Change-Id: Ic24d9c46dfa515306563b195487310eedfae9ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617833 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#661380}
-
Ryan Hamilton authored
Change-Id: Ie60e33efd9b18c737d935349ae5ecaac5121ed66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619010 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#661379}
-
Koji Ishii authored
This patch unifies the same logic separated in two places into one. Originally, the logic needed for new LayoutObjects in the tree is put into |InsertedIntoTree()|. However, some logic are added to |LayoutObjectChildList| too because they are needed to run regardless of |notify_layout_object|, which is an optimization when some of existing notifications can be skipped for in-tree moves. As it turned out that all LayoutNG logic are needed regardless of |notify_layout_object|, this patch moves all of them to |LayoutObjectChildList|. The |SplitFlow()| case was found in crbug.com/964619. Bug: 964854 Change-Id: I777b05fa2355e301ceb713b49d83734546e5ecf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617055 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Rohit Rao authored
This will allow EG2 tests to use these constants without pulling in more of //ios/chrome/browser/ui. BUG=None Change-Id: Ifb5dbeaf841b598767a63521aea6e07bb5f9dc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618123Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#661377}
-
Koji Ishii authored
List markers are not selectalbe. Before this change, it still hits in |LayoutNGMixin::PositionForPoint()| as atomic inline, which leads to crashes. Change-Id: I4563c493417cf72900f9da48a052f564fb5f0369 Bug: 964813, 964814, 964925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619593 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
David Bienvenu authored
Bug: 396477 Change-Id: Ie64abe2a732405d44aec185e3f49907a5fc799a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618747Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#661375}
-
Matthew Jones authored
Bug: 963516 Change-Id: If52da6c0d3c9b1a68e48a1e6ac39d6e785b44126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618032Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#661374}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iac0c69514081b707ef518e8eae076bfe60f10551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619660Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661373}
-
K Moon authored
The SK_CRASH and SK_DEBUGBREAK macros are no longer used by Skia, so there's no point in continuing to define them in SkUserConfig.h. There were a couple of references to SK_CRASH in //src/skia/ext; I've replaced them with equivalent CHECKs. Some other changes: * Refreshes skia/config/SkUserConfig.h from third_party/skia * Drops the now always-false |fatal| parameter in SkDebugf_FileLine * Consolidates customizations after the "Chrome-specific" line The changes pulled from third_party/skia's SkUserConfig.h mostly are comments and formatting, and should have no effect. Similar to https://pdfium-review.googlesource.com/c/pdfium/+/54650, but for Chromium instead of PDFium. The PDFium copy of SkUserConfig.h tries to minimize lint errors, while the Chromium copy tries to preserve the original formatting, so unlike the PDFium change, I haven't tried to fix lint errors. Change-Id: Ieb66af9e2f30a36a19184451966f9a85f2a10997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618148Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: K Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#661372}
-
Roman Sorokin authored
Mostly boilerplate code to let use it in the notification system. Bug: 930109 Change-Id: If263e6228c23f1b91c241b3d0444332a65fd73ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619809Reviewed-by:
A Olsen <olsen@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#661371}
-
David Benjamin authored
As of https://chromium-review.googlesource.com/c/chromium/src/+/882281/, that method no longer exists. Bug: 797998 Change-Id: Iaeadf89b1c696aeec0e7792ee08c406e867a6031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618302 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#661370}
-
Denis Kuznetsov authored
Existing approach did not work on official builds (because skipping update is not supported on them). Test: OobeConfigurationEnrollmentTest.*, with check that removing "updateSkipNonCritical" from sample configuration breaks tests. Bug: 854101 Change-Id: Ic8e598bec9297f5f6e3333abb42a5b2b0018df78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619810Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#661369}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/519d74a5fcd8..cc189177a63a git log 519d74a5fcd8..cc189177a63a --date=short --no-merges --format='%ad %ae %s' 2019-05-20 henrika@webrtc.org Revert "Improve spec compliance of SetStreamIDs in RtpSenderInterface" 2019-05-20 mbonadei@webrtc.org Remove unused dependency. 2019-05-20 mbonadei@webrtc.org Roll chromium_revision 243a2094..f5d37007 (660868:660984) 2019-05-20 danilchap@webrtc.org Update android tests to use single argument PeerConnectionFactory factory 2019-05-20 nisse@webrtc.org Delete configuration of unused transport_sequence_number_allocator 2019-05-20 titovartem@webrtc.org Fix test names in pc_full_stack_tests.cc 2019-05-20 nisse@webrtc.org Reland "Delete deprecated rtc::Thread default constructor" 2019-05-18 titovartem@webrtc.org Introduce peer connection level webrtc video quality tests. 2019-05-17 sukhanov@webrtc.org Add CreateDatagram to MediaTransportFactory 2019-05-17 hbos@webrtc.org Implement RTCOutboundRtpStreamStats.totalPacketSendDelay for video. 2019-05-17 thomasanderson@chromium.org Remove non-source sources from binary targets 2019-05-17 sukhanov@webrtc.org Add juberti@ to webrtc root owners 2019-05-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4c987269..243a2094 (660753:660868) 2019-05-17 srte@webrtc.org Adds feedback generator. 2019-05-17 guidou@webrtc.org Improve spec compliance of SetStreamIDs in RtpSenderInterface Created with: gclient setdep -r src/third_party/webrtc@cc189177a63a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:964411,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaec69a158a6b7d9c8ef4cd9a589bc16bb71f3a93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618595Reviewed-by:
-
Josh Nohle authored
See design at http://go/cros-devicesync-v2-scheduling In preparation for DeviceSync v2, we refactor the v2 Enrollment schedulers. DeviceSync v2 scheduling will be added to these schedulers in a subsequent CL. In this CL, we * Move ownership of the scheduler from the Enrollment manager to DeviceSyncImpl. This way the scheduler can be shared between the v2 Enrollment and DeviceSync managers. * Move all caching and invocation reason determination out of the Enrollment manager and into the scheduler. * Create a pending-request caching mechanism in the scheduler. This allows us store an Enrollment request that is made before scheduling has been started, while an Enrollment attempt is in progress, or while we are offline. * The latter point enables us to easily merge the "persistent" and "network-aware" schedulers into a single implementation. Note: M76 branch is May 30th, so these changes will make it into the v2 Enrollment rollout. Bug: 899080 Change-Id: Ia994141f7f245ff316f0df93b2f979c3756d94ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606244 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#661367}
-
Robert Ogden authored
This enables other flags (in the next CL) to enable this behavior. Bug: 956685 Change-Id: I94e909bda16ff52ad9f5f794ade14dafbc198417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619214Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#661366}
-
Xianzhu Wang authored
By making caret rects using PhysicalRect, we avoid back-and-forth flipping for LayoutNG which was to adapt to legacy, and make it clear of caret rect's coordinate space. Temporary flippings are added before some mapping functions which still require flipped blocks direction. They will be removed soon when we make all mapping functions use pure physical coordinates. Change-Id: Ia8ccd5ca5ae1ca360822637c8946ae4809b4ca79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619042Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#661365}
-
Derek Schuff authored
Bug: 963490 Change-Id: I982e81cd76f0aa0717aa9e0cdcb0b8531df41873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618076 Commit-Queue: Derek Schuff <dschuff@chromium.org> Reviewed-by:
-
Madeleine Barowsky authored
The failures are caused by an internal WebSocketException, details in bug linked. TBR=eyaich@chromium.org Bug: 964960 Change-Id: I1ed9697988164151519eb0b2b1fbb56884f51061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619829 Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by:
Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#661363}
-
Caleb Raitto authored
Currently, RequestFinishedInfo contains UrlResponseInfo and Error members. Because struct-in-struct is implemented to use base::Optional<T>, it therefore contains inline copies of these members. These structures can be large -- the UrlResponseInfo can contain headers, and the Error contains error strings. Therefore, instead of copying these members into the UrlResponseInfo, separate pointers should be passed to OnRequestFinished(). Ownership of those pointers should be shared in a similar manner to |request_info| for consistency and to avoid confusion. Bug: 879208 Change-Id: I9b2ff91706819b8d10e7093e33002d6868dfb735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610591Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#661362}
-
Mihai Sardarescu authored
This CL updates the setting earl grey test to run with unified consent feature enabled. It also adds the settings earl grey tests to the list of tests that are run on the unified consent enabled bot. Note: There are a significant number of earl grey tests for settings, so this CL will significantly increase the time it takes to run the tests on the ios-simulator-full-configs bots. However the unified consent enabled bot is temporary and the current plan is to remove it once unified consent feature is enabled by default. Bug: 960260 Change-Id: If16d2d48f739b3e5e405a8b8976b84f75581e665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617443 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#661361}
-
Maksim Ivanov authored
This CL renames variables that have obsolete names like "gaiaAuthHost", now that the "GaiaAuthHost" class doesn't exist anymore and is finally renamed to "Authenticator" everywhere (see crrev.com/c/1605919). Also fixes some comments that were referring to the old "auth host" thing. This is a pure refactoring CL, no functional changes are expected. Bug: 470893 Test: existing tests Change-Id: Ia07803527e0bf9148e021266cb2e2bc9a1fa67ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617832Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
Madeleine Barowsky authored
Marking external/wpt/css/css-scroll-snap/scroll-margin.html as flaky. This was previously disabled for prefix virtual/threaded, but because of a wpt change, we expect the test to flake for all variants. TBR=majidvp@chromium.org Bug: 964239 Change-Id: Iee686a55ff9142a81a495ee211b65cbb5a0aa508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619833Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6fbc2c914856..fc311e53e3ef Created with: gclient setdep -r src-internal@fc311e53e3ef The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mbarowsky@google.com,sidereal@google.com Change-Id: Ia788396cfd8c470312bf86d397b91f5041803b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619657Reviewed-by:
-
Antonio Gomes authored
... in favor of CrossThreadBindOnce. Reasoning: this method schedules a task that runs once. Hence, coneptually CrossThreadBindOnce is the bind helper to be used. BUG=963574 R=haraken@chromium.org, hiroshige@chromium.org Change-Id: I0c1eede1ecbffeea3a14bacbd81fff40ce702712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619826 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#661357}
-
Lowell Manners authored
Change-Id: Ia76df39e002edc45a9326862db7272a5a21830b3 Bug: 786836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571686 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#661356}
-
Lutz Justen authored
Adds a Chrome OS-only dialog to add Kerberos accounts and displays it in the Kerberos Accounts settings page when the 'Add account' button is clicked there. The dialog is functional, but needs further polish and UX review. The functionality is guarded by the KerberosEnabled policy (off by default, cannot be enabled so far except for dev purposes). BUG=chromium:952238 TEST=Turn on KerberosEnabled policy, e.g. in YAPS or with a json file on the DUT in /etc/opt/chrome/policies/managed/ with contents { "KerberosEnabled": true } (requires writeable rootfs). Note that there's no admin console UI yet. On Chromebook, navigate to chrome:settings/kerberosAccounts, click Add account. Verify that the 'Add Kerberos Account' dialog opens. You might be able to log in with an Active Directory account (e.g. chromeadm-lab.com), but at the time of writing the Kerberos system daemon is not ready, so you should see some error. Change-Id: I94c07c8cbbb59c9b4153929c88a534a9a36210f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596427 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#661355}
-
Jamie Madill authored
This reverts commit 679cb8c1. Reason for revert: Breaking ANGLE tests. https://ci.chromium.org/p/chromium/builders/ci/Linux%20FYI%20dEQP%20Release%20(NVIDIA)/68569 Bug: 965008 Original change's description: > Roll src/third_party/SPIRV-Tools/src 9dfd4b835807..47741f05043a (2 commits) > > https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9dfd4b835807..47741f05043a > > > git log 9dfd4b835807..47741f05043a --date=short --no-merges --format='%ad %ae %s' > 2019-05-17 kpet@free.fr Validate OpenCL memory and addressing model environment rules (#2589) > 2019-05-16 33432579+alan-baker@users.noreply.github.com Validate construct exits (#2459) > > > Created with: > gclient setdep -r src/third_party/SPIRV-Tools/src@47741f05043a > > The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com > > Change-Id: I5d89ae5309cd8d3a201ffb88a62ae722719cf646 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619654 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#661340} TBR=ynovikov@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com,radial-bots+chrome-roll@google.com Change-Id: Icc607f8d6169e4ec358f999e46179fea6239c7bf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618031Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#661354}
-
Christian Dullweber authored
Wait until BrowsingDataRemover is done before checking whether the ServiceWorker has been removed. Bug: 912313 Change-Id: Ic0e269b27554713a5f5327a33fa894c040e5c9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617347 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#661353}
-
Xiaohui Chen authored
Locked fullscreen mode is a special fullscreen mode used for administering quizzes to students on Chrome OS devices (where the user is basically locked inside of one browser window). Assistant is breaking the mode since it allows students to lookup answers to questions. Fix this by disabling the Assistant inside the mode. Bug: 952037 Test: locally build and test with lock screen mode on. Change-Id: I1b9e539374346f247d15ad65e7d11bfe35b4405b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616942Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#661352}
-
Rouslan Solomakhin authored
Before this patch, the logic for payment method change differed between the web-based payment handler and the built-in Google Pay integration on Android, which caused possible differences in logic. This patch passes the same parameters and uses the same code paths for payment method change to the built-in Google Pay integration as to the web-based payment handlers. After this patch, the logic and data for payment method change should be identical between web-based payment handler and the built-in Google Pay integration. Bug: 884680 Change-Id: I8558899a40c75b90eae21a6f4df687175893bb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613964 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#661351}
-
Rohit Rao authored
This file only uses NSString, so it does not need all of UIKit.h. Switching to Foundation.h makes it easier to compile this file into the EG2 test process. BUG=None Change-Id: Id76cf9ed46263a996a5d696cc9bdf5e04cf38eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619830Reviewed-by:
-
Josh Nohle authored
See design at http://go/cros-devicesync-v2-scheduling Bug: 899080 Change-Id: If465d2b1d4a9088f43fcdc9192d59f3b425270ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606967 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Daniel Bratell authored
There are currently two GetWebContents and two GetBrowserClient in content/browser. In certain non-default extreme jumbo builds GetWebContents in storage_partition_impl.cc and GetWebContents in network_service_client.cc could end up in the same translation unit and it would not compile. There were also one GetBrowserClient in storage_partition_impl.cc and one in clear_site_data_throttle.cc This renames one of the functions GetWebContents -> GetWebContentsForStoragePartition and one GetBrowserContext -> GetBrowserContextFromStoragePartition Bug: 952723 Change-Id: I85207edde5fcb85eaa6f32cf22ca05a6e324237b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617837 Auto-Submit: Daniel Bratell <bratell@opera.com> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#661348}
-
Mihai Sardarescu authored
This CL updates the bookmarks earl grey test to run with unified consent feature enabled. It also adds the bookmarks earl grey tests to the list of tests that are run on the unified consent enabled bot. This CL also fixes the test testSignInPromoWithWarmStateUsingPrimaryButton that was actually tapping the secondary sign-in button (not the primary one), and thus was a duplicate of testSignInPromoWithWarmStateUsingSecondaryButton. Note: There are a significant number of earl grey tests for bookmarks, so this CL will significantly increase the time it takes to run the tests on the ios-simulator-full-configs bots. However the unified consent enabled bot is temporary and the current plan is to remove it once unified consent feature is enabled by default. Bug: 960260 Change-Id: I6a998fb29b1dd352c37dcc9ace516a0254b804e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617513 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Yi Su authored
This CL moves WKNavigationDelegate.didReceiveServerRedirectForProvisionalNavigation from CRWWebController into CRWWKNavigationHandler. CRWWebController.didReceiveRedirectForNavigation:context is also moved into CRWWKNavigationHandler and temporarily exposed as a public method. It will be removed when WKNavigationDelegate.didCommitNavigation is moved into CRWWKNavigationHandler. Bug: 956511 Change-Id: I27e8d994544a1e54bdf46a39e3114b1195064296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617827Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#661346}
-
Jordan Demeulenaere authored
* Before: https://screenshot.googleplex.com/hmVvTEU3Bg7.png * After: https://screenshot.googleplex.com/Cp3bg0Wqt7m.png Screenshots: Change-Id: I3c3563eb895fde6a0fd86ab25625eb68aa0ce598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617828Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#661345}
-
Tanmoy Mollik authored
This cl is part of the effort to use CoreAccountId instead of std::string to denote account_id. Bug: 959157 Change-Id: I0fd318d8034fb1294336f7534eb672fd1faeb084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611996Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#661344}
-
Eugene But authored
README says: "This directory contains API to search for text on a web page. This directory does not support any UI API except content highlighting." Bug: 942244 Change-Id: I8e683ac1a99783becf39fbc7f8bd61017c017641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619209 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#661343}
-
