GitLab

This depends on https://bugs.webkit.org/show_bug.cgi?id=66746 and http://codereview.chromium.org/7461059/, neither of which have been landed. So this should be considered a preliminary review at this stage :)

BUG=
TEST=

Review URL: http://codereview.chromium.org/7714017

TBR=koz@chromium.org
Review URL: http://codereview.chromium.org/7740056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98896 0039d316-1c4b-4281-b951-d872f2087c98

it to a different class.
R=ziga, dominich
Review URL: http://codereview.chromium.org/7812011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98895 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=WebIntentControllerPickerTest.*

Review URL: http://codereview.chromium.org/7715037

TBR=binji@chromium.org
Review URL: http://codereview.chromium.org/7778032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98894 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/7785007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98891 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7778017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98889 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=WebIntentControllerPickerTest.*

Review URL: http://codereview.chromium.org/7715037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98888 0039d316-1c4b-4281-b951-d872f2087c98

Third attempt at the following.  Unreviewed, this was originally reviewed in http://codereview.chromium.org/7550002 .

Clean up SSL false start blacklist code. Numerous changes, including:
* Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
* Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them.
* Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
* Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
* Avoid #define and "using".
* Use standard algorithms for similar reasons as using string ops.
* Use file_util functions to significantly abbreviate file reading/writing code.
* Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
* Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
* Convert non-error uses of stderr to the chrome-standard VLOG(1).
* Correctly handle hostnames with trailing dots in the input file.
* In general, shorten code where possible.

Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7804001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/7776018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98884 0039d316-1c4b-4281-b951-d872f2087c98

* Bug fix: fix the issue when there is some files with file names other than '%Y-%m-%d-%H' format in result directory.
* Add two command-line parameter to choose test group CSV file and test group name. The example of such CSV file can be found in testname/media.csv. The test group name shows up in the status email subject. This is necessary to make this analyzer works for arbitrary test group name.
* minor doc change.

Review URL: http://codereview.chromium.org/7806008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98883 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87632
TEST=Manual

Review URL: http://codereview.chromium.org/7740065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98882 0039d316-1c4b-4281-b951-d872f2087c98

Make the "get window rect" message handlers report the work area, rather than the true window size, for maximized windows, since that's how the calling code expects them to function.

BUG=88523
TEST=Open DevTools maximized (full single screen) on Windows Vista/7, click the Gearbox button in the Elements panel's Styles pane. The SELECT popup should not stick beyond the right screen edge and should be right-aligned with the right edge of the button. Move the Windows taskbar to the right edge of the screen and repeat. The popup should still get the correct alignment and should not get clipped in any way.
Review URL: http://codereview.chromium.org/7799004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=86536
TEST=ChunkDemuxerTest.TestReadsAfterEndOfStream, ChunkDemuxerTest.TestEndOfStreamWithPendingReads

Review URL: http://codereview.chromium.org/7806002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98880 0039d316-1c4b-4281-b951-d872f2087c98

Fix link error with components build and media.dll. I have no idea why the bots aren't seeing this, it might be an interaction with supalink.
Review URL: http://codereview.chromium.org/7785013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98879 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/7800012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98878 0039d316-1c4b-4281-b951-d872f2087c98

If a plugin dies with an open modal window the browser window will not be enabled. So, we re-enable the browser if it's ever disabled without any child dialogs.

BUG=90002
TEST=Kill the Flash process while a modal dialog (e.g. file, print) is open. Browser should remain responsive.
Review URL: http://codereview.chromium.org/7812005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98875 0039d316-1c4b-4281-b951-d872f2087c98

Corresponds to stability issues and also a security update:
http://service.real.com/realplayer/security/08162011_player/en/
Review URL: http://codereview.chromium.org/7776019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98873 0039d316-1c4b-4281-b951-d872f2087c98

* Constraint favicon size for bookmarks & most-visited to 16x16.
* Make color strip on bookmarks and most-visited full opacity.
* Set padding space between icon and title for bookmarks & most-visited to 8px.
Review URL: http://codereview.chromium.org/7794005

TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/7776020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98872 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98871 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/7778019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98868 0039d316-1c4b-4281-b951-d872f2087c98

Also adds an Aura test suite.

http://crbug.com/93933
http://crbug.com/93943
TEST=see unittest
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98850
Review URL: http://codereview.chromium.org/7791030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98866 0039d316-1c4b-4281-b951-d872f2087c98

We should never use raw pointers of v8 objects in client code.

We should always use v8::Handle and it subclasses, v8::Local and v8::Persistent,
whenever referencing them.

Any allocation from v8 heap can make raw pointers invalid.

BUG=None
TEST=None

R=mnaganov@chromium.org
TBR=tonyg@chromium.org

Review URL: http://codereview.chromium.org/7779012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98865 0039d316-1c4b-4281-b951-d872f2087c98

1. make drag-over state match hover state for page switchers and nav dots
2. make recently closed text and arrow a hardcoded color (looks fine on a variety of themes; matches nav dot text)
3. don't show pulse for right click on apps

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/7799015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98864 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7785003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98863 0039d316-1c4b-4281-b951-d872f2087c98

Add means for running some tests only o-o-p, add messaging o-o-p test.

BUG=None
TEST=included
TBR=dmichael@chromium.org

Review URL: http://codereview.chromium.org/7799031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94661
TEST=New unit test; also manually add a syncable app to profile, sync, then install extension with same ID: with change, no crash, without, crash on sync.


Review URL: http://codereview.chromium.org/7795011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98860 0039d316-1c4b-4281-b951-d872f2087c98

* Constraint favicon size for bookmarks & most-visited to 16x16.
* Make color strip on bookmarks and most-visited full opacity.
* Set padding space between icon and title for bookmarks & most-visited to 8px.
Review URL: http://codereview.chromium.org/7794005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98859 0039d316-1c4b-4281-b951-d872f2087c98

Logs a subset of the stack backtrace from the point of -dealloc into a
breakpad key to help debug messages to CrZombie objects.  This
productionizes the basic approach taken to debug a few recent zombie
object crashes.

BUG=none
TEST=monitor crash server.

Review URL: http://codereview.chromium.org/7766013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98858 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7790020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98857 0039d316-1c4b-4281-b951-d872f2087c98

Changed all @code to <code> and @endcode to </code> as per dmichael. Adding Polina to the review to look at url_loader.h and give approval of text that points to example.
Review URL: http://codereview.chromium.org/7715005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98856 0039d316-1c4b-4281-b951-d872f2087c98

I removed a bunch of static initializers, so update the expectations
so we don't regress.

Review URL: http://codereview.chromium.org/7806019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98855 0039d316-1c4b-4281-b951-d872f2087c98

The issue seems to be fixed as the ctor of JSONReader is public and there is
a public static Read() function.

BUG=None
TEST=None

R=aa@chromium.org,tony@chromium.org

Review URL: http://codereview.chromium.org/7794003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98854 0039d316-1c4b-4281-b951-d872f2087c98

BUG=89564
TEST=Go back or forward to a slow URL.  No omnibox change until it commits.


Review URL: http://codereview.chromium.org/7790018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98853 0039d316-1c4b-4281-b951-d872f2087c98

Revert 98850 - Proper MouseEvent targeting. Adds a Window method that locates a Window for a given point.

Also adds an Aura test suite.

http://crbug.com/93933
http://crbug.com/93943
TEST=see unittest
Review URL: http://codereview.chromium.org/7791030

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/7739002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98852 0039d316-1c4b-4281-b951-d872f2087c98

TBR=garykac@chromium.org
BUG=94764
TEST=none

Review URL: http://codereview.chromium.org/7785002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98851 0039d316-1c4b-4281-b951-d872f2087c98

Also adds an Aura test suite.

http://crbug.com/93933
http://crbug.com/93943
TEST=see unittest
Review URL: http://codereview.chromium.org/7791030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98850 0039d316-1c4b-4281-b951-d872f2087c98

Protect sensistive chrome: and chrome-extension: schemes as not being able to be manipulated by bookmarklets and javascript: URLs typed into the omnibox.

BUG=93498
Review URL: http://codereview.chromium.org/7748022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98849 0039d316-1c4b-4281-b951-d872f2087c98

mimic what we're doing on the server.

BUG=
TEST=BrowserFeatureExtractorTest


Review URL: http://codereview.chromium.org/7793012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98848 0039d316-1c4b-4281-b951-d872f2087c98

TBR=krisr@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7806021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98847 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98846 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7792041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98845 0039d316-1c4b-4281-b951-d872f2087c98