- 07 Feb, 2019 40 commits
-
-
Alli Murray authored
Bug: 918795 Change-Id: I3ce85373b987f572e901889082d638035acf1235 Reviewed-on: https://chromium-review.googlesource.com/c/1457557 Commit-Queue: Alli Murray <alliemurray@google.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#629872}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96982ab4da6c..1b32378da8f4 Created with: gclient setdep -r src-internal@1b32378da8f4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id871c136f5332151e3bf07032715bcef3007710b Reviewed-on: https://chromium-review.googlesource.com/c/1457485Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629871}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c1a2ea33a340..f36ad269e88a git log c1a2ea33a340..f36ad269e88a --date=short --no-merges --format='%ad %ae %s' 2019-02-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-07 reed@google.com move SkMetaData into src 2019-02-06 bungeman@google.com Add BOT/EOT to Shaper. Created with: gclient setdep -r src/third_party/skia@f36ad269e88a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I0f550fc72ff90c5624726b6640f876a318daa897 Reviewed-on: https://chromium-review.googlesource.com/c/1457639Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629870}
-
Marijn Kruisselbrink authored
We were already treating these responses as errors, but were using UPDATE_OK as "ResultType" when handling the error. This fixes that to treat these errors the same as any other non-200 server response. Bug: 923650 Change-Id: I5f3464bd5ae8dc940f1476297cd935f9ecb5998e Reviewed-on: https://chromium-review.googlesource.com/c/1457469 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#629869}
-
Alex Danilo authored
CL:1345378 swaps out PNG files for the share and delete icons for file selected with SVG files that were 20px in size. This corrects to the proper size of 16px. side by side with SVG version to verify sizing. Bug: 793382 Test: Took screenshot of original with PNG icons, compared Change-Id: I218bc9f059f74a9bd68256ddaaa80fb298332c4b Reviewed-on: https://chromium-review.googlesource.com/c/1345756 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#629868}
-
Alli Murray authored
When partitions are grouped, the eject button is attached to the removable root label. Unmounting a removable root means unmounting all child partitions, and using the drive label in the unmount message. Bug: 918795 Change-Id: Idd175c8f3d7a814bfe0784cfa52e35b12c36a663 Reviewed-on: https://chromium-review.googlesource.com/c/1454339 Commit-Queue: Alli Murray <alliemurray@google.com> Reviewed-by:
-
Scott Violet authored
This is necessary as it's not uncommon to have code like this: SetCanActivate(true); widget->Activate(); SetCanActivate(false); BUG=928939 TEST=none Change-Id: I52c2d79cd7aec2fe5ab13f8ae7821227f1a0214e Reviewed-on: https://chromium-review.googlesource.com/c/1457117 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#629866}
-
Oystein Eftevaag authored
Currently the tracing service will unconditionally connect to the TracedProcess interface on all services, which is a feature provided by the service_manager client lib. This change allows RequestQuit() calls services make, to still succeed even if there's an outstanding TracedProcess bind request, as it's not the service itself which handles this request. See discussion in https://chromium-review.googlesource.com/c/chromium/src/+/1452767 R=ssid@chromium.org Change-Id: Id7a4a6dc8eaa982b0ce24d7a699b430b3c07f833 Reviewed-on: https://chromium-review.googlesource.com/c/1457214 Commit-Queue: oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
ssid <ssid@chromium.org> Auto-Submit: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#629865}
-
Dan Beam authored
Screenshots: https://imgur.com/a/icbglBw R=hcarmona@chromium.org BUG=883049 Change-Id: I64fdd208abfbc71914b8f8a13d34e08d4d305b40 Reviewed-on: https://chromium-review.googlesource.com/c/1457719 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#629864}
-
Lei Zhang authored
BUG=928411 Change-Id: I147411ea096b2c49b3c81cde29f946dc1f1a4dfa Reviewed-on: https://chromium-review.googlesource.com/c/1454087 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#629863}
-
Alli Murray authored
List partitions of external media devices as subdirectories underneath a common root label to improve visual distinction. Make EntryList URL unique for removable roots (otherwise directory change won't be triggered). Bug: 918795 Change-Id: I071664a333d44e0d9f4e1ca77bcb6dafda89e181 Reviewed-on: https://chromium-review.googlesource.com/c/1449472Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f9cc785c3f6a..603ad164a6fc git log f9cc785c3f6a..603ad164a6fc --date=short --no-merges --format='%ad %ae %s' 2019-02-07 lfy@google.com GLES1: dirty bit pass Created with: gclient setdep -r src/third_party/angle@603ad164a6fc The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I6c8208353e5ff39a5d14ee1bc0116adb6bf4f5f2 Reviewed-on: https://chromium-review.googlesource.com/c/1457523Reviewed-by:
-
Erik Luo authored
Bug: 927535 Change-Id: I207bc589b3d6f86b44a3b74309342e5052a9582f Reviewed-on: https://chromium-review.googlesource.com/c/1449047 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#629860}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1b8d2cc9056a..82105494f27a git log 1b8d2cc9056a..82105494f27a --date=short --no-merges --format='%ad %ae %s' 2019-02-07 thestig@chromium.org Use even more size_t in CXFA_TextLayout. 2019-02-07 thestig@chromium.org Fix includes in fx_font.h. 2019-02-07 thestig@chromium.org Reorganize fx_font.h. 2019-02-07 thestig@chromium.org Use a vector inside CPDF_CharPosList. 2019-02-07 thestig@chromium.org Encapsulate CPDF_CharPosList. 2019-02-07 thestig@chromium.org Rename FXTEXT_CHARPOS and FXTEXT_GLYPHPOS. 2019-02-07 thestig@chromium.org Encapsulate CFX_GlyphBitmap. 2019-02-07 thestig@chromium.org Remove unneeded fx_font.h includes from headers. 2019-02-06 thestig@chromium.org Revert "Add --jitless to recommended v8 flags." 2019-02-06 tsepez@chromium.org Document that CXFA_Document::GetLayoutProcessor() never returns null 2019-02-06 thestig@chromium.org Do some clean up in fpdf_parser_decode test. 2019-02-06 thestig@chromium.org Fix xfa/fxfa/layout/BUILD.gn. 2019-02-06 thestig@chromium.org Roll buildtools/ 0e1cbc4ea..2f02e1f36 (3 commits) 2019-02-06 tsepez@chromium.org Break CXFA_Node direct dependence on CXFA_LayoutProcessor. 2019-02-06 thestig@chromium.org Roll build/ 67630827e..10ffa2f5e (30 commits) 2019-02-06 thestig@chromium.org Use more size_t in CXFA_TextLayout. 2019-02-06 thestig@chromium.org Fix an integer overflow inside cpdf_textpage.cpp. 2019-02-06 bungeman@google.com Roll third_party/freetype/src/ 1e7a8f30c..b66d6a911 (5 commits) 2019-02-06 thestig@chromium.org Avoid an integer overflow in CPDF_RenderStatus::ProcessType3Text(). 2019-02-06 tsepez@chromium.org CXFA_TextProvider does not need to know about layout/ objects 2019-02-06 thestig@chromium.org Avoid calling CCodec_FaxDecoder::InvertBuffer(). 2019-02-06 tsepez@chromium.org CJX_Object does not need to know about layout/ objects. 2019-02-06 thestig@chromium.org Do not build googletest/googlemock when building pdfium_test. 2019-02-06 thestig@chromium.org Add CFX_Break::IsGreaterThanLineWidth(). 2019-02-06 thestig@chromium.org Use CalculatePitch32() in CCodec_FaxDecoder. 2019-02-06 tsepez@chromium.org Separate CXFA layout hierarchy from CXFA parser hierarchy. Created with: gclient setdep -r src/third_party/pdfium@82105494f27a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:919643,chromium:917783,chromium:928820 TBR=dsinclair@chromium.org Change-Id: If0c887926e5cbeb9ce07e1c769c22d9054bb1ee5 Reviewed-on: https://chromium-review.googlesource.com/c/1457484Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/61d0c292535e..06d1040fab75 git log 61d0c292535e..06d1040fab75 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@06d1040fab75 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I4aea79ae93e6d1ec17bc316eba9a9d79896256bd Reviewed-on: https://chromium-review.googlesource.com/c/1457638Reviewed-by:
-
Wenzhao Zang authored
maybelle@ will take over wallpaper work. For now, she will cc wzang@ and xdai@ on all the incoming reviews she will get. Bug: None Change-Id: I82c9e8e1820663d0d3fb82ecf6030178caa01d1b Reviewed-on: https://chromium-review.googlesource.com/c/1457669Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#629857}
-
Ken Buchanan authored
This reverts commit e6fd2ecb. Reason for revert: Regresses startup time on Windows. https://crbug.com/929375 Original change's description: > Add metrics for Bluetooth adapter availability > > For Web Authentication we would like to determine the prevalance of > BLE capabilities on clients to understand whether BLE security keys and > caBLE devices are viable for those users. > > This re-enables the UMA on OSX to determine Bluetooth availability and > capabilities, and adds similar metrics to Windows and Chrome OS. > > Bug: 907279 > Change-Id: I8da9165bca5177cb08176cc4ce812340456a97d4 > Reviewed-on: https://chromium-review.googlesource.com/c/1437721 > Commit-Queue: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628560} TBR=kenrb@chromium.org,isherman@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 907279 Change-Id: I8287c1c8a362032f961c6723cf56545f75e41878 Reviewed-on: https://chromium-review.googlesource.com/c/1457458Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#629856}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/11e283fea253..38769c1f96a3 git log 11e283fea253..38769c1f96a3 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 charliea@chromium.org Remove spurious "o" added in crrev.com/c/1455628. Sorry! Created with: gclient setdep -r src/third_party/catapult@38769c1f96a3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib8ca246e6c876042a3fb1bad110cea56079cafec Reviewed-on: https://chromium-review.googlesource.com/c/1457276Reviewed-by:
-
Joshua Pawlicki authored
This reverts commit 4502ddc7. Reason for revert: The Clank team has raised some concerns about removing this. Until there is consensus, it seems safer to stay with the status quo, sorry. Original change's description: > [Android] Remove accounts and sign-in information from Omaha requests > > This CL removes the code that used to add _numaccounts, > _numgoogleaccountsondevice and _numsignedin attributes to Omaha > requests. > > Bug: 926273 > Change-Id: I36edef48dc4d51cbed70ad1a7e14284cfa1c772f > Reviewed-on: https://chromium-review.googlesource.com/c/1451925 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > Auto-Submit: Boris Sazonov <bsazonov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629111} TBR=waffles@chromium.org,jochen@chromium.org,bsazonov@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 926273 Change-Id: If778ea99524b6c199c25292f66f04a07d3271bea Reviewed-on: https://chromium-review.googlesource.com/c/1457674Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#629854}
-
Mason Freed authored
Bug: 927560,927587,928518 Change-Id: I502e1d487fefa06697c064919d5bbb78582da923 Reviewed-on: https://chromium-review.googlesource.com/c/1454090 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#629853}
-
Khushal authored
Add support for PostSubBuffer to GLSurfaceEGLSurfaceControl. This should allow the display compositor to draw the minimum sub-rect necessary from the damage tracking in BufferQueue on the client-side, and also to pass this damage rect to the framework. R=piman@chromium.org Bug: 926020 Change-Id: I73d3320cab68250d4c6865bf21c5531682d8bf61 Reviewed-on: https://chromium-review.googlesource.com/c/1457467 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#629852}
-
Scott Violet authored
BUG=929455 TEST=test only change Change-Id: Iecf7c394f073c6cad59b70c59d78eea43bc44dd0 Reviewed-on: https://chromium-review.googlesource.com/c/1457209 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#629851}
-
Jimmy Gong authored
- Adds RequestUpdatedSharePath helper function to SmbFileSystem. Bug: 922273 Test: compiles Change-Id: Ida2043d9f78b585aa70252b7a8b3937dd456d527 Reviewed-on: https://chromium-review.googlesource.com/c/1445235 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Auto-Submit: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#629850}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I17c639a8a17571da8bab2224c47b08083a5a6c3f Reviewed-on: https://chromium-review.googlesource.com/c/1457482Reviewed-by:
-
Kelvin Jiang authored
activity_log.js will be split into activity_log_history.js and activity_log.js to separate the file in preparation for the real-time stream implementation. activity_log.js takes care of the UI lifecycle and common UI elements logic (i.e. back/clear button, search bar, and loading the activity log when the page is reached) activity_log_history.js takes care of fetching, handling and displaying activity log data from the activityLogPrivate API. In a later CL, the activity log stream (implemented by listening to activityLogPrivate.onExtensionActivity events) will be in a different tab under activity_log.js and will have its own file. This CL aims to prevent putting all activity logic into one large (and very bloated) file. Bug: 832354 Change-Id: I88be6309ba4c4d73e0078ce86e893dafb26594c2 Reviewed-on: https://chromium-review.googlesource.com/c/1432939 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
-
Hector Carmona authored
Also fix some const references surfaced by presubmit. Reason for revert: browser_tests are run in parallel, so they were failing on the focus check sometimes, thus introducing flakiness. Fix to prevent flakiness: Changed test to an interactive_ui_test because they are run in series. Bug: 912026 Change-Id: I3385a0e55daabb4bade7aedc77f329c5b22d9de6 Reviewed-on: https://chromium-review.googlesource.com/c/1444691 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
Alexandre Courbot authored
From the V4L2IP point of view, there is no guarantee that the client "thread" is effectively a single thread. It could be any kind of sequence, for which the thread check may fail while being semantically valid. Bug: None Test: Ran VDA unittest on Hana and VEA unittest on peach_pit, in debug mode. Change-Id: If88e85e216c96fc20446150c0abdbdc9708904a7 Reviewed-on: https://chromium-review.googlesource.com/c/1454019Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#629846}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/82f670fd3d37..2af003349292 git log 82f670fd3d37..2af003349292 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 primiano@google.com Fix GCC build 2019-02-06 primiano@google.com Merge "perfetto-ui: Fix rendering" Created with: gclient setdep -r src/third_party/perfetto@2af003349292 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I08c7ff7bbe26d3d396c8fc6aad77999b327880eb Reviewed-on: https://chromium-review.googlesource.com/c/1457537Reviewed-by:
-
Jun Cai authored
Revert "Reland: Network Service: Use histograms instead of chartjsons for network service performance tests" This reverts commit 9e95fd2b. Reason for revert: linux-perf-fyi bot failed at: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi/1769 Original change's description: > Reland: Network Service: Use histograms instead of chartjsons for network service performance tests > > The initial upload of this CL is the same as: > https://chromium-review.googlesource.com/c/chromium/src/+/1454633 > > New changes in the CL from the above original CL: > Modifies the output histogram filename to be "histograms.json" > > This CL modifies the network service performance tests to generate > histograms instead of chartjsons so that the Pinpoint can automatic > bisect CLs. > > TBR=crouleau@chromium.org, jam@chromium.org, simonhatch@chromium.org, benjhayden@chromium.org > > Bug: 927155 > Change-Id: I7b9dcd9fdabe7b5e59d7d5143b1ec1e2ffd9606e > Reviewed-on: https://chromium-review.googlesource.com/c/1456694 > Reviewed-by: Jun Cai <juncai@chromium.org> > Reviewed-by: Simon Hatch <simonhatch@chromium.org> > Commit-Queue: Jun Cai <juncai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629755} TBR=jam@chromium.org,benjhayden@chromium.org,simonhatch@chromium.org,crouleau@chromium.org,juncai@chromium.org Change-Id: I9d0d6d9ba1ad6a3918799680d3c8c51cb11c02a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927155 Reviewed-on: https://chromium-review.googlesource.com/c/1457818Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#629844}
-
Austin Eng authored
These tests were previously failing but no longer fail on top of tree. Bug: 906735 Change-Id: I2c2c024de7478a668a9c81727849f6710338851b Reviewed-on: https://chromium-review.googlesource.com/c/1438020Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#629843}
-
Kent Tamura authored
This CL restores the loop removed in crrev.com/629490. The new behavior matches to Firefox though it doesn't conform to the specification. Add a test case to WPT based on the current specification, and Blink has a failing expectation. Bug: 928639 Change-Id: Ica431543440b538400cf1af086cab27cf59c4dc8 Reviewed-on: https://chromium-review.googlesource.com/c/1454023 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#629842}
-
Rob Schonberger authored
Adds a result_type, kPlayeStoreReinstallApp to both the ash/app_list code, and use this as the result_type of ArcAppReinstallAppResult. In SearchModel, add a method to filter with a lambda not just a list of app IDs not to show. In SearchResultTileItemListView, pull the list of SearchResult and use the new method in SearchModel to create a list of apps with the reinstall app as the last items. In Chip View, use the same filter to ensure that reinstall recommendations are not shown. In SearchResultTileItemListView and SearchResultTileItemView track the value of whether or not zero state is enabled, and make similar modifications to the UI as the play store changes do. Modify SearchResultTileItemListViewTest to test the new behavior, and parameterize that test by both flags. Bug: 911427 Change-Id: If9d8509835300024d656c89cf127980ae831d4ab Reviewed-on: https://chromium-review.googlesource.com/c/1449963 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#629841}
-
Cecilia Ni authored
This CL set the dwellTime in iron-location manually to prevent extra url to be pushed in window.history stack. This is caused by when navigating from notification page to detail page, queryParam and path both update, but they do not happen simultaneously, and this causes observers in iron-location API get triggered twice, resulting two urls pushed in history.stack. Bug: 906508 Change-Id: I55d5c94e200b068e179b31d9586d9f7497b84885 Reviewed-on: https://chromium-review.googlesource.com/c/1454351 Commit-Queue: Cecilia Ni <ceciliani@google.com> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#629840}
-
Scott Violet authored
This renames set_can_activate to SetCanActivate and routes the change to Widget, which then calls to the NativeWidget implementation. I'm going to use this to call to the server when can activate changes. BUG=928939 TEST=none Change-Id: Ifd1eb3c446827747de203ddf66ae9d7cdbfc5e39 Reviewed-on: https://chromium-review.googlesource.com/c/1456287 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Matt Reynolds authored
When a HID report descriptor describes a report field with both a large report size and a large report count, the total bits occupied by the field can overflow an int32_t. This CL modifies the report size accumulation logic to ensure uint64_t is used when computing the total bits and limits the maximum report size. This int overflow bug was discovered by ClusterFuzz using the following report descriptor: 0xA0, // Collection 0x96, 0x60, 0xEA, // Report Count (60166) 0x76, 0x06, 0xEB, // Report Size (60000) 0x90, // Output The output field is defined to have a size of 3,609,960,000 bits. BUG=928019 Change-Id: I5a29aa1736356b19c5eeb923ecc7352600743278 Reviewed-on: https://chromium-review.googlesource.com/c/1452717Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#629838}
-
Rohit Rao authored
BUG=None Change-Id: I07de8b010065ea27a5f36bdd5f71d12a5bde7ab5 Reviewed-on: https://chromium-review.googlesource.com/c/1457003 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#629837}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=cmumford@chromium.org Bug: 903957 Change-Id: Ia7d71b3bc2536dad0e6adc669aebe36addfd7fd0 Reviewed-on: https://chromium-review.googlesource.com/c/1365805 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#629836}
-
Mason Freed authored
Previous to this CL, a layer with opacity<1 that contained a single compositing child with backdrop-filter would not be properly rendered, due to an optimization that removed the render surface for the opacity<1 layer. That would cause the backdrop-filter to filter elements higher up the tree than it should, due to the lack of isolation imposed by the opacity<1 layer. With this CL, this situation is properly detected and a render surface is assigned to the opacity<1 layer. As part of this CL, backdrop-filter was moved from the Filter node to the Effect node. This is required, because a single element with both opacity and backdrop-filter need to be contained in the same node, so that the render surface created for the backdrop filter also sees the opacity. Bug: 497522, 836885 Change-Id: Ie6ad38231ddfda02fae8d574ca8f30d075c673e5 Reviewed-on: https://chromium-review.googlesource.com/c/1399467 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Darwin Huang authored
- Use range-based for loops - Update documentation links - No logic changes Bug: 896479 Change-Id: I9ba30494d274d96a045d6ec11668f5554b5ee92c Reviewed-on: https://chromium-review.googlesource.com/c/1444707 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Steven Bennetts authored
This moves the WIP network icon logic behind the SeparateNetworkIcons flag from network_tray_icon_strategy.cc to ActiveNetworkIcon. Bug: 923444 Change-Id: I727e68479d592a149caa8f28b376a99a78e96c69 Reviewed-on: https://chromium-review.googlesource.com/c/1448802 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#629833}
-
