- 06 Nov, 2019 40 commits
-
-
Wei Li authored
We are still anticipating using the histogram and flags through Finch through M81. So set the new expiry milestone to M82. BUG=1021153 Change-Id: I2398ccdc38aa1c05a963f6998aac94ac1ab389b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898814Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#713211}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5703cc70..64036088 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I917b9f528af51970a1c698bf33bcd57aaf2f0de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901966Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713210}
-
Findit authored
This reverts commit d6cbc51d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 713147 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q2Y2JjNTFkYjg3NWU5YzQ0ZGJiYTZlNDgwMDZkMTdlODBmYTI0MzMM Sample Failed Build: https://ci.chromium.org/b/8897502697330603712 Sample Failed Step: content_browsertests Original change's description: > bfcache: Save back-navigation's navigationStart in pageshow event's timestamp > > When a page is restored from the back forward cache, there is > currently no way to know its navigationStart time since we aren't > updating performance.timing.navigationStart (which is undesirable), > even though users of bfcache might want to know the navigationStart > time to measure latency. To solve this, we are modifying the > pageshow event’s timeStamp to correspond to the navigation start of > the history navigation. Note as event.timeStamp is defined as time > elapsed since the beginning of the document lifetime [1], this is > effectively the difference between the initial navigationStart and > the navigation start of the last navigation. > > [1] https://developer.mozilla.org/en-US/docs/Web/API/Event/timeStamp > > Note that we are only updating this for pageshow events for pages > that were persisted (restored from the back forward cache). > > For more background, see doc at https://docs.google.com/document/d/1XlZhphHW-bNcUPD98T-rfTa-TASI-3xUtxZzThZLJCA/edit?usp=sharing > > Change-Id: I81e399492eaa377ac56c4325e3134b1ff50ae451 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888627 > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Auto-Submit: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Fergal Daly <fergal@chromium.org> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713147} Change-Id: I72f56bc464cc58851bb6669f059cb8907fdef24c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902515 Cr-Commit-Position: refs/heads/master@{#713209}
-
Joe Mason authored
R=proberge Bug: 969139 Change-Id: Ibb65a3b6b70fe8dcc03623c281e8207206107571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900562 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#713208}
-
ckitagawa authored
This CL adds file compression ability to the FileManager and switches from last-accessed to last-modified times. As per discussions lifetime will be tied to other existing lifetime management systems: history or tab lifetime. So the method for deletion based on time is no longer required. Bug: 1010042 Change-Id: Ic8cc956fcee2476f52043edd646e24d399a5815d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862707Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#713207}
-
David Black authored
This CL exposes changes to vertical scroll direction to WebContentsObservers. Note that this CL only notifies scrolls in the vertical plane as the feature that will utilize this API is not interested in what is occurring horizontally. Bug: 1014681 Change-Id: Ie0027ab8cb9d90d54a2c1142189e2a74dd032ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862724 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#713206}
-
Steven Bennetts authored
For trivial change to resource_bundle.cc: TBR=sky@chromium.org Bug: 1017864 Change-Id: I2afbfa8e02f952d03b36112e0093af92753876ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883292 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#713205}
-
Taylor Bergquist authored
Introduced new constants for toolbar button height in each mode. There's some possibility of refactoring the toolbar button inset calculations to use these constants instead, as discussed in https: //crbug.com/822967, but that isn't done in this CL. Change-Id: I33c6fb199a5c38b6163c5a45718cbd4bd2d890e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898809 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#713204}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=vollick@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I67db06d4d193229cd0835e855fe52f9573e9fb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894890 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
yilkal authored
This CL removes WebContentsImpl::frame_count_. Instead of using frame_count_ to count the number of iframes, this cl iterates through the frame tree when loading finishes. Bug: 850328 Change-Id: I0eca46aab70371f296a66f0e7775acd18611acdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857647Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#713202}
-
Robert Kaplow authored
A couple things I'm not certain on: - I kept the ints matching the Stability proto values which may make it easier to convert queries. But, if this ends up being what we use long term, it will look strange. I'm fine either way. - Even more broadly - should we keep the system of putting all these unrelated values together or do the cleaner things and have histograms for each. It does seem pretty convenient this way so opting to keep it. I gave it the name Experimental over something like Stability.Counts2 since it's unclear as a replacement. Bug: 1019780 Change-Id: Id4f12dcb7bb503fe5b8ea024a2c3ee0a80a080c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890955 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Xiaohui Chen authored
Bug: b/135064564 Test: locally build and run with multiple media playing Change-Id: I3814cfc3bc619077ca6781493fd369c27d50eb4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899184 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#713200}
-
Livvie Lin authored
Follow-up to crrev.com/c/1793260. Adds a test for SSL committed interstitials. Bug: 1017406 Change-Id: I47741700c5233ef6f238b3e2b61692d5a4b10cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900405 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#713199}
-
Chase Phillips authored
Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/FvM-qo7BfkI/AvxoE6JpBgAJ This change marks AppCache API use and manifest selection on a secure origin as deprecated. All AppCache tests that used a secure origin have been updated with new expectations showing the console message. Three of the tests became flaky after the change since they wouldn't always run the exact same code paths, which would cause the output to differ and expectations to fail. This CL migrates those tests from testRunner to testharness.js. Bug: 1019951 Change-Id: I4c58206c094ababc92975cc61625139644607504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891461Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#713198}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/41be80f6159c..23247b993215 git log 41be80f6159c..23247b993215 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 danakj@chromium.org Don't fetch tags when fetching to deapply a patch. 2019-11-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@23247b993215 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1019824 Change-Id: Ia7e8137b1f186174ff3d5ffda638936fc60954ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901802Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713197}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/2dfba53b8214..13adddb32ef0 git log 2dfba53b8214..13adddb32ef0 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 rharrison@google.com Move spirv_cross state out of result and rename opaque state handle (#865) Created with: gclient setdep -r src/third_party/shaderc/src@13adddb32ef0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I5f287e063416f62b70328a9e2c8bd90e706d9fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901535Reviewed-by:
-
Albert Chaulk authored
Changing RFH can change the surface the WebContents draws into, so we need to update the current draw quad being used. Since we can't guarantee that we will get a timely wayland commit, force one immediately Bug: 143651420 Test: browsing webpages Change-Id: I70ebe9b09551c0adbede1eebe245c899572a0984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899751Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#713195}
-
Daniel Rubery authored
This file is opened by Microsoft Access by default, and should be treated as equivalent to MDB. Bug: 1021855 Change-Id: I3398e48b57407a8730100061a57d9de13ecf2191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901638 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#713194}
-
Junbo Ke authored
chromium/1870492 sets |trusted_params| of a ResourceRequest, which can only be used by a trusted URLLoaderFactory. Bug: None Test: Manual Change-Id: I9f589ce4161b87c4e1387c8adbfc37bc68b96cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900552Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#713193}
-
Francois Doray authored
Prior to this CL, Startup.FirstWebContents.NonEmptyPaint2 was recorded for the active WebContents in the first browser of the BrowserList. However, tests highlighted that the first browser is not necessarily visible in session restore. This CL changes the behavior to instead record Startup.FirstWebContents.NonEmptyPaint2 for the active WebContents in the first *visible* browser. It also adds a FinishReason for when no browser is initially visible. This would allow us to track if there is a change in how often Chrome starts with no initially visible browser (e.g. if this CL lands https://chromium-review.googlesource.com/c/chromium/src/+/1888405/3/chrome/browser/sessions/session_restore.cc#477 we would start more often with no initially visible browser). This CL also adds some DCHECKs to make sure that navigation events occur in the order expected by FirstWebContentsProfiler. Bug: 1020549 Change-Id: I0733a2b5af2f3617102232e9996459ad3b1c4c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894417Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#713192}
-
Patrick Monette authored
This CL ensures that the ModuleDatabase task runner, the inspection results cache task runner and the module blacklist cache task runner don't block shutdown. Also, this CL changes the inspection results cache so that it is updated atomically. Bug: 1021904, 1022041 Change-Id: Ia87e13f60e00725583f95c55e231edfd4d7648b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899750Reviewed-by:
-
Jose Dapena Paz authored
GCC build of blink_heap_unittests is broken as it requires the fuzzed data provider. But libfuzzer is not available without clang. Bug: 819294 Change-Id: I377ed09d03fd8bdc2561d766a1964d4ab61943dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901038Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#713190}
-
Dana Fried authored
This CL separates a request for capture from actual video capture (since there may be a delay), and captures thumbnails from pages opportunistically as they are loading. This does not solve the attached bug but will allow us to do the following in subsequent CLs: - isolate the issue of capture not triggering render view creation - rate-limit actual video capture across tabs if necessary, by putting candidates for capture in a queue the prioritizes (but is not exclusive to) those we are currently requesting Bug: 1020782 Change-Id: Ib00747d5c839cd8fe8ca9564ee84dfa6c19262d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897485Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#713189}
-
Natalie Chouinard authored
Move Safe Browsing feature-specific methods from PrefServiceBridge to the dedicated (and renamed) SafeBrowsingBridge. Bug: 1016957 Change-Id: Ia3acb1f505e152369268b20c5fbf24f6449da55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896041 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#713188}
-
Xiaocheng Hu authored
generic_trace.py currently makes multiple calls to AddMeasurement() with the same name if it encounters multiple trace items of the same name. This is now broken, as patch [*] has forbidden that, and requires caller to consolidate measurements of the same name into a list. This patch fixes generic_trace.py to follow the new requirements. Change-Id: I44a0fbc1e4260bfbcbfc2558defd25a3f8cc3fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899903 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#713187}
-
James Cook authored
As part of the Split Settings Sync project Chrome OS settings have a new sync controls UI. This requires that new prefs be registered with the type SYNCABLE_OS_PREF instead of SYNCABLE_PREF. Add a presubmit warning if new code in directories known to be Chrome OS specific register a pref with the browser registration type. This is a warning and not an error because it's theoretically possible to add a browser setting that only affects Chrome OS and hence appears in a Chrome OS-only directory. There are no such prefs today. Bug: 1019988 Test: added to PRESUBMIT_test.py Change-Id: I59b46ac831855ae71d3eb5811b54cabf5ec35995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901646Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#713186}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f7b3a2ac7768..6072d056a7cb git log f7b3a2ac7768..6072d056a7cb --date=short --no-merges --format='%ad %ae %s' 2019-11-06 tobine@google.com Vulkan:Ignore layer warnings about provoking vtx ext Created with: gclient setdep -r src/third_party/angle@6072d056a7cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: Ieb95991a559104ed0780c3bd1bdc8ec1bb8f717e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901796Reviewed-by:
-
Toni Barzic authored
AppListView uses AppListViewDelegate::GetShelfSize() to get the shelf size for calculating: * background shield rounded corners. * the app list layout. For both purposes, app list can assume that the shelf height equals non-in-app height (i.e. assume that in-app shelf is not used). The former is only used in clamshell mode. For the later, app list will not be shown with the in-app shelf (at least in static state). Though, while transitioning from app window to app list (e.g. while dragging the app window), app list view will be laid out while in-app shelf shown - if the actual current shelf height is used to calculate the layout, the app list grid items might jump up once the transition completes (as the shelf height changes and the app list gets laid out again with less vertical space available). This can be avoided if app list view always assumed that the shelf size equals the non-in-app size, as done in this cl. BUG=1013706 Change-Id: I5175781baefe1e92cf8abcd92185b1b3fdf8dc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857200Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#713184}
-
Raymond Toy authored
Change base::Bind to base::BindOnce. Bug: 1007838 Change-Id: I43034aa8bcac8bb26c7108ca4c98d0819a00aaad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901634Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#713183}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0f5f46f39281..61ec88a68d6d git log 0f5f46f39281..61ec88a68d6d --date=short --no-merges --format='%ad %ae %s' 2019-11-06 dhanyaganesh@chromium.org chromite: remove binhost-pre-cq Created with: gclient setdep -r src/third_party/chromite@61ec88a68d6d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ica48588c917d423df1ff043e37bb109571547b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901792Reviewed-by:
-
Matt Falkenhagen authored
1) Properly toggle Site Isolation off, when trying to test that config. 2) Add unnamed namespaces to use the DontAssignSiteContentBrowserClient class defined in this file rather than the class of the same name in another file. 3) Fix the class to actually skip |url_to_skip_|. 4) Test that a new process is not created. Bug: 1012143 Change-Id: I383d3740a42b1ef5ae8126f733c82b927c4ee878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900794Reviewed-by:
-
wutao authored
Currently UiElementContainerView does not auto scroll when the focus in the AssistantCardElementView changes, e.g. during Tab traversing. This patch surfaces the OnFocusChangedInPage event from WebContentsImpl to NavigableContentsObserver, so that the UiElementContainerView can do scroll accordinglly. In this patch, if the bounds of the focused node is clipped by the container, it will scroll the node to the center of the container. Bug: 966806 Test: manual Change-Id: I974db35731b85fdcb957d9898ae921a12dbd7607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885253 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713180}
-
Etienne Bergeron authored
This is a reland of 55549387 Original change's description: > Fix RenderText itemization for complex emoji > > > > This CL is a refactoring on the way RenderText do > > ItemizeTextToRuns for the corner cases where a run > > should be split in grapheme clusters. > > > > The previous code was naming these cases: > > * Unusual characters > > * Special characters > > * Non-regular characters > > But they should be more specific on the purpose of splitting the runs. > > > > Also, the algorithm used for splitting a sequence of codepoint > > was based on the code block of the corresponding codepoints > > and few cases where trying to merge adjacent codepoint in > > a grapheme. The algorithm was incorrect multiple cases (e.g. emoji). > > > > Unicode provide a way to split a sequence of codepoints into > > grapheme and grapheme clusters. > > They provide a state machine which is using the codepoint proporties > > to decide if the current location is a grapheme boundaries. > > > > The ICU library is providing an API over the character properties > > to help iterating over graphemes. > > * ubrk_open > > * ubrk_first > > * ubrk_next > > * ubrk_close > > > > The class base::i18n::BreakIterator(..., BREAK_CHARACTER) is > > providing an easy to use wrapper over that API. > > > > > > The current CL is replacing the previous characters based splitting > > algorithm by the graphemes based version. > > > > > > > > See emoji sequence: > > http://www.unicode.org/reports/tr51/ > > 1.4.5 Emoji Sequences > > > > The full emoji list: > > * http://unicode.org/emoji/charts/full-emoji-list.html > > Emoji data, used to make our unittests: > > * http://www.unicode.org/Public/emoji/12.0/emoji-data.txt > > > > > see: UNICODE TEXT SEGMENTATION (http://unicode.org/reports/tr29/) > > see: https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/ubrk.h > > see: https://cs.chromium.org/chromium/src/base/i18n/break_iterator.h > > Change-Id: I6b9a9c79021f2ce0e2db7cdefdd0838b5911f445 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788804 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712704} Change-Id: I64c877907d6e961bd223a7c4cb1193c240b0b7ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900347Reviewed-by:
-
Bo Liu authored
The compositor surface is opaque, which means when video is lifted into a separate surface during fullscreen below the compositor surface, it is never showing through. Always set the compositor surface to translucent for now, which will use more memory even when not in fullscreen. Bug: 1022042 Change-Id: I2ff368dfa2a04ba0e62891039244c0bcb148e6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899901Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713178}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f73369ec458..2d87f9edb488 Created with: gclient setdep -r src-internal@2d87f9edb488 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:992974 Change-Id: I3ff53a1e3e9f0260747d79cc9624fc7310c1f57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901794Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713177}
-
Owen Min authored
All machine_level_user_cloud_policy* files under chrome/browser/policy are renamed to chrome_browser_cloud_management*. Updating the per-file oaner as well. Bug: 1010704 Change-Id: Ib8bafb1c36227c3d725d973b38d3b330cda445a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900551Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713176}
-
manuk authored
Previously, the document provider backed off upon receiving http 200 responses with certain error codes (403 & 503). However, the backend sends http 400 and 499 responses to notify the client to backoff. This CL modifies doc provider to backoff upon receiving any of the backoff responses: http 200 w/ code 403, http 503 w/ code 503, http 400, and http 499 responses). To avoid having to wait for this CL to rollout, the backend may be modified to reply with the http 200 backoff responses. If that is the case, once this CL rolls out to stable, the backend will return to sending http 403 and 499 backoff responses. Afterwards, the document provider will be modified to no longer listen for the http 200 backoff responses. Alternatively, if the backend is never modified to send http 200 backoff responses, backoff won't work until this CL rolls out. Regardless, the document provider should be modified to only listen to one set of backoff responses going forward. Bug: 1022071 Change-Id: I60070be5a0f727bfda3cf165daed03a82efbb277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900400 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#713175}
-
Maggie Cai authored
This CL connects the App Service with the Pref Service. This is to allow the App Service store and retrieve preferred apps from the preferences file. BUG=853604 Change-Id: I2802173d80126595966626af5d1ff1f42761c49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892475Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#713174}
-
Scott Violet authored
As the aidl directory contains more than just aidl files, the name is mildly confusing. This renames it to 'interfaces' ('interface' would be nice, but 'interface' is a reserved word, event for package names). BUG=none TEST=none Change-Id: I29e9fb737d8f7bbe5b586d26399d78ff262c1bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901727 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#713173}
-
kylechar authored
InProcessGpuMemoryBufferManager wasn't providing memory dumps for GpuMemoryBuffers it allocated. Any GMBs allocated for the GPU process weren't accounted for in memory traces. Share the implementation with HostGpuMemoryBufferManager by refactoring it into AllocateBufferInfo class. Bug: none Change-Id: Ieaf1597106bee2562b0fc99a47243f55af7faf5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894457 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#713172}
-
