GitLab

This CL adds the OnRuleMatchedDebug event for DNR. This event is
emitted every time a DNR rule is matched if the extension is unpacked
and is listening to the event.

Emitting this event for allow rules will be implemented in a follow-up.

Bug: 1017934
Change-Id: I2a4d450c01eb19e5090b1c8cb2d6e1a0b984ed7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880176Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714803}

An encoder driver may expect extra data size between planes in an input
buffer. We currently don't use width and height adjusted by the driver,
but a large-enough width and height computed from the buffer size in bytes.
Therefore, a VEA client is asked to allocate a larger width/height buffer
in the case.

A backend for graphics buffer allocation (e.g. minigbm) is
able to allocate a buffer that has extra data properly from width and height
adjusted by the encoder driver. A client using a backend like minigbm wrongly
allocates a buffer unexpected by the encoder driver due to a large width and
height requested by VEA. ARC++ encoder hits this issue.

This CL resolves the issue by requesting width and height adjusted by the
encoder driver if native_input_mode, that is, a client will feed a buffer
allocated by a backend like minigbm.

Bug: b:144135251
Test: ARC++ encoder on kukui
Change-Id: I5bfbd0169bbff2ad3801a4561d546fbfe290902d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906864Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714802}

This is a reland of 84fcf8bb

Original change's description:
> Reland "[base] Introduce base::CheckedContiguousRange"
> 
> This is a reland of 83ced150
> 
> Original change's description:
> > [base] Introduce base::CheckedContiguousRange
> > 
> > This change introduces base::CheckedContiguousRange, which similarly to
> > base::span is a light-weight wrapper around a contiguous container
> > performing bound CHECKs.
> > 
> > However, in contrast to base::span this class keeps a pointer to the
> > underlying container, and thus is able to respond to changes to data()
> > and size(), which base::span can't do.
> > 
> > Furthermore, this change provides a constexpr overload of base::data()
> > for std::array and fixes a bug in CheckedContiguousIterator::operator-=.
> > 
> > Bug: 990059
> > 
> > Change-Id: I3fef91c7ef7874bf495ac2ab6dbaf3a8b02dab35
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893858
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Reviewed-by: Chris Palmer <palmer@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#712120}
> 
> Bug: 990059
> Change-Id: If7cfd16ca526930643e9fac7567f58ba9ef60b1f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893069
> Reviewed-by: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#712493}

Bug: 990059
Change-Id: I728ab7d229d931919f928b4786a19c8ca46920f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906352
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714801}

It sometimes draws bad wallpaper image.
Temporarily disable while investigating the cause.
(could be an issue on gpu/driver, and in that case it will stay)

Bug: 1020500
Test: manually tested on minnie
Change-Id: I141f04eda13ce2c1280102b9fccdb2933c3456b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912833Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714800}

VideoFrameMapper assumes a given VideoFrame on Map() is not nullptr. This
causes a test crash if the VideoFrame is nullptr. We shall handle the case
as error rather than crash.

Bug: 1020776
Test: VD test on atlas
Change-Id: Ifa49a405cf33e16f2df0e5e5079e7df253a5bb1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911062Reviewed-by: David Staessens <dstaessens@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714799}

The collapse state of the status area should be updated when the shelf state or
bounds change or when a tray item is shown or hidden.

Note that the actual calculation for which trays should be hidden or visible is
unimplemented and will be finished in a future CL.

TEST=unit test
BUG=982511

Change-Id: Ie4a46be7d03435bf8927062af0c7726f5cc090a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904165
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714798}

Currently we hardcode crostini terminal to use the builtin crosh
location, whereas crosh can dynamically allow nassh and nassh-dev
apps to be used instead.

With some expected changes coming in crrev.com/c/1905039 to
have crosh use chrome://terminal, and other changes to gzip
content, it is useful to have terminal use the same URL that
is used for crosh.

Bug: 1023866
Change-Id: I7784b42171c73592acdd99d20ade6367c2afa3de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913283Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714797}

Bug: 1020776
Test: VD test on atlas --output_frames
Change-Id: I3ab7dc8342fd55cfa18d5125d0a8065ad4fa94bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910983
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714796}

https://chromium.googlesource.com/libyuv/libyuv.git/+log/53b529e362cc..6afd9becdf58

$ git log 53b529e36..6afd9becd --date=short --no-merges --format='%ad %ae %s'
2019-11-06 fbarchard I420ToI010 fix for missing LIBYUV_API in DLL
2019-11-06 fbarchard I210ToAR30 support for 422 10 bit to 10 bit RGB
2019-11-05 fbarchard Add U444ToABGR, J444ToABGR, H444ToABGR, H444ToARGB and ConvertToARGB support
2019-11-05 fbarchard BT.2020 pull in tests and upstream fixes; expose a few more methods.
2019-10-29 dalecurtis Add support for BT.2020.
2019-10-28 fbarchard Fix for jpeg to allow fuzz

Created with:
  roll-dep src/third_party/libyuv

BUG=960620
TBR=fbarchard

Change-Id: I8f946aa7359c8abec0ed20175b0eb075b055b44a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912691Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714795}

With kConsolidatedMovementXY enabled, mouse movement in blink is
calculated by current possiont - last position. The initial
implementation forgot to handle the pepper events.
This CL adds a last_mouse_position_ field in pepper and use it to
compute mouse movement.

Bug: 1013753
Change-Id: I116ead5e7bdd25d15072e8793e8e3eee02cd2b80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864566Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714794}

The spec requests that the shelf animates to/from the hotseat
background when the hotseat goes to/from HotseatState::kShown.

Links to spec in Code Review request.

Note: This CL also re-applies a previous change that was accidentally
reverted by an reverted revert. It made sure the hotseat state was
not set until the hotseat bounds have already been changed.

Bug: 1006013
Change-Id: I24124aab0891e5920e2ab95d71e1b517df313811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895922
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714793}

https://dawn.googlesource.com/dawn.git/+log/eac7382eb232..604072bc2ed0

git log eac7382eb232..604072bc2ed0 --date=short --no-merges --format='%ad %ae %s'
2019-11-12 cwallez@chromium.org Make the SwapChain interface match webgpu.h
2019-11-12 brandon1.jones@intel.com Implement D3D12 Native Render Passes

Created with:
  gclient setdep -r src/third_party/dawn@604072bc2ed0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: Ie0eabe6854e21014dba4fcfe620aa91eb05cda37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912694Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714792}

Previously the text on each row and the action button for each row were
separate navigation stops when using ChromeVox. With this change, the
text for each row is no longer its own navigation stop since the text is
the aria-label for the icon.

Bug: 1012565
Change-Id: I23f5d4584fd03b98cab6c7e656711fdd4fcae6cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913568Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714791}

This CL changes the aria string for network summary item button so that
it includes the device type and network display name in cases where the
button directly opens a detail page to give more context.

Bug: 1011003
Change-Id: I8c83cf03d8fdbca58955f66aa88c5aec0ff32184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910862
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714790}

-Same change as
 https://chromium-review.googlesource.com/c/chromium/src/+/1880181
 In original CL we missed fixing edit printer dialog
 as well.

Bug: 950887
Change-Id: I55c4e9cb3fa9c99bc104c660fdc0e555ecf8e860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912648
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714789}

Note: "x" can be configured via registry entry.

Bug: 990079
Change-Id: I142c358be8ffb5e06d3253f7a2ef11dcf3980555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900159Reviewed-by: Tien Mai <tienmai@chromium.org>
Commit-Queue: Rakesh Soma <rakeshsoma@google.com>
Cr-Commit-Position: refs/heads/master@{#714788}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/6d06b6613559..6bfc3bbb7a58

git log 6d06b6613559..6bfc3bbb7a58 --date=short --no-merges --format='%ad %ae %s'
2019-11-12 cjmcdonald@chromium.org DependencyService: Mark 'crosutils' dir as always relevant
2019-11-12 lamontjones@chromium.org paygen_payload_lib: test: move image download inside the semaphore.

Created with:
  gclient setdep -r src/third_party/chromite@6bfc3bbb7a58

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ia045c94ea2c39d2bb020df271a1d69d748e51efd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912689Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714787}

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/fc6c45f78316..9734c36f2aa6

$ git log fc6c45f78..9734c36f2 --date=short --no-merges --format='%ad %ae %s'
2019-11-07 victorhsieh Do not enable ADB sideloading for managed account
2019-09-03 garrick system_api: Add patchpanel dbus service.
2019-10-22 henryhsu system_api: Add DOUBLE_TAP input event
2019-10-22 igorcov system_api: Add new class for stop session reason
2019-10-28 zuan cryptohome: Add LowDiskCallback to UserDataAuth
2019-10-28 sidereal vm_tools: Have concierge pass on mount status to chrome

Created with:
  roll-dep src/third_party/cros_system_api

Bug: None
Change-Id: If730eb2ad5eeec7e753d13266c90d044de3733ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907072Reviewed-by: Fergus Dall <sidereal@google.com>
Commit-Queue: Victor Hsieh <victorhsieh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714786}

Previously FuchsiaVideoDecoder wasn't using protected memory even when
decoding protected content. Now it will use protected IO buffers for
protected content when protected graphics is enabled. Also added
force-protected-video flag in web_engine_config, which allows to
force protected buffers for video output buffers for all content.

Bug: 1014835
Change-Id: Id02bf310804ea05dea2deae7aa5ec47aa6010926
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910283
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714785}

Taking activation upon long alt-tab can affect the foreground
application, e.g. pausing video.

Note that ChromeVox only works for activated windows, so we leave
the cycler activatable if ChromeVox is on.

Bug: b/138914552
Test: Netflix does not pause when alt-tabbing
Change-Id: Idb5ff6db56f9eaa3141140eacebc2bfea6bc3bab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905290Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Kazuki Takise <takise@chromium.org>
Auto-Submit: Kazuki Takise <takise@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714784}

When looking up signed-in non-syncing accounts,
AreEmailsSame is currently being used. However,
username may not be an email so it needs to be
canonicalized first. AreUsernamesSame does this.

Bug: 1023521
Change-Id: Iafe57b0e5accde34a61af6c84e3fdc5796bec4a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912644
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714783}

Add PauseApp and UnpauseApp interfaces to AppService mojo, and
publishers. For extension apps and ARC apps, set the icon effects for
the paused apps.

The icon effect is set based on the paused field of App structure, so
pass the AppRegistryCache to ExtensionApps, to check the App's paused
status.

For ARC apps, the AppRegistryCache can get from AppServiceProxy.

BUG=1011235

Change-Id: Iced5e0f36ba5b1d036fd2431e5810832c59d423a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906851Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714782}

This CL apps the app IDs of Android default apps and their default
app order.

Bug: 1013730
Change-Id: I37ce1aa1633e6a1f4be27a4de2514d2c64a8a0e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909667Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714781}

Bug: 1024031, 997885
Change-Id: Ic12b34115036de7a22fd29d8fe207f16bc07a15d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912690Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714780}

Up until now, LevelDB Proto DB has shared the bug component with the
rest of Internals. This CL changes it to use the newly created
Internals>Storage>LevelDBProto bug component.

Bug: 1023496
Change-Id: Ief55a3616d90e6a6790ad21fc7935a5a2753eb38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907078
Auto-Submit: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714779}

Change-Id: I835c23132ddf9eaec25c6e8e49c3a14096340b34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906883
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714778}

TV/car devices (any device which uses standalone WebView instead of
monochrome) have a bug on N-P where we preinstall the release-keys
signed WebView instead of the "developer test keys" signed WebView on
dev-keys signed builds.

This is a surprising gotcha when folks need to work on TV (especially
since there's only one valid WebView package name, so developers are
guaranteed to hit this). This documents this edge case and provides
guidance for how to work around this.

Bug: 918221
Test: tools/md_browser/md_browser.py android_webview/docs/build-instructions.md
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: If19a6cea88177cee831ec0aaaeda79169ee4177a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912787
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714777}

Bug: 1022562
Change-Id: Ib3863135ea0b4cbb105b24ad89b9c7049b7f6e75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911199
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Huanzhong Huang <huanzhong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714776}

Mark the tooltip as aria-hidden since it is read as the description for
the dropdown.

Bug: 1024004
Change-Id: I23ee342ce23275a805d7ab46c40a5ae3fc5b867a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913082
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714775}

This is a reland of f8dd1ecf

Reverted inadvertently in r714447. Different root cause (https://crbug.com/1023525).

Original change's description:
> Capture test_api.js javascript dependencies in 2 places (rather than ~13).
>
> test_api.js depends on a bunch of JS libraries that appear in many lists.
>
> This CL consolidates those dependencies to two places:
>  - js2gtest.gni, and
>  - A JsTestApiConfig class declared in chrome/test/base/js_test_api.h
>
> Note not all lists captured the axs_testing.js dependency, but this change
> uses the same dependency list in all locations for consistency.
>
> TBR=aboxhall@chromium.org (mechanical change)
>
> Bug: 1000989
> Change-Id: If6e0716c03e42783a2d3529baa70475a9d305045
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900512
> Commit-Queue: Trent Apted <tapted@chromium.org>
> Reviewed-by: Dan Beam <dbeam@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#714421}

TBR=tapted@chromium.org,dbeam@chromium.org,aboxhall@chromium.org,blundell@chromium.org,nuskos@chromium.org

Bug: 1000989, 1023795
Change-Id: I8488e9668614bae07b40d65ab2d80f6b01b85ef4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913221Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714774}

https://pdfium.googlesource.com/pdfium.git/+log/1afa8b609752..96befae82483

git log 1afa8b609752..96befae82483 --date=short --no-merges --format='%ad %ae %s'
2019-11-12 thestig@chromium.org Switch to C++14 by default.
2019-11-12 thestig@chromium.org Roll v8/ 9ddd0c4c1..a423bb8be (1234 commits)
2019-11-12 thestig@chromium.org Fix crash in FPDFPageObj_GetFillColor().
2019-11-12 thestig@chromium.org Add another test for FPDFText_GetFontWeight().

Created with:
  gclient setdep -r src/third_party/pdfium@96befae82483

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=pdfium-deps-rolls@chromium.org

Bug: None
Change-Id: Iac0e17c837d59966510891e712d0f50a46b29fe8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913546Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714773}

The Me2Me native-messaging host has a command-line option:
--check-permission
to check for host permissions. This CL updates this to run the
permission-wizard.

Bug: 1015201
Change-Id: Ie936de8fae413567b5260cde5fb62b0a5803712e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913473
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714772}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/edafde28..29e7d3ba

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie3b844da6c01b8fd3e438353015ded972b5cbc5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913105Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714771}

Split KeyboardShortcut and KeyboardShortcutList out of command.js, and
update them to use es6 class syntax.

These classes do not contain any ui and do not depend on cr.ui.define()
so should be straightforward to migrate to Polymer 3, unlike
cr.ui.Command itself. Moving them to a separate file allows the
FindShortcutBehavior and the bookmarks CommandManager to depend on
only keyboard_shortcut_list.js and not on command.js.

Bug: 1022213
Change-Id: I5478f7ac5820f5316ff8a07d047bdf20f76210cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907773
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714770}

Restricts manage_render_test_goldens.py to only uploading images that
are expected to be golden images. This is achieved by looking for
device/SDK pairs in the filename.

This is to prevent random images that happen to be in the directory from
being uploaded when they shouldn't be.

Bug: 1022632
Change-Id: Iead7b574f38b73a88994d2a6e9f61fdcd72b4ea5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913571
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714769}

Add missing polymer binding.

Bug: 1008121
Change-Id: I881dbec7fa9571c70eb571db9b19b2c46f5c7a02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911069Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714768}

This CL fixes and re-enables tests that will be broken by
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1884528

Bug: 963183
Change-Id: Ia783efb3b292a143108cf92def3821c6f22893fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811866Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#714767}

Setting IS_SHOWING_OVERVIEW to false triggers the TasksSurfaceViewBinder to set visibility to GONE.
Setting the TasksSurface visibility to GONE shifts focus to its parent view.
This implicitly unfocuses the LocationBar, which triggers the UrlFocusChangeListeners.
The StartSurface UrlFocusChangeListener calls StartSurface.notifyStateChange().
Here we crash on "assert mPropertyModel.get(IS_SHOWING_OVERVIEW)", since it's already set to false.
Swapping the two lines resolves the issue.

Bug: 982018

Change-Id: I84f8634871c6990ec6440684a7fe53498c38fe14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911102
Commit-Queue: Mia Glaese <glamia@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714766}

TBR=dbessonov@yandex-team.ru,wangxianzhu@chromium.org

Bug: 1023683
Change-Id: I5be711b3823230e1887a154b38577c9f46f64d59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911341Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714765}

Add the use counter FetchBodyStreamInServiceWorker which is triggered
when the body getter is accessed in the Response class.

The purpose of the use counter is to evaluate the potential benefit of
Response body stream optimisations.

Change-Id: I625bb08712f6fc1996def8bdab52a449fc725f07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909675Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714764}