- 31 Oct, 2018 40 commits
-
-
Ehsan Karamad authored
When 'vertical-scroll' policy is disabled in a document, the contents cannot be scrolled (will not be user-input scrollable and targeted for gesture scroll). However, currently disabling 'vertical-scroll' still leaves the vertical scrollbars behind; the bars position cannot be changed however. This CL fixes the issue by hiding the vertical scrollbars for scrollable elements inside documents where the policy is enforced (i.e., disabled). Bug: 898151 Change-Id: If01925e27184a7370d5b12583dc73bc946f2c6e2 Reviewed-on: https://chromium-review.googlesource.com/c/1305878 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604420}
-
Kristi Park authored
Add functionality for reordering custom links. Will initialize if custom links has not been initialized yet. Bug: 851335 Change-Id: I67710b4187f8f5a45d7f96814c17294f87d60b22 Reviewed-on: https://chromium-review.googlesource.com/c/1308899 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#604419}
-
Jimmy Gong authored
- The text field for File Share URL will now initialize to the most recently used share path. Bug: chromium:887133 Test: end to end Change-Id: Ic59f7d34332b25c0e28832c6109060b849e838f2 Reviewed-on: https://chromium-review.googlesource.com/c/1300797Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#604418}
-
Sergey Ulanov authored
Minor fixes in the code that allocates VMOs to pass images to scenic: 1. VMO handle is now dropped immediately after VMO is mapped. 2. Added check to verify that VMO is mapped successfully. 3. Read-only VMO handle is passed to Scenic. Bug: 899348 Change-Id: Ie78261ffc00dd5c9b80cc2b93ad2006a47c5118d Reviewed-on: https://chromium-review.googlesource.com/c/1309301 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#604417}
-
Yuke Liao authored
This CL updates the md doc's mailing list to code-coverage@chromium. Change-Id: Ifb620a543b4afb13239cf8736832448047787aba Reviewed-on: https://chromium-review.googlesource.com/c/1311089Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604416}
-
Reilly Grant authored
This change resets the SerialDeviceEnumeratorPtr held by this class after enumeration is complete. This breaks the reference cycle between these two objects, allowing them both to be freed. Bug: 898177 Change-Id: I874c62f89f8bb59a2c41f8c40afd537404f4580b Reviewed-on: https://chromium-review.googlesource.com/c/1311533Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#604415}
-
John Rummell authored
It appears that AVC level 5.2 is supported by Chrome for both encrypted and non-encrypted videos, so update MIME checking to indicate that it is supported. BUG=622873 TEST=browser_tests pass Change-Id: I569c1ec64313905ff38ae540c6bf354884959924 Reviewed-on: https://chromium-review.googlesource.com/c/1299909Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#604414}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5ca3e5a0b285..580baf379673 git log 5ca3e5a0b285..580baf379673 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 brandon1.jones@intel.com Recompile D3D11 Blit Shaders 2018-10-31 jmadill@chromium.org Scale down a slow index buffer perf test. Created with: gclient setdep -r src/third_party/angle@580baf379673 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ib72a547f0c9298e510eb330a2440f440fafdc8af Reviewed-on: https://chromium-review.googlesource.com/c/1310602Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604413}
-
Peter Kotwicz authored
This CL: - Introduces H2OTransparentLauncherActivity to handle deep links and share intents - Makes H2OTransparentLauncherActivity launch SplashActivity prior to launching the host browser so that: 1) Launching WebAPK via deep link 2) Tapping app icon brings the already open WebAPK to the front instead of launching a new activity stack - Makes H2OTransparentLauncherActivity update which of SplashActivity and H2OMainActivity is enabled. BUG=817263,817263 Change-Id: I1ff2b66171ae561c804d25257ec54f3d5bda459b Reviewed-on: https://chromium-review.googlesource.com/c/1304222 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604412}
-
Jeremy Roman authored
Change-Id: I8aa29772ece72b8fcf88f1f402746b24740cef9e Reviewed-on: https://chromium-review.googlesource.com/c/1302317Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604411}
-
Lucas Furukawa Gadani authored
This CL also adds an API to retrieve the portal given a portal token. Bug: 865565 Change-Id: Ie8f5e8f5aaea395811e9da3afc04fc89df48196b Reviewed-on: https://chromium-review.googlesource.com/c/1297248Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#604410}
-
Mike Klein authored
Change-Id: Idc26e054b44b1d73a322538464bb2549c801e64f Reviewed-on: https://chromium-review.googlesource.com/c/1308016Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#604409}
-
Kristi Park authored
Root cause has been fixed in https://crbug/898941 Bug: 897006 Change-Id: Ie1a6cbb60345c733fe088858870696dcc69a5683 Reviewed-on: https://chromium-review.googlesource.com/c/1310717Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#604408}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9afc6490c148..861640f6c89b git log 9afc6490c148..861640f6c89b --date=short --no-merges --format='%ad %ae %s' 2018-10-31 ehmaldonado@chromium.org metrics: Collect git version. Created with: gclient setdep -r src/third_party/depot_tools@861640f6c89b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=agable@chromium.org Change-Id: I4b44c2cc00e2c84d5b7f6b1f306521a22e322504 Reviewed-on: https://chromium-review.googlesource.com/c/1311055Reviewed-by:
-
Tarun Bansal authored
Add a periodic timer that checks queued requests and may dispatch requests that have been queued for too long. This change is guarded behind a field trial. Change-Id: I43c85bd92b7a34c078f18fb87931806266f32813 Bug: 897371 Reviewed-on: https://chromium-review.googlesource.com/c/1303412 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604406}
-
Martin Kreichgauer authored
WinWebAuthnApi is a wrapper around the native WebAuthn library. The corresponding headers have not made it into the Windows SDK used by Chromium yet, therefore none of this code is currently included in the build. WinNativeCrossPlatformAuthenticator is a FidoAuthenticator implementation that forwards requests to the native library. Bug: 898718 Change-Id: I1c144bdeabe763debaadadad2c4937f9778c1d96 Reviewed-on: https://chromium-review.googlesource.com/c/1298734 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#604405}
-
Xi Han authored
The ChromeMojoProxyResolverFactory may be created in early startup when the ui thread hasn't be promoted to BrowserThread::UI. Therefore, it can't use DCHECK_CURRENTLY_ON(content::BrowserThread::UI) to check whether it is accessed on the same thread. Instead, we could use SequenceCheck for the check and make sure it is accessed sequentially. Bug: 729596 Change-Id: Id31e53e1ec369b029a843656cf86fc605d768a43 Reviewed-on: https://chromium-review.googlesource.com/c/1308667Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/79263ca083e0..22a617f93038 git log 79263ca083e0..22a617f93038 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 thestig@chromium.org Roll third_party/skia/ 728b7f3cd..7258e97e8 (1 commit) 2018-10-31 thestig@chromium.org Roll third_party/skia/ 8dc68c67f..728b7f3cd (88 commits) 2018-10-31 thestig@chromium.org Roll third_party/skia/ 588f8796..8dc68c67 (1 commit) Created with: gclient setdep -r src/third_party/pdfium@22a617f93038 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie39911bb576066a2f81b80558d1a15662c3ff357 Reviewed-on: https://chromium-review.googlesource.com/c/1310555Reviewed-by:
-
Matt Menke authored
We don't support CT on iOS, so this CL removes the relevant NetworkService APIs and objects on iOS. We also don't support it on Android, but removing the APIs there would require a fair bit of work on the net-internals code. Bug: 887122 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I012ea593f1df5a25a9379f57a268225ba2d42381 Reviewed-on: https://chromium-review.googlesource.com/c/1249884Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604402}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c9eace8194dd..06768fc14b7a git log c9eace8194dd..06768fc14b7a --date=short --no-merges --format='%ad %ae %s' 2018-10-31 brianosman@google.com Use std::numeric_limits for SK_FloatNaN and Infinity 2018-10-31 halcanary@google.com SkShaper: Fix a couple of crashes when fonts aren't found 2018-10-31 bsalomon@google.com Make nanobench --mpd flush between canvases. 2018-10-31 herb@google.com Don't allocate space for the unique glyphs. 2018-10-31 halcanary@google.com experimental/tools/generate-unicode-test-txt: update 2018-10-31 caryclark@skia.org docs with more pop 2018-10-31 recipe-roller@chromium.org Roll recipe dependencies (nontrivial). 2018-10-31 herb@google.com Size buffers properly for bulk interface between Painter and SkDraw Created with: gclient setdep -r src/third_party/skia@06768fc14b7a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I7b85222feb2e5c35b99808bef5d4dfce949a6c9c Reviewed-on: https://chromium-review.googlesource.com/c/1310556Reviewed-by:
-
Avi Drissman authored
If a beforeunload dialog is being shown, the commit has to wait for the user's response. Do not allow the commit timeout to fire during that time. This also does some associated cleanup, moving the GPU switching observer to be the RenderViewHost. BUG=891423 Change-Id: Ie2274098ef4de451e17334a9716776242e9c07ee Reviewed-on: https://chromium-review.googlesource.com/c/1303094 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#604400}
-
Stephen McGruer authored
This CL aligns Chromium with the URL spec, such that we consider '#' to mark the end of the content and the start of the fragment section only. GURL::GetContent was updated to reflect this, with a special case for javascript URLs specifically (as their spec mentions including '#' in the URL content). This is a reland of I49c6f4d739a2dd42eecc9947f8e75071b84e9be7. Recent data shows that kDataUriHasOctothorpe is now rare on WebView, and the Chrome side data has also shifted to be a long tail of smaller users. Plan is to land this change again and see if anything breaks. TBR=rdevlin.cronin@chromium.org,mlamouri@chromium.org,pfeldman@chromium.org,boliu@chromium.org Bug: 123004 Change-Id: Ib72b8eef4bd61db4f2488e522d3d4cfcfa8a1a14 Reviewed-on: https://chromium-review.googlesource.com/c/1297172 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#604399}
-
Charlie Harrison authored
Bug: 900062,839190 Change-Id: I0b5ed1f711a221790cfe0f2ee40842a46556e50c Reviewed-on: https://chromium-review.googlesource.com/c/1308034Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#604398}
-
Scott Violet authored
This changes how ExtensionAppWindowLauncherController watches for activation. ExtensionAppWindowLauncherController inherits activation watching from wm::ActivationChangeObserver. The ActivationChangeObserver is added to Shell's root window. This doesn't work for mash. This switches ExtensionAppWindowLauncherController to use a Widget observer. This works in both the mash and non-mash code. I did not promote this logic to AppWindowLauncherController as AppWindowLauncherController is also used for arc/crostini windows, which are created in ash and should continue to use AppWindowLauncherController (at least for the single-process-mash case). For multi-process-mash the arc/crostini launcher code likely does not work at all (because the windows are entirely created by ash) and will need more extensive changes. BUG=826386 TEST=covered by test Change-Id: If5f89d88f782ce452f10889da17210f41189dc77 Reviewed-on: https://chromium-review.googlesource.com/c/1306355Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#604397}
-
Ryan Sturm authored
In a refactor from the InfoBar delegate into the PreviewsUITabHelper, we stopped reporting non-opt outs to Previews code. This will break Previews for all users in M71 once they dismiss enough previews (even if we serve them a lot of Previews they do not dismiss). Bug: 900711 Change-Id: I1f0e2da1c7421f3ec8668b79b09ad0367e4dce47 Reviewed-on: https://chromium-review.googlesource.com/c/1311118Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#604396}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/59f591bd4e30..454cfea9e32c Created with: gclient setdep -r src-internal@454cfea9e32c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:856278 TBR=mmoss@chromium.org Change-Id: I43d9f88d60591c8efc9328a1e13f8127357d1ac5 Reviewed-on: https://chromium-review.googlesource.com/c/1310600Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604395}
-
Carlos Knippschild authored
This change adds a new metrics that works as a mirror of OfflinePages.OfflineUsage, aptly named OfflinePages.OfflineUsage.NotOfflineResilient, that should report exactly the same values but does not accumulate counters in PrefsService, reporting them directly to UMA instead. We want to compare these two metrics to try and assess the loss bias of metrics often reported in offline situations. Bug: 899800, 857134 Change-Id: I90b83ce1da638ca389ef38785a9f5ef1bb4538f3 Reviewed-on: https://chromium-review.googlesource.com/c/1305397 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#604394}
-
Tibor Goldschwendt authored
Fakes module install by copying a feature module on the device's download folder into the directory where SplitCompat expects downloaded modules. Then invokes SplitCompat to emulate the module. The fake install mode is activated via a command line flag. The fake install mode is useful for testing purposes where it is difficult to host the module on Play. + Refactors install logic out of ModuleInstaller into the ModuleInstallerBackend. + Adds two backends - one for the existing install logic and one for the fake install logic described above. Bug: 862702 Change-Id: I8f2deff34a9aa4f8c0d434429fe7895038be7464 Reviewed-on: https://chromium-review.googlesource.com/c/1308608 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#604393}
-
Vlad Tsyrklevich authored
While reading through this header file, I ran across this outdated warning that said that use of function-level static initializers was not thread-safe and hence not advisable for use with ThreadLocalStorage. This comment was written before C++11 and function-level static initializers were ensured to be constructed thread safely. Change-Id: I8407edc5c32dc30e307a7192c42b411f22e75f7e Reviewed-on: https://chromium-review.googlesource.com/c/1309300Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#604392}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/71822866c65d..062a691cae73 git log 71822866c65d..062a691cae73 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9996ac89..6271fcdc (604166:604273) 2018-10-31 Peter) Slatala When SDES is used, pass pre-shared key to media transport. Created with: gclient setdep -r src/third_party/webrtc@062a691cae73 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I708331050d6efab0f78c5533f689f14be2eb8f3d Reviewed-on: https://chromium-review.googlesource.com/c/1310597Reviewed-by:
-
Francois Doray authored
The goal is to improve readability of upcoming additions to the tests. Bug: 885293 Change-Id: I154a924e0493440d6ecf2b574c90183fbbc1ce73 Reviewed-on: https://chromium-review.googlesource.com/c/1305205 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#604390}
-
Morten Stenshorne authored
Avoid duplicate BuildResponseHeaders(): https://chromium-review.googlesource.com/c/1292008 introduced compilation errors, because there was already a BuildResponseHeaders() in content/browser/devtools/protocol/network_handler.cc , and that file and content/browser/devtools/protocol/fetch_handler.cc got bundled together in the same translation unit by Jumbo. Similarly, we suddenly got two ToInterceptorStage() functions. The new one in fetch_handler.cc, in addition to the one we already had in network_handler.cc. TBR=caseq@chromium.org Change-Id: I07e130ef68a57d3fdb012c3beaa64be7b16edb7c Reviewed-on: https://chromium-review.googlesource.com/c/1310815Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#604389}
-
Paul Meyer authored
This patch implements crash reporting, as detailed in the reporting spec: https://w3c.github.io/reporting/#crash-report This is a fixed version of the previously reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1174965 Bug: 898860 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I95c3995bac79801e7321f8d0909563bf7bf89db8 Reviewed-on: https://chromium-review.googlesource.com/c/1220031Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Douglas Creager <dcreager@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#604388}
-
Stephen Martinis authored
Bug: 756686, 873373 Change-Id: I22adc1b01841e97a81e230f4fa8b94e96fdf623a Reviewed-on: https://chromium-review.googlesource.com/c/1309229 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604387}
-
Min Qin authored
DownloadManagerImpl::PostInitialization() is called twice, one by history db, one by download db. If History db is initialized first, it will call OnHistoryQueryComplete() and set load_history_downloads_cb_. If download db is ready later, it calls PostInitialization() and executes load_history_downloads_cb_ immediately. Since load_history_downloads_cb_ calls PostInitialization() again, we got an reentrance issue. BUG=900417 Change-Id: Ie89146f9bd7d30ca955601c7288e0f33c2e9e11b Reviewed-on: https://chromium-review.googlesource.com/c/1309218Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604386}
-
Sammie Quon authored
Test: manual Bug: 900281 Change-Id: I96380621d6b10fbf364dbb7e33df9dfa36aa86c7 Reviewed-on: https://chromium-review.googlesource.com/c/1308262Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#604385}
-
Sergey Berezin authored
The builder is experiencing a massive failure due to a swarming error. Making it non-blocking for CQ while the fix is being worked on. TBR=tandrii@chromium.org Bug: 900742 Change-Id: Ie6f95ec39062107b77fca6942992dbcb35557ec7 Reviewed-on: https://chromium-review.googlesource.com/c/1311128Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604384}
-
Giovanni Ortuño Urquidi authored
StopScan just sends the command directly to the active adapter. Future iterations will cause the state to change to kTransitioning, and support concurrent calls. Bug: 870192 Change-Id: I84e57147e7b1c82f3137841d615d7250bfac4cb9 Reviewed-on: https://chromium-review.googlesource.com/c/1295612 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#604383}
-
dpapad authored
Also remove PaperInputBehavior. Last usages of these were in paper-input which was removed recently. Bug: 899982 Change-Id: I3fc9c741d726851a4c694d73d91aa11159ad8e2d Reviewed-on: https://chromium-review.googlesource.com/c/1309226Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#604382}
-
Yuke Liao authored
This CL implements the Clang code coverage compiler wrapper, which can be used to instrument a subset of source files, and the main use case is to enable generating code coverage reports at per-cl level during try jobs. This CL only focuses on the wrapper itself, how to hook this wrapper into the build system will be addressed in a separate CL. Bug: 898695 Change-Id: Idb21640b5566ce78089059b3d0116390b488a383 Reviewed-on: https://chromium-review.googlesource.com/c/1301969 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#604381}
-
