- 02 Jun, 2020 40 commits
-
-
Clark DuVall authored
I was testing my in-progress popup change, and found a crash when opening multiple popups. Bug: 1090492 Change-Id: I2c3cb3cc655d13ce5476192117c4d863c9d4c044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225626 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#774364}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2ad3dfb46bb6..4af57c9c55fd 2020-06-02 bsalomon@google.com Check for sync extensions only on correct context types 2020-06-02 reed@google.com Revert "Revert "gms for SkParagraph"" 2020-06-02 mtklein@google.com does -fms-compatibility-version=19 still matter? 2020-06-02 herb@google.com Make strike fields private 2020-06-02 nifong@google.com A example of 3D rotation that shows a quotation with all the glyphs rotated. 2020-06-02 michaelludwig@google.com Add localmatrix w/ perspective GM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I9804c0609a41ac050a00d0cffa7e7fc2b932cbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227161Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774363}
-
kylechar authored
Fix NOTIMPLEMENTED() that gets hit with SkiaRenderer+Dawn for max texture size. There is no API to query max texture size but WebGPU needs to support 8k textures so that is a safe placeholder for now. Bug: 1090476 Change-Id: Ia25ab3441b717410f09e21bb3785413c8a3c097a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225624 Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#774362}
-
Marijn Kruisselbrink authored
For drag&drop we'll need a different implementation of this mojo interface. This CL factors out the common code into an abstract base class, with the existing implementation as a concrete subclass. Later for drag&drop a different concrete subclass will be added. Bug: 1080811 Change-Id: Ie16836f315918e1f20dde82fc2a7efac40f67c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221432 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774361}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib2ce63d55287247b34dd8c3cc89117692b3a8941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227171Reviewed-by:
-
Katie D authored
No translation screenshots as this is not yet UX approved. cursor colors in chromebook a11y settings. AX-Relnotes: Users with cursor color flag enabled can now change their Bug: 1085442 Change-Id: I583f6b28ea69387e598e595b513bf4cf6928bbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220492 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#774359}
-
Ian Vollick authored
With this CL, we count the portal's web contents as a single frame in its parent, ensuring that we do not exceed NodeRareData's connected frame count bits. However, we do not yet include frames within the portal in the total. If limit is exceeded, HTMLPortalElement::InsertedInto will early out. Successful insertion and removal of portal elements will impact the subframe count (and, naturally, the consistency check on subframe count must also account for portals as well as frames). In order for the test to run in a reasonable amount of time, I've also made it possible to reduce the frame limit for testing. Bug: 970038 Change-Id: I64d458b640c193c96662b0dd1e2101b6438e2e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187200Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#774358}
-
Lei Zhang authored
For instance, if (ptr != nullptr) can just become if (ptr). Change-Id: I56fc1a8f97d72f46bca8035e3bcb9b4fae199b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227114Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#774357}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2fbd57b6362a..907433b9f820 2020-06-02 bclayton@google.com SpirvShaderDebugger: Implement Array types 2020-06-02 bclayton@google.com SpirvShaderDebugger: Replace 'builtins' / 'root' with a global scope 2020-06-02 bclayton@google.com SpirvShaderDebugger: Silence release only warning 2020-06-02 bclayton@google.com SpirvShaderDebugger: Handle None sizes for composite types 2020-06-02 bclayton@google.com SpirvShaderDebugger: Handle template types 2020-06-02 bclayton@google.com SpirvShaderDebugger: Don't display SSAs for array types 2020-06-02 bclayton@google.com SpirvShaderDebugger: Don't display SSA values with DebugInfo 2020-06-02 capn@google.com Make ManagedStatic registration thread-safe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:950343 Tbr: swiftshader-team+autoroll@google.com Change-Id: If9d9b4d797122029bd272992a663e5109fdf8b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226963Reviewed-by:
-
Jon Mann authored
Previously, networks were only synced after they have had a successful connection. This change now allows syncing after they are configured so long as the password isn't rejected during a 20s waiting period. Bug: 966270 Change-Id: I21d4e9d71c0fd2a55a22303bc3febca28fb787b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223152 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#774355}
-
Zach Trudo authored
This change adds ReportQueue for generating reports. File Changes: ~ chrome/browser/ | ~ BUILD.gn | | Add report_queue.h to the buildable unit. | ~ policy/messaging_layer/ | | ~ proto/record.proto | | | Change EncryptedRecord::encrypted_wrapped_record from byte to | | | string. Behind the scenes they are treated the same, but in | | | practice it is easier to work with std::string(). | | + proto/test.proto | | | Adds a test proto for testing. | | + public/report_queue.h/cc | | | Add ReportQueue, temporary StorageModule and temporary | | | EncryptionModule. | | + public/report_queue_unittest.cc | | | Add tests for ReportQueue | | ~ public/report_queue_configuration_unittest.cc | | | Import missing library. ~ chrome/test/BUILD.gn | Add unit tests and test proto. Bug: chromium:1078512 Change-Id: If3fff7ac59e7d4a486d47ab87148cb27020c2866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191201Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#774354}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Icf8e7f1cd9751fd79d13ad21aa708a4cea8e38aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227162Reviewed-by:
-
Peter Kasting authored
Major changes: * Remove mutable reference section from Blink guide due to recent Google style changes. Minor changes: * Remove Blink guide section on documentation since the Google style guide already mandates this. * Add section on TODO formatting to Dos-And-Don'ts page; remove similar section from Blink guide in hopes the Google guidelines + Dos-And-Dont's text covers it. * Add information about C++17 (lack of) support. Trivial changes: * Clarify that the Blink style guide is a diff atop the Chromium guide (which is a diff atop the Google guide). * Cite Chromium guidance around bare "new" from Blink guide. * Minor link fixes, wording changes, inlining. Bug: none Change-Id: I1e3c2b265930cc73501e3557b25ca52b6902126e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223452 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Yi Gu authored
Previously CompositorTimeline was updated on Animation level which introduced a reverse dependency. This patch moves the update logic up to AnimationTimeline level to fix this issue. Bug: 921031 Change-Id: Iaaa92686003c741cad424eb9867a0993193c05c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225853Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774351}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e246638c18ca..cd6894f0a29e 2020-06-02 taylori@google.com Fix slice interleaving bug If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: wenbinzhang@google.com Change-Id: I9fed1ca29c65c12d9b53906baf10c6a32fbf18c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227150Reviewed-by:
-
Arthur Wang authored
This reverts commit 41dddd7d. Reason for revert: Break gclient runhooks for someone https://bugs.chromium.org/p/chromium/issues/detail?id=1090465 Original change's description: > Refractor manage_render_test_goldens.py and add manage_wpr_archives.py > > R=bsheedy@chromium.org,harringtond@chromium.org > > Bug: 1060399 > Change-Id: Ifb06c6a94a51a6b1a2815bf94fa8f5a53dec1db8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219525 > Reviewed-by: Haiyang Pan <hypan@google.com> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Arthur Wang <wuwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774253} TBR=iannucci@chromium.org,bsheedy@chromium.org,hypan@google.com,harringtond@chromium.org,wuwang@chromium.org Change-Id: I3597b11b7ae43b93747ae4ee2821c15d5072d50c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1060399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225632Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#774349}
-
Tom Anderson authored
This is a reland of 0af7d7aa Original change's description: > [XProto] Remove all remaining non-event usages of XRandR > > BUG=1066670 > R=msisov > CC=sky > > Change-Id: Iecd593c0c77878a80bf84e9e3c504fd90815db6c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220686 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773876} Bug: 1066670 R=msisov TBR=jamiewalch Change-Id: Id24ace289778fc9f6feb8de9ed2744a2630be766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226785Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/c43545625d9c..724a60fb10c7 2020-06-02 rwkeane@google.com Code Coverage: Force CI Bot Waterfall Run If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ib3a2716014a42a0777041f90bafafc61c8867196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226967Reviewed-by:
-
Roman Aleksandrov authored
Since the pin pad buttons are no more tabbable (see for more details: https://crbug.com/1043194) we can return focus to textfield on number insert. Bug: 1009417 Change-Id: I4b1ebeef0a8e32a5ff2ba9b39da3ee424b7bdb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208864Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#774346}
-
Findit authored
This reverts commit 00c7f91f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 774325 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzAwYzdmOTFmMDk0NjIzOTlmZmY1ZTUyNjZlZWRkY2Q2ZTBjOTQwNWMM Sample Failed Build: https://ci.chromium.org/b/8878570367609188432 Sample Failed Step: compile Original change's description: > Re-land migrate md5sum tool to portable zlib utils > > Use the set of portable code from zlib that shouldn't have > extra dependencies (e.g. 'base'). > > Also allow building the tool for other targets (e.g. Linux, > OSX, etc) as that allows easier testing and profiling. > > Compilation is disabled for Windows, see crbug.com/1090428. > > Bug: 1076580, 1087999 > Change-Id: Ic036685029be99b06753ea18f9fc62ce7c1a6540 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225526 > Reviewed-by: Tao Bai <michaelbai@chromium.org> > Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774325} Change-Id: I90e7158af6e9484a63f523cc75f5bfc52288262b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1076580, 1087999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227311 Cr-Commit-Position: refs/heads/master@{#774345}
-
Peter Kasting authored
ArcCustomTabView was the lone implementation of this abstract base. Merge the two classes and simplify the construction to happen directly, rather than through a factory method. Further simplify the class by making it not be a View override. ArcCustomTabView didn't do anything related to being a View other than call GetWidget(), which it can just as easily call on (what was) its child NativeViewHost. Now that view is made a direct child of the widget ContentsView, without the ArcCustomTabView in between. For now, lifetimes stay the same -- the NativeViewHost becomes set_owned_by_client() instead of |this| in order to preserve the property that the custom tab and its |host_| are deleted together, irrespective of the lifetime of the widget ContentsView. Bug: none Change-Id: I921189cf74b63cc34d3789332e1b53a627e83602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225493Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#774344}
-
Evan Stade authored
Bug: 1007826 Change-Id: Ibfbad4000f7144629fe01d856e2fcbda26228f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107585 Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#774343}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f0122481..ce9a17d4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If6c2cf309af57fcd8b6a2001eda8838af6926636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225545Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774342}
-
Ben Pastene authored
This is a reland of 3a8d37c3 Reland fix: - Only adds the needed test data if `cros_sdk_version != ""` That will prevent ebuild invocations from trying to add non-existant items to data (since the ebuild doesn't use the cros chrome-sdk cache). Original change's description: > chromeos: Add only the current SDK version's items to a test's data. > > Instead of adding every version of a given item, this will add only the > current version's. This is a bit tricky since individual versions of an > item are keyed by symlink. And since isolate doesn't follow symlinks, > we have to follow them ourselves. > > Bug: 1027382 > Change-Id: I6b3ea4ec15de3804e99fd6af768daac64f490d5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931155 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771959} Bug: 1027382 Change-Id: I2ff8c8452f5f6f43e178d547e963b6f8b7d17166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218581Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#774341}
-
Lei Zhang authored
Use a well defined way to do this. Change-Id: Ifb70fdc002251d00b8db73e8f8a6130c7a126357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227113Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#774340}
-
Mustafa Emre Acer authored
Users may sometimes press non character keys such as ESC when on a webpage (e.g. to close popups or other prompts). This CL ignores these cases and does not undelay the warning. Bug: 1057157 Change-Id: Id20dc58b279e3e85935e4619dce3f958e512f3b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225361 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#773833} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225525 Cr-Commit-Position: refs/heads/master@{#774339}
-
Lily Chen authored
This adds comments to better explain use cases for adding the special exceptions to SameSite cookie rules for chrome:// scheme pages that were added in https://crrev.com/c/1904544. Bug: 1007320 Change-Id: Iba4f6c20d2a4bbca6297be813ebdc9aa0437dcef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227058 Commit-Queue: Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Auto-Submit: Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#774338}
-
Scott Violet authored
It does nothing, and AFAICT hasn't done anything for more than two years. It's also the case that we already rerun failing tests. I would also argue that having an annotation for this is a bit of anti-pattern. BUG=797002 TEST=none Change-Id: I37349d54a4c9d86fd54e5c97cfd244e7ad52a4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226780Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#774337}
-
Kevin Marshall authored
Tests which play back video can flake when run in parallel due to a problematic DCHECK in VideoCadenceEstimator (see bug). Bug: 1090159,1090489 Change-Id: Ie4e93ba562108503a98992011632355e4ddfc7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226923Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774336}
-
Stephen Chenney authored
We don't support CSS mask on html elements. The image-orientation tests have some problems that need fixing. TBR: fs@opera.com Bug: 1071173, 432153, 1071929, 1076121 Change-Id: I3ff1e9c93845b3c6e5d56a0a1c7f943830b04dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225623Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#774335}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iea9020d6d7a75ae1f36987100f06accb1cc89f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225284Reviewed-by:
-
Lukasz Anforowicz authored
If content::ContextMenuParams includes a non-empty |frame_url|, then the context menu (the menu shown after right clicking in a frame) includes frame-specific commands like "View frame source" and/or "Reload frame". Before r749036 / 82.0.4084.0, context menu shown for the main frame would exclude such frame-specific items. This behavior has regressed in r749036, because it failed to preserve the following logic from //third_party/blink/renderer/core/page/context_menu_controller.cc: if (selected_frame != page_->MainFrame()) data.frame_url = WebURL(UrlFromFrame(selected_frame)); and instead started to unconditionally populate the |frame_url| field in RenderFrameHostImpl::OnContextMenu. This CL fixes the regression. Bug: 1085040 Change-Id: I149447654bee858037a4230828e2c4a7b3c7c0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212995Reviewed-by:Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Maggie Chen authored
Bug: 949839 Change-Id: I86f724255250bf7219c2c81bdc80dcc31f343d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226315Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774332}
-
Jun Mukai authored
On some occasions, ui::Layer gets a transform which is identical to the original. Setting and handling transform causes some tasks, and that doesn't make much sense to do so when the transform doesn't change actually. It seems a few of unittests expect to get invoked, so this CL also changes those expectations. This wouldn't change the actual system behavior. Bug: 1082562 Test: compositor_unittests, aura_unittests, views_unittests Change-Id: Ia83b3b2ba87aa9825da6e2862aee3db9c665c72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225227 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
-
Jerome Jiang authored
https://aomedia.googlesource.com/aom.git/+log/c810066815b8..2aa13c436e4d $ git log c81006681..2aa13c436 --date=short --no-merges --format='%ad %ae %s' 2020-06-01 marpan rtc-svc: Set init_seq_coding_tools in svc_set_params 2020-06-01 marpan rtc-svc: Fix to framerate with set_svc_params 2020-05-14 vdziumenko Add NEON version of few subpixl|variance functions 2020-05-27 yunqingwang Extend prune_starting_mv to speed 3 2020-05-28 remya.prakasan Disable 'prune_ref_frame_for_gm_search' for mt 2020-05-19 marpan Update comment in scene detection 2020-05-14 vdziumenko Optimize NEON version of aom_sse function 2020-05-28 vdziumenko Fix av1_inv_txfm2d_add_NxM_neon for arm 32bit 2020-05-21 paulwilkins Change to active best Q calculation. 2020-05-21 chiyotsai Remove adaptive motion search speed feature (...) 2020-04-30 jzern aom/aom.h: rm AOM_SET_DBG_* controls 2020-04-29 chiyotsai Packs txfm_search parameters in MACROBLOCK to TxfmSearchParams 2020-05-01 elliottk Doc update for control codes 2020-04-29 marpan rtc: Refactor active_best_quality for 1 pass cbr 2020-04-25 wtc Remove the put_frame and put_slice callbacks 2020-04-26 wtc Minor cleanup related to external frame buffers 2020-04-26 elliottk Remove multi-resolution encoding from API 2020-04-25 wtc Move NELEMENTS macro to aom_dsp/aom_dsp_common.h 2020-04-20 wtc Replace for loops with range-based for loops 2020-04-28 yaowu.google.com Avoid the copy of non-existing u&v planes Created with: roll-dep src/third_party/libaom/source/libaom R=jzern@google.com Change-Id: Id0b26a6ad183ccf92f706a1efe86467b009ff69c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225868Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#774330}
-
Siyu An authored
Fixed: 1088618, 1088617, 1088616, 1088602 Change-Id: I05bd235d90ae7d4ed42345f701fa393f0e35889c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225395 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#774329}
-
Wei Li authored
Touch point view can be owned by views hierarchy if we manage to remove it from the view hierarchy when we need to delete it or to transfer ownership to someone else. Thus this CL removed using set_owned_by_client() for touch point view. BUG=1044687 Change-Id: I7790a8bc679faadd4288dc16024a05eed8038048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224007Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#774328}
-
Dominic Mazzoni authored
Bug: 1090432 Change-Id: I00eea4851b95669ffa5e6824d2eecf1366f65dbc Tbr: tapted@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226972Reviewed-by:
-
Dana Fried authored
Issue was caused by a previous fix for CrOS not taking hover card images into account. Now there is a uniform margin around preview images, as there was before. Also removed a redundant SetProperty call that was overridden later in the same function. Bug: 1087759 Change-Id: I5d1ab7081f9e1195961ead27cfc365bb6e25ede8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225239Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#774326}
-
Adenilson Cavalcanti authored
Use the set of portable code from zlib that shouldn't have extra dependencies (e.g. 'base'). Also allow building the tool for other targets (e.g. Linux, OSX, etc) as that allows easier testing and profiling. Compilation is disabled for Windows, see crbug.com/1090428. Bug: 1076580, 1087999 Change-Id: Ic036685029be99b06753ea18f9fc62ce7c1a6540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225526Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
-
