- 21 Nov, 2020 40 commits
-
-
Peter Wen authored
As recommended in the lint README, lint-suppressions.xml should only be used for temporary and permanent ignores, not for old code that should be fixed at some point: https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.md Thus, bulk-moving ignores for old code into lint-baseline.xml. The one exception is for UnusedResources, since having these checks in lint-baseline.xml causes a lot of bloat in terms of lines since each language's xml file is listed on a separate line for every resource. Bug: 1069186, 1077861, 1116130, 1085410, 1039415 Fixed: 1069186, 1085410 Change-Id: Iac10f4dc087e12b43595aae154dc7ffb821f2325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552853 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#829920}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/16973d613fed..8f8e2dc7d50f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I528774ac7c0b843af830e1ae05b848a745ccf4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551517Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829919}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ce4be1e64050..4d62438ecdeb 2020-11-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7ffc87db..81ed1058 (829478:829759) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I812fc276305fcb5eaa811972fec50ef74ad0130a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552900Reviewed-by:
-
David Van Cleve authored
This CL updates blink::SecurityOrigin and url::Origin to include port-0 origins' ports in their serializations. Right now, url::SchemeHostPort has the following control flow: serialize the scheme and host if port == 0, return if there's a default port for the scheme, and the port is not the default, serialize the port The port == 0 branch was previously necessary because blink::SecurityOrigin didn't support port-0 origins and some tests compared blink::SecurityOrigins' serializations to those of url::Origins. With crbug.com/1136678 fixed, blink::SecurityOrigins now support port 0 and we can update the serialization behavior in blink::SecurityOrigin and url::Origin simultaneously to be the above pseudocode with the "port == 0" branch removed. Test: Adds unit tests covering port 0 serialization Change-Id: Ide11b75302a1abda7a602b24678e2985bfe39e3b Fixed: 1136966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472446 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#829917}
-
Arthur Eubanks authored
Some configurations are hitting the current 12 hour timeout limit, like the ToT Clang Mac ASan bot. Bug: 1151435 Change-Id: I3527d18ddfb0d135ea8afc5e66e35d42d758e416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553186Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#829916}
-
Hirokazu Honda authored
V4L2VEA DCHECKs both bitrate and framerate are more than zero. It depends on clients and can be false due to an issue. We would rather checks it by if-clauses and skips if they are invalid. Bug: b:173420909 Test: meet.google.com on trogdor Change-Id: I0f3776368b782c8bb2691dbc5e49ebc22cf16d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548583 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#829915}
-
Christopher Cameron authored
Several callsites only use ImageData::GetSkImageInfo in the process of retrieving all of the relevant information to construct a SkPixmap. TBR=yiyx,fserb Bug: 1150969 Change-Id: I3a44bcb8ab357559f4f16d749b5abf8b69136f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552999Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#829914}
-
Jesse Schettler authored
Ensure the scrollbar is always visible when scanned images extend beyond the app window. Bug: 1059779 Change-Id: I6aca5b1ffa478e1cfff4d5f081e92f79a86eb535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552214 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#829913}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b69a9d48bf17..c5a37b1d7286 2020-11-20 egdaniel@google.com Revert "Move vulkan memory uma stats to report on submit." 2020-11-20 johnstiles@google.com Enable SPIR-V disassembly output from skslc. 2020-11-20 johnstiles@google.com Revert "SkSL: Test/implement "geometric" intrinsics" 2020-11-20 robertphillips@google.com Revert "Hook up ShaderErrorHandler in the Metal backend." 2020-11-20 robertphillips@google.com Revert "Remove legacy SkImage::MakeFromYUVATextures." 2020-11-20 robertphillips@google.com Remove uses of SkCanvas::flush 2020-11-20 mtklein@google.com tweak SkVMBlitter for paints with no shader 2020-11-20 johnstiles@google.com Factor out redundant code for compiling GLSL/Metal/SPIR-V/CPP/H files. 2020-11-20 michaelludwig@google.com Don't allow replaceClip to exceed bitmap device size 2020-11-20 adlai@google.com Spruce up iOS viewer and cut CPU drain 2020-11-20 jvanverth@google.com Hook up ShaderErrorHandler in the Metal backend. 2020-11-20 brianosman@google.com SkSL: Test/implement "geometric" intrinsics 2020-11-20 reed@google.com resolve filterquality up front in imageshader 2020-11-20 brianosman@google.com SkSL: Reduce default heap usage, improve heap benchmarks 2020-11-20 johnstiles@google.com Reland "Remove inliner from IR generation stage." 2020-11-20 robertphillips@google.com Update GrProgramInfo's constructor 2020-11-20 michaelludwig@google.com Revert "Simplify layer bounds syncing and no-device error handling in SkCanvas::internalSaveLayer" 2020-11-20 egdaniel@google.com Move vulkan memory uma stats to report on submit. 2020-11-20 bsalomon@google.com Remove legacy SkImage::MakeFromYUVATextures. 2020-11-20 johnstiles@google.com Allow swizzle optimizations to apply to any 'trivial' ctor fields. 2020-11-20 johnstiles@google.com Enable Mac to build with SK_VULKAN enabled. 2020-11-20 egdaniel@google.com Pass in the color load op to GrProgramInfo. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1151195,chromium:1151270,chromium:1151294,chromium:1151320,chromium:1151322 Tbr: lovisolo@google.com Change-Id: Id87f7f9fb5200a36243fb06793b85a298d0f0224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553121Reviewed-by:
-
Khushal authored
This is dead code since we use OOPR by default now. R=boliu@chromium.org Bug: 1151490 Change-Id: I860a440064e67c4561f016292d37d45d0dfeeb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552889 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#829911}
-
Olivier Yiptong authored
This CL implements a Chrome UI that allows users to pick one or more fonts, resulting from a request originating from a Blink API call. This change implements a multi-select chooser that offers the option to "import" fonts to sites as well as the ability to cancel. It is implemented as a permission bubble initially. Fixed: 1138621 Change-Id: I9f4a0bd7a990823d2de0c19372cbedc4e811d7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543603 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829910}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a08962107ef6..cd00d19b5ae3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tbansal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1127088,chromium:1138953 Tbr: tbansal@google.com Change-Id: I3825cbb3b9e41e84a9426ae7e4867116b50cba37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552178Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829909}
-
Tom Anderson authored
* Removes the concept of "overridden dispatchers" and converts the few usages to event observers instead. * Removes Linux.X11.ServerRTT histogram as it has expired. R=sky NOPRESUBMIT=true Bug: None Change-Id: I14837f7dddc5876f1c72cda23a702e6a8e0a5966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552714 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#829908}
-
Hiroshige Hayashizaki authored
To unify how V8CacheOptions is set across classic script evaluation code paths. Bug: 1111134 Change-Id: Ie84d896775951a2eb31bfaa23251c99fe3372ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541362Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#829907}
-
Curt Clemens authored
The illustration is part of an iron-iconset. For whatever reason, <use> tags don't work inside iron-iconset, so strip those out and replace them with the actual path definitions. Bug: 1151511 Change-Id: Ic4a8d21e7f079f61c3cfb91bafba0daff141bdf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552965Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#829906}
-
Chris Thompson authored
Manually tested that the crash is fixed and no negative effects. Bug: 1150751 Change-Id: Id46097e62f3e826fb42abb4d65f0e7f0c2691570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553004Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#829905}
-
Olivier Yiptong authored
This implements the blink portion of the API to trigger a font chooser. This extends the previous stub to communicate with the Browser process. The content/embedder side will be extended in a future CL to complete the implementation end-to-end. Bug: 1138621 Change-Id: I0d5206b10566eed6a40227f994523cabaf3e0913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538143 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
-
James Cook authored
After discussion with security team and the files team, we want to avoid using hard-coded /home/chronos/user/MyFiles paths in lacros. Instead, have ash-chrome pass the paths to lacros-chrome at startup over mojo. This also avoids making the exact path an implicit API contract between ash and lacros. If a future Chrome OS release moves the directories to new locations, lacros will follow along. Ash currently uses /home/chronos/u-<hash> for paths. The security folks would like to switch to /home/user/<hash>, but ash doesn't use those yet. Once ash switches, lacros will automatically follow. We have to leave a few references to /home/chronos/user in lacros for now, until we drop support for Chrome OS M89 and can be sure that ash always sends the default paths. crbug.com/1150702 tracks clean up. Because unit tests are not launched by ash, we override the default paths for documents and downloads in the test harness, to simulate how ash launches lacros in production. Bug: 1150575 Test: added to unit_tests Change-Id: Ifcf637dcbdcb91fa5bb7f3b81c161e3ce87c7e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495961 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#829903}
-
Max Moroz authored
R=inferno@chromium.org TBR=dpranke@chromium.org Change-Id: I56d6684addf8e7f9c16dca2d963e01c0c8020b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553147Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#829902}
-
Tom Anderson authored
The old code used dlsym(RTLD_DEFAULT), which will attempt to obtain the symbol from libraries already loaded. This works most of the time because Xlib gets loaded by eg. GTK, but in cases where Xlib is not already loaded (eg. certain ChromeOS setups), XFree will not be found, leading to a crash. The fix is to switch to the existing xlib_support which internally does dlopen("libX11.so.6") so it shouldn't have this issue. R=sky Bug: 1150918 Change-Id: I82d28cf86e187cc1213b607482f7bd1f4a8e2287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552209 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: -
Dominic Mazzoni authored
This is a quick fix for a performance issue that we've seen in several cases but is particularly bad for one Android app on Android TV. Whenever a node in the accessibility tree changes, we fire a TYPE_WINDOW_CONTENT_CHANGED accessibility event, which is needed for Android to clear its accessibility cache. However, when a major change to a web page happens and a lot of events are fired on different nodes, the overhead of firing an event on every single node is much too high and just ends up slowing the device to a crawl or causing an ANR. The alternative is to just fire TYPE_WINDOW_CONTENT_CHANGED on the root, invalidating the whole WebView. This is inefficient compared to invalidating just one node, but much more efficient than individually updating hundreds of nodes. What this patch does is add some really simple and quick logic to count how many WINDOW_CONTENT_CHANGED events we're firing within a single accessibility tree atomic update, and when we reach some maximum it fires an event on the root and then suppresses further events of this type until the next update. It might be cleaner to move this logic to AccessibilityEventDispatcher instead in the future, but for now this is the most straightforward fix and it results in a big performance improvement in practice. is changing Bug: b/159131746 Change-Id: Ic04f5e87a205e80f460715de14f99de70a0cf90e AX-Relnotes: improves performance on some Android pages when lots of content Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552897 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#829900}
-
Alison Maher authored
Forced colors should now happen at used value time. This change adds an internal property to store the forced colors value of border-color. This internal value is then applied to the visited /unvisited border-bottom-color, border-top-color, border-right-color and border-left-color at used value time when appropriate. The other forced color properties will be moved in follow up changes. Bug: 970285 Change-Id: If2da52205595edf38b5009adaedcb0008c87d0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511858 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#829899}
-
Sinan Sahin authored
This CL also includes a bug fix for the show/hide animations so that the "message dismissed" callback isn't called for animations that don't actually hide the message. Bug: 1137941 Change-Id: I8286feacf03196879642870ce5d582910d8df01e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538338Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#829898}
-
Yue Li authored
Bug: 1149455 Test: None Change-Id: Ibf022a85132defcbbda53326da21d13287cb3210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546171 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#829897}
-
Kyle Horimoto authored
WireMessage protocol v3 used an unsigned 16-bit integer to represent the message length. Unfortunately, when big messages are sent (e.g., images sent through Phone Hub), the size can exceed the maximum value of a 16-bit int, so the protocol breaks down. This CL introduces v4, which uses an unsigned 32-bit integer to represent the message size. For backward compatibility, we still use v3 to send messages used for authentication, Smart Lock, and Instant Tethering. If a message is sent for any other feature type, we use v4. Bug: 1150565, 1106937 Change-Id: I2e074505f8efa8a6a7ba355229e8cd0adf7e7c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552250 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Ryan Heise authored
Remove x86 Chrome on ARM Mac perf tests (no longer relevant) Change sharding to 7 to take advantage of https://chromium-review.googlesource.com/c/chromium/src/+/2548360 Bug: chromium:1138953 Change-Id: I626d9c43a02290afdd592e58c11c9bba1cc6054a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548360Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ryan Heise <heiserya@google.com> Auto-Submit: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#829895}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/aeb3616301c8..6d612051c083 2020-11-20 amaiorano@google.com Kokoro: add Windows x86 (Win32) debug builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I40ea318aa1faab2242b58077f8c642e9b2c48c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552176Reviewed-by:
-
Adam Whiteside authored
Given |GetMaxBufferedFrames| runs during attribute initialization, the thread checker this DCHECK looks for doesn't exist yet causing crashes. This check is unnecessary as the only member variables that are accessed by the method are const. Bug: internal 173625018 Test: Build eng build and check no crash. Change-Id: I34e8b1b51ba75a3325466c1383a7000f039463b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553221Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Adam Whiteside <awhiteside@google.com> Auto-Submit: Adam Whiteside <awhiteside@google.com> Cr-Commit-Position: refs/heads/master@{#829893}
-
Mohammad Refaat authored
Updated the browsing_data_remover_impl to call a different method on session service which will get all session directories and remove them. Bug: 1151388 Change-Id: I21f62b6d5f6ccbf3279383d872e1a2b5fbaee954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551849 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/361d02972a3d..929fc7c79f0c 2020-11-20 bmeurer@chromium.org [wasm] Introduce unregisterLanguageExtensionPlugin API. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1041362,chromium:1083146,chromium:1151280 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I98c3743e2556c5854fe76b6c39be1f3bbef2263a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552809Reviewed-by:
-
Jesse Schettler authored
Instead of displaying scanned images in a preview area with a fixed height, let the scanned images extend to the bottom of the app window. Bug: 1059779 Change-Id: I0b004a9d758fa5a164dab43148d46df3fd3400ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553024 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
-
Gordon Seto authored
Create eSIM setup flow navigation state machine and connect to Mojo API, add unit tests Bug: 1093185 Change-Id: I8160f01f4d2c46e00512b9f0bbb8395533b19e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544905 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#829889}
-
Aleks Totic authored
Small change to ComputeGridMinMax was necessary. 0% width cells are treated as "no percentage". This is a common pattern in table algorithms: "Zeroes are special!" The fix for LayoutNGTable::AddVisualEffectOverflow was good. It made 11 more invalidation tests pass. The old visualoverflow was too large. Bug: 958381 Change-Id: Ie6eec7f749ebd4400674e581f1dc128e4c3f81ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551540Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#829888}
-
James Cook authored
Some code has behavior differences when run on real Chrome OS hardware versus in the linux "emulator". That code uses base::SysInfo::IsRunningOnChromeOS() to check where it is running. Tests override this with base::SysInfo::SysInfo::SetChromeOSVersionInfoForTest(). For tests, we provide chromeos::ScopedIsRunningOnChromeOSForTest. However, this lives in //chrome/browser/chromeos/ and can't be used by Lacros (go/lacros). //c/b/chromeos is actually ash-specific code, and will be renamed to //c/b/ash shortly. To work around this, some tests have rolled their own scoped helper classes. We need test helpers that can be shared across ash-chrome and lacros-chrome. Since these test helpers are overriding the behavior of base::SysInfo, I think it should live in //base/test. Split the class into two parts, one to handle the common case of just overriding IsRunningOnChromeOS and another to override the version info. Also, use the helpers in a few more places for tests that were not resetting the Chrome OS version when they were done (a potential source of flake for subsequent unit tests). Bug: 1148904 Test: existing unit_tests Change-Id: I1442e54155c008e6447cd147f23a1dfd5ebfbb97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538285Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#829887}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/16973d613fed..8f8e2dc7d50f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I73111b94db4d1be54d6713d288203be19e3119f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553036Reviewed-by:
-
Patrick Noland authored
Testing a smaller (included) fix for a crash in updateMicButtonState revealed a few other post-destruction issues that were previously hidden by LocationBarLayout never being nulled out. So this CL * Null checks VoiceRecognitionHandler in updateMicButtonState * Guards against post-destruction callback/delegate invocation in URLBar * Prevents a post-destruction call to onSuggestionsReceived in AutocompleteMediator (and fixes incorrect documentation) Bug: 1151225, 1151080, 1146585 Change-Id: Iae295a7629c35aeae8ce357e414b05e6847d62e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552570Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#829885}
-
Stephen Roe authored
and Linux distro. This supports running tests on x64 Ubuntu and on arm64 Ubuntu 16.04 and arm64 Ubuntu 18.04. Bug: 1131647 Change-Id: Ie75adcb775bc32601fb4001720e960b17607edee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517991 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#829884}
-
Adam Langley authored
Add support version=2 caBLE extensions with a sessionPreKey that carries the same information that would be sent via a QR code. This allows a server to create a caBLEv2 link. BUG=1002262 Change-Id: I0dc1e40a2beee927f4fa4faef243b350e017cc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548123 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#829883}
-
Sophie Chang authored
Bug: 1146151 Change-Id: If63c626ce0ef01d86d7465a0715cfea7470a3ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552886Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829882}
-
Sorin Jianu authored
This change is just renaming files, changing header guards, include directives, and build files to match the new names. Bug: 1151106 Change-Id: Ia52ff972d3cee0d6623cfd051be7cababafbdce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551852Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829881}
-
