- 19 Aug, 2020 40 commits
-
-
Nohemi Fernandez authored
Follow-up to patch 2362248 that migrates all instances of the deprecated 'showMesage:' method to [MDCSnackbarManager.defaultManager showMessage:] in the Chrome remoting codebase. TBR=yuweih@chromium.org Bug: 1117399 Change-Id: I2e777c7759d7a16b51f989a225526dff94dfce87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363752Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#799560}
-
Ioana Pandele authored
Puts phished credentials before leaked ones and orders them by recency (from most recent to least recent) within each category. Bug: 1102025, 1092444 Change-Id: I6e7ef30e85a0df436ac4234e248b07c7d3bdaeab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360085 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#799559}
-
Christian Dullweber authored
This reverts commit 4838b76a. Reason for revert: 1119297 Original change's description: > Add more checks for chrome.debugger extensions > > Bug: 1113558, 1113565 > Change-Id: I99f2e030f9a38f1ffd6b6adc760ba15e5d231f96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342277 > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799514} TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org,caseq@chromium.org,yangguo@chromium.org,sigurds@chromium.org Change-Id: I01ad12ca99ac75197f9073e2c6c9d0eaa0d95147 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113558 Bug: 1113565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362920Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#799558}
-
Sigurd Schneider authored
Change-Id: I2a53835ae1beaf1128ab13af5a734fe83c15ab45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346670Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#799557}
-
Kai Ninomiya authored
And update regenerate_internal_cts_html.sh for changed build targets. Updates expectations, as always. Bug: None Change-Id: Ie6f8d6846a3feabf72ce8b174bf8f7fa8f7e3524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355098 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#799556}
-
Julie Jeongeun Kim authored
This CL cleans up the unused OnDidGetPrintedPagesCount which was a handler for PrintHostMsg_DidGetPrintedPagesCount from PrintMockRenderThread. The PrintHostMsg_DidGetPrintedPagesCount message has been converted to Mojo [1] and the handler is not used anymore. [1] https://crrev.com/c/2326857 Bug: 1008939 Change-Id: Ifec8922958de92d544444d63198f22987a931aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362070Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#799555}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e28436f2b8a2..3434cb0b006d 2020-08-18 jaebaek@google.com Let ADCE pass check DebugScope (#3703) 2020-08-18 andreperezmaselco.developer@gmail.com spirv-opt: Implement opt::Function::HasEarlyReturn function (#3711) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC cnorthrop@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: cnorthrop@google.com,radial-bots+chrome-roll@google.com Change-Id: I5e415865eae76734928a06dd54b7e07ce1066853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364130Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799554}
-
Yoshifumi Inoue authored
This patch makes |ShapreResult::CopyRange()| to merge sub range and last run if possible to reduce number of runs in |ShapreResult| and parts in |ShapeResultView| to reduce memory (run headers) and calling |SkFont:: getWidthsBounds()|. Bug: 707656 Change-Id: Iefbc621b37dd0a0522a046ff73be2e47c41793cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353979 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799553}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a46c048cdaf0..314d6b7155ca 2020-08-19 kprokopenko@google.com [issues] Get target for each issue individually (instead of main target) to get correct node in case of out of process iframes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1115421 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icc6fa85231ac37b74b6903e8bfab30d58cb980de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363970Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799552}
-
Andreea Costinas authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/bbd71acf57db..8125d936f9e0 $ git log bbd71acf5..8125d936f --date=short --no-merges --format='%ad %ae %s' 2020-08-13 chenghaoyang system_api: Update Iioservice Bootstrap Methods 2020-08-12 acostinas system_api: Update System-proxy D-Bus API Created with: roll-dep src/third_party/cros_system_api Change-Id: I6a7b543dd6b4fcd258f5249beef90e277ef2457f Bug: 1112722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362917Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#799551}
-
danielng authored
Port forwarding for Crostini landed in M85 and hasn't caused any issues. Removing the flag (that was enabled by default) and any code that used it. Test: ran unit tests and tested locally Bug: 848127 Change-Id: I5d0895f243aabdcb6cf1158739a4103b6dd4ebc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355358 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#799550}
-
Andy Paicu authored
This is a reland of 4e31d46a Original change's description: > Immediately stop media streams if users revokes consent > > Since camera and microphone are particularly sensitive permissions we > should be viligent and stop streams immediately when the user revokes > the permission. > > This CL uses the permission controller subscription functionality to > listen to permission changes on the relevant origins. Each DeviceRequest > will have up to 2 permission subscriptions (1 audio, 1 video). When > a permission is changed to non-Granted the specific DeviceRequest is > canceled. Subscriptions are removed when the DeviceRequest is deleted. > > Because MediaStreamManager is an IO thread class but > PermissionController is a UI thread class, this CL has to do a bit of > thread hoping: > > FinalizeStream(IO) > SubscribeToPermissionControllerOnUIThread(UI) > > SetPermissionSubscriptionIDs(IO) >(maybe)> > UnsubscribeFromPermissionControllerOnUIThread(UI) > > DeleteRequest(IO) > UnsubscribeFromPermissionControllerOnUIThread(UI) > > Bug: 1116435 > > Change-Id: I6649125e028d607eeb7ba5701b710a715addf6f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352790 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798564} Bug: 1116435 Change-Id: Iede170df981bc69d025bcf66b029237977bc7a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362288 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#799549}
-
ssid authored
EmitTrackDescriptor can send mojo messages. The trace event trying to check for privacy filtering hits deadlock when mojo call adds trace event when data source already holds the lock in EmitTrackDescriptor. Set TLS flag in EmitTrackDescriptor to block trace events. BUG= 1117513 Change-Id: I8856c181e3da6e6f7bf4ad9c26033977d0701037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362447 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#799548}
-
Yao Xiao authored
Before: Schedule the computation events using a RepeatingTimer and use a session number to address potential race conditions. After: Use a flag |floc_computation_in_progress_| to guard the process from ComputeFloc to OnComputeFlocCompleted. Incoming computation will be ignored if there’s one ongoing. After each OnComputeFlocCompleted, a ComputeFloc event will be scheduled 24 hours later / override the existing scheduled event. Why: The new pattern would be more suitable for a future plan where more computation triggers are introduced (e.g. kHistoryDelete). In that case, the caller can simply call ComputeFloc(ComputeFlocTrigger::kHistoryDelete) without needing to reset the timer. Bug: 1062736 Change-Id: Ic128262272c71be3bc8998bb192ff7c7b615faa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359394 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799547}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9bca022b076d513b56d1fd75ab87678558bb6bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364255Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799546}
-
Mark Brand authored
The existing example fuzzer code used RunUntilIdle to avoid runloop recursion issues caused by re-entrancy in the scheduling of fuzzer tasks. This change removes the re-entrancy and refactors out the use of RunUntilIdle, working towards refactoring out the common code duplication between fuzzers that's currently necessary. Bug: 1076336 Change-Id: I3729d20264638c00c14c3a8149395e3f22e90089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329531 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#799545}
-
Javier Ernesto Flores Robles authored
For some reason chrome_test_util::WebViewMatcher is flaky in these ones. Could be related to the keyboard being in screen. The flakiness appears to be related to iOS 13.4. Maybe a recent update to the bots or a version upgrade of earl grey. Using a simpler matcher seems to fix the issue. Fixed: 1116043, 1116734, 1114899, 1111076, 1115321, 1111258, 1115282 Change-Id: I9172417a20d5b8e09dc47cd986256fc0a8cb46ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362892Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#799544}
-
Josh Simmons authored
The App Service is not present for all profiles (ie. when in Incognito mode). After requesting it for a profile, ensure we got back a valid pointer before use. Incognito mode. Expect Chrome not to crash. Chrome does not Crash. Bug: 1111695 Test: Try to launch default app from "File Saved" notification while in Test: out/Default/browser_tests --gtest-filter="*FilesAppBrowserTest*" Change-Id: I04a88fc756bcba2898f4b990dc412b58e6df0c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360089Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#799543}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6004bcb3bd06..356838b9f8c0 2020-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 06c431ff to ff3c2756 (515 revisions) 2020-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from dceaabb18162 to 699bcde0b729 (17 revisions) 2020-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6f74415e2f74 to cbfd396756c6 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Test: Test: Test: angle_perftests --gtest_filter=TracePerfTest.Run/*cod_mobile* Change-Id: I0987aede01580dad0d6e897eaeb756165926b6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363665Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799542}
-
Frédéric Wang authored
Currently, URLs calculated by protocol handlers escape spaces as "+". This CL changes this to use "%20" instead, aligning with Firefox and the specification. For details, read the following links: https://chromestatus.com/feature/5678518908223488 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/osabCTBhDSs https://bugs.chromium.org/p/chromium/issues/detail?id=795919 https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers https://github.com/whatwg/html/issues/3377 Bug: 1110842 Change-Id: I31e2250c56d3c4654d5a8655ead953af33b5fb5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324126Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#799541}
-
wutao authored
There are several situations we can use cached photos for display: 1. No internet. 2. No access token. 3. Failed to fetch topics. 4. Failed to download photos. When failure happens, we use cache as a ring buffer to get next available photo on disk. The cached photos are saved during normal workflow when fetching topics and photos succeeds. When reading from cache, for simplicity, we can try to read max times, e.g. loop from index 0 to 99, for all possible file names. If failed, means no disk cache available, reading from disk will pause until next time the photo is downloaded successfully. Cache will be cleared when Settings changes. Bug: b/162945419 Test: Added new AmbientPhotoControllerTest. Change-Id: I7d4d04ee1f6e9f40c64a23f6e04c35d0ce46c01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348689 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#799540}
-
Nohemi Fernandez authored
- Consolidates all button tap actions under 'tap' prefix. - Consolidates all verification actions under 'verify' prefix. - Removes single-use methods. Bug: 1103274 Change-Id: Id398e1c80da233f101a87b9b40eda1b0e45f4bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362700Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#799539}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/577fc0c395d8..c1e6d1aba7c7 2020-08-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a0c9fe7f..75c4e773 (798709:799488) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I541e8c57ca7081fadd9ee6f51cbc2af46393ca65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363664Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799538}
-
Vasilii Sukhanov authored
- PasswordManager.ShowAllSavedPasswordsShownContext - PasswordManager.ShowAllSavedPasswordsAcceptedContext Fixed: 1117136 Change-Id: I3409a9a04dd20a57b6cb97206e53e24be7accc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362909Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#799537}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.59-1597657121-benchmark-86.0.4232.0-r1 to 86-4183.59-1597657121-benchmark-86.0.4237.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I6ea5e9899b48c6a539b2eb63955a8c8fd406dff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364252Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799536}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5358c08137f8..a46c048cdaf0 2020-08-19 isherman@chromium.org Pull code for formatting the X-Client-Data header from Chromium/upstream 2020-08-19 soxia@microsoft.com Fix issues when reloading DevTools after setting change 2020-08-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103854,chromium:1105779,chromium:1113601 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I83543e6a605ae6420086c4f711a37ec36699f8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364103Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799535}
-
David Jean authored
Bug: 1110827 Change-Id: I52c9ee5015fcb9cc61f4060473797a00614446f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362811 Auto-Submit: David Jean <djean@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#799534}
-
Miyoung Shin authored
This is a reland of c7737b99 Original change's description: > Remove RenderWidget::QueueMessage and WidgetHostMsg_FrameSwapMessages > > This CL removes RenderWidget::QueueMessage, > WidgetHostMsg_FrameSwapMessages and all the codes associated with > them including unit tests since they are no longer used after > crbug.com/c/1071588. > > Bug: 1107491 > Change-Id: Icef72aa166e8e5112e2e6635a92654e3abfb720c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309831 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793880} Bug: 1107491 Change-Id: Ibf4665445f514f502062f1f09aba4d469cc8d180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342538 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#799533}
-
Xiaocheng Hu authored
The histograms were introduced to help launching feature FontPreloadingDelaysRendering. Now that the feature has been launched, we remove these histograms. Bug: 1109873, 1109874 Change-Id: Iad1d2ddeb7819d63be71063d0289e47d80283996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360336 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#799532}
-
Yutaka Hirano authored
CORS preflight request mode was set to kNoCors up until now, and with cross-origin-embedder-policy: require-corp CORS preflights fail unless a CORP header is attached. Fix the bug. Bug: 1116990 Change-Id: Id91c8d92a17c701bacb2289c2f5a23561f3e7538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362065 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799531}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1597658380-benchmark-86.0.4232.0-r1 to 86-4183.59-1597658380-benchmark-86.0.4237.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If7b8b4e06e20c0ab04a168a9090f7fc185504e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364253Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799530}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cf6f2d3ab620..050fece535f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hajimehoshi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1111893,chromium:1118189,chromium:1118191 Tbr: hajimehoshi@google.com Change-Id: I9b28ea4fcac17df902c0aaabc7c44721a47d3919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363589Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799529}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.59-1597659923-benchmark-86.0.4232.0-r1 to 86-4183.59-1597659923-benchmark-86.0.4237.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ife6a2e28d3d238b7b63597acd891b248c61c37fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363666Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799528}
-
Andrei-Laurențiu Olteanu authored
Add mojom interface for GetRoutineUpdate. Add converters for RoutineUpdate structures in privileged context. Add implementation of GetRoutineUpdate from trusted to untrusted. Bug: b:162051831 Change-Id: I822406a3a09d612f256b3fd4dc6ff35805165f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329750Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#799527}
-
Yuki Shiino authored
Fixes the exposure expr so that the following case works as expected (two features are required for the exposure of |f|). [RuntimeEnabled=F1] interface X { [RuntimeEnabled=F2] void f(); }; Bug: 839389 Change-Id: I46b7a8205690ca3a1de9fb456d223aca2c6bb665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361944Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#799526}
-
Chris Harrelson authored
Bug: 1115577 Change-Id: I17411a1e73aeccf9a242ee104ba2a7b963d08472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357093 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#799525}
-
Yuki Yamada authored
We shouldn't call ProcessSendQueue() in WebSocketChannelImpl::Close() when execution_context_->IsContextDestroyed() returns true. In current implementation, it is guaranteed that execution_context_->IsContextDestroyed() returns false in WebSocketChannelImpl::Close(), but it will return both of true/false with another CL https://crrev.com/c/2359657 Bug: 1116995, 1100257 Change-Id: Id5157f78859e2d9aa5dbd02a7b82bafd58808e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362042 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#799524}
-
Maggie Cai authored
Currently, the specific activity name is not passed from ARC. This causes an issue where if we try to share a file to an app that has multiple activities that can handle the file, it will trigger the disambiguity dialog. This CL pass the activity name with the activity label from ARC to ensure launching the correct activity. BUG=1092784 Test: Manually test with share jpeg file to facebook app. Change-Id: I4290ddce72c80548d23171f020284c39c87ce688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360094Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#799523}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/81eabce6a3af..6004bcb3bd06 2020-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from d95180deded1 to b54c82ed3948 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I8ef28bc4beca92bc5c1b1b029909370d267bc87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363501Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799522}
-
Callistus authored
In particular, this affects the "See what's new" button on the Settings About page and the Release Notes notification. - Also added Notification as an App Launch Source. Bug: b/159394556 Change-Id: Icc498f4c571098c922a8da29003fc8780d386ec0 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352459 Commit-Queue: Callistus Tan <callistus@google.com> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#799521}
-