- 09 Nov, 2020 40 commits
-
-
Ali Juma authored
This deletes the SafeBrowsingAvailableOnIOS feature flag since the feature has been enabled by default and shipped to 100% of Stable. This also deletes code related to detecting WebKit-provided Safe Browsing warnings, since WebKit-provided Safe Browsing is disabled unconditionally. Bug: 1028755 Change-Id: Idae751f84aa274ffdd8b17a5660a752fa19de8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522907Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#825502}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b674f8a27725..934ac6ebdf6b 2020-11-09 gavinmak@google.com [depot_tools] Add --fork-point when computing merge-base 2020-11-09 sokcevic@google.com Set default branch in fake_repos 2020-11-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-11-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1111269,chromium:1144918 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I52c22bb41b43627128dad628dd3dec4b977af9b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527665Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825501}
-
Eric Orth authored
Another case of the apparently poor job I did adding in the malformed vairant of HttpsRecordRdata. ServiceFormHttpsRecordRdata::IsEqual() did not check if the input was malformed before casting to service form. Fix is to check before casting, and also to use the AsServiceForm() helper instead of a raw cast, as the helper has the CHECKs designed to make bugs like this obvious. Fixed: 1146873 Change-Id: I5222a09c9c032bc163ca1beebf4bf1e0504ccad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526931 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#825500}
-
My Nguyen authored
Amharic, Bengali and Burmese are still under discussion Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/8yAKy4aHVk8hLSp Bug: 889763 Change-Id: If1256942d3f57cef5c6fa563937605bf374179b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524804Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825499}
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/Bn9YsR6A6SNXmC6 Bug: 889763 Change-Id: I73c8962a041ced655bcb711f78326d2db0652c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524805Reviewed-by:
-
Fletcher Woodruff authored
OnGetNextImageResponse was deserializing the response as StartScanResponse instead of GetNextImageResponse. Somehow, this was still working, but it should be fixed. Bug: None Change-Id: I2202b34103232659ebe0157fa7578fdff5e029bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526910 Commit-Queue: Fletcher Woodruff <fletcherw@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#825497}
-
cfredric authored
The first time I was notified about ICU not being initialized, it was for the first_party_sets_parser_json_fuzzer target, which makes sense because that target did not depend on net_fuzzer_test_support, so ICU didn't get initialized for it. But when I added the manual initialization to both fuzzers, now the first_party_set_parser_fuzzer had ICU initialized twice. This could also be fixed by calling AllowMultipleInitializeCallsForTesting, but it's neater to just remove the manual initializations for both fuzzers and add the dependency to the JSON fuzzer. Bug: 1146783 Change-Id: I4f3c81ca0cf662010db3e159e226b13e09a55b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526907 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
-
Mark Pearson authored
This reverts commit e15311e1. Reason for revert: causes consistent compile failures on win64-chrome bot, starting here: Failure looks like: [3375/20246] CXX obj/chrome/installer/setup/lib/google_chrome_behaviors.obj FAILED: obj/chrome/installer/setup/lib/google_chrome_behaviors.obj c:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) ../../chrome/installer/setup/google_chrome_behaviors.cc(27,10): fatal error: 'chrome/installer/setup/uninstall_metrics.h' file not found #include "chrome/installer/setup/uninstall_metrics.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > Deprecate uninstall_metrics. > > Remove the tracking/persisting of these metrics in prefs. Removed > uploading in uninstaller. > > Bug: 1107516 > Change-Id: I84499820cea86b5f785949d9274e8b2205714aae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308133 > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825461} TBR=rkaplow@chromium.org,tommycli@chromium.org,ntfschr@chromium.org,grt@chromium.org Change-Id: I9873f0a1da27389ca4066b23e312fd3e4cefbf67 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1107516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527847Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#825495}
-
Stephen Roe authored
Bug: 1126177 Change-Id: I081553be89d56a872b4bb6e8c08f32c1fbb3544b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422889 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#825494}
-
Thanh Nguyen authored
This CL adds Index mojom and its implementation. It also adds LinearMapSearch functions that are inherited from new Index interface. Design doc: go/lss-sandboxing Implementation plan: go/lss-sandboxing-impl Bug: 1137560 Change-Id: Ic12d6d5d93a3dddf7f34adf69041262608abeab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515422Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825493}
-
Jérôme Lebel authored
Adding WaitUntilCacheIsPopulated() before calls: * ChromeIdentityService::GetIdentityWithGaiaID() * ChromeIdentityService::HasIdentities() * ChromeIdentityService::GetAllIdentities() * ChromeIdentityService::GetAllIdentitiesSortedForDisplay() * AuthenticationService::GetAuthenticatedIdentity() * AuthenticationService::IsAuthenticated() This patch also adds the following method as an helper: AuthenticationService::WaitUntilCacheIsPopulated() This method should be temporary, and should be replace by ChromeIdentityService::RunAfterCacheIsPopulated() (or a AuthenticationService version). Design doc: http://go/async-identityservice-api crrev.com/c/2489915 Adding methods in ChromeIdentityService crrev.com/i/3353161 Implementing in ChromeIdentityServiceImpl crrev.com/c/2490110 Adding metrics crrev.com/i/3353162 Implementing the metrics => crrev.com/c/2490010 Adding WaitUntilCacheIsPopulated calls crrev.com/i/3354983 Adding DCHECK for cache state Bug: 897470 Change-Id: Iced6e7e50d704091abfe7d5b705157fe71c50ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490010 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#825492}
-
Javier Ernesto Flores Robles authored
Bug: 1138702 Change-Id: Ic2ba09f4e6eab748f93ca9aee4fc2cbd0bf70532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517993 Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Daniel Cheng authored
This metric has expired. Fixed: 1072662 Change-Id: Iad422fcd3ba65a8e43da385961aaac406c5e2d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524921Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825490}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/095896a516a7..b6999d94c051 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mpearson@google.com,bcwhite@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1142577 Tbr: mpearson@google.com,bcwhite@google.com Change-Id: I21d7079ecd4bb13b64ff305957e266085f081620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525754Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Yu Han authored
Prior to this CL, the text selection color on Mac/dark mode is too dark. It doesn't provide enough of a contrast between the selected text and its background highlight color. The reason is that Chrome blends the Mac specific highlight color with white, Color::BlendWithWhite(). It adds a .6 alpha channel which results the color being too dark. The fix is to mimic Safari's logic[1] and apply a greater alpha value, making the alpha channel more transparent. Thus, the selection background color is lighter. [1] https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/rendering/RenderThemeMac.mm#L385 Bug: 1146379 Change-Id: Ib4d54f0b3dbe5c32038e10af65c644db2f4e8dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525368 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#825488}
-
Rainhard Findling authored
This CL prevents the safety check Chrome cleaner child from sending additional SC parent completion events to the UI when the Chrome cleaner status changes in the backend. Bug: 1087263 Change-Id: I80c8c2549053460e20fadd03d91deab97f4cda6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527381Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#825487}
-
Shakti Sahu authored
This CL adds 1- Handle reading list bookmark type in BookmarkId string serialization. Serialized string ids will have 'r' prefix, similar to 'p' prefix in partner bookmarks. 2- Added missing reading list type to BookmarkBridge::DoesBookmarkExist 3- Added missing reading list type to BookmarkBridge::DeleteBookmark. Bug: 1139070 Change-Id: If34fc167ad5d92f22e13f941f55a04f9bea2bd0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524704 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825486}
-
Vincent Boisselle authored
This is experimental code gated behind a feature flag. We may decide to not proceed with the experimentation but we at least want the code in M88 just in case. Change-Id: Icb2263a48ac35f071f2bd857aaa2e6bc0a38d7bb Bug: 1146458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522914Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#825485}
-
Brian Sheedy authored
Fixes Skia Gold triage links and test failures being associated with all tests in a batch, instead only associating them with the result for the particular test that produced the bad image. This is handled by including the full test name in the JSON that gets pulled from the device, then using that in the test runner to look for matching results to modify. Bug: 1146498 Change-Id: I5cad7333aa69332f3e46165a6a73c25a0aa6266f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521249Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825484}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202011090600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/pWeqsIGRIui0WPD3a7xaKASeJ10P8A3jGHGdlGXx0loC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159960286 Tbr: help-app@grotations.appspotmail.com Change-Id: I17b68f955d7ffceae60e8173e9c00fc16a67a732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525864Reviewed-by:
-
Morten Stenshorne authored
So mark them as passing when LayoutNGBlockFragmentation is enabled. TBR=kojii@chromium.org Change-Id: Ia7c78a57aa4d5d90a6e23ff2eacb109eba67d595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527027Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#825482}
-
Jamie Madill authored
This is eating up a lot of capacity for a config that we don't intend to ship. This removes the tests from several NVIDIA and Intel Windows GPU testing configs. Bug: angleproject:5305 Change-Id: I1f11f6751101b18b664e99e83f34b2834fe79913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525041Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#825481}
-
Nico Weber authored
Xcode 12 added support for real response files, so let's use them. Allows making response file contents more like on other systems (libs, solibs, frameworks, swiftmodules now go in the rsp file too), and makes it theoretically possible to have object files with spaces in their name. No intentional behavior change. Bug: none Change-Id: I8c2d6ff1abd47261bf7674dc7bf4506814681ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527621 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#825480}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d564b0d2baa3..4643cf651889 2020-11-09 tsepez@chromium.org Avoid allocating CFXJSE_Values for |this| in poperty callbacks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I41a2aefe49c86fa62871a71b73f5e3fb77c1b83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527501Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ic911e76c8f2a4ef6a6e37983802c1f24fe278908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526145Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#825478}
-
Yicheng Li authored
This is because users needs to explicitly know that they can reject the authentication - tapping outside dialog to cancel is not clear enough. Bug: b:156258540, b:144861739 Change-Id: If47cd9bb76a48e6149eba3606cc1434db53662c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525855Reviewed-by:
-
Peter Boström authored
Bug: 1002162 Change-Id: I2329db999c674c33865e45efc47305ba24b44f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521157 Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#825476}
-
Yann Dago authored
Bug: 1026442 Change-Id: I9b4ee82690ea45b85ac3094821b9a9ecc2ccb143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524504 Commit-Queue: Yann Dago <ydago@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#825475}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I1093184b89ce97df04b1256d160d8a81877eaf4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523755Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#825474}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2f30936d46eb..5de0b38dd133 2020-11-09 rmistry@google.com [bugs-central] Add documentation for sheriffs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: I73e0b9d9cea981f7e99bf177ff73d3ad917c1e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525749Reviewed-by:
-
Owen Min authored
Removing future and using unlisted and cloud_only for the following policy: AssistantOnboardingMode BYPASS_POLICY_COMPATIBILITY_CHECK=AssistantOnboardingMode is a launched policy with future tag. Bug: 1117637 Change-Id: Idf964a9e6bc661c4fd4d7e0eada34d847d9b286d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488043 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825472}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b21a40d6e974..5226a88fe0de 2020-11-09 tvanderlippe@chromium.org Update karma-related packages 2020-11-09 jacktfranklin@chromium.org Fix new data-grid text overflowing in cells If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ica94a3f19faec1c7a440b851609c6f74ae520976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525751Reviewed-by:
-
Zach Trudo authored
EncryptedReportingJobConfiguration will allow CloudPolicyClient to upload EncryptedReportingJobs. Bug: chromium:1078512 Change-Id: I9b124346f4628eab888d591a1658a63d56fa6a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499072 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#825470}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b4a39160..c19c1b2c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I31e51003e0bc9680b0d78885249106728a900f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526626Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825469}
-
Friedrich Horschig authored
This CL defers adding the "Use other [password|username]" button until the newly introduced helper confirmed that there is at least one credential to show. To do that, the helper fetches the passwords when it's created. If it finishes before suggestions are to be refreshed, the stored boolean is used, otherwise, the callback is queued and will trigger an update. Smaller clean-ups: * New test fixture for filling (mostly moved to save setup code and to prevent ScopedFeatureList issues) * Moved accessory sheet state (focused field) into helper since frame state shouldn't be used by the accessory controller (if possible but required by all pwds sheet) Bug: 1104132 Change-Id: I4fa5757744dda5c2091fec24daf0654f92b2be46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489914 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#825468}
-
Victor Hugo Vianna Silva authored
This CL fixes the implementation of SendTabToSelfBridge::DismissEntry() to upload an updated sync entity with the notification_dismissed field set. As a bonus: - It increases test coverage for server uploads after the operations of sharing a tab, deleting an entity (e.g. on history deletion) and opening a notification. - Removes unused instances of ScopedFeatureList from the test suite. Bug: 1146376, 956722 Change-Id: Idc0c27fde0cb4444900cf4f64d0f8161f6fee0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521816Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#825467}
-
Chong Gu authored
Bug: 1080853 Change-Id: Ibdb7b1b295e2ee05016baea32358dbc6a18c4cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523961 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825466}
-
Olivier Li authored
Bug: 1135528 Change-Id: I5d1a406854e5b6e7ef7a6c2421198c1358a2497c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499423Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#825465}
-
Scott Violet authored
This is a regression from: https://chromium-review.googlesource.com/c/chromium/src/+/2483342 The case under which the crash happens is when the internal cache (URLIndexPrivateData) is being rebuilt on the history thread and GetMostRecentVisitsForURL() returns false. I believe that basically only happens if there is a problem with the db. I would have liked a test for this, but there is no way to force the db to return false. BUG=1146970 TEST=none Change-Id: Ied6a7e1c75ef8fcc47043d231f4877a597757bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527006Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#825464}
-
Livvie Lin authored
Makes Safety Tip component updater logic available on iOS for use in lookalike interstitials and Safety Tips. Bug: 1140271 Change-Id: Iacf47c91d9fcaadf8a12a9475352eee27e882a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521446Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825463}
-
