GitLab

## Description of the problem
On iOS, tapping on an empty omnibox triggers a request to the
ClipboardUrlProvider.
The ClipboardURLProvider then calls VerbatimMatchForURL with an empty |input| (if the omnibox was empty), which eventually triggers a
DCHECK_GT in |AutocompleteMatch::ClassifyLocationInString|:

  // Classifying an empty match makes no sense and will lead to validation
  // errors later.
  DCHECK_GT(match_length, 0U);

## Description of the solution
This CL makes it forbidden to pass an empty input to
|VerbatimMatchForURL|, and fixes the clipboard_url_provider.

BUG=625313

Review-Url: https://codereview.chromium.org/2124563002
Cr-Commit-Position: refs/heads/master@{#405136}

This fixes the order of destruction of two of the members of RenderProcessHostImpl.

BUG=627778

Review-Url: https://codereview.chromium.org/2143013003
Cr-Commit-Position: refs/heads/master@{#405135}

- Rename listBoxSelectItem to selectMultipleOptionsByPopup, and it accepts index
  vector.
- Rename valueChanged to selectOptionByPopup.

Single-selection menulist accepts only selectOptionByPopup().
Multiple-selection menulist accepts selectOptionByPopup(-1) and
selectMultipleOptionsByPopup().

Review-Url: https://codereview.chromium.org/2143863003
Cr-Commit-Position: refs/heads/master@{#405134}

ipc_fuzzer starts failing to link recently due to undefined symbols to
NaCl messages on NaCl-disabled build.
This CL fixes the error by excluding them on the problematic case.

R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/2136943002 .

Cr-Commit-Position: refs/heads/master@{#405133}

In Webgl's transferToImageBitmap(), we create an ImageBitmap from the
drawingBuffer's mailbox. When calling transferToImageBitmap() twice, the
mailbox is invalid in the second call. In this case, we should return
an ImageBitmap that is the same size as the drawingBuffer but should be
transparent black.

Corresponding layout test has been updated to reflect this case.

BUG=627374
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2139353003
Cr-Commit-Position: refs/heads/master@{#405132}

Reland of WebGL: use storage texture for DrawingBuffer only if CMAA is enabled. (patchset #1 id:1 of https://codereview.chromium.org/2133253003/ )

Reason for revert:
ATI bot failed due to this CL.

ATI bot was fine because we disabled WebglConformance.conformance_textures_misc_tex_image_webgl
However, https://codereview.chromium.org/2141893002/ enabled the test again, so this CL must be reverted.

Original issue's description:
> Revert of WebGL: use storage texture for DrawingBuffer only if CMAA is enabled. (patchset #3 id:60001 of https://codereview.chromium.org/2131863003/ )
>
> Reason for revert:
> ATI GPU bots became green, no matter this CL. ATI GPU bot might be in bad shape for some reasons.
> So revert this redundant speculative fix.
>
> Original issue's description:
> > WebGL: use storage texture for DrawingBuffer only if CMAA is enabled.
> >
> > It's because Linux ATI bot fails
> > WebglConformance.conformance_textures_misc_tex_image_webgl
> > When finding the solution for ATI driver, rollback this patch.
> >
> > BUG=557848
> > TEST=WebglConformance.conformance_textures_misc_tex_image_webgl
> > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/65f8f6c737278a80acee2bcd407d1fdc15426fa8
> > Cr-Commit-Position: refs/heads/master@{#404514}
>
> TBR=piman@chromium.org,kbr@chromium.org,zmo@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=557848
>
> Committed: https://crrev.com/e33a44a7077c60edfa28bc0d79b0910ab43d58d1
> Cr-Commit-Position: refs/heads/master@{#404563}

TBR=piman@chromium.org,kbr@chromium.org,zmo@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=557848

Review-Url: https://codereview.chromium.org/2143423002
Cr-Commit-Position: refs/heads/master@{#405131}

R=haraken@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2145863003
Cr-Commit-Position: refs/heads/master@{#405130}

BUG=625161

Review-Url: https://codereview.chromium.org/2121133002
Cr-Commit-Position: refs/heads/master@{#405129}

This cl aims on reducing amount of memory used. Once request
is sent, flush buffers to free allocated memory.

BUG=622073

Review-Url: https://codereview.chromium.org/2130733003
Cr-Commit-Position: refs/heads/master@{#405128}

fast/repaint/line-flow-with-floats-9.html
fast/repaint/nested-fixed-iframe-scrolled.html
fast/repaint/repaint-during-scroll-with-zoom.html
fast/repaint/resize-scrollable-iframe.html
fast/repaint/text-match-document-change.html

TBR=wangxianzhu@chromium.org
NOTRY=true
BUG=627798,617799

Review-Url: https://codereview.chromium.org/2140673008
Cr-Commit-Position: refs/heads/master@{#405127}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/05929e2..87fd07b

TBR=tommi

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2146803002
Cr-Commit-Position: refs/heads/master@{#405126}

Cleaning up video-poster* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2130383003
Cr-Commit-Position: refs/heads/master@{#405125}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fe6d66c4..990ed91c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2148733002
Cr-Commit-Position: refs/heads/master@{#405124}

Move the pref_names related to browsing data deletion from chrome/common/ to components/browsing_data. They will be needed in the componentized counters.

BUG=620317

Review-Url: https://codereview.chromium.org/2136373003
Cr-Commit-Position: refs/heads/master@{#405123}

BUG=613414
TBR=bsep@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2143413002
Cr-Commit-Position: refs/heads/master@{#405122}

iOS system, Chrome itself and all of the third-party libraries
supports those locales, so pack them when building with gn.

BUG=625667

Review-Url: https://codereview.chromium.org/2133223002
Cr-Commit-Position: refs/heads/master@{#405121}

Reland of Android: Add support for TraceEvent before the native library is loaded. (patchset #1 id:1 of https://codereview.chromium.org/2145443002/ )

Reason for revert:
Reland.

Original issue's description:
> Revert of Android: Add support for TraceEvent before the native library is loaded. (patchset #12 id:220001 of https://codereview.chromium.org/1486053003/ )
>
> Reason for revert:
> https://crbug.com/627142
>
> Original issue's description:
> > Android: Add support for TraceEvent before the native library is loaded.
> >
> > Currently TraceEvents recorded before the native library load are
> > silently discarded. This CL adds support for such "early" events.
> >
> > The events are buffered in Java, and then sent to the native side once
> > it is available. This support is intentionally simple now. The aim is to
> > ease performance investigation of early startup, and to ease tracking of
> > early startup performance regression, since timings are then accessible
> > to TBM tests.
> >
> > Also use the newly-introduced events in a couple places, and fix a bug
> > in the TraceEvent we use to record the launcher activity lifetime (when
> > an Activity calls finish from onCreate(), onPause() is not called).
> >
> > BUG=564041
> >
> > Committed: https://crrev.com/fb0784294541c53f12e283124672750ab2e291f1
> > Cr-Commit-Position: refs/heads/master@{#404635}
>
> TBR=pasko@chromium.org,yfriedman@chromium.org,jam@chromium.org,lizeb@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=564041
>
> Committed: https://crrev.com/ffda73103b9a84e4739088175b9250a0c28e6f8c
> Cr-Commit-Position: refs/heads/master@{#404752}

BUG=564041
TBR=jam

Review-Url: https://codereview.chromium.org/2142803002
Cr-Commit-Position: refs/heads/master@{#405120}

Just a refactoring of test classes. This extracts a
FakeScatteredBuffer class out of the existing unittest. This
class will be reused by other unittests added in
upcoming CLs.

BUG=608719
TEST=components_unittests --gtest_filter=ScatteredStreamWriterTest.*

Review-Url: https://codereview.chromium.org/2138903002
Cr-Commit-Position: refs/heads/master@{#405119}

BUG=626736
R=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2143353003
Cr-Commit-Position: refs/heads/master@{#405118}

Unable to find gfx::NumberOfPlanesForBufferFormat symbol :

media/gpu/vaapi_wrapper.cc:634: error: undefined reference to 'gfx::NumberOfPlanesForBufferFormat(gfx::BufferFormat)'

BUG=none
TEST=verify that video_encode_accelerator_unittest links successfully

Review-Url: https://codereview.chromium.org/2134633002
Cr-Commit-Position: refs/heads/master@{#405117}

The migration code had some unnecessarily complicated parts which made
https://codereview.chromium.org/2127533003/ harder than needed.

This CL pulls common database tasks related to table scheme migration
and creation into a separate class, SQLTableBuilder. During that the code
is also cleaned up and made safer by using transactions.

The CL also fixes two typos in the test files.

BUG=413020

Review-Url: https://codereview.chromium.org/2126713006
Cr-Commit-Position: refs/heads/master@{#405116}

BUG=623168
R=mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2145873003
Cr-Commit-Position: refs/heads/master@{#405115}

Password manager uses a switch to allow the user to override the
auto-detection of the appropriate password store. OSCrypt should
respect this switch as well.

The switch value is read and passed to OSCrypt at a very early
point in Chrome's start, before any of OSCrypt's dependents
use it.

I also reworked OSCrypt's build to make it simpler for chrome to
deduce whether the linux implementation of OSCrypt will be used.
 - Previously, os_crypt_linux was used only if we also decided to
   link at least one linux backend. Otherwise we used os_crypt_posix.
 + Now, we always use the linux implementation for linux. If no
   KeyStorage is linked, the linux implementation defaults to the
   same behavior as for posix.

BUG=602624

Review-Url: https://codereview.chromium.org/2118443002
Cr-Commit-Position: refs/heads/master@{#405114}

https://chromium.googlesource.com/chromium/src/+/a1d6a0e73

BUG=490511
TBR=kochi@chromium.org

Review URL: https://codereview.chromium.org/2145943002 .

Cr-Commit-Position: refs/heads/master@{#405113}

This patch adds null-check for focusable view.

BUG=625357
TEST=crash doesn't happen

Review-Url: https://codereview.chromium.org/2124093003
Cr-Commit-Position: refs/heads/master@{#405112}

Revert of [gin] Unify snapshot loading on Windows and other platforms. (patchset #2 id:20001 of https://codereview.chromium.org/2103903002/ )

Reason for revert:
Investigate effect on Win7 startup.cold.blank_page metrics.

BUG=501799,625516

Original issue's description:
> [gin] Unify snapshot loading on Windows and other platforms.
>
> Removes extra v8 snapshot and natives validation on Windows. All platforms
> have the same validation henceforth.
>
> BUG=501799
>
> Committed: https://crrev.com/10b5a96b363a6ff23176d27a2e7fb1bba300f089
> Cr-Commit-Position: refs/heads/master@{#403430}

TBR=jochen@chromium.org,ben@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=501799

Review-Url: https://codereview.chromium.org/2141043002
Cr-Commit-Position: refs/heads/master@{#405111}

Add a new variable "multi_arch_target_cpus" that can be defined by the
user via "gn args" to build for more than one architecture. It should
be set to a list of two or more architectures supported by gn build.

Add support for multi-architectures application to the "ios_app_bundle"
template. The template expands to a simple "executable" target if the
toolchain is not the default toolchain. For the default toolchain the
real executable is generated by assembling all single architecture
binaries using "lipo" tool.

BUG=603180

Review-Url: https://codereview.chromium.org/2123253004
Cr-Commit-Position: refs/heads/master@{#405110}

virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance.html
virtual/scalefactor150/fast/hidpi/static/data-suggestion-picker-appearance.html

BUG=627754,593567
TBR=bsep@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2139293003
Cr-Commit-Position: refs/heads/master@{#405109}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3d24ece9..fe6d66c4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2149503002
Cr-Commit-Position: refs/heads/master@{#405108}

- Remove |allowMultipleSelection| arguemnt of optionSelectedByUser().
  It's always false.

- Remove |shift| argument of listBoxSelectItem().
  It's always false.

Also, make optionSelectedByUser() private.

This CL has no behaivor changes.

Review-Url: https://codereview.chromium.org/2147683003
Cr-Commit-Position: refs/heads/master@{#405107}

BUG=627747

Review-Url: https://codereview.chromium.org/2147483002
Cr-Commit-Position: refs/heads/master@{#405106}

Displays a feature notification informing the user about quick unlock.
Upon clicking the notification the user is taken to the settings page.

The UI strings used in the notification are still TODO and not final.

BUG=626079
COMPONENT=Chrome OS, Quick Unlock, Preferences, Strings

Review-Url: https://codereview.chromium.org/2128053002
Cr-Commit-Position: refs/heads/master@{#405105}

It's always true in practice

BUG=627483

Review-Url: https://codereview.chromium.org/2142083002
Cr-Commit-Position: refs/heads/master@{#405104}

The NTPSnippetsService currently delivers snippets to the UI via the
Android bridge. Change it to additionally serve as a
ContentSuggestionsProvider implementation and deliver
ContentSuggestions for the ARTICLES category. These ContentSuggestions
are currently only delivered to the ContentSuggestionsService and not
served to the UI, yet.

Adjust NTPSnippetsServiceTest, SnippetsBridge and SnippetsInternals
because of a few renamed functions.

Change NTPSnippetsServiceFactory to register the NTPSnippetsService
as a provder with the ContentSuggestionsService.

BUG=619560

Review-Url: https://codereview.chromium.org/2131943002
Cr-Commit-Position: refs/heads/master@{#405103}

Using update-w3c-deps in Chromium 1e9dc390.

BUG=490511, 505364, 612924, 627706
TBR=suzyh@chromium.org, nzolghadr@chromium.org

Review-Url: https://codereview.chromium.org/2143653006
Cr-Commit-Position: refs/heads/master@{#405102}

USE_V4L2_CODEC is needed by GpuVideoEncodeAccelerator.

BUG=541408
TEST=check Media.RTCVideoEncoderInitEncodeSuccess histogram

Review-Url: https://codereview.chromium.org/2146463002
Cr-Commit-Position: refs/heads/master@{#405101}

https://chromium.googlesource.com/chromium/src/+/c35147b9b

BUG=626278
TBR=glebl@chromium.org

Review URL: https://codereview.chromium.org/2149433003 .

Cr-Commit-Position: refs/heads/master@{#405100}

In the top10_mobile page set google.com gets redirected to google.ca. This
sometimes causes problems in telemetry with scrolling. As a short term fix,
replace google.com with google.co.uk in the page set. We cannot change it
to google.ca because memory_top_10_mobile uses the same page set but with
a different wpr that has a recording of google.co.uk. Updated dual_browser
page set to be consistent with top_10_mobile page set.

Also recorded new wprs for memory_top_10_mobile, dual_browser and
top_10_mobile_memory.

BUG=chromium:617914
LOG=N
CQ_INCLUDE_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2138133003
Cr-Commit-Position: refs/heads/master@{#405099}

A compound Knuth-Morris-Pratt failure function is used to match URLs against the
|pattern|.

The |pattern| is split on the '*' wildcard symbol and then a failure function is
built for each subpattern by BuildFailureFunctionFuzzy or BuildFailureFunction
(depending on whether the subpattern contains separator placeholders), and
appended to a vector. Some of the subpatterns can be exempted from being
indexed. E.g., if the |pattern| has a BOUNDARY left anchor, the first subpattern
can be matched by checking if it's a prefix of a URL.

Each subpattern indexed with BuildFailureFunctionFuzzy is prepended with a value
1 (to distinguish them from the subpatterns indexed with BuildFailureFunction,
their failure functions always start with 0).

BUG=609747

Review-Url: https://codereview.chromium.org/2098233002
Cr-Commit-Position: refs/heads/master@{#405098}

The old files in the corpus had the woff signature instead of the woff2
signature and AFL could not discover any paths as a result. The new ones
have the correct signature.

BUG=539572

Review-Url: https://codereview.chromium.org/2145623002
Cr-Commit-Position: refs/heads/master@{#405097}