- 28 Apr, 2020 40 commits
-
-
Mason Freed authored
To enable feature detection, this CL enables this: HTMLTemplateElement.prototype.hasOwnProperty("shadowRoot") This is as documented in the explainer, at [1]. [1] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#feature-detection-and-polyfilling Bug: 1042130 Change-Id: I529af9ce952b4d2e162e099c7ca703af8f3c4791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166466 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#763495}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d50c00bf..c301c370 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2e842b9b2c775d6dda8c68292b35148fb75cca7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170806Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763494}
-
Maksim Ivanov authored
Remove the assertion on |googleResponseReceived| from the MergeSessionTest.XHRNotThrottled test, because checking this variable hits a race with the JS code that writes this variable (in the observer of XMLHttpRequest). It seems correct that the test shouldn't assert on this variable, because, unlike other MergeSessionTest tests, the merge session completion is already performed in the beginning of the test, and requests to Google addresses shouldn't be blocked. Bug: 990844 Test: Run the test ("browser_tests --gtest_filter=All/MergeSessionTest.XHRNotThrottled/1") several thousand times and with stress-ng Change-Id: I92d09409969fcc66623f2025abc3162af02cca04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170867Reviewed-by:Chris Mumford <cmumford@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#763493}
-
Scott Violet authored
BUG=1075662 TEST=FullscreenCallbackTest.testDestroyFragmentWhileFullscreen Change-Id: I46cc5865fe5b395304f860d715704bc909a818ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170976Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#763492}
-
zhaoyangli authored
Handles unknown system dialog by catching the exception. If it's a system update alert, choose later. If not, deny it. Bug: 1072000 Change-Id: Ifc12a37771c247d2f68c7f73ac0169aa337e5dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159916 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#763491}
-
wutao authored
This is a preparation to create access token controller for ambient mode. This cl extracts common logic of ambient mode related unittests into an AmbientAshTestBase. Bug: b/148463064 Test: new AmbientAshTestBase Change-Id: I5b94820521653a3b519b4ed223322da919333a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138505 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#763490}
-
Dan Harrington authored
Bug: 1044139 Change-Id: I8b6ce0db6e9cc9930f49080c5fbde533d199dbfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166343 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#763489}
-
Roman Sorokin authored
on branded builds Bug: 977743 Change-Id: Ie0a017323f26051601bde74c4d28e41ea85a95df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170866Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763488}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I372cc59df1d4fa529f2e5e02d5320055e8130f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170802Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763487}
-
Becca Hughes authored
Add a Media.Feed.Discover UKM event that is recorded when we discover a new Media Feed. This is to track usage of the feature. BUG=1065014 Change-Id: If0fb31dcf597cc51716c1397904412f199c09524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122368 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#763486}
-
Tommy Li authored
This test is flaky on Mac in general: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/33739 Bug: 1076005 Change-Id: I9c338cc128d43e8d44977dc7328a73f7c23efd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170554 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#763485}
-
Koji Ishii authored
The test itself is unchanged, so this probably starts to fail, or starts to flake (one win bot I checked passed this test.) TBR=mstensho@chromium.org Bug: 1076028 Change-Id: I7a69b5b4e4adad7c01815d62ece1a973db1ad907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170747Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#763484}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7d66c798bb49..d70aa16fd5af git log 7d66c798bb49..d70aa16fd5af --date=short --first-parent --format='%ad %ae %s' 2020-04-28 sokcevic@google.com Reland "Print ps in intervals while the process is running" Created with: gclient setdep -r src/third_party/depot_tools@d70aa16fd5af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1074355 Tbr: agable@chromium.org Change-Id: I85571be61eb9b0259a93e697258441635c2306e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170791Reviewed-by:
-
wutao authored
There could be multiple URL requests at the same time. This patch creates URL loader for each request. Bug: b/153504737 Test: manual Change-Id: I990f60e09242fc1ce65e23b8068aa0edda59601c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141614Reviewed-by:
-
Haiyang Pan authored
- android-bfcache-rel - android-opus-arm-rel - android_blink_rel - android-cronet-arm-dbg - android-lollipop-arm-rel-swarming - ToTAndroid Also add cronet-gtests to the builder android-cronet-lollipop-arm-rel The following builders are not migrated for now since they are no working properly with Lollipop: - android-cronet-asan-arm-rel - android-asan Bug: 1032336, 1074410 Change-Id: I3186742244be821ca22f5481f0e652b0b3477410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168797 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#763481}
-
Amr Aboelkher authored
This CL is doing the following: - Rolling to the recent version - Update the README with the exact version Bug: chromium:1076079 Change-Id: Ie16aeaf8e2325762e6928a991c1aefe21dbfb24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170868Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#763480}
-
Chris Lu authored
This creates the placeholder request config to be used to hold a place in the Overlay queue. This will be useful for when Translate waits to finish to show the show original banner. Bug: 1071914 Change-Id: I77801c572b8aa83c7bbaf43ae934ce75667732c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163850 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#763479}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9bb56813821..06cce0bd8dab Created with: gclient setdep -r src-internal@06cce0bd8dab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com,hendrich@google.com,tommycli@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1065456,chromium:1074070 Tbr: yukishiino@google.com,hendrich@google.com,tommycli@google.com Change-Id: Ia07e2bd13b97653054b3344f66bc38b18ad1ce32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170788Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763478}
-
David Black authored
This CL also creates: - chromeos::assistant::mojom::AssistantEntryPoint::kLauncherChip - chromeos::assistant::mojom::AssistantQuerySource::kLauncherChip Bug: b:154153233 Change-Id: Iea6255b794588ff98ff66f75ada8cc7316087901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160107 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Ben Joyce authored
Needs this CL to land first: https://chromium-review.googlesource.com/c/chromium/src/+/2166636 Bug: 1069613 Change-Id: I20d705ff00ed038f506315b8a22728fd4feec857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169847Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#763476}
-
Mason Freed authored
Per the explainer [1] and associated spec PRs, getInnerHTML() should use an options bag parameter, rather than just a boolean for the includeShadowRoots flag. This CL implements that change. [1] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#serialization Bug: 1042130 Change-Id: I678db433bc9555b6cf441d93f245cb1485c16e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166138 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 35 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-10-25. TBR=chromium-metrics-reviews@google.com Change-Id: I24021565e71a8416ac6b488bd0a40eedb0b46480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170303Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#763474}
-
haozhe authored
This patch uses owning_element of animations to sorting animations in getAnimations(), aligning the implementation with the spec: https://drafts.csswg.org/css-transitions-2/#animation-composite-order Bug: 1070460 Change-Id: I1bc627ffecc8450e1f2ad1cff0fefc12ac3971da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139359Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#763473}
-
Rohit Rao authored
Compiles the SamplingHeapProfiler, with associated tests, and adds iOS to the list of platforms which use the allocator shim. BUG=1075702 Change-Id: I4e20027633f0e4ca9b49c37b110f6548ae8ace46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168810 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#763472}
-
Yves Arrouye authored
Use the term "Forced Re-Enrollment" for messages about FRE. Keep the term "Initial Enrollment Check" for initial enrollment. Add a log message when waiting for clock sync. Add a verbose log message when we have decided that an Initial Enrollment Check is needed. Add more verbose logging for conditions that make us skip that check. Bug: None Test: N/A Change-Id: I5e9b661e9a41da9e053afeed460d9c2b13ca77b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165863 Auto-Submit: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#763471}
-
Alexander Timin authored
As child FrameTreeNodes are now owned by RenderFrameHost, make parent() return RenderFrameHostImpl* because the parent RenderFrameHost cannot change for the lifetime of the FrameTreeNode. This makes our handling of non-current (pending deletion, bfcache) frames more robust by making harder to refer to a frame which is not your parent. R=arthursonzogni@chromium.org,creis@chromium.org,alexmos@chromium.org CC=,bfcache-bugs@chromium.org BUG=1073269 Change-Id: Ic2661b69ddd09e1cc5d9095caf7f158fa31f4189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160970 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#763470}
-
Vaclav Brozek authored
DoCanonicalizeFileSystemURL transforms a filesystem URL and also checks that the path of the inner URL (i.e., the path of the URL following the filesystem: prefix) has length at least 2. At the same time, canonicalizing the inner path can decrease the URL length, e.g., "/." becomes "/". So if the path length is checked on the non-canonicalized URL, the sanity check passes, whereas on the canonicalized it does not. The former situation is what happens before this patch. As a result, canonicalizing the URL twice (e.g., once when constructing and the second time when applying even empty replacements) results in a valid URL the first time and an invalid one the second time. This is a bug, because canonicalizing a canonicalized URL should not change its properties. Therefore this CL ensures that the sanity check is done on the already canonicalized path. This fixes the above described bug. Some URLs which used to be considered as valid (only) on the first canonicalization, are now considered invalid every time. Example: "filesystem:http://e:/.". Also, this CL does a minor clean-up in DoCanonicalizeFileSystemURL: The function cached a const version of the parsed.inner_parsed() pointer, but then sometimes used the cached const version, and sometimes the original non-const. The CL turns all of the latter cases into the former one. Bug: 1075515 Change-Id: I48ae1efc6de9207ea29ae774180a9e2662def9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169891Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#763469}
-
Mustafa Emre Acer authored
We have an allowlist for URLs that trigger lookalike heuristics, but we don't have the same for URLs that the lookalikes match to. This can be useful when many lookalikes match the same domain and we know that the lookalikes are not spoofs of the matched domain. In that case, allowlisting the matched domain is simpler than allowlisting multiple lookalikes. This new target allowlist contains regexes as opposed to SafeBrowsing style patterns. This is because it only makes sense to include hostnames as allowed targets and not full URLs. Bug: 1075739 Change-Id: I61b908123eca4df57f695f380e905715750a5e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166504 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#763468}
-
Andrew Grieve authored
Prevernts spamming bot logs when java_deobfuscate.py is broken Bug: 1075998 Change-Id: I0d56ffde20e58c065b6ff575673f656a4396f745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169764 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#763467}
-
Stephen Roe authored
This will enable BigQuery searches on exit codes to find intermittent errors. Bug: 1063106 Change-Id: I7387869331957f851817a7aa2deabf654ee3a954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162105Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#763466}
-
Tom Anderson authored
x11::Connection::Get() should replace gfx::GetXDisplay(). R=sky CC=msisov,nickdiego BUG=1066670 Change-Id: I5a2020c10f158f98697074fb9fec19c13ff6e644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168927 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I054e9ccfcbe6417607237e46a42622194956f1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164513 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#763464}
-
Yi Gu authored
Previously during the shutdown process the compositor timeline may not be detached if it still has animation attached to it. Rather, it should be detached unconditionally. This patch moves the condition check to the call sites to make sure that the timeline cannot be detached if it still has animation attached. Bug: None Change-Id: I0e9b02493ffab9521211a0723557dafa19917f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167517Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#763463}
-
oysteine authored
This reverts commit 9cdc65f2. Reason for revert: crbug.com/1076102 Original change's description: > Make installation of the elevation service optional. > > There are cases where the elevation service may fail to install, for > instance, if security software prevents installation. > > Bug: 1023080 > Change-Id: Ibab20f2ee44395254ef702a460f8fad60836e682 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168825 > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: S. Ganesh <ganesh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#763421} TBR=ganesh@chromium.org,grt@chromium.org Change-Id: I341d30e6449f862d13a0a3be43a2cdfc42451c0e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1023080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169876Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#763462}
-
Kevin Ellis authored
This patch reduces memory usage by doing an in place deduplication of keyframes. It further reduces memory by compacting keyframes when there are mixed easing functions. A safeguard is added to prevent overriding a property at the same offset when processing keyframes. https://pinpoint-dot-chromeperf.appspot.com/job/109e04b5e20000 Bug: 1073751, 1068639, 1070627 Change-Id: I35ba4e4eb3096bad2ec66757c6ec705cca4e6761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163639 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
-
Maksim Moskvitin authored
BuildTrustedVaultNigoriSpecifics() had its own implementation for each of single_client_nigori_sync_test, nigori_sync_bridge_impl_unittests and fake_server_helper_android (was inlined into other function). This CL factors out the implementation and addresses these duplicates. There is small difference between old implementations: keybag_is_frozen wasn't set in some of them, but this field isn't consumed by modern clients. Bug: 1046663 Change-Id: Ia173ac1f1942b988d972adc3e47c3b3c803a3d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168881 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#763460}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 108 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-10-25. TBR=chromium-metrics-reviews@google.com Change-Id: I03a528e541a4d5863d50bf796a64689ccededb8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170786Reviewed-by:
-
Tom Anderson authored
This CL adds x11::Future::OnResponse() to install a response handler for X11 requests. Previously you could only Sync() to get the response. ui::X11WorkspaceHandler is changed to demo usage of async response handling. Eventually it should be migrated to a higher-level property handler, like we currently have in x11_util.* for Xlib. R=sky CC=msisov,nickdiego BUG=1066670 Change-Id: Ifcab2553008395bcfd9090e6aa1ccc5b4e53ae2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164245 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
chrome://inducebrowsercrashforrealzEugene But authored
Start rapidly leaking memory by 10MB blocks if chrome://inducebrowsercrashforrealz?leak&crash=no URL gets loaded, which this causes out of memory termination by the OS. This feature allows to simulate UTEs for testing purpose in projects related to UTEs detection and fixes (like Synthetic crash logs for UTEs and Low Level Profiling). Bug: None Change-Id: I362f74c2e8fb7966fdf026a854dd587263d089cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167009Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#763457}
-
Xinghui Lu authored
Now that the implementation in internal repository is removed, it is safe to remove the interface. Bug: 1070836 Change-Id: I196df7afd48dd051b2f8e053166248eedd24305b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168648Reviewed-by:
-
