- 04 Sep, 2019 23 commits
-
-
Gyuyoung Kim authored
This CL converts mojo::Binding to mojo::Receiver in TestDocumentInterfaceBroker class. Bug: 955171, 978694 Change-Id: I7f6800d611ed3d015852de939d4c768c690c5290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778443Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#692952}
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new Mojo types more. - Apply mojo::PendingRemote to MediaStreamDispatcherHostPtr. - Replace mojo::Binding with mojo::Receiver. - Apply mojo::Remote to MediaStreamDispatcherHostPtr. Bug: 955171, 978694 Change-Id: Iefacee2172332ba8891fe56f04449e68483373db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780084Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#692951}
-
Dale Curtis authored
Our hardware decoders don't have support for alpha decoding at present, so skip tests for support early in the renderer instead of needing to make a gpu round trip. BUG=996960 TEST=none R=chcunningham Change-Id: Ib1701f51beff883bb6b4e062d35a92fc0acc3dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783520 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#692950}
-
Regan Hsu authored
Wallpaper preview mode breaks when the alphaEnabled flag is removed. This reverts commit 86b21972. Bug: 997115 Change-Id: Iaf34c5da55bb44dfd5e728ccb1a219a4569e4954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783723Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#692949}
-
Sergey Ulanov authored
Now CastRunner enables VULKAN feature for the web context, which will enable Vulkan for rendering. Also CastRunner now passes HARDWARE_VIDEO_DECODER flag. That flag is currently ignored (video decoder is always enabled), but that will change in the future. Bug: 962617 Change-Id: If4160828cf11ec1fa73f0d5465c5ea9c2c0a6209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783665Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#692948}
-
Andrew Grieve authored
This reverts commit f6e84797. Reason for reland: Removed -checkdiscards. TBR=agrieve # Trivial rename Change-Id: I8924fb2ef16ba1a1704e33634c45471c56d84e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780955Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#692947}
-
Maks Orlovich authored
The test removes |cache_dir_|, which seems risky since other instances might touch it; so instead put the cache one more level down. Bug: 999584 Change-Id: I56f100b0308e45f1e6bbc66c7306cbf3af822e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782878Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#692946}
-
Yuke Liao authored
This CL sets up linux-chromeos-coverage-rel, which replicates linux-chromeos-rel with coverage instrumentation, and the intention is to evaluate the stability of coverage instrumentation on ChromeOS platform. Bug: 1000378 Change-Id: I9065c1ef67f81f9a2286632178af12b54c0eb36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782990Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#692945}
-
Kent Tamura authored
* Change the type of potentially_violated_features_ from std::bitset to Vector<bool>. * Remove feature_policy.mojom-blink.h dependency from security_context.h Also, apply *.mojom-blink-forward.h as much as possible. Bug: 242216 Change-Id: If0c0d1816a5dcad726507c0a22cddbebac34dccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782209Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#692944}
-
Wei Li authored
On Mac, we follow platform convention to use all titlecase for button text. On other platforms, we should prefer full sentence -- non titlecase for button text. So this CL make the button text casing depending on platforms. BUG=979530 Change-Id: I47afe2192e65a42511b36133d0c69cb325c238af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783240 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#692943}
-
Jeevan Shikaram authored
This CL updates the existing ShowAppManagementPage function to open App Management within OS Settings. Bug: 1000104 Change-Id: Iebd02bfc69071d4c6e4dfdd7aee3f5427a575825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781983 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#692942}
-
John Lee authored
https://i.imgur.com/nZEwnkK.png Bug: 989131 Change-Id: I748c3591adeabe43c0e5a3e653185c94b0f3a6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779524Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#692941}
-
Marijn Kruisselbrink authored
We shouldn't be creating or truncating files if the access to the directory is going to be blocked by the restricted folder checks. So swap around the order of the two operations. Bug: 999788 Change-Id: I0b7519e079f79f4cb031f8f5d1d905fee1bbbb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783725 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#692940}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8df216c09227..1a9881e19baa git log 8df216c09227..1a9881e19baa --date=short --no-merges --format='%ad %ae %s' 2019-09-03 vapier@chromium.org image_lib: remove au-generator.zip support 2019-09-03 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@1a9881e19baa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I8f74037c6b44a8b22b933f7f225ac35b75720232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783737Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692939}
-
Manas Verma authored
Adding opt_in bit which will be set to true when user intends to opt-in for FIDO Authentication for future card unmasking. When set to true, the payments server will respond with creation options for enrollment, or will simply opt-in the user if they are already enrolled. Bug: 949269 Change-Id: I0a6caa61d9c91706db5efc9e0a2866f0228297a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730292 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#692938}
-
Jeevan Shikaram authored
This reverts commit 70aabb04. Reverting this revert and disabling tests as this needs to go to UI review soon. Tests will be fixed in a following CL. TBR=calamity@chromium.org Bug: 1000271 Change-Id: Id681d795194e1d4a7cac8ec5e6167ccdfb2a3434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783677Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#692937}
-
Yutaka Hirano authored
This reverts commit 619a3f3e. Reason for revert: suspected to break ash_unittests on MSAN: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/14981 Original change's description: > desks: Fix unnecessary highlight on disabled new desk button. > > Test: manual > Bug: 1000191 > Change-Id: Iad3e0918ae6c82e3939e0e9413d93b0f58c2eda5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782671 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692794} TBR=afakhry@chromium.org,sammiequon@chromium.org Change-Id: I4baf70a77f62b2880aaeca4d5b3b7d4aca9aa51f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1000191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782360Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#692936}
-
Yannic Bonenberger authored
*** Note: There is no behavior change from this patch. *** This CL replaces calls to base::{Bind,BindRepeating} with calls to base::BindOnce, and removes calls to base::AdaptCallbackForRepeating when the returned base::RepeatingCallback is immediately converted to a base::OnceCallback. This CL was uploaded by git cl split. R=yhirano@chromium.org Bug: 714018 Change-Id: I33444d67bd5d4d2b5d7fed7c50d77b22078c3270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778608Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com> Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com> Cr-Commit-Position: refs/heads/master@{#692935}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7ffef1e8cc2e..aeba7fa1fd36 git log 7ffef1e8cc2e..aeba7fa1fd36 --date=short --no-merges --format='%ad %ae %s' 2019-09-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@aeba7fa1fd36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: None Change-Id: Ic15f9aa720ffc4e944d54e03d1d6608484678395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783617Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692934}
-
James Hawkins authored
The input method list item element is essentially an abuse of the default list item implementation in that selecting the main area of the input item sets the selected input method as the enabled input method. After selection, this part of the list item element should not be focusable or respond to activation. This change provides a few things: * Override the cursor for an actionable input list item element so it does not appear as an activatable button. * Only set the tabindex on the non-enabled input list item elements. * Prevent focusing the input list item element such that a focus ring does not flash then disappear on click. R=jamescook@chromium.org, khorimoto@chromium.org Bug: 987607 Test: none Change-Id: I60c79b50a4e8691ab378d43721116fbbc7202ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783239Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#692933}
-
dalyk authored
If the probe query was cached, the RTT could be significantly less than what a non-cached query would require. Updating the timeout for DoH queries based on the probe RTT is thus potentially problematic. Getting rid of it also reduces code complexity. Bug: 1000043, 985589 Change-Id: Id8db1930c6b8a9a7f409f32a4c04b0ea9ae4c22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783402Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#692932}
-
Matt Mueller authored
The output of 'security find-certificate -a -p -Z' in 10.15 includes both a SHA-256 and SHA-1 hash for each cert. The old parser split on the SHA-1 hash, confusing the rest of the parsing. Now it splits on the "-----END CERTIFICATE-----" PEM marker, which should be a consistent place to split regardless of any future changes. The parsing of the hash value looks for the first hash mentioned in the text regardless of algorithm. (It's only used for SCOPED_TRACE and LOG messages, so the particular algorithm isn't important.) Bug: 998845 Change-Id: Iaea008a253d0dc4d25314010b2803b841206b7ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783661Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#692931}
-
Yun Liu authored
Bug: 970083 Change-Id: I2603767429b481622db8bd85c60687e616c090fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776716 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#692930}
-
- 03 Sep, 2019 17 commits
-
-
Toby Huang authored
LoggedInUserMixin provides the same functionality as SupervisedUserTestBase for logging in as child or regular users without the associated multiple inheritance diamond problems. Deprecate SupervisedUserTestBase. Bug: 990909 Change-Id: Ibc01f9d3298fff1cc15812d0aa1373a75e30c394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764935Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#692929}
-
chrome://flagsJared Saul authored
Change-Id: I794519bc2691f7d223d35a8ac7a3090db12f863e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783726 Commit-Queue: Siyu An <siyua@chromium.org> Auto-Submit: Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#692928}
-
Miyoung Shin authored
This CL converts PaymentHandlerHost{Ptr, PtrInfo} in blink and components to the new Mojo types. Bug: 955171, 978694 Change-Id: I903ce85df7ca3d221fcff3c64c366ba1e107d2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782199Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#692927}
-
David Trainor authored
Due to some work with our cold start tab loading experience, these metrics will be useful for a few more milestones. Bug: 975243 Change-Id: I685b8adc77b589dc79a04c6f454bbc13722292e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783362 Auto-Submit: David Trainor <dtrainor@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#692926}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a877ee62b1fc..f38bc1796282 git log a877ee62b1fc..f38bc1796282 --date=short --no-merges --format='%ad %ae %s' 2019-09-03 ehmaldonado@chromium.org git-cl: Clean up a bit Created with: gclient setdep -r src/third_party/depot_tools@f38bc1796282 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I5511a5b8462f4b99225f4355698d8034b9b5992d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782734Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692925}
-
Nate Fischer authored
No change to logic, this just changes explicit calls to the std::unique_ptr constructor to instead use make_unique() or implicit conversion from nullptr. This is to conform with a chromium presubmit check. Test: ninja -C out/Default android_webview:common Change-Id: If7ebeb1c67e9b5d07b13728cb3971b45491463ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783702 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#692924}
-
tby authored
The latency of the call to the Item Suggest API is too long, causing UI issues with results popping into the list. This CL moves the call to immediately after the launcher is opened into peeking state, giving a longer window for the call to complete. Bug: 959679 Change-Id: Idc10c56f3807ed9079ac8924fc49417b1d427d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772788Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#692923}
-
Kenneth Russell authored
This reverts commit b04bb574. Reason for revert: root cause of flaky tests believed fixed in https://chromium-review.googlesource.com/1783297 . Original change's description: > [Sheriff] Disable Flaky ContextLost Tests on Mac > > TBR=kbr@chromium.org > > Bug: 999327 > Change-Id: I28240c209f4599978e0be64376629e5be7cce0c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781641 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692610} TBR=kbr@chromium.org,jdoerrie@chromium.org Bug: 999327 Change-Id: Ib9971cdf5d8b0ef221b920ca5786b2ff3ecd6530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783482Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#692922}
-
Maksim Ivanov authored
Decrease the spacing between the title and the subtitle in the security token PIN dialog shown during SAML sign-in. To achieve this, remove the extra <p> element that was adding extra margin/padding. Also adjust accordingly the position of the PIN keyboard, so that the spacing between the subtitle and the PIN keyboard stays the same after this CL. Bug: 964069 Test: verify in DevTools that (1) distance between bottom edge of title and subtitle is 32dp, and (2) distance between bottom edge of subtitle and top edge of the PIN input field is 78dp Change-Id: I6fc9e073e100870755830a8011087ecd90d4a49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777865Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#692921}
-
Hiroshige Hayashizaki authored
To enable `spec.src.json` to specify (possibly nested) source contexts, this CL adds `source_context_list_schema` that represents source contexts from where subresource requests are sent, and how policies are delivered (by source contexts or subresource requests). This CL adds `source_context_list` field to each `test_expansion` entry, of which value is the key of `source_context_list_schema` to be used. This CL adds `source_context_schema` and `subresource_schema` that represent supported delivery types and subresources for each source context or subresource type. These are used: - To filter out test files for unsupported combinations of delivery types, source contexts and subresources. A part of the filtering was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1717535 and this CL re-adds it (in a different form of implementation). - To determine what delivery types should be used for `anotherPolicy` placeholder. After this CL, the generate.py generates `source_context_list` and `subresource_policy_deliveries` fields that are passed directly without coversion. Specifically, - The conversion from `classic-data-worker-fetch` to `classic-data-worker` + `fetch-request` in mixed-content-test-case.js is removed. - <iframe srcdoc>-related tests for `img-tag` referrer-policy tests are split into separate tests, and related code in referrer-policy-test-case.sub.js is removed. Instead, to support tests inside <iframe srcdoc>, this CL adds `referrerSource` calculation that can support <iframe srcdoc>s. This CL also changes the structure of generated file names. Now all files are generated under a dedicated directory `gen/`. This CL creates `test-case.sub.js` instead of modifying `referrer-policy-test-case.sub.js` etc., because: After this CL, I'll commit new generated test HTML files, incrementally in order to monitor potential regressions, Because thousands of files are modified, split, and renamed. During the incremental commits, `test-case.sub.js` is used by new generated tests while `referrer-policy-test-case.sub.js` etc. are still used by old tests. After all commits are done, `referrer-policy-test-case.sub.js` etc. will be removed. This CL renames subresource names, to make the names of subresources, source contexts and source context lists consistent. `test-case.sub.js` reflects renaming of JSON keys and values done in previous commits. - opt_in_method -> delivery_type/value https://chromium-review.googlesource.com/c/chromium/src/+/1717107 - delivery_method -> delivery_type https://chromium-review.googlesource.com/c/chromium/src/+/1716109 - referrer_policy -> delivery_value https://chromium-review.googlesource.com/c/chromium/src/+/1717592 - source_protocol -> source_scheme https://chromium-review.googlesource.com/c/chromium/src/+/1717115 https://chromium-review.googlesource.com/c/chromium/src/+/1718991 - target_protocol + origin -> origin https://chromium-review.googlesource.com/c/chromium/src/+/1717470 - Use shorter values for origin and redirection https://chromium-review.googlesource.com/c/chromium/src/+/1717475 - referrer_url -> expectation https://chromium-review.googlesource.com/c/chromium/src/+/1717319 - source context names https://chromium-review.googlesource.com/c/chromium/src/+/1777110 Bug: 906850 Change-Id: Ia6695081e5a93355c29fb1bdb7e89ba6b673261f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586548 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#692920}
-
Eric Roman authored
Bug: 859536 Change-Id: I3cba0cfe960917dd87eff238ea9d6a11e5dc88ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783662 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#692919}
-
Simon authored
TBR=crouleau@chromium.org Bug: 10004604 Change-Id: I96dbddaa7a234768c451323acf6238389ed674c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782735Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#692918}
-
Scott Violet authored
ContentView is needed for events and all sorts of other fun stuff. BUG=none TEST=none Change-Id: Ia8d02f0e322c3051c91fb0e37c6f2890834edcf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783582Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#692917}
-
Chisoon Jeong authored
Correct parameter names with capital character which is old style. Add missing parameter name of a method. Change-Id: Ib70e84411215bd0a20e7cb2c91c45d3141c33034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772952Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#692916}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5198ea1a702a..f790aa521cc6 git log 5198ea1a702a..f790aa521cc6 --date=short --no-merges --format='%ad %ae %s' 2019-09-03 simonhatch@chromium.org Pinpoint - Need to add these git hash inputs for try jobs Created with: gclient setdep -r src/third_party/catapult@f790aa521cc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1000421 Change-Id: I25ec33deb24dd5d563fc859aa47e26b8131ad32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783618Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692915}
-
John Lee authored
Bug: 989131 Change-Id: I91eae8668ef23531ba87c6fd97bfadf89b1b1f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779462 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#692914}
-
Michael Montvelishsky authored
It's not verbose, but would be a great help in narrowing down low level audio issues. Change-Id: Id84bc9894b554dab443a5a017cec1ef888418e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783718Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Michael Montvelishsky <mont@chromium.org> Auto-Submit: Michael Montvelishsky <mont@chromium.org> Cr-Commit-Position: refs/heads/master@{#692913}
-