Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 23 Jun, 2018 2 commits
    • Min Qin's avatar
      All callbacks to notify when InProgressDownloadManager is initialized · 39c14237
      Min Qin authored 
      Currently DownloadManagerImpl intializes InProgressDownloadManager.
However, when only ServiceManager is running, DownloadManagerImpl will
not be created.
As a result, some other class will initialize InProgressDownloadManager.
And when chrome fully starts, DownloadManagerImpl needs to know whether
InProgressManager has been initialized.
This CL allows InProgressDownloadManager to take more callbacks to
notify when initialized.
So multiple classes can observe the initialization event.

BUG=842245

Change-Id: I5881b10db0f93f98262ab1baebc67621c2743fbe
Reviewed-on: https://chromium-review.googlesource.com/1111027
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569849}
      39c14237
    • Nate Fischer's avatar
      AW: do not allow proguard to optimize ApiHelper classes · 428de580
      Nate Fischer authored 
      We recently introduced a series of ApiHelperFor* classes to help us
ensure the WebView APK's classes pass compile-time verification in order
to avoid runtime verification (which causes logspam and startup
penalties). However, proguard was inlining these classes in our release
builds, which re-introduced the class verification issues.

This adds an annotation to prevent inlining. The @DoNotInline
annotation is used to configure Proguard.

R=torne@chromium.org

      (tested on L,M,NMR1 with standalone webview and monochrome)
      android-webview-google -v --pageset-repeat=1
      (no startup penalty on L device)
      "StatusRetryVerificationAtRuntime" (ensure the fixed classes no
      longer show up)

Bug: 791099
Bug: 838702
Test: adb logcat | grep 'Failed resolution of'
Test: tools/perf/run_benchmark system_health.webview_startup --browser \
Test: use oatdump after installing APK. Then, grep for
Change-Id: I7e85718916313f03287e5f2d5fe8f51a02661f11
Reviewed-on: https://chromium-review.googlesource.com/1109464Reviewed-by: default avatarRichard Coles <torne@chromium.org>
Reviewed-by: default avatarBo <boliu@chromium.org>
Reviewed-by: default avataragrieve <agrieve@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569848}
      428de580
  3. 22 Jun, 2018 38 commits