- 27 Feb, 2019 38 commits
-
-
Daniel Rubery authored
The request_ap_verdicts field was set after the serialization of the the ClientDownload request, so it was not send to the backend. I also add this field to the chrome://safe-browsing page, for testing. Change-Id: I578aed3aa2c9dba791b8689ac06a0acb2b3b7eea Reviewed-on: https://chromium-review.googlesource.com/c/1490498 Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635802}
-
Luciano Pacheco authored
This allows the string to be shared between Files app and ARC++. Bug: b:123362537 Change-Id: I9aedc65e4799ba1363e1c6981459ab25a08ce303 Reviewed-on: https://chromium-review.googlesource.com/c/1476887Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#635801}
-
Ian Kilpatrick authored
I noticed inside the stack-sampled metrics, we were burning a bunch of time hopping through these calls. Bug: 635619 Change-Id: Ic7788a666aafdf0630fd441e2762e7b7d4302879 Reviewed-on: https://chromium-review.googlesource.com/c/1489303Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#635800}
-
Ce Chen authored
Result from on device head will be set as [AutocompleteProviderType::TYPE_ON_DEVICE_HEAD|AutocompleteMatchType::SEARCH_SUGGEST|subtype_identifier=271]. Bug: 925072 Change-Id: Iac72e0df2ab03bb331efab68b71a2f9e26f81eee Reviewed-on: https://chromium-review.googlesource.com/c/1484502 Commit-Queue: Ce Chen <cch@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#635799}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33105789ee1e..f9240dad68dd Created with: gclient setdep -r src-internal@f9240dad68dd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:928475,chromium:894099,chromium:888864,chromium:883361,chromium:845990 TBR=mmoss@chromium.org Change-Id: I9541beee4dbe62f455559e1e9830c1fea99041ae Reviewed-on: https://chromium-review.googlesource.com/c/1490373Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635798}
-
Caitlin Fischer authored
Change-Id: I4d0d15aef5a0596cf9da45609a00645fbe1168bd Reviewed-on: https://chromium-review.googlesource.com/c/1482555Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#635797}
-
Danyao Wang authored
Spec: https://w3c.github.io/payment-request/#merchantvalidationevent-interface Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/fXwI0c6m0lE/cEZzhSSYAQAJ This CL adds the MerchantValidationEvent interface behind a new runtime flag. The .complete() method will be implemented in a separate CL. IsValidMethodFormat() is extracted from PaymentRequests to PaymentValidators to allow code reuse. Bug: 867904 Change-Id: I7b504e365da1198b14c78b1f4e58c4c9f052df8f Reviewed-on: https://chromium-review.googlesource.com/c/1480636 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#635796}
-
Ryan Hansberry authored
This is a necessary change now that Polymer 2 is enabled. Previously, Multidevice and Smart Lock pages were being informed of an authToken change by their child element passwordPrompt, but that is no longer bubbling up to the parent. Now, explicitly bind to the authToken of passwordPrompt as a property, and use it when the dialog close event is fired. As a consequence of this, the authTokenChanged() callbacks in both parents is unnecessary and has been removed. Bug: 934987 Change-Id: Ie0d624dde09f895a7076122aaed9eb224a629a1a Reviewed-on: https://chromium-review.googlesource.com/c/1484495Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#635795}
-
Xiaocheng Hu authored
[Sheriff] Disable org.chromium.chrome.browser.fullscreen.FullscreenManagerTest#testManualFullscreenDisabledForChromePages Bug: 936252 NoTry: True Tbr: skyostil@chromium.org Change-Id: I4748aff78894faf2472a4fc958aad3fb0bcb9d5f Reviewed-on: https://chromium-review.googlesource.com/c/1490896Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635794}
-
Joel Einbinder authored
Bug: 891675 Change-Id: Id1b6cfc1afc1f9afb32bacb43fbd05da2c394a5b Reviewed-on: https://chromium-review.googlesource.com/c/1344872 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#635793}
-
John Chen authored
This reverts commit 4fe92e6c. Reason for revert: Causing failures in a couple of Java tests: ElementEqualityTest.testAnElementFoundInADifferentFrameViaJsShouldHaveSameId ElementFindingTest.testAnElementFoundInADifferentFrameViaJsCanBeUsed Original change's description: > [ChromeDriver] Remove unused shadow DOM object cache > > ChromeDriver uses object caches for use while calling JavaScript > functions. The data structure was designed to allow a separate cache for > each shadow DOM, but that feature was never used, and objects in shadow > DOMs have always been stored in the main page cache. This CL removes > unused code, and resolves differences between test expectancies and > actual code behavior. It prepares for future changes to make the object > cache standard compliant. > > Bug: chromedriver:1461 > Change-Id: I10fcd94a7fd2359cc43fe6bc7241d36647e9d744 > Reviewed-on: https://chromium-review.googlesource.com/c/1485011 > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635754} TBR=crouleau@chromium.org,johnchen@chromium.org Change-Id: I7e092258ef2298d2bccc27ef8bd4ffdea5e5eee2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromedriver:1461 Reviewed-on: https://chromium-review.googlesource.com/c/1490747Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635792}
-
Yann Dago authored
Bug: 933517 Change-Id: I25a5de9d70545623bce187fe21843fbb185b9009 Reviewed-on: https://chromium-review.googlesource.com/c/1478109 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635791}
-
Daniel Murphy authored
There are still a large number of renderer hangs from GetAll. Since the other possible hang call sites have been marked [Sync], this means that the loading of the storage area map is the final obvious area where this hang could be occurring. mek@ and I found a number of possible optimization spots where a map is known to be empty during the GetAll (or Fork) calls, and in these cases the code can avoid hitting disk. Hopefully this captures many common cases and can help the code hit disk less. https://docs.google.com/document/d/1Pw8W74-7NCHpxrtglVHqFZpLV_p2JFwdMNqo03kx2l8/edit has the discussion notes. R=mek@chromium.org Bug: 897581 Change-Id: I92de5848ebf17e2ab4fd5cd85610922858e629a8 Reviewed-on: https://chromium-review.googlesource.com/c/1488178 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#635790}
-
Tsuyoshi Horo authored
Bug: 910516 Change-Id: Idea34833925b9aeead30c00fc0ae409a505c2846 Reviewed-on: https://chromium-review.googlesource.com/c/1488488Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635789}
-
Noel Gordon authored
Wrap raw image data in a PiexStreamReader, and process it via Piex, to extract the preview and thumbnail image properties. Caller (JS on the same web page) owns the data. All this code needs to do is provide the offset and length of the image preview or thumbnail, as well its EXIF color space and orientation information, and callback these results in a JS object. The result includes the camera maker and model, and preview and thumbnail image format/width/height properties, for testing purposes [1]. Add fake DEPS to node_modules/piex to silence bogus presubmit error on uploading this patch. Update Wasm Makefile for new piex.cpp code. Build products we care about are the a.out.{js,wasm}. Build sizes look good running: % ls -sh a.out* 36K a.out.js 60K a.out.wasm [1] Note the upstream Piex code is fuzzed, and has a large test suite. Our test approach can be much simpler therefore, as we'll soon see. Tbr: slangley Bug: 935285 Change-Id: I406dc08c908027782390e793bf6c7765bf0afa39 Reviewed-on: https://chromium-review.googlesource.com/c/1488474 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635788}
-
Lei Zhang authored
Do not bother with the extra effort of trying to detect the case of the user going into annotation mode and then not making any edits. Just assume they likely will to keep the state machine simpler. BUG=936094 Change-Id: I82a793e39f7175c5bffdb3c93630f9b085385dca Reviewed-on: https://chromium-review.googlesource.com/c/1490397Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#635787}
-
Etienne Bergeron authored
The trace event is setting an args on from a char[]. R=oysteine@chromium.org TBR=drott@chromium.org Change-Id: I8fd6f9acc1db4328698d75109ccce4f0bed59fa4 Reviewed-on: https://chromium-review.googlesource.com/c/1489639Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635786}
-
Xiaocheng Hu authored
Bug: 936129 Tbr: wanderview@chromium.org NoTry: True Change-Id: Ifcfd654ab9a40fdbd6792779601ebcc4a3b1c4bd Reviewed-on: https://chromium-review.googlesource.com/c/1490743Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4efdb5120090..ac0f524bb103 git log 4efdb5120090..ac0f524bb103 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 thestig@chromium.org Optimize FindSubWordLength(). 2019-02-26 thestig@chromium.org Avoid some WideString construction inside FX_ParseDateUsingFormat(). 2019-02-26 thestig@chromium.org Save results from FPDF_GetFieldAttr() calls. 2019-02-26 thestig@chromium.org Add constants for form field types. 2019-02-26 thestig@chromium.org Add constants for common form field dictionary entries. 2019-02-26 thestig@chromium.org Simplify CheckForUnsupportedAnnot() internals. Created with: gclient setdep -r src/third_party/pdfium@ac0f524bb103 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:935241,chromium:935241 TBR=dsinclair@chromium.org Change-Id: Ic3b21fbfc95ebcdbe9089dae9b7a8a401ad2f81e Reviewed-on: https://chromium-review.googlesource.com/c/1490372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635784}
-
Yuwei Huang authored
This version fixes an integer overflow bug in 32bit architecture, which causes out-of-bound memory read. Bug: 934128 Change-Id: I1a63f8949e0e67aa4998609ffe07846a36105051 Reviewed-on: https://chromium-review.googlesource.com/c/1490471Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#635783}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f12d67517903..4dbb96dfaa04 git log f12d67517903..4dbb96dfaa04 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader fe3d4978886b..8adf1fcd08d0 (2 commits) 2019-02-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 024f271ae0c7..fe3d4978886b (1 commits) 2019-02-26 brianosman@google.com Particles: remove non-stable random, add better enum reflection Created with: gclient setdep -r src/third_party/skia@4dbb96dfaa04 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I684d53946620eed63815fe82769f97ad250096de Reviewed-on: https://chromium-review.googlesource.com/c/1490371Reviewed-by:
-
Sky Malice authored
This reverts commit 18d4c919. Reason for revert: getUpdateConsumer() would initialize some part of the Feed that needed to be initialized. An uninitialized Feed drops requests on the floor. This caused refresh requests to be ignored. Original change's description: > [Feed] Call simple triggerRefresh method. > > Bug: 933395 > Change-Id: I2b76b43f15c695449c6af30db0992b386fd02222 > Reviewed-on: https://chromium-review.googlesource.com/c/1476827 > Commit-Queue: Sky Malice <skym@chromium.org> > Reviewed-by: Gang Wu <gangwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#633351} TBR=gangwu@chromium.org,skym@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 933395 Change-Id: Id047d0ac979ab3b36dd1e6c7c74d5b3f37c54cf9 Reviewed-on: https://chromium-review.googlesource.com/c/1490492Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#635781}
-
Alexei Filippov authored
BUG=884147 Change-Id: Ib68bc3e2be3d8361f085c8c1fc484658c47e4a15 Reviewed-on: https://chromium-review.googlesource.com/c/1489634Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#635780}
-
Daniel Murphy authored
Maps that are being forked from are not being held open until the fork operation is complete, which is probably causing the GetAll hanges in the attached bug. This idea came from mek@ out of the discussion here: https://docs.google.com/document/d/1Pw8W74-7NCHpxrtglVHqFZpLV_p2JFwdMNqo03kx2l8/edit#heading=h.lwd5sacdhs8q R=mek@chromium.org Bug: 897581 Change-Id: I700bbc580b0f4360354b87b4b9a8cfb3cb4bd6ee Reviewed-on: https://chromium-review.googlesource.com/c/1489897 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/958d88e26d2e..be28670fe2bf git log 958d88e26d2e..be28670fe2bf --date=short --no-merges --format='%ad %ae %s' 2019-02-26 vadimsh@chromium.org [cipd] Rebuild all Go binaries with Go 1.12. Created with: gclient setdep -r src/third_party/depot_tools@be28670fe2bf The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:936067 TBR=agable@chromium.org Change-Id: Ifa552946ab3bca0ffd8d93c9d8966662a4edddde Reviewed-on: https://chromium-review.googlesource.com/c/1490097Reviewed-by:
-
Hirokazu Honda authored
VideoDecoder client, before it calls VD::Initialize, decodes EOS buffer (i.e. VDA::Flush()) first and waits until the EOS buffer is decoed (i.e. VDA::NotifyFlushDone()). Therefore, VdaVideoDecoder doesn't have to call VDA::Flush() in the beginning of reinitialization. This removes the unnnecessary VDA::Flush() call. Bug: 929565 Test: no video corruption on some issued sites on grunt and eve Change-Id: I4e842996896378f0d6f03fc5942833944e3afcaf Reviewed-on: https://chromium-review.googlesource.com/c/1487758Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635777}
-
Eric Stevenson authored
This reverts commit a2c39735. Reason for revert: https://crbug.com/935964 Original change's description: > Android: Fix fat lib toolchain in Trichrome. > > Missed in https://crrev.com/c/1481019. Only causes errors when > resource whitelisting is enabled. > > Tbr: agrieve@chromium.org > Bug: 935088 > Change-Id: Ide099850512681bc6494995310e6c63ac7441365 > Reviewed-on: https://chromium-review.googlesource.com/c/1485232 > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634979} TBR=agrieve@chromium.org,estevenson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 935088, 935964 Change-Id: Ica482153d538741a0b65828dde0e84e28416283d Reviewed-on: https://chromium-review.googlesource.com/c/1490515Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#635776}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/44fde444..d28f8754 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9df01e967a4ec520f9b944e0475e406ee0eacf18 Reviewed-on: https://chromium-review.googlesource.com/c/1490214Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635775}
-
Marcin Wiącek authored
This is a reland of d9d05e18 (https://chromium-review.googlesource.com/c/chromium/src/+/1142764) with fix created by donnd@google.com for bug described inside https://chromium-review.googlesource.com/c/chromium/src/+/1488575 Original change's description: > Migrate PanelState from enum to @IntDef + remove one Map > > @IntDef/@StringDef annotation are preferred way for declaring > set of String/int values > > 1. they need less space in APK than enum, see > https://developer.android.com/topic/performance/reduce-apk-size#remove-enums > 2. they give more control over allowed values than "static final" values > > Main goal of patch is writing PanelState enum in the form common with other Chrome @IntDef: > > 1. with @IntDef first, @Retention second > and related @interface third > 2. with values inside @interface > 3. with NUM_ENTRIES declaring number of entries > 4. with comment about numbering from 0 without gaps > 5. with @Retention(RetentionPolicy.SOURCE) > 6. without "static final" in the @interface > > There is additionally removed one unnecessary Map. > > BUG=919666 > > Change-Id: I8149a0800bd5c0bb205028d230edadc83016ebb9 > Reviewed-on: https://chromium-review.googlesource.com/c/1142764 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Donn Denman <donnd@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635196} TBR=agrieve@chromium.org,dtrainor@chromium.org Bug: 919666, 935923 Change-Id: I6bceed612d667d47a9a7205c057d6b04b16c3bb0 Reviewed-on: https://chromium-review.googlesource.com/c/1489732 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#635774}
-
Xiaocheng Hu authored
Tbr: ricea@chromium.org NoTry: True Bug: 936108 Change-Id: I2bb162f307480a9af8de15729462f29e54535a6b Reviewed-on: https://chromium-review.googlesource.com/c/1490507Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/002ef361cabc..32b0f6739fa5 git log 002ef361cabc..32b0f6739fa5 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 stevenperron@google.com Use correct option in spvTextToBinary. (#2416) 2019-02-26 stevenperron@google.com Handle back edges better in dead branch elim. (#2417) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@32b0f6739fa5 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I26056b6ef3fcb97281656b4e22fa2517edcf2971 Reviewed-on: https://chromium-review.googlesource.com/c/1490096Reviewed-by:
-
Brad Hall authored
Bug: 790139 Change-Id: Ia6bda22ca94937dcc2a22f9ec6e23f1222fe217b Reviewed-on: https://chromium-review.googlesource.com/c/1474679 Commit-Queue: Brad Hall <bradhall@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#635771}
-
Amos Lim authored
Move On*Event(Stub) functions from EmbeddedWorkerTestHelper to FakeServiceWorker. Bug: 934665 Change-Id: I44bd5b26ebf0a3672c785fb2433a46a2f1a451a3 Reviewed-on: https://chromium-review.googlesource.com/c/1484406 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Auto-Submit: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#635770}
-
siashah authored
- Add a text view to display masked card details - Add error message for showing error on invalid expiration date - Move validation logic from CardUnmaskPrompt to AutofillUiUtils - Fix the width and the padding of expiration date and month input texts Current Demo Initial dialog -> https://screenshot.googleplex.com/46v8wXw33hA Dialog with error message -> https://screenshot.googleplex.com/xPha3pv3PuM Bug: 926316 Change-Id: Ia6e01b3910be4dd75c13a8d050c0286e331c91af Reviewed-on: https://chromium-review.googlesource.com/c/1471501Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#635769}
-
Julie Jeongeun Kim authored
This CL moves input_host.mojom and input_messages.mojom to public/mojom/input in order to organize mojom files at mojom folder. Bug: 919393 TBR=dcheng@chromium.org Change-Id: Ic260ba051088e77fdd115876a6bf5a0fa0db8935 Reviewed-on: https://chromium-review.googlesource.com/c/1478322Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#635768}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/793add9a8d60..3ee6a6225e33 git log 793add9a8d60..3ee6a6225e33 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 evanhernandez@chromium.org purge_gs: Move deps to contrib. Created with: gclient setdep -r src/third_party/chromite@3ee6a6225e33 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I305e5e2b0ad9f0f1ec8b6495d5c35a531595f889 Reviewed-on: https://chromium-review.googlesource.com/c/1490093Reviewed-by:
-
Caitlin Fischer authored
Logging will now only occur when one of the two cards being compared is a masked card and the two cards' last four digits match. Previously, logging was occuring regardless of whether or not the last four digits matched. Change-Id: I1a0d9d44df52cf9b6853dbaab041d05a1585e230 Reviewed-on: https://chromium-review.googlesource.com/c/1486431Reviewed-by:
-
Juan Antonio Navarro Perez authored
Start with a simple file adding pointers for further documentation of `run_benchmark` command. Follow up CLs can add on top by documenting other scripts in this directory. Bug: 922030 Change-Id: Ife3e22246746c416abf70ca0b0e92c2b51e2819d Reviewed-on: https://chromium-review.googlesource.com/c/1489231Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#635765}
-
- 26 Feb, 2019 2 commits
-
-
Austin Eng authored
This sets up the WebGPUImplementation to extend the right interfaces so we can later serialize commands into transfer buffers and receive the return command stream from the WebGPUDecoder. Bug: 877147 Change-Id: If707ad59de03f3e5a8f46423adc0249a22fb78a4 Reviewed-on: https://chromium-review.googlesource.com/c/1481614Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#635764}
-
Xiaocheng Hu authored
[Sheriff] Disable org.chromium.chrome.browser.autofill.AutofillPopupTest#testClickAutofillPopupSuggestion Tbr: rouslan@chromium.org NoTry: True Bug: 936183 Change-Id: I3003f32ee02103ab33b2b8fa0006e7df08245028 Reviewed-on: https://chromium-review.googlesource.com/c/1490501Reviewed-by:
-
