GitLab

I had added a hack in http://codereview.chromium.org/196007 to mimic a
behavior of how rc.exe replaces \n with a newline.  Unfortunately, this
didn't make it possible to have legitimate uses of \n in a string.

Instead, remove all occurrences of \n in preparation of removing this hack.

BUG=105985

Review URL: http://codereview.chromium.org/8757009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112526 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105941
TEST=Verify NTP4 page continues to function properly.
Review URL: http://codereview.chromium.org/8760003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112525 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST={content,media}_unittests,test_shell_tests,trybots


Review URL: http://codereview.chromium.org/8764002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112523 0039d316-1c4b-4281-b951-d872f2087c98

I added these accelerators based on the following sources in the Chromium OS window_manager.git:
- layout2/layout_manager2.cc
- window_manager.cc

BUG=97255
TEST=Manual


Review URL: http://codereview.chromium.org/8689003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112522 0039d316-1c4b-4281-b951-d872f2087c98

Be more careful when calling methods on chromeHidden. If chromeHidden didn't have the method before, it would stop the current stack because of an unhandled try/catch.

BUG=100401
TEST=described in bug

Review URL: http://codereview.chromium.org/8759018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112521 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79722
TEST=compiles


Review URL: http://codereview.chromium.org/8743021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112518 0039d316-1c4b-4281-b951-d872f2087c98

This was accidentally broken in http://codereview.chromium.org/8573018 .

BUG=105970
TEST=none


Review URL: http://codereview.chromium.org/8775018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112516 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=memory bot happiness


Review URL: http://codereview.chromium.org/8775017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112515 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105046
TEST=none


Review URL: http://codereview.chromium.org/8769010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112514 0039d316-1c4b-4281-b951-d872f2087c98

The UI is currently only implemented on Windows.  This CL will disable the
enhanced protection for all non-Windows OSes by simply not sending any
server request and always returning a SAFE verdict to API clients.

BUG=102540
TEST=No visible change. Run all unit-tests for DownloadProtectionServiceTest.


Review URL: http://codereview.chromium.org/8724014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112513 0039d316-1c4b-4281-b951-d872f2087c98

I basically turned off everything that is turned on in the root DEPS file, and then selectively turned stuff on. I had to provide some macros to replace the use of base/compilerspecific.h and build/buildconfig.h.

I'm not sure if we have a coherent understanding of private vs trusted yet, but my thinking is that trusted can do anything, but private can't use trusted (it sounds like we may start selectively exposing some private interfaces to installed apps).

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8764004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112512 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105954
TEST=Manual


Review URL: http://codereview.chromium.org/8758001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8651005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112510 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23472
TEST=Go to chrome://settings/internet, should not see import network settings option.

Review URL: http://codereview.chromium.org/8764008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112509 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23124
TEST=Network configuration continues to work, options are locked down for policy-configured networks.


Review URL: http://codereview.chromium.org/8726008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112508 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23124
TEST=Network configuration continues to work, options are locked down for policy-configured networks.


Review URL: http://codereview.chromium.org/8726007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112507 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103986
TEST=Checked all the accelerator text shown in the menu equal to the ones on non-Aura Chrome OS.


Review URL: http://codereview.chromium.org/8773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112506 0039d316-1c4b-4281-b951-d872f2087c98

BUG=85132
TEST=NONE


Review URL: http://codereview.chromium.org/8760021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112505 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106010
TEST=

Review URL: http://codereview.chromium.org/8770014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112504 0039d316-1c4b-4281-b951-d872f2087c98

2 parts:
- not all RenderWidgetHosts are RenderViewHosts
- correctly set window/viewport size regardless of order of RenderWidgetFullscreenPepper::OnResize vs RenderWidgetFullscreenPepper::CreateContext

BUG=101848
TEST=Pepper Flash on Youtube, go fullscreen


Review URL: http://codereview.chromium.org/8758017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112503 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8764005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112502 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103949
TEST=manual


Review URL: http://codereview.chromium.org/8729042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112501 0039d316-1c4b-4281-b951-d872f2087c98

Make TaskManager not use ChildProcessInfo. After this change, I will make BrowserChildProcessHost not derive from ChildProcessInfo, and just remove that struct completely.

BUG=98716
Review URL: http://codereview.chromium.org/8764021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112500 0039d316-1c4b-4281-b951-d872f2087c98

The previous attempt read values from the valuator without properly checking if
the valuator is set or not. This resulted in incorrect location at times (when X
or Y didn't change). So this change makes sure the valuator is set correctly
before reading from it.

BUG=103981
TEST=manually (on desktop and device)

Review URL: http://codereview.chromium.org/8634009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112499 0039d316-1c4b-4281-b951-d872f2087c98

New API used:

gtk_widget_get_window - replaces direct access
gtk_widget_get_allocation - added in 2.18 - replaces direct access
gdk_window_get_width / gdk_window_get_height added in 2.24 - replaces
deprecated gdk_window_get_size so is added to ui/base/gtk/gtk_compat.h

With these changes the file can be compiled with sealed structures and
deprecated API disabled with the exception of the deprecated function
gdk_bitmap_create_from_data used in the cursor creation. That will come in a
separate change.

BUG=79722
TEST=Compiles and chrome runs


Review URL: http://codereview.chromium.org/8635018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112498 0039d316-1c4b-4281-b951-d872f2087c98

You are asked to review this as you have OWNERS for these files.

BUG=None
TEST=Compiles
R=tim@chromium.org


Review URL: http://codereview.chromium.org/8699011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112497 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cbentzel@chromium.org
BUG=106010
TEST=none


Review URL: http://codereview.chromium.org/8758019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112496 0039d316-1c4b-4281-b951-d872f2087c98

Reapply of http://codereview.chromium.org/8632023/
CLs 8710002 and 8671004 should fix various build issues
related to CrOS and other builders.

Remove include of untrusted.gypi in normal ppapi gyp files
to prevent WebKit from depending on NaCl.

Refactor PPAPI gyp files to pull out source lists which are
shared between trusted and untrusted targets.

Fix scons hack which pulls list of sources from GYP so that
we can build with scons.

This CL should allow us to revert the DEPS change:
http://trac.webkit.org/changeset/101011 on the webkit side

Submitting tbr to avoid more build change collisions.
TBR= bradnelson@chromium.org
Please review the scons interaction with ppapi_sources.gypi
Review URL: http://codereview.chromium.org/8727029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112495 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112494 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 389f3285de9ce81ef8931b27b7a01af40d199efa.

Review URL: http://codereview.chromium.org/8772010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112493 0039d316-1c4b-4281-b951-d872f2087c98

Dispatch the Windows font caching IPCs in one filter. This avoids having the code that calls those functions be duplicated and also makes the chrome service code not know about internal content IPCs. It also cleans up ChildProcessHost a bit, which will be useful when it gets an interface around it for the Content API.

BUG=98716
Review URL: http://codereview.chromium.org/8759013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112492 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105792
TEST=NONE
Review URL: http://codereview.chromium.org/8774009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112491 0039d316-1c4b-4281-b951-d872f2087c98

This code only needs to access a few static fontconfig-related
methods, so use the minimal WebKit::initializeWithoutV8()
instead of the full initialize() (the same call is used by the
browser's in_process_webkit).

Review URL: http://codereview.chromium.org/8748015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112490 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112489 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61619


Review URL: http://codereview.chromium.org/8770009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112488 0039d316-1c4b-4281-b951-d872f2087c98

TBR=adamk, rogerta, bradnelson, tbroch, rcui, kochi

BUG=
TEST=

Review URL: http://codereview.chromium.org/8775016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112487 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105958
TEST=manually, double clicked title bar of a window in aura_shell. The window
maximized.

Review URL: http://codereview.chromium.org/8763020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112486 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8760022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112485 0039d316-1c4b-4281-b951-d872f2087c98

Before, we were "feeding" the driver in the callback when OS returned audio
buffer to us. MSDN disallows that, but We were avoiding deadlock when stopping
the stream by using some clever tricks. Unfortunately, exactly the same
deadlock happens when Windows were draining audio stream when switching
the device, and our tricks did not help, as we were not controlling exact timing.

Fix is to separate receiving freed buffer and "feeding" audio driver. Now we are
using CALLBACK_EVENT wave out mode in which Windows signal event when buffer runs
out of data, and using RegisterWaitForSingleObject() so our callback is called by
one of thread pool threads.

Stopping of playback became slower because now it is synchronous. If that ever
become a problem we can use singleton that keeps track of the playing audio
streams, than stopping can become instaneous, at a cost of more complex checks
in the callback.

Unfortunately, no automatic test, as there is no documented way to programmatically
switch default audio device on Windows. People were able to figure it out (see
http://www.daveamenta.com/2011-05/programmatically-or-command-line-change-the-default-sound-playback-device-in-windows-7/),
but there is no guarantee it will continue to work in Win8, or even in next Service Pack
for Win7.

BUG=41036

TEST=Play any HTML5 audio/video on Windows and change default audio device
TEST=using "Control Panel | Sound". There should be no hang, you should hear
TEST=audio from the newly chosen device.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112147

Review URL: http://codereview.chromium.org/8591028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112484 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sail@chromium.org
BUG=106041
TEST=Heapcheck bot 2

Review URL: http://codereview.chromium.org/8769014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112483 0039d316-1c4b-4281-b951-d872f2087c98