GitLab

The SafeBrowsing code tracks more types of redirects than the /net code which strictly adheres to spec and so can drop various types of redirects which can obscure the referrer chain.

BUG=685905

Review-Url: https://codereview.chromium.org/2779643002
Cr-Commit-Position: refs/heads/master@{#468389}

BUG=681705

Review-Url: https://codereview.chromium.org/2856613002
Cr-Commit-Position: refs/heads/master@{#468388}

SkCanvas.h will no longer pull SkBitmap.h and SkImage.h:
https://skia-review.googlesource.com/c/14904.

Include these explicitly, where needed.

TBR=

Review-Url: https://codereview.chromium.org/2853833002
Cr-Commit-Position: refs/heads/master@{#468387}

BUG=

Review-Url: https://codereview.chromium.org/2849973003
Cr-Commit-Position: refs/heads/master@{#468386}

This reverts commit da1b049f.

The original patch landed before the first flake, so I don't think
this is it. Reverting revert.

OPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
R=eustas@chromium.org,holte@chromium.org,rdsmith@chromium.org,holte@chromium.org,mmenke@chromium.org
TBR=eustas@chromium.org,holte@chromium.org,rdsmith@chromium.org,holte@chromium.org,mmenke@chromium.org
BUG=716594

Review-Url: https://codereview.chromium.org/2852123002
Cr-Commit-Position: refs/heads/master@{#468385}

These seem to be consistently failing on the bots.

BUG=none
TEST=none
R=jonross@chromium.org

Review-Url: https://codereview.chromium.org/2853733005
Cr-Commit-Position: refs/heads/master@{#468384}

This way we don't try to find tracing on disk, which as there is no
data_dep is out of date.

BUG=none
TEST=none
R=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2854633002
Cr-Commit-Position: refs/heads/master@{#468383}

arc::ArcProcess has a relatively complex operator<() which should be
paired with a test. I'd add this before adding more changes for
crbug.com/706048.

BUG=None
TEST=try

Review-Url: https://codereview.chromium.org/2853633002
Cr-Commit-Position: refs/heads/master@{#468382}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2841723002
Cr-Commit-Position: refs/heads/master@{#468381}

BUG=

Review-Url: https://codereview.chromium.org/2838993002
Cr-Commit-Position: refs/heads/master@{#468380}

Prevent print preview error state from being unrecoverable by resetting
the state when the user selects a new printer. Add test to check that
the state resets and to check that the response to the INVALID_SETTINGS
event is correct.

BUG=708834
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2849733002
Cr-Commit-Position: refs/heads/master@{#468379}

This CL implements a class and some geometry tools to manipulate the viewport
on a mobile client. For now this is only for iOS only. Later we should try to
also use this on Android to reduce platform-specific codepaths.

Review-Url: https://codereview.chromium.org/2843373005
Cr-Commit-Position: refs/heads/master@{#468378}

BUG=717092
TEST=Bot goes green.

Review-Url: https://codereview.chromium.org/2852923003
Cr-Commit-Position: refs/heads/master@{#468377}

This reverts commit f07732ec
(https://codereview.chromium.org/2791933004)
and reapplies b6d0c9a0
(https://codereview.chromium.org/2690183002/).

BUG=653916, 707986
TBR=jam@chromium.org, rkaplow@chromium.org
Previously reviewed at https://codereview.chromium.org/2690183002/

Review-Url: https://codereview.chromium.org/2856583002
Cr-Commit-Position: refs/heads/master@{#468376}

BUG=716201

Review-Url: https://codereview.chromium.org/2853843002
Cr-Commit-Position: refs/heads/master@{#468375}

This is the first step of deprecating Native App Launcher. This step
removes the functionality from Chrome so testing can start.

There will be lots of dead code and unused classes/methods left after
this step and they will be pruned in subsequent CLs.

BUG=711511
TEST=Tools > Settings > Google Apps should not be there. Visits to Maps or YouTube sites will not show infobar. Tapping on Maps or YouTube links may still launch Maps and YouTube app because of Universal Links.

Review-Url: https://codereview.chromium.org/2821453003
Cr-Commit-Position: refs/heads/master@{#468374}

to serve as the base class for all QUIC tests.

This includes code to flip flags back to their default values.

Merge internal change: 154732382

BUG=

Review-Url: https://codereview.chromium.org/2848203002
Cr-Commit-Position: refs/heads/master@{#468373}

This is needed for proper latency reporting in Mus and in fact also in classic
Chrome now that renderers submit compositor frames over Mojo.

BUG=686865

Review-Url: https://codereview.chromium.org/2847553003
Cr-Commit-Position: refs/heads/master@{#468372}

BUG=

Review-Url: https://codereview.chromium.org/2850983002
Cr-Commit-Position: refs/heads/master@{#468371}

Enable post script printing by default, modify flag to turn off the
feature so that it can be used as a killswitch if needed.

Also remove the print scaling histogram entries as they are no longer
needed (see https://codereview.chromium.org/2834453004/)

BUG=706218

Review-Url: https://codereview.chromium.org/2847273002
Cr-Commit-Position: refs/heads/master@{#468370}

This change ensures that the pending container policy is used (along with the
pending sandbox flags) when constructing a new renderframe to support a cross-
origin navigation.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Bug: 716478
Change-Id: Ib6b46ea639e660527e4e144845dcaea4b8e2695f
Reviewed-on: https://chromium-review.googlesource.com/490466Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468369}

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584
R=gab@chromium.org
TBR=emircan@chromium.org, tdresser@chromium.org

Review-Url: https://codereview.chromium.org/2846933002
Cr-Commit-Position: refs/heads/master@{#468368}

This UMA metric tracks the number of icons requested to create per
JumpList update. The actual number of icons created may be less if it
fails to create certain icons due to random reasons.

Since I've landed some CLs reducing this number and will try to
further reduce it, I think this metric should be re-enabled to track
the progress.

BUG=40407, 179576, 715902

Review-Url: https://codereview.chromium.org/2848763002
Cr-Commit-Position: refs/heads/master@{#468367}

A tooltip for the app menu button is currently not displayed, although it is
defined in Toolbar.xib. In viewDidLoad: of ToolbarController, we replace the
app menu button from the xib with an AppToolbarButton instance for the material
design, so we need to explicitly set a tooltip for it again.

BUG=716749

Review-Url: https://codereview.chromium.org/2851063003
Cr-Commit-Position: refs/heads/master@{#468366}

This CL was reverted because of flakiness on try jobs that
ran on early patch sets. Errors were fixed on the patch set
that landed.

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2770783002
Cr-Original-Commit-Position: refs/heads/master@{#466677}
Committed: https://chromium.googlesource.com/chromium/src/+/b67baf11ed95e0e7eb570d99b6de407e48d89476
Review-Url: https://codereview.chromium.org/2770783002
Cr-Commit-Position: refs/heads/master@{#468365}

Two major things here:
- The bar is no longer relaid-out directly in response to changes in view size, bookmark model etc. Instead, a new UI-direction-agnostic view model (BookmarkBarLayout) is created from the current state, and if it's different from before, it's applied to the view.
- Removed a bunch of layout-related code that's no longer necessary

BUG=648560

Review-Url: https://codereview.chromium.org/2751573002
Cr-Commit-Position: refs/heads/master@{#468364}

BUG=705252

Review-Url: https://codereview.chromium.org/2850183002
Cr-Commit-Position: refs/heads/master@{#468363}

An alias is when multiple names map to the same symbol. This happens a
lot with small member functions (e.g. getters), as well as with C++
templates. The .map file choses only one name for each symbol, but using
nm we can recover the complete list.

A shared symbol is one that exists in multiple .o files. The linker map
picks one path to attribute the symbol to, but using nm we can recover
the complete list of .o files containing the symbol.

For aliases, each one is stored as a separate Symbol entry, and a new
attribute "pss" returns size / num_aliases.

For shared symbols, rather than storing all paths for a symbol, the
paths are altered to be the common ancestor. E.g.:
/a/b/c.o and /a/d/f.o --> /a/{shared}/2  (2 is the number of paths)

For ChromePublic.apk:
* 17717 symbols have shared ownership (991402 bytes)
* Contains 83869 aliases, mapped to 9209 addresses (550582 bytes)

BUG=708865

Review-Url: https://codereview.chromium.org/2851473003
Cr-Commit-Position: refs/heads/master@{#468362}

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584
R=gab@chromium.org
TBR=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2846723005
Cr-Commit-Position: refs/heads/master@{#468361}

This CL:
* Updates the API code to make better use of user_manager::User.
* Adds an isSUpervised property to usersPrivate::User.
* Hides the email address for supervised users and whitelisted users not on the device (where the name is unknown).
* Adds CrScrollableBehavior to the user list so that top and bottom borders for the list display properly.
* Adds a requestUpdateScroll method to CrScrollableBehavior so that borders are set properly when the list updates (in addition to when it scrolls).

BUG=715518
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2840313002
Cr-Commit-Position: refs/heads/master@{#468360}

Recovery count is used to track the recovery behavior of Chrome OS
users.

BUG=693754

Review-Url: https://codereview.chromium.org/2844493003
Cr-Commit-Position: refs/heads/master@{#468359}

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL23.

Purpose of this CL:
Stop service when last client disconnects. Once we host it in a separate process, this will allow the service to automatically restart when a new request comes in.

Changes in this CL:
* Split class video_capture::ServiceImpl into two classes
  ServiceManagerServiceImpl and VideoCaptureServiceImpl.
* In class ServiceManagerServiceImpl, following the example of ImageDecoder [2],
  use a ServiceContextRefFactory to manage service lifetime and implement a
  delayed service shutdown when there are no clients.
* Add tests ServiceQuitsWhenNoClientConnected and
  ServiceQuitsWhenClientDisconnectsWhileUsingDevice
* In service.mojom, add a method for setting the service shutdown delay.
  For the automated tests, set the delay to zero.
* In DeviceFactoryMediaToMojoAdapter, make sure that
  |capture_system_->GetDeviceInfosAsync()| is called before
  |capture_system_->CreateDevice()|. This is required by the implementation
  VideoCaptureSystemImpl in order to fill the cache |devices_info_cache_|.
* In DeviceMediaToMojoAdapter, unsubscibe from
  |receiver.set_connection_error_handler()| in order to avoid use after free
  on service shutdown.
* In ReceiverMojoToMediaAdapter, introduce class ReceiverOnTaskRunner in order
  to ensure that mojom.Receiver methods are posted to the correct thread.
* In VideoCaptureDeviceClient, allow |external_jpeg_decoder_| to be nullptr,
  since in the context of the video_capture service, this will (for now) be the
  case.

BUG=584797
TEST=
  service_unittests --gtest_filter="*Video*"
  content_unittests --gtest_filter="*Video*"
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing
[2] https://cs.chromium.org/chromium/src/services/data_decoder/data_decoder_service.cc?dr=CSs

Review-Url: https://codereview.chromium.org/2824883005
Cr-Commit-Position: refs/heads/master@{#468358}

Currently, an empty temp file is created before a JumpList icon's
content is written to it. However, the temp file is not deleted right
away if the content writing fails, which explains why there're empty
icon temp files in the jumplist folder sometimes. This indicates we're
leaking temp files and may cause performance issues.

This CL fixes this issue by deleting the empty temp files right away
when necessary.

BUG=40407, 179576, 715902, 716601

Review-Url: https://codereview.chromium.org/2852763003
Cr-Commit-Position: refs/heads/master@{#468357}

BUG=716029

Review-Url: https://codereview.chromium.org/2854503002
Cr-Commit-Position: refs/heads/master@{#468356}

If a download is interrupted on start, notification is not posted.
However, the download will show up in download home.
This CL fixes the issue by allowing interrupted downloads to post new notifications.

BUG=714798

Review-Url: https://codereview.chromium.org/2848723004
Cr-Commit-Position: refs/heads/master@{#468355}

Final experiment results here: https://bugs.chromium.org/p/chromium/issues/detail?id=682041#c18

BUG=682041

Review-Url: https://codereview.chromium.org/2850653002
Cr-Commit-Position: refs/heads/master@{#468354}

This reverts commit 14d9d00f.

Reverting in hopes of fixing 716594. See it for details.
I had to do this manually as codereview complained about file being
too big.

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
R=eustas@chromium.org,holte@chromium.org,rdsmith@chromium.org,holte@chromium.org,mmenke@chromium.org
TBR=eustas@chromium.org,holte@chromium.org,rdsmith@chromium.org,holte@chromium.org,mmenke@chromium.org
BUG=716594

Review-Url: https://codereview.chromium.org/2849193002
Cr-Commit-Position: refs/heads/master@{#468353}

And remove the now unused test related classes.

BUG=707057
TEST=test only changes
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2847283002
Cr-Commit-Position: refs/heads/master@{#468352}

Make sure save as PDF sets DPI to a nonzero value. Since we now check it
in Windows, if the job settings were previously invalid it will crash if
the printer does not reset them correctly.

BUG=None

Review-Url: https://codereview.chromium.org/2847003007
Cr-Commit-Position: refs/heads/master@{#468351}

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
----------------------------------------------------------
| BEFORE                   | AFTER                       |
----------------------------------------------------------
| AcceptedCardTypes        | AcceptedIssuerNetworks      |
| basic_card_payment_type  | basic_card_issuer_network   |
| BasicCardPaymentType     | BasicCardIssuerNetwork      |
| "card type"              | "card issuer network"       |
| CardTypeInfo             | CardIssuerNetwork           |
| card_type                | issuer_network              |
| CardTypes                | CardIssuerNetworks          |
| CreditCardType           | CardNetwork                 |
| CreditCard::type         | CreditCard::network         |
| masked_credit_cards.type | masked_credit_cards.network |
| TypeAndLastFourDigits    | NetworkAndLastFourDigits    |
| TypeForDisplay           | NetworkForDisplay           |
| TypeForFill              | NetworkForFill              |
| TypeForMaskedCard        | NetworkForMaskedCard        |
| CardTypeForBasicCardPaymentType |                      |
|               | IssuerNetworkForBasicCardIssuerNetwork |
----------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants have been removed because they were not used
  anywhere.

BUG=602665

Review-Url: https://codereview.chromium.org/2844463004
Cr-Commit-Position: refs/heads/master@{#468350}