- 03 Feb, 2020 40 commits
-
-
arthursonzogni authored
Instead of sending this using this path: blink internal -> blink public -> content/renderer -> content/browser Use: blink internal -> content/browser This avoid crossing many layers and converting in between all the required structs. There were two APIs using WebContentSecurityPolicy. One is left: BeginNavigation. Once BeginNavigation is moved to blink, all the blink::WebContentSecurityPolicy (+5 classes) can be removed. Bug: 1043182 Change-Id: I61625cc189ba85b1e953b1ad88b3a28da9928d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014453Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#737835}
-
Lukasz Anforowicz authored
An earlier CL (https://crrev.com/c/1970834) realized that IME tests depend on focus/activation state of the browser window, and to fix test failures moved OutOfProcessPPAPITest.ImeInputEvent test from browser_tests to interactive_ui_tests. In this CL we speculate that the flakiness tracked in https://crbug.com/135403 was caused by running focus-dependent tests in browser_tests + that the flakiness is gone now and the tests can be re-enabled on Linux and Windows. Fixed: 135403 Change-Id: I2b650b213fea722d82cb8e45b792f7c2d0da576f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995500 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#737834}
-
Roman Sorokin authored
This CL fixes system tray still shows "Sign in to another user..." button when all the available users are deleted. Fixed: 955395 Change-Id: I19b6812a27a7c0a0855354bfdd5bed211b934228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034529Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737833}
-
Łukasz Anforowicz authored
This reverts commit ad44950e. Reason for revert: Test flakiness reported in https://crbug.com/1047941 Original change's description: > Relax request_initiator_site_lock checks for PDF plugin. > > In some scenarios (e.g. http range requests for linearized PDFs) the PDF > plugin may need to initiate requests on behalf of the PDF's origin. > Such requests are currently proxied by the renderer process hosting the > plugin (i.e. the renderer hosting the PDF extension - > mhjfbmdgcfjbbpaeojofohoefgiehjai) and therefore go through > URLLoaderFactory that is locked via request_initiator_site_lock to a > different origin (i.e. the origin of the PDF extension, rather than the > origin of the website that hosts the PDF file). > > Before this CL, such requests would be classified by > CorsURLLoaderFactory::IsSane and > VerifyRequestInitiatorLockWithPluginCheck as incorrect and possibly > malicious. After this CL, the request_initiator checks are relaxed by > PluginServiceImpl::FindOrStartPpapiPluginProcess using a new mechanism > similar to AddCorbExceptionForPlugin exemption available for Flash. > > We don't want to relax request_initiator_site_lock checks for renderer > processes hosting arbitrary origins from the web, so as a > defense-in-depth the CL adds a CHECK to FindOrStartPpapiPluginProcess > that verifies the origin lock of the renderer process that is granted > the extra capabilities. > > Relevant tests: > - ChromeFindRequestManagerTest.FindInChunkedPDF (tests that range > request do not result in a request initiator lock mismatch) > - PDFExtensionTest.EnsureInternalPluginDisabled (tests that the PDF > plugin may only be embedded in trustworthy contexts) > - PDFExtensionTest.RedirectsFailInPlugin (the 'noRedirectsSucceed' testcase > tests non-range requests initiated by the PDF plugin) > > Bug: 1027173b > Change-Id: Ib5111fd7a5d5b31727a9754c46c316e75def5143 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986923 > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737503} TBR=creis@chromium.org,nasko@chromium.org,yhirano@chromium.org,lukasza@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027173b Change-Id: Icc030c676025c042b7647f5ac265511bbb6f25cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035857Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#737832}
-
Andrew Grieve authored
Bug: 1039421 Change-Id: I236accef33d27ff801c362fa6b46a7ddb61a0d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032805 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#737831}
-
Mila Green authored
This adds a new function to mount an updater DMG and run its installer script, as well as a test to verify that functionality. Bug: 1031552 Change-Id: Ica62c90f2a613ed3bd6f1a0dd215dd431fdec58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018150 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#737830}
-
Daniel Rubery authored
Upon feedback from UX, we should be using GetErrorIconSize() in the APP deep scanning prompts. Bug: 1048199 Screenshot: https://screenshot.googleplex.com/CxJwRFQ66UQ.png Change-Id: I9eba847f297520b1f3c5879bf8f748c0c69ad9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033753 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737829}
-
Gauthier Ambard authored
The feature has been launched, no need to explicitly enable it. Bug: none Change-Id: Id73b232d7df9c9726966f74dcedfbe0cfd4cc383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034528 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737828}
-
John Budorick authored
Created by https://ci.chromium.org/b/8889586384407014320 Bug: 922145 Change-Id: Icc08f6d01c001ddaae52e62389d80ffe68f678cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035304 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#737827}
-
Xiaoqian Dai authored
Bug: None Change-Id: I0204923c6fc55f3318471041a68515c4fe391954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035859Reviewed-by:
Mitsuru Oshima (slow in TOK) <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#737826}
-
Sammie Quon authored
Also change some ui codes to use new AddChildView. Ran overview enter exit tast test and did not see a noticeable increase in smoothness. But removing layers means we'll likely have less renderpasses in other scenarios, so I think it's still good to do. Also, reduces GPU memory when alt tab is shown. Test: manual Change-Id: Icb1ab23a41adc8f5ecd15c5301f2d041da463ae4 Fixed: 1047020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030047 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#737825}
-
gogerald authored
The issue this CL solves should happen very rarely. Screenshot without feed in single pane: https://drive.google.com/a/google.com/file/d/10BPinS2HA0ciF6TbAJILNoYK9M-8WHAo/view?usp=sharing When there is no Tabs: https://drive.google.com/a/google.com/file/d/1r5_NJO-e1osd2bajyOM24B9ePR_QJI1F/view?usp=sharing Bug: 1047488 Change-Id: I3844a162e1e3e4206738bc8ca60cffbb01093489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031441 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737824}
-
Henrique Nakashima authored
Instead of runNowOrAfterNativeInitialization(), the method should enqueue tasks to run when full browser starts, and not when native is started. There is a distinction - reduced mode means native is started but full browser, which includes Profiles, isn't. This fixes a crash when transitioning from reduced mode to full browser if a task that uses Profile was scheduled with runNowOrAfterNativeInitialization(). Now, it will only run after the transition, rather than immediately. Also change hasNativeInitializationCompleted() to isFullBrowserInitialized() and update clients. All but DownloadMetrics are meant to run in full browser, so that should actually revert their behavior back to what it was before reduced mode was introduced. DownloadMetrics still checks if native was loaded, which includes in reduced mode. Bug: 1045945, 1014098 Change-Id: Icdeed1ad6a1999fe518c551c404285170a7118e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032049Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#737823}
-
Lukasz Anforowicz authored
When an extension message is received, we check `MessageSender.id` to disallow requests from unknown clients. Unfortunately, `MessageSender.id` is currently not trustworthy (issue 982361) and therefore this CL switches to using `MessageSender.origin` instead. Bug: 10321587 Change-Id: I25e94ff9fafb9aaca4d1b8f933ef472f58cd2c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031664Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#737822}
-
Kyle Milka authored
Change-Id: I1841cacc92eded2fa3592b44976c9b2ee0322d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032337Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#737821}
-
David Manouchehri authored
Change-Id: I216576a94ceeb210800d318dab39d39801c26509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035856 Auto-Submit: David Manouchehri <david@davidmanouchehri.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#737820}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d6d8abbe40ba..e1a7bef8922f Created with: gclient setdep -r src-internal@e1a7bef8922f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045981,chromium:992974 Tbr: jbudorick@google.com Change-Id: Idc76bd51e7185e3d221d53763dffc9ebb3a1149d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035845Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737819}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/326c900efd28..4546c5cefa0e git log 326c900efd28..4546c5cefa0e --date=short --first-parent --format='%ad %ae %s' 2020-02-03 tdusnoki@inf.u-szeged.hu Skip failing end2end tests on Windows on ARM Created with: gclient setdep -r src/third_party/angle@4546c5cefa0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I12967bd901b98ae93c4c5df79ed1480635ded181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035113Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737818}
-
Lukasz Anforowicz authored
Before this CL, GuestViewBase::GetOwnerSiteURL would return: owner_web_contents()->GetLastCommittedURL() The code above is incorrect for two reasons: 1. It doesn't account for about:blank URLs 2. It doesn't work before |owner_web_contents()| commit their first navigation. Problem #2 is what happens when a new, blank popup is opened and then written to via document.write. In such scenario, GetOwnerSiteURL would return an invalid URL which incorrectly caused PDF rendering pipeline to fail by rejecting invalid URLs in URLPattern::MatchesURL: URLPattern::MatchesURL() extensions::URLPatternSet::MatchesURL() extensions::SimpleFeature::GetContextAvailability() extensions::SimpleFeature::IsAvailableToContext() extensions::ExtensionsGuestViewManagerDelegate::IsGuestAvailableToContext() ^- IsGuestAvailableToContext passes result of GetOwnerSiteURL to IsAvailableToContext above guest_view::GuestViewBase::Init() guest_view::GuestViewManager::CreateGuest() extensions::MimeHandlerViewEmbedder::CreateMimeHandlerViewGuest() Bug: 1041880 Change-Id: I252a15e464d70a7131c101b4f4889fa9fa968a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023047Reviewed-by:Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#737817}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d4f68317fe3a..fb3951000894 git log d4f68317fe3a..fb3951000894 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 jvanverth@google.com Reland "Wrap page index packing in helper methods." 2020-02-03 scroggo@google.com Update link to BreakingTheBuildBots bugs Created with: gclient setdep -r src/third_party/skia@fb3951000894 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I29da2695e2e61bf7a63fa77f16d5898fb9a433c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035838Reviewed-by:
-
Michael Thiessen authored
In migrating the TestWebServer to use GURL, I needed to add a native library to the weblayer shell, allowing it to use the native GURL code. Bug: 783819 Change-Id: I14b13f242b6ddf9367c2b0f29c0a1665eae6da78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026112 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737815}
-
Weiliang Chen authored
When viz::Display receives swap buffers ack, it checks that |renderer_| is not null. This implies this function could be called after |renderer_| is deleted. By the same logic we would need to check for |overlay_processor_| not being null either. Bug: 1048041 Change-Id: Ib57ee5151eaae3b885c55f478959f747a96ab837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035301Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#737814}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f2be3eff26fd..2181228624d1 git log f2be3eff26fd..2181228624d1 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 ilnik@webrtc.org Revert "[VP9] Shift spatial layers on RTP level to always start from 0." 2020-02-03 kron@webrtc.org Move spec of experimental RTP header extensions to source repository Created with: gclient setdep -r src/third_party/webrtc@2181228624d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iefbc5649b21fe77f91dd98bbfe726cb9b980f0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035842Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iee89da30d7535fbdae672d0ffc754d70a2d6b959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035840Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/784967be4d56..91f38e4aa97b git log 784967be4d56..91f38e4aa97b --date=short --first-parent --format='%ad %ae %s' 2020-02-03 skyostil@google.com TrackEvent: Add support for ids, thread and timestamp overrides for legacy events Created with: gclient setdep -r src/third_party/perfetto@91f38e4aa97b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:147743479 Tbr: perfetto-bugs@google.com Change-Id: I265c8e349e89c74e058085d6aa9f1a598096d074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035841Reviewed-by:
-
Rob Schonberger authored
Bug: 1009290 Change-Id: I55866a8d591153bc1ef978b924cdb93a03c68f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033057 Auto-Submit: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#737810}
-
Charlie Hu authored
Since parsing of DocumentPolicy only happens in renderer, there is no need to put Parse as part of DocumentPolicy which gets exposed to browser. This CL separates Parse from DocumentPolicy and puts it in renderer/core. Bug: 993790 Change-Id: I1d7f196c9b47735d947d74c9cd7916f5001ec5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017925Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#737809}
-
Renato Silva authored
Removed the powerwash/reset screen from the list of screens for which the status area will be hidden. This issue only came to light once the functionality of hiding/showing the status tray became possible for the Mojo-based version of LoginDisplayHost -- LoginDisplayHostMojo. This functionality was added in https://crrev.com/c/1926481 Hiding the status area prevents the user from accessing many options that could be necessary, such as networking and accessibility. Fixed: 1045848, 1045851 Change-Id: Ib8b21c6be9587ef4c0c484c23bac0c1150afaa04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031039Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#737808}
-
Alex Chau authored
- As a follow-up of https://crrev.com/c/2012286, follow go/proto-best-practices-checkers#tag_changed to avoid changing tag numbers and add v2_ suffix. - This also brings back previously reserved sender_id_ fields as deprecated so they can still be used by server clients. Bug: 1044607 Change-Id: Ia3df7c72c554e81f421d8644eceadf92734ff34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035870 Commit-Queue: Alex Chau <alexchau@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Auto-Submit: Alex Chau <alexchau@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#737807}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1418552cad29..c0feb63a6ff4 git log 1418552cad29..c0feb63a6ff4 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 pfaffe@chromium.org Enable experiments in e2e tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@c0feb63a6ff4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1047677 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iec919ef6335166de5d9b578cd8f311b77ff52186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035112Reviewed-by:
-
Kamila authored
Bug: 1046341 Change-Id: Ia45fa0be8876e043bd5e9922da6f61995c7d3fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030884 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#737805}
-
Mark Yacoub authored
1. Move DRM SetCrtc and Disable from Crtc Controller Modeset to Plane Manager Atomic/Legacy Modeset to abstract the implementation based on the platform. 2. Move common code from HardwareDisplayController Enable and Modeset to a common function. BUG=987274 TEST=HardwareDisplayPlaneManager*Test.Modeset, HardwareDisplayPlaneManager*Test.DisableModeset Change-Id: Iebc8287d0dad49efa6ddf69306e057c0650e5278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032234 Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#737804}
-
Nicolas Ouellet-Payeur authored
This reverts commit c2b90515. Reason for revert: blocking CQ (crbug.com/1047696) Original change's description: > [Traffic Annotation] Fail on CQ on C++ parsing error > > Previously, CQ would pass if extractor.py failed at parsing the C++ > declaration. With this CL, parsing errors make CQ turn red (to avoid > committing code that will make linux-annotator-rel fail). > > Also, always rerun extractor.py when there's an error to get stderr > contents. Previously, when running with --error-resilient, it wouldn't > re-run the Clang tool. This saved several minutes on CQ, but didn't > report a useful error message. Since extractor.py is _much_ faster, > the tradeoff is different: the error message is more important than > the couple of seconds saved. > > Finally: slightly improve extractor.py's error reporting when it fails > to parse the annotation declaration. This makes it more actionable and > gives better context to the CL author. > > TESTED=traffic_annotation_auditor_unittests, extractor_test.py, > annotation_tokenizer_test.py > > Bug: 1046794 > Change-Id: Id397dcfcced39fbebf72ffcdc6d6549c66c2910f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028707 > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737039} TBR=rhalavati@chromium.org,nicolaso@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1046794 Change-Id: I67764d599a4dd353898c60275c6162c0139961c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033677Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#737803}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 210d8bb5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I9315401c2c9228a3cf63f88205d2c14e0504b980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035700Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737802}
-
Andrew Grieve authored
And tweak README.md build instructions Bug: None Change-Id: Ic092e33392d30b27dd3666593c1e0d601b5617c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032804Reviewed-by:
-
Victor-Gabriel Savu authored
dhe_rsa.patch uses some python 2 only constructs, replace with code that is compatible with both 2 and 3. Bug: chromium:1041448 Test: tast run <ip> policy.* Change-Id: I4bba7c77512a2fb51b9b26a05781767f330da97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035415Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#737800}
-
Omer Katz authored
This CL removes the option to initialize a worklist to less than max_tasks. Having a static number of tasks allows replacing some DCHECKs with static_asserts. Bug: 986235 Change-Id: Ia14792bd946f8ef08606138b56617f90be9cc6ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030970Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#737799}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/352de2b8..24046f60 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I465134111910cb15c7a125eb3d3c5198c644e21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035697Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737798}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8b9cdcbe79ef..094c157fc3f0 git log 8b9cdcbe79ef..094c157fc3f0 --date=short --first-parent --format='%ad %ae %s' 2020-02-01 vapier@chromium.org gs: upgrade gsutil to 4.47 2020-01-31 saklein@chromium.org flash_ap: Fix command run output checking. 2020-01-31 tbegin@google.com packages: update manifest in uprev_ebuild_from_pin Created with: gclient setdep -r src/third_party/chromite@094c157fc3f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I6ca03ef942489cc38cafc3164e81974164ad7e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035835Reviewed-by:
-
Mike Frysinger authored
This was first deprecated 5 years ago, and then disabled 3 years ago (with the disable hitting stable in Jan 2017 in M56). That is way longer than necessary, and it's annoying people who want to use the old shortcut with extensions (e.g. the linkable extension's default). Bug: 492454, 486198, 498565, 405317 Change-Id: Id24b902ff54601f1cd22f6305df4dc54dbe24d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015701Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#737796}
-
