- 09 Mar, 2020 40 commits
-
-
Toni Barzic authored
Currently, we show gesture navigation screen in tablet mode only, though for touch centric devices, the screen should be shown even if the device is in clamshell mode. To achieve this, add support for a command line switch "oobe-force-tablet-first-run" that would force tablet mode flow for the first user run, even if the device is in clamshell during setup. The flag is expected to be passed in by login manager during chrome setup. BUG=976949 Change-Id: I754eb09c4b3ddbb85af2148f5f062e971e6a1e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092696Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#748279}
-
Takashi Toyoshima authored
Following tests were modified or added by https://chromium-review.googlesource.com/c/chromium/src/+/2054468. * http/tests/inspector-protocol/network/xhr-cors-preflight-redirect-failure.js * http/tests/inspector-protocol/network/xhr-post-replay-cors.js They started reaching timeout after the CL, and we won't fix it for Blink CORS. NOTRY=true Bug: 958524, 941297 Change-Id: I349e00a5ff6c7590fc843797e75246bb14413c10 TBR: horo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094902Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#748278}
-
Jan Wilken Dörrie authored
This change adds a pluralized string for the number of compromised passwords. In order to do so it makes use of the recently introduced PluralStringProxy that dispatches to the C++ backend to get the correct string. Bug: 1047726 Change-Id: I1b6223d72e67d5b32690b42c04b5644c5f9da067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093594 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#748277}
-
Rainhard Findling authored
* Makes safety check elements focusable independently of their state. * Attaches dynamic accessibility info to the elements to allow screen readers informing users about their state even in states they would otherwise not be focusable. * DD: http://shortn/_uEauSbBMVy Bug: 1015841 Change-Id: I52d2c932478d6e66661938b08f7d43f5d82a394a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089698Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4869d471b9d6290064162dc83ca65961fdb78eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095337Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748275}
-
John Budorick authored
Disabling all parameterizations of tests disabled in crrev.com/c/2089975. Bug: 1054829 Change-Id: Ifcccfb6040a0eb0637b43aa18b0ff4f845778a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094901Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#748274}
-
Jan Wilken Dörrie authored
This change improves the formatting of elapsed time since a compromised password was found. Time deltas smaller than a minute are now shown as "Just now", while deltas exceeding 30 and 365 days are formatted with months and years, respectively. Bug: 1047726 Change-Id: Ic08bf80ac300724a64fe304e032936ee0968b6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095298Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#748273}
-
jonross authored
Video on Android using Vulkan was broken. This suppresses the failures until the root cause can be fixed. TBR=ynovikov@chromium.org TEST=vulkan_content_browsertests vulkan_pixel_skia_gold_test Bug: 1059724, 1051705 Change-Id: I77abd2bf710620b76c9ddbc1ff56253f72a630fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093912Reviewed-by:Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#748272}
-
Sadrul Habib Chowdhury authored
The INPUT_EVENT_LATENCY_ACK_RWH_COMPONENT component is set from the browser, and immediately looked up in the same cycle. So remove the component, and use the timestamp directly instead. BUG=849719 Change-Id: Id28352d7ad0f56c5b0b89df26c9aa45d3d190f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093019 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#748271}
-
Scott Violet authored
This reverts commit ea173bd3. Reason for revert: Still seeing failure of mini_installertests. Hoping this will fix the flake. Bug is https://bugs.chromium.org/p/chromium/issues/detail?id=1059314 Original change's description: > Fix InstallServiceWorkItemTest deletes Chrome key under ClientState. > > Greg discovered that InstallServiceWorkItemTest.Do_ServiceName will > create Google\Update\ClientState\{8A69D345-D564-463c-AFF1-A69D9E530F96} > if it does not exist and then delete it. If the test is run on a > development machine, it will corrupt the stable Chrome install. > > Bug: 1057233 > Change-Id: I5e71c6ab9776f376dcffe0a415bfb084baec8e26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086353 > Auto-Submit: S. Ganesh <ganesh@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746738} TBR=ganesh@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1057233 Change-Id: I57c3d50264dcf433a123e2802f04a70af8742935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094466Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#748270}
-
David Jean authored
Move from /ios/chrome/browser/settings/ui/password to /ios/chrome/common/reauthenticaton Moved metrics out of it and into (non test) callers. Changed result from BOOL to 3 states enum for success, failure and skipped. The goal is to be able to use it in the credential extension. Bug: 1045455 Change-Id: I94104044c82b637b9d183f07fc6d8ce291e5b7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089864 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#748269}
-
Ali Juma authored
This creates an iOS version of SafeBrowsingService, which handles creating and initializing a SafeBrowsingDatabaseManager, and also handles starting and stopping the database manager depending on the value of the Safe Browsing opt-out preference. Behind the kSafeBrowsingAvailableOnIOS flag, this creates a SafeBrowsingServiceIOS owned by ApplicationContextImpl and initialized during IOSChromeMainParts::PreMainMessageLoopRun. Change-Id: I5eaf3ee1a92ab55ef84eb38936a4818a246f6df9 Bug: 1028755,1049327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044521 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#748268}
-
Stepan Khapugin authored
Moves isTabSwitcherActive, dismissingTabSwitcher to SceneController. Bug: none Change-Id: If90fd2ee706f42a57433beabc3d564058bada511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087401 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#748267}
-
Vasiliy Telezhnikov authored
This CL removes restriction for ext_srgb_write_control for WebGL context types. While extension is not supported in WebGL underlying context might and the GL_FRAMEBUFFER_SRGB must be restores in this case. Bug: 1019787 Change-Id: I9d06b70d6fc712cdfd68f068a68eceaed72166eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091600Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#748266}
-
Vasilii Sukhanov authored
Bug: 1049185 Change-Id: I948f68fb5e7487a072617ed07911fd4d4213f6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094302 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#748265}
-
Friedrich Horschig authored
This CL updates the status according to native events instead and queries the status initially. This enables continuous updates (e.g. during or after a password check). Bug: 1047726 Change-Id: I075a56b4713782cc1df782b93d3569946e8d9ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089769 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Andrew Grieve authored
This will let GN validate that deps are not missed. Note: deps->public_deps needed in order to appease GN's "do you depend on the targets that produce your inputs" check (you can directly depend on them, or indirectly when listed as public_deps). Bug: 1054892 Change-Id: I1f5c752590a259cb932a6ccdf5cf61cbf33d45f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088804 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#748263}
-
Rainhard Findling authored
* Sync extension state names within safety check (see also crrev.com/c/2091353) by using "blocklisted" for potentially problematic extensions. Bug: 1015841 Change-Id: Ib93054834ae8b86c81d2725e1d6d2da70c6bf9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095006Reviewed-by:
-
mark a. foltz authored
The Cast SDK expects a MEDIA_STATUS message with an IDLE player after stopping media. This updates the Cast MRP to send it. Bug: 1040185 Change-Id: Ieae8f30906026d2c9d067aecc31a61bcf9027eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087700Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748261}
-
Andrey Zaytsev authored
Bug: 1059753 Change-Id: I6c36d8729372fb93d35f73c214cf7c253139cd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095067 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Greg Thompson <grt@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#748260}
-
Mason Freed authored
The [1] CL attempted to change the focus ring to #005FCC, but ended up actually changing it to #CC5F00. Because there are no tests (until [2]), this got missed. This CL fixes that. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2088296 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1986972 Bug: 1054813 Change-Id: I0eb848a99efd8d3e99f75ab5335e3453c63ab202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092412 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#748259}
-
Monica Basta authored
As part of friendly settings, the title of the Advanced sync page is changed. Bug: 1043122 Change-Id: Ifd98b613907916f7547e310c1d6c2b8788dfe537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093478Reviewed-by:
-
Takashi Toyoshima authored
Mark as [ Failure ] for now, but bisect and triage would be needed later. NOTRY=true TBR=yhirano@chromium.org, yoichio@chromium.org Bug: 1059776 Change-Id: Icb51c2af1314e2991528d935993144aa4b67d05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093969 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Scott Violet authored
This reverts commit b256ed1f. Reason for revert: I'm hoping reverting this and your other patch will fix the flake. Bug is here: https://bugs.chromium.org/p/chromium/issues/detail?id=1059314 Original change's description: > Better registry cleanup in InstallServiceWorkItemTest. > > mini_installer_tests ChromeUserLevel and ChromeUserLevelUpdate are > failing with the following error: > > AssertionError: In state 'chrome_user_installed_not_inuse', Registry key > HKEY_LOCAL_MACHINE\Software\Chromium exists. > > This is most likely due to the change I made in change 2086353 to delete > a value instead of the key. > > Now the test will delete the key if the test is the one that created the > key in the first place. > > Bug: 1059314 > Change-Id: I2b85e1f4c979c52a41aebb41c4951b60cf58a50a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092939 > Commit-Queue: Greg Thompson <grt@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Auto-Submit: S. Ganesh <ganesh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748062} TBR=ganesh@chromium.org,grt@chromium.org Change-Id: I875c730322f5bc4cc9fdfa8b5497e26f2b8b81da No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095201Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/424d28b0701d..c27e70235ff5 git log 424d28b0701d..c27e70235ff5 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 borenet@google.com [infra] Overhaul gen_tasks_logic Created with: gclient setdep -r src/third_party/skia@c27e70235ff5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I979f73daad7d5e5b3f12f038c86ae6a642fe3a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094609Reviewed-by:
-
Yann Dago authored
When the user deletes browsing data, snapshot files are deleted if they are in relation to the deleted data. Prefs are deleted if one of the deleted data also affects the prefs. Snapshotted data created before the start of the time range where browsing data is deleted will not be affected. Bug: 1052788 Change-Id: I560a844183905a58cdab2c2266869dd91c5b0f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066564 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Anna Malova authored
Bug: 1007815 Change-Id: Icae708380d0ac98643e6620e2d593a240e6872ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089786 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#748253}
-
Justin Miron authored
This adds a new boolean to the Popup.Closed UKM: WindowOpenDisposition. This records the disposition used to create the popup, recorded at the time the pop-up tracker is created. This will be used to better understand how pop-ups are opened and perceived by users in order to identify more abusive pop-up experiences and improve the pop up blocker. BUG=1044601 Change-Id: Ie32bff8f5753eb4210054569058e6df75d5f5258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075138 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#748252}
-
Anna Malova authored
Bug: 1007815 Change-Id: I406a6de24c91a09220cf9a4b5cbba53980b2400b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091745 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1c5d6304..3c2d9f15 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibed682199b00bb672430fe7cb2b6c9b9c6407992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095078Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748250}
-
Marian Fechete authored
This CL introduces the option to customize the informational text shown on the onboarding screen based on the incoming intent. The existing text is kept as a default, and overrides can be set up based on intent strings. Bug: b/150927780 Change-Id: Id49b0adc4210ea621287b32bad45dacc00a63a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094299Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#748249}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5e9dd1d5e265..0d9de2003ea9 git log 5e9dd1d5e265..0d9de2003ea9 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 szuend@chromium.org [utilities] Replace Array#remove with helper in DOMModelUndoStack 2020-03-09 szuend@chromium.org [utilities] Replace Array#remove with helper in AnimationTimeline 2020-03-09 szuend@chromium.org [utilities] Replace Array#remove with ArrayUtilities.removeElement 2020-03-09 szuend@chromium.org [utilities] Port Array#remove to a ArrayUtilities.removeElement helper 2020-03-09 janscheffler@chromium.org Revert "[utilities] Use Set instead of Array in CSSModel for pseudo classes" 2020-03-09 tvanderlippe@chromium.org Monkey-patch tsbuildinfo to make it deterministic 2020-03-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-09 tvanderlippe@chromium.org Use rollup to bundle module entrypoints 2020-03-09 tvanderlippe@chromium.org Add extra information for changed files check 2020-03-09 tvanderlippe@chromium.org Cleanup linter check 2020-03-09 szuend@chromium.org [utilities] Replace Array#remove call-site with Array#filter 2020-03-09 petermarshall@chromium.org Don't disable clear IndexedDB object store button 2020-03-09 szuend@chromium.org Prepare ResourceScriptMapping.js for asynchronous live locations 2020-03-09 szuend@chromium.org [utilities] Use Set instead of Array in CSSModel for pseudo classes Created with: gclient setdep -r src/third_party/devtools-frontend/src@0d9de2003ea9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016,chromium:1046596,chromium:1050549,chromium:1054494,chromium:841126 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0d6f6f1e52cc821e3e5b8267ecf7b370d73df8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094611Reviewed-by:
-
Nicolas Ouellet-Payeur authored
Change-Id: I2a9f6b033b78d610fcae2f0c880613043a403db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089991Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#748247}
-
Michael Crouse authored
Enabled UKM collection for the XSrcset and WSrcset tags for image srcset. See Opt-in instructions here: https://cs.chromium.org/chromium/src/docs/use_counter_wiki.md Srcset usage is fairly low but is likely above the 1% recommended threshold. However, I think several of the other features counted are also higher. Would like to have this available as an experiment for using lower resolution image versions for data savers is run. Bug: 1059444 Change-Id: Id2fba387d85f2c6d8537002d8cf5f6b0e06e36dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092184Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#748246}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6ff5bd12. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id935f1cf36e92a93bb0776627cedb8eece4698f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095235Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748245}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/13188a24a490..2d525fe9bd56 git log 13188a24a490..2d525fe9bd56 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 mbonadei@webrtc.org Fix compile all in debug mode. 2020-03-09 kron@webrtc.org Update ObjC video decoder factory to use same parameters as encoder factory Created with: gclient setdep -r src/third_party/webrtc@2d525fe9bd56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029737 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie88fa0da1fa0ed8141d9f89ff601b841450087f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094610Reviewed-by:
-
Nicolás Peña Moreno authored
This CL adds a test to ensure that FCP is not triggered when there's a textfield with no text but is triggered when there's text. Spec issue: https://github.com/w3c/paint-timing/issues/52 Bug: 1059427 Change-Id: I4cf4f961d43bfa92d6be2abd519a9d8acfde8141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091968 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#748243}
-
Lukasz Anforowicz authored
This CL stops rewriting chrome-devtools: scheme URLs into devtools: scheme URLs, by tweaking //components/url_formatter/url_fixer.cc. This CL also stops special-casing chrome-devtools: scheme in //components/policy/core/browser/url_util.cc. The CL then also proceeds to remove all other mentions of the chrome-devtools: scheme from the codebase. This part of the change was initially done with the following command: $ git grep -l 'chrome-devtools[^-]' | xargs -n 1 \ sed -i -e 's/chrome-devtools/devtools/g' and then manually reviewing and tweaking the edited files. Bug: 1055524 Change-Id: Ie9d51332e4c28fd6201f4b5590bbba5c79fc09d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088335Reviewed-by:Yang Guo <yangguo@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
Bug: 1049185 Change-Id: I9a688339f61d60d943088c413857744d7090e98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094129 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Anatoliy Potapchuk authored
This handler was little bit overcomplicated. This led to a bug in web kiosk mode when we update network state, but do not update the handler. Because of this convolution, in web kiosks, the network configure screen did not update itself when connected to network(which is what client will expect from the handler which observes network state). Now it behaves more logically and predictably. Bug: 1015383 Change-Id: I94eb7d8c1ff60f0f5b4a5843f6e3b2885c63b776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083018 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
-
