GitLab

Revert of EasyUnlock: Work around the ghost overlay from CSS animation. (patchset #3 id:40001 of https://codereview.chromium.org/487373002/)

Reason for revert:
No longer needed since underlying blink issue http://crbug.com/405250 is fixed.

Original issue's description:
> EasyUnlock: Work around the ghost overlay from CSS animation.
>
> BUG=404779
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290743

TBR=tbarzic@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404779

Review URL: https://codereview.chromium.org/521343002

Cr-Commit-Position: refs/heads/master@{#292816}

Cr-Commit-Position: refs/heads/master@{#292815}

https://chromium.googlesource.com/chromium/blink/+log/a00905c53f2a7e9c79d324b3ac36dc8b05fb0e7f..332a56a9d8e5d800e3a1fb8aa69c241d0ce59912
TBR=

Review URL: https://codereview.chromium.org/525163002

Cr-Commit-Position: refs/heads/master@{#292814}

https://skia.googlesource.com/skia/+log/9e19ce1641422857b850cdedaee40927643b2f42..21e613505562368e7719215f824fa8b3b4be652d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/524263002

Cr-Commit-Position: refs/heads/master@{#292813}

Revert of Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes. (patchset #4 id:80001 of https://codereview.chromium.org/521703002/)

Reason for revert:
Breaks InstallerStateTest.InitializeTwice on XP:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481

Original issue's description:
> Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes.
>
> Use registry virtualization so that stale data on the test machines
> don't interfere with the tests.
>
> BUG=375739
>
> Committed: https://chromium.googlesource.com/chromium/src/+/6d6ac988d6a7a311876f3b0d0257086ac58c8181

TBR=robertshield@chromium.org,grt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=375739

Review URL: https://codereview.chromium.org/520863005

Cr-Commit-Position: refs/heads/master@{#292812}

https://chromium.googlesource.com/chromium/blink/+log/244a450e5891380a808296994588063b762f2a63..a00905c53f2a7e9c79d324b3ac36dc8b05fb0e7f
TBR=

Review URL: https://codereview.chromium.org/520383005

Cr-Commit-Position: refs/heads/master@{#292811}

OpenGL/gl.h is required to be included to make the build pass.

BUG=
TEST=

Review URL: https://codereview.chromium.org/522533002

Cr-Commit-Position: refs/heads/master@{#292810}

Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/)

Reason for revert:
Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481

InstallerStateTest.InitializeTwice (run #1):
[ RUN      ] InstallerStateTest.InitializeTwice
c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
  Actual: false
Expected: true
[  FAILED  ] InstallerStateTest.InitializeTwice (219 ms)

InstallerStateTest.InitializeTwice (run #2):
[ RUN      ] InstallerStateTest.InitializeTwice
c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
  Actual: false
Expected: true
[  FAILED  ] InstallerStateTest.InitializeTwice (109 ms)

Original issue's description:
> clang/win: Fix a few warnings in targets not in chromium_builder_tests.
>
> Also don't use "default" as a variable name, as it's a keyword.
> Also fix a bug where a wstring was passed to %ls.
>
> No real behavior change.
>
> BUG=82385
> R=hans@chromium.org
> TBR=cpu, vitalybuka
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09

TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=82385

Review URL: https://codereview.chromium.org/519463003

Cr-Commit-Position: refs/heads/master@{#292809}

https://skia.googlesource.com/skia/+log/7843a24ab2c2dc4fe77e82b9689cde953d6abd7c..9e19ce1641422857b850cdedaee40927643b2f42

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/521283002

Cr-Commit-Position: refs/heads/master@{#292808}

There was a race condition in the added test check in the previous
attempt. That made the test Super Flaky. This is more noticeable in the
Release builds than the Debug build that I was working with.
(see https://codereview.chromium.org/471233003/)

With a Release build I was able to repro the flakiness (40% failure
over 200 runs). After the fix, I tested 500 runs and the success rate
is now 100%. I can't say it won't flake for other reasons, but
this fixes the main flake that was introduced. Historically,
the test does ocassionally need to be retried due to timeouts,
according to the bot log history. We may want to split the
CORS and the non-CORS test case to see if that will help w/ timeouts.

I didn't want to do that for this patch, since it would get
much more complicated and this is intended for merging to M38.

Retry with the race condition fixed. Also re-enable the test since
it got disabled by another CL for being flaky.

BUG=401755
BUG=315328

Review URL: https://codereview.chromium.org/524683002

Cr-Commit-Position: refs/heads/master@{#292807}

Hide registration promos for supervised and guest users. Also hide cloud print
connector section and irrelevant "cloud devices" section (since users cannot log
in).

BUG=288614,340893

Review URL: https://codereview.chromium.org/521953002

Cr-Commit-Position: refs/heads/master@{#292806}

https://chromium.googlesource.com/chromium/blink/+log/dafd1d0b92247b98a38dfa8bc29ceb80e77582f1..244a450e5891380a808296994588063b762f2a63
TBR=

Review URL: https://codereview.chromium.org/528453002

Cr-Commit-Position: refs/heads/master@{#292805}

Was necessary for https://codereview.chromium.org/517213005/.

R=lcwu@chromium.org,damienv@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/526693002

Cr-Commit-Position: refs/heads/master@{#292804}

Depends on https://codereview.chromium.org/495763005/

BUG=406622

Review URL: https://codereview.chromium.org/497273002

Cr-Commit-Position: refs/heads/master@{#292803}

https://chromium.googlesource.com/chromium/blink/+log/3bbc0b2b6d62c60bd38ce576e1af5a68e1e7cb6d..dafd1d0b92247b98a38dfa8bc29ceb80e77582f1
TBR=

Review URL: https://codereview.chromium.org/526703002

Cr-Commit-Position: refs/heads/master@{#292802}

TBR=niklase
NOTRY=true

Review URL: https://codereview.chromium.org/525083002

Cr-Commit-Position: refs/heads/master@{#292801}

Also change remote video and pepper plugin MediaStreamVideoSource implementations to not set a guessed frame rate.

BUG= 394315

Review URL: https://codereview.chromium.org/517973002

Cr-Commit-Position: refs/heads/master@{#292800}

TBR=niklase@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/526683002

Cr-Commit-Position: refs/heads/master@{#292799}

https://chromium.googlesource.com/chromium/blink/+log/b28553bee158127ed49ff22547f909f49ed9e00a..3bbc0b2b6d62c60bd38ce576e1af5a68e1e7cb6d
TBR=

Review URL: https://codereview.chromium.org/521163002

Cr-Commit-Position: refs/heads/master@{#292798}

_GetFileVersionFromCache/_GetFileListingVersionFromCache, because they're
protected not public methods. More importantly, make them return Futures.
Plus a little more cleanup.

These are small changes in preparation to the more interesting patch which
addresses bug 402903.

BUG=402903
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/522183002

Cr-Commit-Position: refs/heads/master@{#292797}

https://skia.googlesource.com/skia/+log/6d134201a90692b0c7a1c0c4a97c894dae7b2158..7843a24ab2c2dc4fe77e82b9689cde953d6abd7c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/521143003

Cr-Commit-Position: refs/heads/master@{#292796}

BUG=none
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/527473002

Cr-Commit-Position: refs/heads/master@{#292795}

https://chromium.googlesource.com/chromium/blink/+log/abff6854093617bd6461c113d1b91f7498b399a0..b28553bee158127ed49ff22547f909f49ed9e00a
TBR=

Review URL: https://codereview.chromium.org/523403002

Cr-Commit-Position: refs/heads/master@{#292794}

BUG=none
R=mukai@chromium.org
TBR=vollick@chromium.org for DEPS addition on //ui/compositor

Review URL: https://codereview.chromium.org/521013004

Cr-Commit-Position: refs/heads/master@{#292793}

See here: https://codereview.chromium.org/516143002/

TBR=ajm

Review URL: https://codereview.chromium.org/523073003

Cr-Commit-Position: refs/heads/master@{#292792}

R=byungchul@chromium.org,isherman@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/506083003

Cr-Commit-Position: refs/heads/master@{#292791}

https://skia.googlesource.com/skia/+log/5c49b70ae3e19620bbecfe72eb68aa4513c4fd18..6d134201a90692b0c7a1c0c4a97c894dae7b2158

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/522163002

Cr-Commit-Position: refs/heads/master@{#292790}

Revert of Disable UI flags for non-desktop OSes (patchset #4 id:60001 of https://codereview.chromium.org/480453002/)

Reason for revert:
This will cause android to lose account consistency. I should not have removed the file!

Original issue's description:
> Disable UI flags for non-desktop OSes
>
> This is mostly to prevent the high res avatars from being downloaded when not necessary, and will also prevent any other non-UI side effects which are undesired on non-desktop OSes.
>
> BUG=404066
>
> Committed: https://chromium.googlesource.com/chromium/src/+/8003a95bb88e1d25ad59251b5d7e8609d76e5669

TBR=noms@chromium.org,rogerta@chromium.org,newt@chromium.org,dzhioev@chromium.org,aruslan@chromium.org,xiyuan@chromium.org,nkostylev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404066

Review URL: https://codereview.chromium.org/524023002

Cr-Commit-Position: refs/heads/master@{#292789}

BUG=408797

Review URL: https://codereview.chromium.org/517343003

Cr-Commit-Position: refs/heads/master@{#292788}

Cr-Commit-Position: refs/heads/master@{#292787}

https://chromium.googlesource.com/chromium/blink/+log/dec670cdd2062a6598b108047c78c455207c9d6a..abff6854093617bd6461c113d1b91f7498b399a0
TBR=

Review URL: https://codereview.chromium.org/524083002

Cr-Commit-Position: refs/heads/master@{#292786}

BUG=

Review URL: https://codereview.chromium.org/498373003

Cr-Commit-Position: refs/heads/master@{#292785}

Also cleanup src/PRESUBMIT.py to use a common pattern for this.

BUG=409029

Review URL: https://codereview.chromium.org/518863002

Cr-Commit-Position: refs/heads/master@{#292784}

https://chromium.googlesource.com/chromium/blink/+log/97a3b93bcfffa9d20d8c58a9c5418be6d1b783eb..dec670cdd2062a6598b108047c78c455207c9d6a
TBR=

Review URL: https://codereview.chromium.org/516113003

Cr-Commit-Position: refs/heads/master@{#292783}

Cr-Commit-Position: refs/heads/master@{#292782}

https://skia.googlesource.com/skia/+log/2fe2ce41e3e5647c7aead4d76d75f5500f573fde..5c49b70ae3e19620bbecfe72eb68aa4513c4fd18

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/523273004

Cr-Commit-Position: refs/heads/master@{#292781}

https://chromium.googlesource.com/chromium/blink/+log/e306342ba6b7f74c1be3745e789d75ffe0e809b0..97a3b93bcfffa9d20d8c58a9c5418be6d1b783eb
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/525743002

Cr-Commit-Position: refs/heads/master@{#292780}

This should be the memory pressure calculation as it is performed by the kernel today.
As discussed this is done to experiment with a more detailed resource management algorithm. Once this we have a satisfying solution this can be moved back.

BUG=381212
TEST=none (for this equation)

Review URL: https://codereview.chromium.org/511383003

Cr-Commit-Position: refs/heads/master@{#292779}

Currently reload/stop button is not present in content shell. If user
has to do reload operation then only option to do that is select
the url bar and click go button.Similarly stop button is not present. To stop loading of page only option is to press back button.
Added code to support stop/reload option.

BUG=

Review URL: https://codereview.chromium.org/513183002

Cr-Commit-Position: refs/heads/master@{#292778}

BUG=110610
TBR=sievers@chromium.org

Review URL: https://codereview.chromium.org/515943002

Cr-Commit-Position: refs/heads/master@{#292777}