- 10 Sep, 2014 40 commits
-
-
bengr authored
Adds a mechanism by which a net/ embedder can add headers to a HTTP CONNECT tunnel request. BUG=400872 Review URL: https://codereview.chromium.org/517693002 Cr-Commit-Position: refs/heads/master@{#294252}
-
jdduke authored
Prevent hardware keyboard events from hiding text handles if the events are not dispatched to an editable region. This allows seamless arrow key navigation of the page while a (non-editable) selection is active. BUG=409778 Review URL: https://codereview.chromium.org/560963002 Cr-Commit-Position: refs/heads/master@{#294251}
-
jdduke authored
This field will soon be removed entirely, instead replaced by the |WebTouchEvent.touches| field as the global container for all touches offered to embedders. Use that field to populate Pepper's changed and target touch lists, eliminating Pepper's dependency on |WebTouchEvent.changedTouches| and |WebTouchEvent.targetTouches|. This is part 1 of a 4-sided patch simplifying WebTouchEvent: 1) This change 2) https://codereview.chromium.org/558773002/ 3) https://codereview.chromium.org/559693003/ 4) https://codereview.chromium.org/560493003/ BUG=358132 Review URL: https://codereview.chromium.org/557863002 Cr-Commit-Position: refs/heads/master@{#294250}
-
tdanderson authored
Remove RootView::DispatchGestureEvent() and instead call up to the unified event processing logic in EventProcessor::OnEventFromSource(). This CL also introduces the virtual method EventProcessor::OnEventProcessingFinished(), which is called when the processing of an event is finished. BUG=404234 TEST=EventProcessorTest.OnEventProcessingFinished Review URL: https://codereview.chromium.org/533323004 Cr-Commit-Position: refs/heads/master@{#294249}
-
achuith authored
BUG=412713 TEST=bots Review URL: https://codereview.chromium.org/546633005 Cr-Commit-Position: refs/heads/master@{#294248}
-
James Robinson authored
This enables all blink targets and nearly all content targets in the android build. This produces a content shell APK, but not a fully operational one yet. This also flips on a bunch of other targets pulled in by deps. R=brettw@chromium.org Review URL: https://codereview.chromium.org/561623002 Cr-Commit-Position: refs/heads/master@{#294247}
-
Nico Weber authored
Now that NT_PAGE is gone, rewrite the function to be single-return and add a comment pointing out that what the function is doing is incomplete. No intended behavior change, should fix 2 clang warnings of the form ..\..\sandbox\win\src\sandbox_nt_util.cc(560,3) : warning(clang): 'operator new' should not return a null pointer unless it is declared 'throw()' or 'noexcept' [-Wnew-returns-null] return NULL; ^ BUG=82385 R=rvargas@chromium.org Review URL: https://codereview.chromium.org/556293002 Cr-Commit-Position: refs/heads/master@{#294246}
-
thestig authored
Also fix the formatting of chrome_elf/OWNERS Review URL: https://codereview.chromium.org/546733002 Cr-Commit-Position: refs/heads/master@{#294245}
-
sky authored
The current code floors, which means we may not paint enough, an in fact you can see this in views at certain scales. BUG=none TEST=none R=danakj@chromium.org Review URL: https://codereview.chromium.org/557953004 Cr-Commit-Position: refs/heads/master@{#294244}
-
gcasto authored
Currently the password manager only controls uploads of ACCOUNT_CREATION_PASSWORD but uploads of PASSWORD happen during the normal Autofill form submit process. This is problematic in that there are different criteria for triggering uploading between the two, which makes the ratio of votes difficult to judge. Two such cases include that Autofill doesn't trigger uploads on XHR form submits, and that Autofill will surpress uploading if the user has no saved Autofill state. By pulling uploading of these types into the same code path, the ratio of uploads should be much more stable. This does also change what the expected ratio will be, since now we only upload PASSWORD when the user actually saves the password instead of just submitting the form. There is still some uncertainty in the numbers (i.e. uploads will not complete when user is Incognito) but for well behaving sites there should be approximately as many ACCOUNT_CREATION_PASSWORD labels as PASSWORD labels. BUG=408829 Review URL: https://codereview.chromium.org/543283002 Cr-Commit-Position: refs/heads/master@{#294243}
-
thakis authored
The previous increase in r293993 didn't help anything; make the timeout really large to make sure that things aren't just slow. (Once this hasn't helped either, we're going to remove this win/asan special case.) BUG=412471 TBR=timurrrr@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/557333007 Cr-Commit-Position: refs/heads/master@{#294242}
-
davidben authored
Somewhat cleaner without having to pass around half-constructed EVP_PKEY objects everywhere. BUG=none Review URL: https://codereview.chromium.org/553223002 Cr-Commit-Position: refs/heads/master@{#294241}
-
jdduke authored
Add back auto recede, and hasten the recession upon explicit release. BUG=389744 Review URL: https://codereview.chromium.org/543123002 Cr-Commit-Position: refs/heads/master@{#294240}
-
eakuefner authored
There was an issue with outputting Chart JSON that came down to a typo and was not caught by unittests. This patch fixes the bug and adds a unittest to make sure it won't crop up again. R=nednguyen,sullivan Review URL: https://codereview.chromium.org/551293003 Cr-Commit-Position: refs/heads/master@{#294239}
-
Elliot Glaysher authored
The line endings were wrong and this is preventing the trybots and CQ from applying a patch. This has to be landed manually. No functional changes here. BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/556413002 Cr-Commit-Position: refs/heads/master@{#294238}
-
davidben authored
Revert of Switch Mac over to BoringSSL from NSS. (patchset #1 id:1 of https://codereview.chromium.org/539163002/) Reason for revert: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builder/builds/10583 Original issue's description: > Switch Mac over to BoringSSL from NSS. > > This is a much much larger change than the diff suggests. If it breaks > something, please revert first and ask questions later. > > BUG=338885 > > Committed: https://crrev.com/dd7edfa679492a6feb3ef2e1630f05da82a1b31f > Cr-Commit-Position: refs/heads/master@{#294233} TBR=rsleevi@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true BUG=338885 Review URL: https://codereview.chromium.org/565473002 Cr-Commit-Position: refs/heads/master@{#294237}
-
dtseng authored
Revert of Add logspam to help diagnose flaky tests (patchset #2 id:20001 of https://codereview.chromium.org/485843002/) Reason for revert: No longer needed since AutomationApiTests have been running for some time without flaking. Original issue's description: > Add logspam to help diagnose flaky tests > > BUG=391279,385701,353039,379927,384673 TBR=kalman@chromium.org,aboxhall@chromium.org NOTREECHECKS=true NOTRY=true BUG=391279,385701,353039,379927,384673 Review URL: https://codereview.chromium.org/561923002 Cr-Commit-Position: refs/heads/master@{#294236}
-
mohsen authored
BUG=407659 Review URL: https://codereview.chromium.org/558203002 Cr-Commit-Position: refs/heads/master@{#294235}
-
jmedley authored
BUG=none R= TEST=none NOTRY=true (documentation only change) Review URL: https://codereview.chromium.org/546713003 Cr-Commit-Position: refs/heads/master@{#294234}
-
davidben authored
This is a much much larger change than the diff suggests. If it breaks something, please revert first and ask questions later. BUG=338885 Review URL: https://codereview.chromium.org/539163002 Cr-Commit-Position: refs/heads/master@{#294233}
-
zork authored
BUG=381007 Review URL: https://codereview.chromium.org/547503002 Cr-Commit-Position: refs/heads/master@{#294232}
-
fgorski authored
BUG=412819 NOTRY=true Review URL: https://codereview.chromium.org/561733004 Cr-Commit-Position: refs/heads/master@{#294231}
-
dgozman authored
BUG=none TBR=horo@chromium.org Review URL: https://codereview.chromium.org/559933003 Cr-Commit-Position: refs/heads/master@{#294230}
-
scottmg authored
This fixes differences in -Wno-unused-function and -Wno-unneeded-internal-declaration. It also changes the diff'ing script to accept -Wendif-labels -Wextra -Wsign-compare when in GN but not gyp, because they're more conservative. These mostly happen when GN declares a lib chromium_code, but gyp doesn't. Also, remove some defines from the dont_care, as I'm not sure that we don't care yet. And some minor tweaks to diff script output. R=brettw@chromium.org BUG=335824 Review URL: https://codereview.chromium.org/555343002 Cr-Commit-Position: refs/heads/master@{#294229}
-
isherman authored
BUG=406642 TEST=none R=tbarzic@chromium.org Review URL: https://codereview.chromium.org/559863003 Cr-Commit-Position: refs/heads/master@{#294228}
-
eranm authored
BUG= Review URL: https://codereview.chromium.org/561793002 Cr-Commit-Position: refs/heads/master@{#294227}
-
pshenoy authored
BUG=412282 NOTRY=True Review URL: https://codereview.chromium.org/562443002 Cr-Commit-Position: refs/heads/master@{#294226}
-
earthdok authored
BUG=412903 TBR=glider@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/559203002 Cr-Commit-Position: refs/heads/master@{#294225}
-
fsamuel authored
BUG=412883 Review URL: https://codereview.chromium.org/542193004 Cr-Commit-Position: refs/heads/master@{#294224}
-
bengr authored
This change removes logic that would issue a request through the data reduction proxy immediately after every network change. BUG=411448 Review URL: https://codereview.chromium.org/548993002 Cr-Commit-Position: refs/heads/master@{#294223}
-
primiano authored
This change changes heap_dump to use ptrace rather than SIGSTOP to freeze the target process. Recent kernels (Android L) forbid to attach to /proc/PID/mem if the process is not ptrace-d. This has also two advantageous side effects: 1. PTRACE_ATTACH is independent of the process state (if it was STOPped it will stay stopped after the detach). 2. If heap_dump crashes or is killed, the process is automatically detached by the kernel (so we can get rid of the SIGPIPE/INT logic). Furthermore this CL makes the consistency checks optional (adding a -n switch to disable them). BUG=382489 Review URL: https://codereview.chromium.org/553403002 Cr-Commit-Position: refs/heads/master@{#294222}
-
reed authored
BUG= Review URL: https://codereview.chromium.org/558213003 Cr-Commit-Position: refs/heads/master@{#294221}
-
tdresser authored
TEST=see crbug.com/412875 BUG=412749 Review URL: https://codereview.chromium.org/565433002 Cr-Commit-Position: refs/heads/master@{#294220}
-
dbeam authored
R=estade@chromium.org BUG=411771 Review URL: https://codereview.chromium.org/558723003 Cr-Commit-Position: refs/heads/master@{#294219}
-
maniscalco authored
Prior to this change UploadState objects would synchronously notify AttachmentUploaderImpl that they were done and could be deleted. This meant they were still on the call stack when their destructor was invoked. While it worked, it was subtle and might lead to bugs in the future. BUG= Review URL: https://codereview.chromium.org/556083002 Cr-Commit-Position: refs/heads/master@{#294218}
-
hendrikw authored
only occur when we haven't drawn anything and as a result the color_ member needs to be initialized to transparent. BUG=412377 Review URL: https://codereview.chromium.org/552633004 Cr-Commit-Position: refs/heads/master@{#294217}
-
hclam authored
cast.streaming API will be notified if there is a hardware initialization error. This way extension can decide whether to restart with a different codec or just fail. Also fixed a small issue that Framer is printing too many messages. BUG=402182 Review URL: https://codereview.chromium.org/555563003 Cr-Commit-Position: refs/heads/master@{#294216}
-
jshin authored
Now that CrOS has Noto Sans Sinhala. There's no need to block it any more in the Accept-Language list. BUG=240586 TEST=In accept-langauge selection UI, Sinhala is listed. Review URL: https://codereview.chromium.org/552063002 Cr-Commit-Position: refs/heads/master@{#294215}
-
sergeyu authored
BUG=386441 Review URL: https://codereview.chromium.org/471243002 Cr-Commit-Position: refs/heads/master@{#294214}
-
Justin TerAvest authored
This change removes some unnecessary includes in the trusted plugin and replaces uses of nacl::string with std::string. This is intended to make it easier to (eventually) include headers from Chromium, which currently conflict with nacl_log.h. BUG= R=dmichael@chromium.org Review URL: https://codereview.chromium.org/552533006 Cr-Commit-Position: refs/heads/master@{#294213}
-