- 24 May, 2018 20 commits
-
-
Tessa Nijssen authored
Previously, after a section of text was removed and the removal was undone, the cursor was placed after the text. The desired behavior would be a selection of the re-placed text. This change saves the current selection range on delete or replace. The selection range is then restored on undo. Changed tests: - TextfieldModelTest.UndoRedo_CutCopyPasteTest - OmniboxViewTest.UndoRedo Added tests: - TextfieldModelTest.Undo_SelectionTest Bug: 615345 Change-Id: I9ce001099de7175da688a993ed3bfd29d296660c Reviewed-on: https://chromium-review.googlesource.com/1066675 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#561338}
-
Sasha Morrissey authored
the console should show the recorded metrics correctly. Test: Set metrics.log = true and try and open one of each file type; Bug: 846136 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I95bc7439f79a2f8c616a4ca655938b956b5bfd59 Reviewed-on: https://chromium-review.googlesource.com/1070907Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561337}
-
Koji Ishii authored
The `style_variant_` field was originally added when we introduced NGStyleVariant[1] and extended to all fragments[2], but it was not initialized and suddenly starts failing for box fragments to have kEllipsis in some tests when '--run-layout-test' option is used. This patch initializes it to kStandard. [1] https://chromium-review.googlesource.com/956552 [2] https://chromium-review.googlesource.com/1068781 Bug: 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib7013e9c80f54550f9fc1262345ffd2fa18b3790 Reviewed-on: https://chromium-review.googlesource.com/1068793Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#561336}
-
Michael Lippautz authored
This avoids writing a pointer for each traced wrapper on dispatch. It also brings the wrapper tracing descriptor closer to the regular trace descriptor. Bug: chromium:841830 Change-Id: I6be7566a465184b12d9021926b3a61cd66934bc6 Reviewed-on: https://chromium-review.googlesource.com/1067572Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#561335}
-
Quentin Fiard authored
- Improve the documentation of TimeDelta::InXYZ methods to clarify that they return a truncated value (aka rounded towards zero). - Add a new InDaysFloored method to convert a TimeDelta into a floored number of days. - Fix the implementation of InMillisecondsRoundedUp for negative time deltas. Bug: 831545 Change-Id: I4afd256308f6f28ff459925772059fdfc5824995 Reviewed-on: https://chromium-review.googlesource.com/1049906Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Quentin Fiard <qfiard@google.com> Cr-Commit-Position: refs/heads/master@{#561334}
-
Vlad Tsyrklevich authored
Blacklist base::Callback as a conservative solution to crbug.com/845855 Also add two files that call dlsym() resolved functions identified by looking at functions that immediately trap (consist of only a ud2 instruction) after enabling cfi-icall. BUG=845855 Change-Id: I54a74902fd5db5d85f396f200f96f97bd8e1e463 Reviewed-on: https://chromium-review.googlesource.com/1071090Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#561333}
-
Patrick Hulce authored
- Convert dropdowns to radio/checkbox inputs - Resize icons/line height/padding - Overlay size fix - Minor typographic adjustments - Disable start audit button when on active view BUG=844331,844334,844374,844352,844324,844318 Change-Id: Ieb87ce0994031c69a260bddf83f8ad995c8ea70c Reviewed-on: https://chromium-review.googlesource.com/1066302 Commit-Queue: Patrick Hulce <phulce@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561332}
-
Chris Harrelson authored
Bug: 823365 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia97f4fac5a0fd9929d8ff03b109057db7171e8f3 Reviewed-on: https://chromium-review.googlesource.com/1070621 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#561331}
-
Xu Xing authored
BUG=821176 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If78dca0b4526fb85f09ff6a641b5dc7e18bb12b3 Reviewed-on: https://chromium-review.googlesource.com/1068649Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#561330}
-
Mohamed Heikal authored
This renames "Startup.Android.Experimental.Cold.TimeToFirstNavigationCommit" to "Startup.Android.Cold.TimeToFirstNavigationCommit.Tabbed" similarly for "Startup.Android.Experimental.Cold.TimeToFirstContentfulPaint". This also creates another suffix ".WebApk" for these histograms to track startup numbers for PWAs in chrome. The new histograms now use "Medium Times" which has a shorter range since the long tail is no longer a problem. This change also refactors the Activity related tracking code in UmaUtils into AcitivityTabStartupMetricsTracker.java Change-Id: Ia8c309f1c791a2c491832f3945bb54b47952f821 Bug: 842023 Reviewed-on: https://chromium-review.googlesource.com/1063011 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#561329}
-
Scott Violet authored
If the bounds don't change, but the LocalSurfaceId does, then the request needs to be processed. This is important for windows that have LocalSurfaceId, such as at the embedding. This bug resulted in the ksv not drawing correctly initially. BUG=837684 TEST=covered by test Change-Id: I0bf67a15bc2af0ae42df07378908d3c1a8d90885 Reviewed-on: https://chromium-review.googlesource.com/1070689 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#561328}
-
Aga Wronska authored
Bug: 835436 Change-Id: Ie7d07234197b0159a429a69de84e1e3c1724c1c0 Reviewed-on: https://chromium-review.googlesource.com/1025395 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#561327}
-
Trent Apted authored
A range of factors were leading to the ChromeOS "Sign out" button getting an incorrect text color (details: https://crbug.com/779732#c21 ). The button is constructed using TrayPopupItemStyle::TextStyle::BUTTON and TrayPopupUtils::CreateTrayPopupBorderlessButton(..), but nothing else was using these. Move the construction code into user_view.cc, which is the only place that needs it. Use a views::style::TextContext, CONTEXT_TRAY_POPUP_BUTTON, to adopt the standard way of configuring the button's font. The color is trickier. Hardcode gfx::kChromeIconGrey to keep the current behaviour. It's the only text in the menu using gfx::Font::Weight::MEDIUM, so using the same color as other text (#212121) makes it look too dark. kChromeIconGrey is lighter and matches the icons in the menu. The old codepaths (using TrayPopupItemStyle::TextStyle::BUTTON) were trying to set #212121 and would get clobbered by ui::NativeTheme to use kChromeIconGrey instead. Bug: 779732 Change-Id: If87a11a9296980c0925c10bca2021cc5e6edd208 Reviewed-on: https://chromium-review.googlesource.com/1065597Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
-
Nektarios Paisios authored
R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 845651 Change-Id: I797678c5bd39e191e1511d6397d112a8a04ab35c Reviewed-on: https://chromium-review.googlesource.com/1069807 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#561325}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5dd3fccb3c7d..13235d8966e4 $ git log 5dd3fccb3..13235d896 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 csmartdalton Revert "ccpr: Handle winding and even-odd in the same shader" 2018-05-23 fmalita [skottie] SK_API-export public classes 2018-05-23 scroggo Alternate between two SkBitmaps in SkAnimatedImage 2018-05-23 scroggo Make DNG decodes single threaded on Android Created with: roll-dep src/third_party/skia BUG=chromium:78866720,chromium:78878033 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: Icdded072680d84c7b34590c332626f47cb8a722e Reviewed-on: https://chromium-review.googlesource.com/1070927 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561324}
-
Helen Li authored
These two field trials are not actively being worked on. It's unclear whether tuning the buffer size is still relevant given the other changes (with respect to socket buffers) that landed since. This CL removes the field trials from the code. Bug: 631140 Change-Id: If4fc665551f76d35f36b702055fef64499e4e582 Reviewed-on: https://chromium-review.googlesource.com/1070650Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#561323}
-
Trent Apted authored
Currently BrowserWindowController and BrowserFrameMac set some delegates on the NSWindow object during construction for validating and dispatching commands in the mainMenu bar (and other means). These are not cleared upon destruction. However, AppKit may retain NSWindows on NSEvents and things, resulting in validation or dispatch attempts attempting to lookup a Browser* for the window and finding null. This CL adds plumbing in MacViews so that the NSWindow customisation done at construction has a symmetric destruction opportunity as well. Adds some test coverage to simulate the codepath that currently DCHECKs that covers both Views and Cocoa browser windows. Bug: 828738 Change-Id: I96f69c7912328abf84076f202c98617f4729f38a Reviewed-on: https://chromium-review.googlesource.com/1068906Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#561322}
-
Gary Kacmarcik authored
Rather than have each platform convert Unicode combining characters before adding them to the DomKeyboardLayout, with this change each platform adds the Unicode combining characters and they are converted into printable characters as the LayoutMap is being created for the user. Bug: 832811 Change-Id: Ie1b23b228c1227b7c4be6e5409dba881ef1ff586 Reviewed-on: https://chromium-review.googlesource.com/1070756Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#561321}
-
John Rummell authored
BUG=658026 TEST=new fuzzers run Change-Id: I8251f3b77a561985f626e079cecd18a756cca240 Reviewed-on: https://chromium-review.googlesource.com/1067494 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#561320}
-
Emily Stark authored
As an enterprise requirement for the HTTP-Bad rollout, we need to support wildcard hostname patterns like *.foo-corp.com for the --unsafely-treat-insecure-origin-as-secure flag and policy. This CL supports this requirement by expanding the whitelist configured by that flag to allow hostname patterns. Unfortunately, this means that the whitelist is now made up of std::strings instead of url::Origins; origins are still canonicalized and serialized before being placed into the whitelist. Consumers of the whitelist now check for exact origin matches as well as pattern matches. Bug: 844885 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I6ccea22f499045bf7ec50bfb903320baa8e37095 Reviewed-on: https://chromium-review.googlesource.com/1068262 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#561319}
-
- 23 May, 2018 20 commits
-
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8dd790d49a52..f1e34db090a1 $ git log 8dd790d49..f1e34db09 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 wangxianzhu Fix frame viewer ui issues Created with: roll-dep src/third_party/catapult BUG=chromium:842238 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9df8041171da342c420309e0267c3103c4b87267 Reviewed-on: https://chromium-review.googlesource.com/1070651 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561318}
-
Theresa authored
This reverts commit b422141f. Reason for revert: Suspect that this broke ui automator tests Original change's description: > Clean up scrim logic in LocationBarLayout > > Scrim visibility in the location bar is now completely controlled by > a single function. The scrim observer is now added and removed based > on the scrim visibility to avoid conflict with other observers (like > the bottom sheet). > > Bug: 834927 > Change-Id: I172ca637dde5bc026b1b7f629bc34c6d939dff2d > Reviewed-on: https://chromium-review.googlesource.com/1026168 > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558785} TBR=tedchoc@chromium.org,twellington@chromium.org,mdjones@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 834927 Change-Id: I46401b29a91f67cfa6aa6611b7d9bf854d1fd610 Reviewed-on: https://chromium-review.googlesource.com/1070890Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#561317}
-
Chris Harrelson authored
Bug:823365 Change-Id: I188e8521d0981c3da23f978caaffdc0009190691 Reviewed-on: https://chromium-review.googlesource.com/1070887 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1f2355297a3986ecb4e1d3534d473000cbe97fc2 Reviewed-on: https://chromium-review.googlesource.com/1070193Reviewed-by:
-
Quan Nguyen authored
Bug: 841629 Change-Id: I54467a28469b901c0fc69f9a6d20101d693307c3 Reviewed-on: https://chromium-review.googlesource.com/1070616 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#561314}
-
Esmael El-Moslimany authored
Bug: 842013 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0a3eb6e2343fc224da22a88cb1cc10581e6833c5 Reviewed-on: https://chromium-review.googlesource.com/1067766Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#561313}
-
Junbo Ke authored
Bug: internal b/72129709 Test: mannual test, cast_shell_unittests Change-Id: I54a0e8971e7869cd6c222d9abf089161b84ac467 Reviewed-on: https://chromium-review.googlesource.com/1053293 Commit-Queue: Junbo Ke <juke@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#561312}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d4aebad9..cfd1ec50 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6a7bb041f46e8c237c4596433f871da2acf1fdbb Reviewed-on: https://chromium-review.googlesource.com/1067611Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#561311}
-
Robert Ma authored
Using wpt-import in Chromium d22debff. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18379 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bajones@chromium.org: external/wpt/gamepad drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts jsbell@chromium.org: external/wpt/IndexedDB TBR=lukebjerring No-Export: true Change-Id: I2b24ac2799d25b6a1ffc64825694b840ce952e22 Reviewed-on: https://chromium-review.googlesource.com/1069746Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#561310}
-
Biao She authored
Bug: 841607 Change-Id: I936202dcf3b01459e7914f237b22d8c0e5b09137 Reviewed-on: https://chromium-review.googlesource.com/1070544 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#561309}
-
Nektarios Paisios authored
Anonymous blocks were not correctly marked as editable and richly editable in Blink and thus unnecessarily ignored affecting selection on Windows. R=dmazzoni@chromium.org Bug: 831179 Change-Id: Ic53ad29e63d7e9bbfd775ce5f933f20e7ea656f5 Tested: Layout test Reviewed-on: https://chromium-review.googlesource.com/1004925 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Chris Harrelson authored
Bug: 823365 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I38f0e9c871eceb5d842cd9a5aa0c5449ec034321 Reviewed-on: https://chromium-review.googlesource.com/1070603Reviewed-by:
-
Liam Murphy authored
This extra work is done in ppapi [0], so let's try it here. It might not work, but it can be verified on canary. This extra work is done separately from the existing warmup, because: - this extra work is only desired when CSRSS lockdown is enabled - this enabled state is not exposed widely in target_services.cc, so the existing warm up code does not know about this state. 0: https://cs.chromium.org/chromium/src/content/ppapi_plugin/ppapi_thread.cc?l=70-83&rcl=1ce0b94580c68f7288f0ee60c0e9fcfbc77f5879 Change-Id: I87ea6ce06f7658350bbe3005fd6667f2a6201f9e Bug: 464430 Reviewed-on: https://chromium-review.googlesource.com/1070610Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Liam Murphy <liamjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#561306}
-
Malay Keshav authored
This patch fixes an incorrect DCHECK that was landed in the previous patch. The DHCECK_LT should instead be DCHECK_GT. Bug: 839458 Change-Id: I4b45aae9a1cb1c3870774b4c3e2d654ffbf7bb4f OriginalChange: I4d5bd761506c6ec14dc92b3d3a120b87e02e2cb7 Component: Display util, dsf, zoom levels Reviewed-on: https://chromium-review.googlesource.com/1070619 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#561305}
-
Hongchan Choi authored
|audio_worklet_thread_| is constantly peeked by the rendering thread in the loop while it can be touched by the main thread when a promise from audioWorklet.addModule() gets resolved. This CL fixes the data race between these two threads. Bug: 842941 Change-Id: I404bb8963b2f25f42a2e12c20de867cb6c781032 Reviewed-on: https://chromium-review.googlesource.com/1070456 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#561304}
-
Pawel Osciak authored
Add a feature flag to enable VA-API-based VP8 hardware video encode acceleration. BUG=794608 TEST=run Chrome with feature disabled/enabled, verify availability Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5866d7b158a071ea94b06d49453af1ec85ba3e2e Reviewed-on: https://chromium-review.googlesource.com/1068905Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#561303}
-
Thomas Anderson authored
This reverts commit 7a20abbc. Reason for revert: Breaks Google Chrome Linux x64 bot https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/31569 Original change's description: > [Components] Move ToInstalleResult to component\update_client > > This would allow the template function to be used in other modules without > depending on chrome\browser\. > > Change-Id: I10ccfcabf6677162367e0e90101b9169fa6a4c35 > Reviewed-on: https://chromium-review.googlesource.com/1070669 > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561290} TBR=sorin@chromium.org,mxnguyen@chromium.org Change-Id: I037c9c139d0529573687ac12ab149cd5ed3af7ca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1070880Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#561302}
-
Dave Schuyler authored
This reverts commit 801b2e7c. Reason for revert: Doesn't have the intended effect. Original change's description: > [base] escape Polymer binding characters in escape HTML > > This cl escapes Google Polymer HTML binding characters when escaping > HTML (and the reverse when un-escaping). > > Other changes were due to presubmit or linter errors/warnings. > > Bug: 843736 > Change-Id: I080bb610f80ab689f792c3d27797a9cd55b531f6 > Reviewed-on: https://chromium-review.googlesource.com/1066732 > Commit-Queue: Dave Schuyler <dschuyler@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561274} TBR=mmenke@chromium.org,dschuyler@chromium.org Change-Id: Idaddadd1223286caad17a412ba9f593bfaf57984 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843736 Reviewed-on: https://chromium-review.googlesource.com/1070891Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#561301}
-
Noel Gordon authored
Bug: 845087 Change-Id: Ib454c78465ac7d76b93f7d66307dac74ddbbb2e3 Reviewed-on: https://chromium-review.googlesource.com/1067573Reviewed-by:
-
Findit authored
This reverts commit bc80a210. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 561244 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JjODBhMjEwZmQzYjU2Nzc4NDc4OTNhN2I4MTdjYzQ3YTcwMTJjYTkM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/50226 Sample Failed Step: viz_unittests Original change's description: > Move LayerTreeHostImpl-dependent code in viz/client/ to cc/. > > Currently there is a HitTestDataProviderSurfaceLayer class in > components/viz/client, which receives a cc::LayerTreeHostImpl* from cc/ > and then calls back into cc::LayerTreeHostImpl* to build the > HitTestRegionList from the active tree. This is problematic for these > reasons: > > 1. cc is-a viz client, so it could depend on viz/client/ code. But the > viz/client/ should not depend back on cc/. The use of the > cc::LayerTreeHostImpl pointer breaks this. > > 2. The LayerTreeFrameSink implementation can call back to > LayerTreeHostImpl, but it should not do so with the actual LTHI pointer > type. Instead it should use the LayerTreeFrameSinkClient interface, > which LayerTreeHostImpl implements. > > 3. The order of exection is that cc::LayerTreeHostImpl calls > ClientLayerTreeFrameSink::SubmitCompositorFrame() (through the > LayerTreeFrameSink interface), which then calls back to the > cc::LayerTreeHostImpl class to generate the HitTestRegionList, > creating the A-B-A anti-pattern. We can resolve this by passing > the HitTestRegionList directly to SubmitCompositorFrame(), but to do > so we need ClientLayerTreeFrameSink to not get it from the virtual > HitTestDataProvider interface in this case. > > In order to satisfy these things we: > > A. Move the implementation of HitTestDataProviderSurfaceLayer into > LayerTreeHostImpl, and move the unit test there. > > B. Add a BuildHitTestData() method to LayerTreeFrameSinkClient, which > is implemented in LayerTreeHostImpl as per (A). > > C. Move the branching out of the HitTestDataProvider virtuality. > If the HitTestDataProvider in ClientLayerTreeFrameSink is null, then > it uses the LayerTreeFrameSinkClient to ask the LayerTreeHostImpl to > build the HitTestRegionList. This does not break behaviour as the > HitTestDataProvider is created as a HitTestDataProviderDrawQuad > preferably, falling back to HitTestDataProviderSurfaceLayer. > Similarly the HitTestDataProviderDrawQuad would be preferred if the > pointer is not null, falling back to using LayerTreeFrameSinkClient. > (We also leave a TODO that we can just submit the HitTestRegionList > directly to SubmitCompositorFrame.) > > This patch would be pretty small.. except.. > > Because cc/ is building the HitTestRegionList, it can not depend > on services/viz/ which depends back on cc/. So we implement the > viz::mojom::HitTestRegionList and viz::mojom::HitTestRegion as > standard c++ types viz::HitTestRegionList and viz::HitTestRegion > in components/viz/common/hit_test/, which cc/ can make use of. And > we add struct traits to pass these types to mojo and receive them > from mojo. > > Then all plumbing code must be changed from the mojom-defined type > to the standard-c++-defined type. > > The mojom type was viz::mojom::HitTestRegionListPtr (aka > mojo::StructPtr<viz::mojom::HitTestRegionList>), which is an > optional field in the CompositorFrame, so we must preserve its > ability to be null. We may use a struct traits directly to > viz::HitTestRegionList, and base::Optional<viz::HitTestRegionList> > throughout the plumbing, or we can use a struct traits to a > std::unique_ptr<viz::HitTestRegionList> (which is itself considered > nullable by mojo) and plumb that through directly through > everything. I don't actually know which is preferable here, but > settled on making viz::HitTestRegionList move-only, and using the > former option. This makes most of this patch just type renames. > > Lastly, we need LayerTreeHostImpl to not return a HitTestRegionList > in cases where no HitTestDataProvider would have been given to the > ClientLayerTreeFrameSink previously. This is in the case where > features::IsVizHitTestingSurfaceLayerEnabled() returns false. So we > add a field to LayerTreeSettings, which we set to the value of that > feature flag, and have LayerTreeHostImpl return an empty optional > value when the setting is false. > > R=gklassen@chromium.org, piman@chromium.org, sadrul@chromium.org > > Bug: 722935 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I0208c2cbd2ede14a088e4430c9eb75437e763c27 > Reviewed-on: https://chromium-review.googlesource.com/1066987 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561244} Change-Id: I9b7c6e16cbd2c74a2d692ccce974e47bfd08cc13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 722935 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1070879 Cr-Commit-Position: refs/heads/master@{#561299}
-
