- 31 Jul, 2018 40 commits
-
-
Xiaohan Wang authored
The original problem has been fixed in the latest Widevine CDM. Bug: 851027 Change-Id: I9aced3ea2152e33fcc8a5bcddc8a587c45dee6cc Reviewed-on: https://chromium-review.googlesource.com/1154087Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#579615}
-
Vlad Tsyrklevich authored
Bug: 866290 Change-Id: Ic5d175b3b854665f50781650406d599d09ee9849 Reviewed-on: https://chromium-review.googlesource.com/1157136Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#579614}
-
Nico Weber authored
lld is on by default on linux and windows now, so these were no-ops. Bug: none Change-Id: I391846d8ac7776aa45d47e394e76067fd7575051 Reviewed-on: https://chromium-review.googlesource.com/1156859Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579613}
-
Johannes Henkel authored
Earlier, I presented an alternative to this, which I prefer, by storing the values in separate fields. It's in thic PR: https://chromium-review.googlesource.com/c/chromium/src/+/1157185 Change-Id: I52740475b18dfed26fb4753ba11aff7523bedc0c Reviewed-on: https://chromium-review.googlesource.com/1157248 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#579612}
-
Yutaka Hirano authored
blink::ResourceRequest, blink::ResourceResponse and blink::ResourceLoaderOptions have CrossThreadCopier specializations in order to support main-thread proxied load in workers. Now it's gone, so this CL removes them. This CL also removes ThreadableLoaderTest for workers. Actually the mock system, WebURLLoaderMockFactoryImpl, is not capable of serving requests on a non-main thread, and these tests are working now just accidentally. ResourceResponse::was_fetched_via_proxy_ is removed as no one uses it. Bug: None Change-Id: I39c1e242abd56f16aa2fd3595aff2f5a5e174653 Reviewed-on: https://chromium-review.googlesource.com/1152632 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#579611}
-
Matt Falkenhagen authored
This experiment is ready for testing on the Beta channel. Bug: 846235 Change-Id: Ibcaafcab93fced86a2831b6c7cb53b02bbc869db Reviewed-on: https://chromium-review.googlesource.com/1147891Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#579610}
-
Nicolas Pena authored
This CL changes the name of a PerformanceEntry to become a name. It should be noted that in general performance entries can be accessed from main or worker threads, so some care is needed. An exception to this is paint and longtask entries, and appropriate DCHECKs were added for those cases. Assessment of this change: Speed: AtomicString comparisons are faster but this CL increased the number of conversions between string types. So overall unclear, but likely insignificant speed changes. Memory: PerformanceEntry names are now shared so the memory usage should be improved by this change. Code complexity: increased (AtomicStrings are IMO harder to reason about than slightly simpler Strings). Bug: 852050 Change-Id: Iaee67c6bcd6123851a0f6657d12fb6b2c61cb5fc Reviewed-on: https://chromium-review.googlesource.com/1153608Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#579609}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8deec54fb837351422b8543080bd9f26beb62bd6 Reviewed-on: https://chromium-review.googlesource.com/1157507Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#579608}
-
Scott Haseley authored
Change supported platforms to kOkAll for kStopNonTimersInBackground so we can experiment on desktop. Bug: 869565 Change-Id: I491eba6b0a8e11c2255b8ed58a0ea0f3e32454e1 Reviewed-on: https://chromium-review.googlesource.com/1157253Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#579607}
-
Daniel Rubery authored
Begin reporting password re-use on URLs which were traditionally not valid for reputation computation, in an attempt to catch phishing on these URLs. Bug: 865625 Change-Id: Ib7492b9b9988dd1aa084973994dcda25c258bf93 Reviewed-on: https://chromium-review.googlesource.com/1155709 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#579606}
-
Michael Spang authored
Change DrmFramebuffer from a virtual interface to a concrete wrapper for a DRM framebuffer. This is what used to be ScanoutBuffer and is all that is needed for modesetting. In particular, we don't need access to gbm_bo, skia surfaces backed by dumb buffer mmaps, or other bits from {Gbm,Drm}Buffer in the modesetting internals. DrmFramebuffer is composed into GbmBuffer and DrmBuffer so that we can still access framebuffers for those types when presenting a buffer. GbmBuffer and DrmBuffer are no longer refcounted after this change. Bug: 868010 Change-Id: I6d31b000b35bc4a6caa6280bee4156ca9b271bb9 Reviewed-on: https://chromium-review.googlesource.com/1155916 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#579605}
-
Vasilii Sukhanov authored
Currently ellipsis is added to the value but it should be just truncated. Bug: 869394 Change-Id: I68cee8a70a45564ace59512356489c195327ca1c Reviewed-on: https://chromium-review.googlesource.com/1156696Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579604}
-
mark a. foltz authored
https://chromium.googlesource.com/media_router.git/+log/9f9f41bdd831..475baa8b2eb0 $ git log 9f9f41bdd..475baa8b2 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 mfoltz [Media Router] Log the dialog type 2018-07-23 mfoltz [MR extension][Cast MRP] Post-in-browser Cast discovery cleanup. 2018-07-19 mfoltz Removes support for test: URLs from mr.TestProvider. Created with: roll-dep src/chrome/browser/resources/media_router/extension/src TBR=imcheng@chromium.org Change-Id: Iadf9a61ddf90b206100a143c3a2f1150ae049863 Reviewed-on: https://chromium-review.googlesource.com/1157209Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579603}
-
Gabriel Marin authored
The Linux config file was generated by autoconf and manually edited to define PC_FROM_UCONTEXT for ARM, change size_t printf format specifiers to zd instead of ld, and add a GCC compiler guard around the HAVE_BUILTIN_EXPECT macro definition. The file is being committed into the repository for the purpose of cross-platform compilation. The Windows config file was copied from an older version of tcmalloc and must be manually inspected before being used with the new tcmalloc version. The Android and FreeBSD config files are just stubs and must be generated by autoconf on those respective platforms before they can be used. Added windows/mingw.h and windows/port.h to the list of allowed include rules of the DEPS file in the top tcmalloc dir. BUG=724399,b:70905156 Change-Id: Ib18197d03824d0e9cca8c1002cedb25363dc8b03 Reviewed-on: https://chromium-review.googlesource.com/1130673 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#579602}
-
Peter Kvitek authored
Change-Id: Iec45bb977b603eef79ac91f4cb243c4e13d7e103 Reviewed-on: https://chromium-review.googlesource.com/1157247Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579601}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e782f8472f61..f107a2fd014c git log e782f8472f61..f107a2fd014c --date=short --no-merges --format='%ad %ae %s' 2018-07-31 halcanary@google.com SkUTF 2018-07-31 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms f80f027f8ac9..dc97dc542b6d (1 commits) Created with: gclient setdep -r src/third_party/skia@f107a2fd014c The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: If2d30238685c0f690e84be76bce2e28a3545dfc1 Reviewed-on: https://chromium-review.googlesource.com/1156915Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579600}
-
Carlos Knippschild authored
Expose to Java Offline Prefetch flag and configurations to allow the upcoming work on Android UI and settings to access them. Bug: 850588 Change-Id: I697e944b57ebae57df73def9bffc8059b13eaa5d Reviewed-on: https://chromium-review.googlesource.com/1154144Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#579599}
-
Siddhartha authored
The CFI unwinder only works for chrome stack frames. Write a hybrid unwinder which can use libunwind for android and CFI unwinder for chrome. Does not support unwinding in x86 and arm 64bit builds. It supports pausing a different thread and unwinding frames on that thread. This will be useful for UMA sampling profiler and tracing profiler. BUG=859260 Change-Id: I208b9b21c8f6a73a4d593f1446095da92c0cb848 Reviewed-on: https://chromium-review.googlesource.com/1132144 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#579598}
-
Scott Violet authored
AccessibilityManager is always created, so the mash conditional is not needed. BUG=none TEST=none Change-Id: Iab76b0e63a89ec5fa296ba308e5d3b52d3288dcb Reviewed-on: https://chromium-review.googlesource.com/1157223Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#579597}
-
Lukasz Anforowicz authored
Bug: 869193 Change-Id: I911ec71a13c432a0111bdd8ec9da0f5ab679d082 Reviewed-on: https://chromium-review.googlesource.com/1155828 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#579596}
-
Scott Violet authored
AccessibilityManager is always created, so the mash conditional is not needed. The conditional dates back to early on in mash when the AccessibilityManager was not created. BUG=none TEST=none Change-Id: I3a8945aa8659703d8a2edec03a1a46ec3513505a Reviewed-on: https://chromium-review.googlesource.com/1157214Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#579595}
-
Lu Chen authored
Add recording of AnchorElementMetrics.Visible.HrefEngagementScore2. Bug: 850624 Change-Id: I5291067e2b9f1edfb8dd4e23fca3df802a153228 Reviewed-on: https://chromium-review.googlesource.com/1156000 Commit-Queue: Lu Chen <chelu@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#579594}
-
Michael Spang authored
Since HardwareDisplayControllers are never moved between DRM devices, it's much simpler to manage the cursor buffers there - we never need to reallocate them due to a device change. This will also allow us to remove the refcounting. Bug: 868010 Change-Id: Ie7e3615b4c653ea6250a4a4a45510c84badabe9c Reviewed-on: https://chromium-review.googlesource.com/1155915 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#579593}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2eb65034db71..8c1508bc0b4f git log 2eb65034db71..8c1508bc0b4f --date=short --no-merges --format='%ad %ae %s' 2018-07-31 courtneygo@google.com Update name of ANGLE Android apk to match expectations 2018-07-31 jmadill@chromium.org Context: Cache attributes masks. 2018-07-31 ianelliott@google.com Add Android-specific version struct to GetSystemInfo results. 2018-07-31 oetuaho@nvidia.com Allow reads from a multiview framebuffer with one view Created with: gclient setdep -r src/third_party/angle@8c1508bc0b4f The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ieb9485799b5e0b84bbce7222ad97560ac44c696b Reviewed-on: https://chromium-review.googlesource.com/1156908Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579592}
-
Sam Maier authored
Currently, the AsyncTask that creates the SecureRandom is on the SERIAL_EXECUTOR - this is causing a lot of ANRs. Since it doesn't appear to require any synchronus guarantees with anything else in the SERIAL_EXECUTOR, we can move this to the THREAD_POOL_EXECUTOR. This means when we block on SecureRandom creation using get(), we don't have to wait on all tasks currently in the SERIAL_EXECUTOR finishing. Bug: 866998 Change-Id: I771724a184bf501b2da55f7d42a93b3943e7a058 Reviewed-on: https://chromium-review.googlesource.com/1157211Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#579591}
-
Malay Keshav authored
This patch adjusts the shelf width such that in pixel space there is no gap left between the shelf and the edge of the display. The adjustment is done via a utility method which can be used to adjust any bounds to ensure that they cover the edge of the display or screen. Bug: 843354 Change-Id: Ica9adfe6e21e7ae71ef8206e20507a372317c105 Component: Screen util, shelf Reviewed-on: https://chromium-review.googlesource.com/1154040 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#579590}
-
Reid Kleckner authored
In this expression, the reference would be bound to the member of a temporary object returned from GetContainerBounds(): const gfx::Size& view_size = shell()->web_contents()->GetContainerBounds().size(); Clang has become smarter about the lifetimes of temporary objects like these, so ASan now reports this as a use-afer-scope. The fix is to copy the small gfx::Size object. TBR=sergeyu@chromium.org Bug: 869067 Change-Id: Ie15d45d8698d7024c8755980725fdedaa0ccaaad Reviewed-on: https://chromium-review.googlesource.com/1157274 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#579589}
-
xlou authored
When sending URLs to the PDF plugin, the page index in the URL needs to be the page index for the displayed PDF document. When N-up > 1, this will not match the page index from the selected pages in the UI, since the N-up page numbers will be recalculated using the number of pages selected and pagesPerSheet Value. The new number of pages will be ceil(#pages selected/pagesPerSheet), and the index of the N-up pages will start from 0. Hence changing the function onPagePreviewReady_ to use the N-upped document index when pagesPerSheet > 1. In printing, 2-up, 3-up, or more generally N-up refers to a page layout strategy in which multiple pages are composited onto a single page. Bug: 775999 Change-Id: I1488431713815b573eb2798e23b011417b9fa46d Reviewed-on: https://chromium-review.googlesource.com/1155906 Commit-Queue: Shirleen Lou <xlou@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#579588}
-
Eric Orth authored
Generally just applies the mapping to the input HostPortPair and passes on to the wrapped implementation. Some special handling for when the input is mapped to an error. Bug: 821021 Change-Id: I0d108976e363993ebb36b8081948ef410894fa47 Reviewed-on: https://chromium-review.googlesource.com/1156856Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#579587}
-
Michael Spang authored
Prepare for removing mock framebuffers by moving the class into MockDrmFramebufferGenerator. We don't need a mock framebuffer type. Bug: 869206 Change-Id: I8a909d385f455fde0776e3cf5ad8d24791753e23 Reviewed-on: https://chromium-review.googlesource.com/1155913 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#579586}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8b8cc1cc..15016c7f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id4c0b59e6a43ce82a7bdcf6374ba3d4ed9dc8f4d Reviewed-on: https://chromium-review.googlesource.com/1157130Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579585}
-
Fabrice de Gans-Riberi authored
This reverts commit de31a634. Reason for revert: This has made the Mac10.12 Tests content_unittests fail on the following tests: WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationLess180 WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationGreater360 WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationLess90 WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationLess360 WebInputEventBuilderMacTest.BuildWebTouchEvents See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14711 Original change's description: > Make pen inputs behave like touch inputs on MacOS > > Currently on MacOS the pen behaves like a mouse input, because we > generate mouse events for the pen input. We agreed that the pen input > should behave like a touch input, so we now send touch events instead. > > Bug: 854354 > Change-Id: Iac7910e250020a8125a57fb6055fb282db3faf0e > Reviewed-on: https://chromium-review.googlesource.com/1136721 > Commit-Queue: Lan Wei <lanwei@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579482} TBR=meacer@chromium.org,tdresser@chromium.org,lanwei@chromium.org,nzolghadr@chromium.org Change-Id: I51b85daec63d39ef9aebb9dd727def7dfd7ca432 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854354 Reviewed-on: https://chromium-review.googlesource.com/1157304Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#579584}
-
Ben Pastene authored
They were accidentally re added in https://chromium-review.googlesource.com/c/chromium/src/+/1145768 Bug: 869456 Change-Id: Ifb991ccc82980e2f51d38ad29ae1b3b7f206d5ad Reviewed-on: https://chromium-review.googlesource.com/1157188Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#579583}
-
Lu Chen authored
Finch is used to control the scales of each feature when calculating navigation scores. This CL is blocked on 1132680. Bug: 850624 Change-Id: I422f1e7f9f9db17530694d7445ab1233976f5930 Reviewed-on: https://chromium-review.googlesource.com/1152037 Commit-Queue: Lu Chen <chelu@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#579582}
-
Mao Huang authored
dump. Original CLs: - http://codereview.chromium.org/6532051 Fix heap profiler to always append the process id to the heap dump. To run Chrome: HEAP_PROFILE_ALLOCATION_INTERVAL=1000000 HEAPPROFILE=heapprof out/Debug/chrome To analyze: pprof --text out/Debug/chrome heapprof.21026.0039.heap pprof --gv out/Debug/chrome heapprof.21026.0039.heap (pprof is slooow) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86273 - https://codereview.chromium.org/8957007 Change the heap file names to be Cleanup'ed in third_party/tcmalloc/chromium. In spite of Chromium's changing heap file names dumped in heap-profiler.cc:DumpProfileLocked(), the file names cleaned-up in heap-profile-table.cc:HeapProfileTable::CleanupOldProfiles are not modified. (See the difference between third_party/tcmalloc/chromium/src/heap-profiler.cc and .../vendor/src/heap-profiler.cc) This patch is originally from http://codereview.chromium.org/7865021/. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114777 BUG=724399,b:70905156 Change-Id: Iab590a6a34f3e3922b0958460169e517accef7df Reviewed-on: https://chromium-review.googlesource.com/1130782 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#579581}
-
Hector Carmona authored
Bug: 832938 Change-Id: Ie3cec973be983a74aff44a3e77e99a3789044fec Reviewed-on: https://chromium-review.googlesource.com/1145596 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#579580}
-
Reid Kleckner authored
The temporary base::Optional<PersistentWindowInfo> object is destroyed at the end of the full expression in this statement: const auto& persistent_window_info = *window_state->persistent_window_info(); Avoid the lifetime issue by making a copy of the small struct. This bug was found by ASan after a clang change to more accurately track the lifetime of temporaries like these. TBR=afakhry@chromium.org Bug: 869067 Change-Id: Ibb4cd6761ec29fc09cd42c75b8d7bb13844f5352 Reviewed-on: https://chromium-review.googlesource.com/1157256Reviewed-by:Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#579579}
-
Yao Xiao authored
Bug: 863889 Change-Id: Ib1c68ca3053f3dfea5e06e40127a74634e45f6da Reviewed-on: https://chromium-review.googlesource.com/1140204Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#579578}
-
sczs authored
Changes the title and subtitle contentCompressionResistancePriority to prevent them from being compressed by the stackView. Bug: 862744 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0587b639cb76215c7f1c5b3bc26fdf87a21ab7c3 Reviewed-on: https://chromium-review.googlesource.com/1157197 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#579577}
-
Wei-Yin Chen (陳威尹) authored
Parameters |white_list| and |black_list| in FilterSourceFile() take iterables of strings, and they don't have to be tuples. Single-entry tuples are harder to read. The trailing comma could be confusing, especially in a list of arguments. They are converted to lists in this CL. Bug: None Change-Id: Iec5ed2f1e2d25bacf444165b734f76eaa3375aff Reviewed-on: https://chromium-review.googlesource.com/1155708 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#579576}
-