GitLab

This moves the File API and its objects to Oilpan using transition
types.

R=haraken@chromium.org,tkent@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/176853004

git-svn-id: svn://svn.chromium.org/blink/trunk@168460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Don't trace the RefPtr for the CSSCursorImageValue workaround. It is trace via the RefCountedGarbageCollected persistent.

We are correctly hitting an UNREACHABLE when tracing a RefPtr with
enable_oilpan=1 on the bots.

R=haraken@chromium.org, wibling@chromium.org, oilpan-reviews@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/177413009

git-svn-id: svn://svn.chromium.org/blink/trunk@168459 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Oilpan: Use weak pointers in StyleSheetContents caches. (https://codereview.chromium.org/185403016/)

Reason for revert:
This patch seems to have made a number of layout tests fail on the oilpan bots. Reverting while I investigate.

Original issue's description:
> Oilpan: Use weak pointers in StyleSheetContents caches.
> 
> This fixes use-after-free that could occur when StyleSheetContents
> dies when an allocation happens during insertion of a new
> StyleSheetContents. Using the built-in weak processing this will
> not happen because the iterator used during insertion will keep
> the StyleSheetContents alive.
> 
> R=erik.corry@gmail.com, haraken@chromium.org, vegorov@chromium.org
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168444

TBR=erik.corry@gmail.com,haraken@chromium.org,vegorov@chromium.org,zerny@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/187473003

git-svn-id: svn://svn.chromium.org/blink/trunk@168458 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, the lifecycle of DrawingBuffer is different from it of
WebGraphicsContext3D, so there is so many checks if the context is valid.
This complexity is not necessary because DrawingBuffer does not own any
objects when the context is lost or impossible to be created.

To be clear the lifecycle, this CL makes DrawingBuffer take ownership of WebGraphicsContext3D.

The DrawingBuffer creation or resize can fail if the memory is not enough. This
logic is preserved.
In detail,
1. If it occurs during WebGLRenderingContext creation, we give up creating
WebGLRenderingContext.
2. If it occurs during restoration of lost context, we will try again.
3. If it occurs during resizing DrawingBuffer, we slightly ignore, because we
can reuse different size FBO in this case.

In addition, this CL fixes two bugs.
1. maybeRestoreContext() pretends to success to restore although creating FBO in
DrawingBuffer fails. As mentioned earlier, we will try again.
2. WebGLRenderingContext calls DrawingBuffer::reset() twice during creation,
because the constructor of DrawingBuffer internally calls reset().

BUG=344393

Review URL: https://codereview.chromium.org/163773007

git-svn-id: svn://svn.chromium.org/blink/trunk@168457 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Specifically MediaQuery, MediaQueryExp, MediaQuerySet, MediaQueryResult, and MediaList. Also added a persistent in  CSSStyleSheet and MediaQueryList. Finally changed FontFace to RefCountedGarbageCollected when oilpan is enabled. FontFace require a bit more separate work to move entirely so leaving that for a separate change.

The reason for the test breakage was that I had overlooked a MediaQueryExp that was a part object in MediaQueryResult.  

Finally fixed an incorrect persistent found by Ian's oilpan plugin, yay:)

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167798

Review URL: https://codereview.chromium.org/170283019

git-svn-id: svn://svn.chromium.org/blink/trunk@168456 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=loislo@chromium.org

Review URL: https://codereview.chromium.org/186833002

git-svn-id: svn://svn.chromium.org/blink/trunk@168455 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c.f. shadow-styling spec:
/shadow-all/: http://dev.w3.org/csswg/shadow-styling/#shadow-all-combinator
/shadow-deep/: http://dev.w3.org/csswg/shadow-styling/#shadow-deep-combinator

BUG=348891
TEST=Replaced all ^ and ^^ with /shadow-all/ and /shadow-deep/ and rebaselined.

Review URL: https://codereview.chromium.org/183803016

git-svn-id: svn://svn.chromium.org/blink/trunk@168454 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL regressed performance of Dromaeo/dom-traverse unacceptably.
https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-mac6%2Cchromium-rel-mac8%2Cchromium-rel-win7-dual%2Clinux-release&tests=dromaeo.domcoretraverse%2Fdom&checked=core


> Move popular DOM attributes to prototype chains
> 
> Design document: https://docs.google.com/a/google.com/document/d/1yeHTCHhulVIlrKyx9_gCguAhLfcefVOa9uxxfW2LVG0/edit
> 
> Intent-to-ship-and-implement in blink-dev: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/t0XiZuMey7M/9-5AuhoFyisJ
> 
> This CL moves DOM attributes used in Dromaeo to prototype chains. When I landed the CL two months ago (https://codereview.chromium.org/94403002), it caused 20+% regression in benchmarks. However, now that a V8 side fix is landed, there should be no overhead in moving DOM attributes to prototype chains in theory.
> 
> Dromaeo/dom-attr 1086 runs/sec => 1077 runs/sec (-0.8%)
> Dromaeo/dom-modify 522 runs/sec => 525 runs/sec (+0.5%)
> Dromaeo/dom-query 26150 runs/sec => 26200 runs/sec (+0.2%)
> Dromaeo/dom-traverse 564 runs/sec => 544 runs/sec (-3.6%)
> 
> I don't understand the regression in dom-traverse. The regression is reproducible but I cannot reproduce the regression in a super-micro benchmark that just repeats accessing div.firstChild. Probably the regression might be a noise.
> 
> I'm going to land this CL and see how much regression is observed in perf bots (I'll email to perf-sheriff@). If I find the regression is unacceptable, I'll revert the CL.
> 
> See the design document and the Intent-to-ship email for justification for the regression.
> 
> BUG=43394
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167680
> 
> R=jochen@chromium.org
> 
> Review URL: https://codereview.chromium.org/158713002

TBR=haraken@chromium.org

Review URL: https://codereview.chromium.org/187343006

git-svn-id: svn://svn.chromium.org/blink/trunk@168453 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a remnant from WebKit when there was a volume slider container
that could be shown and hidden. What remains is essentially dead code,
because at most it shows the slider when m_mediaController->hasAudio(),
but MediaControls::reset() already does that.

BUG=341813

Review URL: https://codereview.chromium.org/176883020

git-svn-id: svn://svn.chromium.org/blink/trunk@168452 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=346642

Review URL: https://codereview.chromium.org/180273012

git-svn-id: svn://svn.chromium.org/blink/trunk@168451 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Transparency layers were implemented before composited layers
were made to be fully sub-pixel aware. Blink r164561 was the
sub-pixel fix for composited layers, which caused them to behave
differently than transparency layers leading to off-by-one
errors. This patch teaches transparency layers about sub-pixel.

BUG=347521

Review URL: https://codereview.chromium.org/180163008

git-svn-id: svn://svn.chromium.org/blink/trunk@168450 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove unnecessary textDirection parameter from the min/maxLogicalWidth
methods and computePreferredLogicalWidths and instead use the resolved
text directionality.

BUG=333004
R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/183013005

git-svn-id: svn://svn.chromium.org/blink/trunk@168449 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The message passed to the method is a result of JSON.stringify and may contain noncharacter unicode code points (http://www.unicode.org/faq/private_use.html#noncharacters). Since we know that the message is a JSON string we can use \uXXXX escape sequences for bad symbols. The function escapes not only noncharacters which produces valid output and allows to keep implementation simple.

BUG=347899
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/178473027

git-svn-id: svn://svn.chromium.org/blink/trunk@168448 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=348993
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/184313003

git-svn-id: svn://svn.chromium.org/blink/trunk@168447 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The rebaseline-json results are returned as a JSON object
with |return_code| and optional error |output| fields.

R=eseidel,dglazkov@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/183383008

git-svn-id: svn://svn.chromium.org/blink/trunk@168446 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes use-after-free that could occur when StyleSheetContents
dies when an allocation happens during insertion of a new
StyleSheetContents. Using the built-in weak processing this will
not happen because the iterator used during insertion will keep
the StyleSheetContents alive.

R=erik.corry@gmail.com, haraken@chromium.org, vegorov@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/185403016

git-svn-id: svn://svn.chromium.org/blink/trunk@168444 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intoducing new HitTestRequest::TouchAction hit test type, which will be used
in Special hit testing for computing effective touch-action in eventhandler.

BUG=247396, 319479

Review URL: https://codereview.chromium.org/137123009

git-svn-id: svn://svn.chromium.org/blink/trunk@168443 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman, apavlov, eustas
NOTRY=true

Review URL: https://codereview.chromium.org/182113004

git-svn-id: svn://svn.chromium.org/blink/trunk@168442 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://lists.w3.org/Archives/Public/public-media-fragment/2014Feb/0000.html
http://lists.w3.org/Archives/Public/public-media-fragment/2014Feb/0002.html

In this thread about looping over media fragments it became clear that
no spec actually says how media fragment end times integrate in
HTMLMediaElement. (The start time is mapped to the "initial playback
position", which almost matches what Blink does.)

Blink/WebKit pauses at the fragment end time once. Firefox Nightly does
the same, while IE11 appears to not support MF URIs at all.

The counter data will tell us whether or not breaking changes can be
made and the relative usage could help inform the spec discussion.

BUG=none
R=acolwell@chromium.org

Review URL: https://codereview.chromium.org/185363002

git-svn-id: svn://svn.chromium.org/blink/trunk@168441 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=237312
NOTRY=true

Review URL: https://codereview.chromium.org/183093010

git-svn-id: svn://svn.chromium.org/blink/trunk@168440 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Add a checkbox and have its setting stored in localStorage.
- Update all non-hash anchor targets whenever the settings is changed.
- Honor the setting in ui.createLinkNode (moved from base.createLinkNode,
  since it is a UI-related task, in fact).
- Drive-by: fix (and simplify) tab switching so that disabled tabs will no longer get activated.

R=dglazkov@chromium.org, eseidel
NOTRY=true

Review URL: https://codereview.chromium.org/183923025

git-svn-id: svn://svn.chromium.org/blink/trunk@168439 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It is always set to true.

Also drop the volume change check, since HTMLMediaElement::setVolume()
and MediaController::setVolume() already do that.

BUG=341813

Review URL: https://codereview.chromium.org/177423011

git-svn-id: svn://svn.chromium.org/blink/trunk@168438 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to implement:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/MGxEfzBPw68

The spec reference is:
  http://www.w3.org/html/wg/drafts/2dcontext/master/#dom-context-2d-ispointinstroke
  http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-context-2d-ispointinstroke

BUG=330506

Review URL: https://codereview.chromium.org/179383002

git-svn-id: svn://svn.chromium.org/blink/trunk@168437 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DOMImplementation can not be null and this CL only makes implementation() return
a reference instead of pointer.

Review URL: https://codereview.chromium.org/184813005

git-svn-id: svn://svn.chromium.org/blink/trunk@168436 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes the state.element().isLink() calls in applying color
properties for visited links. This has a small behavioural change where
the -webkit-link color keyword will now be the visited link color for a
visited link descendent (bug 82498). I don't think we can currently test
visited link colors in a layout test.

This also fixes a crash when trying to set color in a pseudo-element
animation on a link element (or descendent), since we go through the
StyleBuilder with a null element. Note that the other places in the
StyleBuilder where we access the element already check for null.

BUG=82498,343048

Review URL: https://codereview.chromium.org/179363005

git-svn-id: svn://svn.chromium.org/blink/trunk@168435 bbb929c8-8fbe-4397-9dbb-9b2b20218538

scenario:
1) record less than one second timeline
2) zoom in or zoom out

BUG=
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/187303003

git-svn-id: svn://svn.chromium.org/blink/trunk@168434 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixed build failures with ENABLE_OILPAN after [1].

[1] http://src.chromium.org/viewvc/blink?view=revision&revision=168422

BUG=
TBR=haraken@chromium.org, ch.dumez@samsung.com

Review URL: https://codereview.chromium.org/187283006

git-svn-id: svn://svn.chromium.org/blink/trunk@168433 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All text selection colour again.

TBR=dpranke@chromium.org
BUG=348800

Review URL: https://codereview.chromium.org/178193031

git-svn-id: svn://svn.chromium.org/blink/trunk@168432 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of DatabaseBackend objects should be destructed in the originator thread (https://codereview.chromium.org/183883005/)

Reason for revert:
Unnecessary change


Original issue's description:
> DatabaseBackend objects should be destructed in the originator thread.
> 
> Before this CL, it was possible that DatabaseThread held the last
> references of DatabaseBackend objects and it was released in the
> database thread.
> We must destruct objects in the originator thread in Oilpan.
> 
> Implementation:
> DatabaseThread::recordDatabaseClosed doesn't remove a RefPtr<
> DatabaseBackend>, and we release RefPtr<DatabaseBackend> objects
> in ~DatabaseThread, which is executed in the main/worker thread.
> Note that there are no ways to close a database explicitly, and
> DatabaseBackend objects are never destructed before their
> DatabaseContext is stopped. DatabaseThread::recordDatabaseClosed
> is actually unnecessary.
> 
> DatabaseThread doesn't know DatabaseBackend open status any longer.
> We remove DatabaseThread::isDatabaseOpen, and its existing
> callsites use DatabaseBackend::open() instead.
> 
> 
> BUG=347902
> TEST=none; no visible behavior changes hopefully.
> R=michaeln@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168362

TBR=michaeln@chromium.org,oilpan-reviews@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=347902

Review URL: https://codereview.chromium.org/178103007

git-svn-id: svn://svn.chromium.org/blink/trunk@168431 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All text selection colour again.

TBR=dpranke@chromium.org
BUG=348800

Review URL: https://codereview.chromium.org/187023006

git-svn-id: svn://svn.chromium.org/blink/trunk@168430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All text selection colour.

TBR=pdr@chromium.org
BUG=348800

Review URL: https://codereview.chromium.org/178103006

git-svn-id: svn://svn.chromium.org/blink/trunk@168429 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168335

BUG=114658
TBR=cbiesinger@chromium.org

Review URL: https://codereview.chromium.org/183013012

git-svn-id: svn://svn.chromium.org/blink/trunk@168428 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168335

BUG=114658
TBR=cbiesinger@chromium.org

Review URL: https://codereview.chromium.org/187393003

git-svn-id: svn://svn.chromium.org/blink/trunk@168426 bbb929c8-8fbe-4397-9dbb-9b2b20218538

More selection colour.

TBR=dpranke@chromium.org
BUG=348800

Review URL: https://codereview.chromium.org/181063028

git-svn-id: svn://svn.chromium.org/blink/trunk@168425 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dpranke@chromium.org
BUG=348800

Review URL: https://codereview.chromium.org/177473005

git-svn-id: svn://svn.chromium.org/blink/trunk@168424 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Avoid calling hasAttribute() and then getAttribute() for performance.
This causes the attribute to be looked up (linear search) twice instead
of once if we call getAttribute() directly and then check if the returned
AtomicString is null.

R=eseidel@chromium.org, eseidel, rwlbuis

Review URL: https://codereview.chromium.org/183763033

git-svn-id: svn://svn.chromium.org/blink/trunk@168423 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Have DOMWindow deal with references instead of pointers when possible. This
makes the code look safer and gets rid of unnecessary null checks.

This CL also updates the generated bindings so that they allow for the
implementation to return references instead of pointers in more cases.

R=adamk@chromium.org, nbarth@chromium.org, adamk

Review URL: https://codereview.chromium.org/176763009

git-svn-id: svn://svn.chromium.org/blink/trunk@168422 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move Document code out of Node.cpp and into Document.cpp for clarity. There is
no reason (e.g. inlining) requiring that this code be in Node.cpp.

R=adamk@chromium.org, adamk, eseidel

Review URL: https://codereview.chromium.org/178543006

git-svn-id: svn://svn.chromium.org/blink/trunk@168421 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Have positionInParentBeforeNode() / positionInParentAfterNode() take a
reference as the implementation expected the pointer to be non-null. This makes
the code look safer.

R=adamk@chromium.org, adamk

Review URL: https://codereview.chromium.org/182383012

git-svn-id: svn://svn.chromium.org/blink/trunk@168420 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Store IdTargetObserver::m_registry as a reference instead of a pointer.
This makes the code look safer and gets rid of an unnecessary null check.

Also make IdTargetObserverRegistry non copyable to protect against bad
assignments to references.

R=adamk@chromium.org, adamk, rwlbuis

Review URL: https://codereview.chromium.org/183463004

git-svn-id: svn://svn.chromium.org/blink/trunk@168419 bbb929c8-8fbe-4397-9dbb-9b2b20218538