- 27 Aug, 2020 40 commits
-
-
Mitsuru Oshima authored
This is a revised version of original attempt crrev.comc/c/2166804. Instead of creating a new layers, this clone and animate the window's layer, but makes sure that the animating layer is at the bottom of other layers within the window. * It adds a invisible view with a layer at the bottom of the non_client_view (no frame w/o this, so we can exclude such case). * Adds the animating layer as a child of this view, with "SetMasksToBounds(false)" so that it will not be clipped during animation. * Once animation is done, this animating, old layer will be removed. Bug: 1073685 Test: covered by unittests. Change-Id: Ib5ae6a218d200394c54932e5b559217fcc7f89e1 Fixed: 2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375686Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#802386}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/788aa6fd2c18..be71f6d9f008 2020-08-27 agrieve@chromium.org Add npm-debug.log and out-devil-deps to .gitignore If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: I4ca78935635c5b53da113d7dfe099e72b2c445a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380203Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802385}
-
Moe Ahmadi authored
CommandId and ClickInfo are sent by OneGoogle inside a 'data' property in MessageEvent.data. This CL fixes handling of OneGoogle promo browser commands by looking for CommandId and ClickInfo in MessageEvent.data.data Bug: 1106421 Change-Id: I87f2d58ea47aa71e6662bb331170d0074cefb212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376979 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#802384}
-
Xing Liu authored
These are failing on recent builds. StartSurfaceLayoutTest.testThumbnailAspectRatio_default. StartSurfaceLayoutTest.testThumbnailAspectRatio_point75. TBR=wychen@chromium.org Bug: 1122657 Change-Id: Ib68765728b77dbb08c23d81667a2eb680231781a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380199Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802383}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/11944f7122cf..cc61e5a98324 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I41e102bbb1e6f694d47e7b27e028614c63186f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380082Reviewed-by:
-
dpapad authored
_generate_js_imports() was assuming that HTML files have no copyright header, and consequently produced incorrect results when that assumption was broken. Tests based on lucmult@ attempt at: https://chromium-review.googlesource.com/c/chromium/src/+/2379414 Bug: None Change-Id: I1ac190518fb7141d0016b7d4717cee08146e3853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380076 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#802381}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1fd76f85b10e..aac228ce1bbf 2020-08-27 cjamcl@chromium.org [Lighthouse] Roll Lighthouse 6.3.0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:772558 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia499d1b5c0bb78e4b8597fb55fae672d5b01940d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380044Reviewed-by:
-
Haiyang Pan authored
This config makes a difference for test suite to pass or not. See crbug.com/1115229#c51. So add it the trybot config. Bug: 1115229 Change-Id: Ib7c738608ebc2ff6e92d6287b38ea52354254fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380103 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#802379}
-
Wayne Piekarski authored
Change-Id: Idcf17aad024c6417976615f8bfbf3cc2df138369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378800 Commit-Queue: Wayne Piekarski <waynepie@google.com> Auto-Submit: Wayne Piekarski <waynepie@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#802378}
-
Scott Little authored
This test is timing out frequently on Mac, so this CL adds that to TestExpectations. TBR=gogerald@chromium.org Bug: 1045599 Change-Id: I77d567490cb3a9b200522670e8973e4e83c2aa90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380146Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#802377}
-
Findit authored
This reverts commit 0ad6a0b8. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 802334 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzBhZDZhMGI4YjRlNGIyZWMwZmE2ZTY3ZWZmNzk5MDYwZGMyMDA0ZTQM Sample Failed Build: https://ci.chromium.org/b/8870779059616927872 Sample Failed Step: compile Original change's description: > Replace AndroidX Preference[Dialog]FragmentCompat with the version from master > > This CL replaces the PreferenceFragmentCompat and > PreferenceDialogFragmentCompat classes in the AndroidX preference > library with the version from master, which has a change needed for > WebLayer. The preference library maintainers say they won't create a new > release just for this fix, so to get it we'll have to pull it in > ourselves. > > Bug: 1092986 > Change-Id: I0e1c936f6372cb541cabfa29c2aea0d0ee7225fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253029 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802334} Change-Id: I25e202b3329b651719e2903f7378b7d5811b3435 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1092986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380635 Cr-Commit-Position: refs/heads/master@{#802376}
-
harrisonsean authored
Add UI for the update check, and support for base error and offline for the update check. Actual update check logic will be added later after addition of support for ad-hoc queries to the service. Bug: 1078782 Change-Id: I78a5a5b1713a8a040dde638cfbcdecbb313bbd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352907 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#802375}
-
Randy Rossi authored
Chromecast implementation of ExtensionsBrowserClient can return null for GetExtensionResourceManager. Added a check to return early if null. Bug: internal b/166307109 Test: Local display assistant build with screen reader extension Change-Id: I61e3a1a55026d531e1947cd0d80e59e57d386a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372890 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Ryan Daum <rdaum@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#802374}
-
zhaoyangli authored
The pool is going to be removed. Bug: 1119885 Change-Id: I5dc5511a8078e305a139c07fd572ab2fac373fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378777Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#802373}
-
Sahel Sharify authored
This cl downloads and encodes instrument icon for SPC before it is written to db. Bug: 1121021, 1121331 Change-Id: Ifa875ad6a42380fb5f7a7790022f4dd17b835122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380142 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802372}
-
Tom Anderson authored
When running under a VNC session, the connection setup data sometimes has duplicated depths, like so: depth=24: visuals={123,456} depth=24: visuals={789} Previously, we were searching for the unique depth that matches the root depth, then searching for the visual within the list corresponding to that depth. However, since the depths may not be unique, search through all depths until we find a matching visual ID, and then use that to set both the default depth and default visual. R=sky Change-Id: I51f75260f584f85f2bdc93048e6c4848cf00997a Fixes: 1121438, 1115929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375888Reviewed-by: -
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/80848e3b..81f3d945 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ide9420d14b8d9271c462bd9f9065050aa735dfe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379633Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802370}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/faa844b3686c..532a264c141d 2020-08-27 herb@google.com use bit 15 to encode page information in glyph UV 2020-08-27 adlai@google.com Add GrDirectContext arg to SkImage::readPixels 2020-08-27 csmartdalton@google.com Don't pre-scale tessellated strokes by the matrix scale 2020-08-27 brianosman@google.com Run glnarrow/glesnarrow on GPU perf bots 2020-08-27 reed@google.com use pathbuilder 2020-08-27 brianosman@google.com Make SkRuntimeShaderBuilder safe for reuse 2020-08-27 johnstiles@google.com Improve control-flow support in early-return detection. 2020-08-27 bsalomon@google.com New helpers for SkYUVAInfo when used with pixmaps. 2020-08-27 bsalomon@google.com Remove do-nothing MPD benchmarking from nanobench If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ie546955976a0d4665307f374713fe276c3c9aa3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380378Reviewed-by:
-
Steven Bennetts authored
This is a fix for logic introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2350315 It also includes a unit test that would have caught the regression. BUG=1112814 Change-Id: I057f01f29892278231f36e6abb5334692e8ea401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378459Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#802368}
-
Mugdha Lakhani authored
Currently, the network prediction user preference allows link rel="prerender" to continue because disabling it doesn't really prevent web developers from fetching these resources by other means, like a regular fetch. The same argument should apply to link rel="next", which is what this CL does. This also affects the handling of the WebLayer network prediction setting in the same way. Bug: 1122563 Change-Id: I54517c9f12ae11f56f43a0e6c42f586492d89579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379890Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#802367}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ib8d61a2f38dc6a083bd6510475d2bf4cdefd18fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380077Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#802366}
-
Kalvin Lee authored
base::StringPiece erased support for its starts_with() method in https://crrev.com/c/2358745. This change modifies PpdMetadataManager to use the base::StartsWith() function instead. Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdMetadataManagerTest.*' Change-Id: If8fef9b2e066f852168cadcf8a02c445033e5028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373387Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#802365}
-
Mohamed Mansour authored
While sorting the TableView the focus ring was in the incorrect spot. Upon investigation, the position was always the model_index instead of the view_index. Added a unit test to make sure that the active row index matches the view index being shown meanwhile the model index differs (which tells us it has been sorted). Previously this test will fail since the focus ring is being rendered in a different position. AX-Relnotes: A focus ring now appears around the correct cell in tables that are found in e.g. Chromium's Task Manager. Bug: 1121394 Change-Id: I6921268a7274d5f41eaec8de013e2ea90e3abdb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373236 Commit-Queue: Mohamed Mansour <mmansour@microsoft.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#802364}
-
Tom Anderson authored
These were removed in [1] because the message loop was changed to TYPE_UI, which automatically flushes. However, if there are a lot of tasks in the queue, the flush may happen later than we'd like, and this increases latency between frames. This CL adds the flushes back in an effort to fix perf regressions. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2343314 R=sky BUG=1119639 Change-Id: I04d6854fce7df69830f421dd81d734a14ae6d5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377609 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1598262024-benchmark-86.0.4240.8-r1 to 86-4183.59-1598262024-benchmark-86.0.4240.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I6c228452555f76d4e082e79097961eb03ed90163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380047Reviewed-by:
-
Mugdha Lakhani authored
Bug: 1122177 Change-Id: Iffcd5094ab99f403f1abcde908f417efaad9695d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379830Reviewed-by:
-
Mike Dougherty authored
Bug: 891834 Change-Id: I2f7247085324fc1c31bd7092b51d181fbe4e2328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377512 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#802360}
-
Scott Little authored
This test has been consistently timing out on Mac, so this CL marks that in the TestExpectations. https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/19844 TBR=gogerald@chromium.org Bug: 1111287 Change-Id: Ia0aeaaa6f09cae3e27544200a444e5eb6611bbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380424Reviewed-by:
-
Tom Anderson authored
This is needed so we can reland [1] and [2]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2379674 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2380370 R=thestig Change-Id: If2dbda4d38e7df58905718525918135a617e7f76 Bug: 1122702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380572 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#802358}
-
Michael Moss authored
This is primarily needed to bring in symupload native symbols support on Mac. 9c38ab7 Add native symbol uploads to Mac OS symupload tool. 62d9272 linux: Fix segfault when there is no section header in ELF file 087795c processor: subtract 1 from return pointers while scanning 014e842 Escape more characters in Mac OS sym-upload-v2 debug_file strings. BUG=1021742 R=nbilling@google.com, rohitrao@chromium.org Change-Id: I7bc63acfb5fb94e1c9b9f6d38801886a6225c2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380139Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#802357}
-
Mike Wasserman authored
Only fire screenschange for frames with the Window Placement permission. Fire isMultiScreen changes for all visible frames (e.g. 1 <-> 2 screens) (obviates pollling isMultiScreen(), which is exposed without permission) Add a TODO to postpone events instead of dropping, and refine criteria. Update test expectations and add TODO to test events with permission. Bug: 1080690, 1109989 Test: event only fires for permissioned sites or isMultiScreen changes. Change-Id: I5b46bd6944bc4b923b6357e9b370c80ce14a09b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375671Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#802356}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c08c71bedfbb..7d98e228f836 2020-08-27 glenrob@chromium.org Allow 'main' as a local main branch name. 2020-08-27 sweilun@chromium.org Also Pretty print the split histogram_suffixes_list If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1121852 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ifb50a0b64aa1c8594a4ad9755baed24ec08fae4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380530Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1f580a97e55f..3cdde9771d8f 2020-08-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 824b4e64..55f2a783 (802144:802244) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8bee58ed2e937bf4303176b1773a4fd8bf987059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380336Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
- Add news strings for eSim UI - Adds new UI elements to esim_flow_ui.html - Current UI: https://imgur.com/zdfcmbx - UI spec https://docs.google.com/presentation/d/1Mfk5ZMEmeHwSbadUbyRU0Si5k6XDIvw-j4u7TUaCIGY/edit#slide=id.g921c12802d_0_1 Bug: 1093185 Change-Id: Iadf0b8a411d93d59c1782d103f34c96442092481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351392 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#802353}
-
Jonathan Backer authored
There are crash reports and performance issues that remain uninvestigated. Disable for now until we can fix that. Bug: 1122650 Change-Id: I09fb05de39b5e3b5e3c26a8e0dbb90cbcffea4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380374 Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#802352}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cc61e5a98324..ed2e4739280f 2020-08-27 treehugger-gerrit@google.com Merge "Fix missing include." 2020-08-27 oksamyt@google.com Merge "[trace processor] Add core type distribution to WV power metric" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0f5260bda2fb427909033989f1df4156d5dcef4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380373Reviewed-by:
-
Xianzhu Wang authored
This is because this blink runtime feature doesn't work by itself. It's controlled by the corresponding Chromium feature which needs to be enabled to make the whole feature work. We'll continue to use the virtual test suites to test the feature. Bug: 1121839 Change-Id: I902cf87e8fba8e1123dd4a6f5e6fe8c7f821f524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378631Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802350}
-
Rouslan Solomakhin authored
Before this patch, if WebAuthn returned an error when creating an assertion, Web Payment called into ShowErrorMessage(), which called into OnCancel(), which rejected the PaymentRequest.show() promise, but kept the secure payment confirmation UI open. This patch makes sure that the dialog is closed in OnCancel(). After this patch, if WebAuthn returns an error, then the secure payment confirmation UI is closed. Bug: 1122696 Change-Id: I99fae1d7b0b903338fca8cd03ecf57646dd78699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380550 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#802349}
-
Sebastien Marchand authored
This ensures that child processes don't die before flushing their profile data to disk. This is supposed to happen automatically at shutdown but it doesn't always have a chance to complete (probably because we tend to fast kill processes). This affects mostly the utility processes, and as they end up writing their data into the same file as the renderer they can sometime end up corrupting these files and make us lose some precious profiling data. This only affects profile instrumented builds (PGO profiling builds and coverage builds). Bug: 1119887 Change-Id: Ib50e876e7637a670ad05982c5ff03a898dc84ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378272Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#802348}
-
Torne (Richard Coles) authored
Some apps appear to pass null for one or more of the header names/values in WebView.loadUrl(url, extra_headers). Check for null before trying to validate the header format as Matcher doesn't permit null arguments. Fixed: 1122574 Bug: 1108405, 1105745 Change-Id: Ib2675efa78266d97b5e2c5c63b4b7f6182e089d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380269 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#802347}
-
