- 18 Jul, 2018 6 commits
-
-
Xiaocheng Hu authored
Bug: 830337 Change-Id: Ica61483028f3cd92787191d3115476f54b5f84c2 Tbr: achuith@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/1140798Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575867}
-
Miguel Casas authored
Follow up and correction to crrev.com/c/1132112: we should only log those VideoFrames that are not supported _and_ that are not Textures/GMBs already. This CL adds the latter part. Bug: 787122 Change-Id: Ieb4e4fff0f2e14e9beb6949f1531507ac80733ce Reviewed-on: https://chromium-review.googlesource.com/1140834Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#575866}
-
CJ DiMeglio authored
This reverts commit fed7475d. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable two flaky tests on ChromeOS > > Disable ShelfLayoutManagerTest.FlingUpOnShelfForFullscreenAppList > Disable WindowSelectorTest.RoundedEdgeMaskVisibility > > Tbr: xiyuan, xdai > Bug: 864467, 864465 > Change-Id: I77a0dbcddad5176575f0dc5991beb9eef8090167 > Reviewed-on: https://chromium-review.googlesource.com/1140683 > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575707} TBR=zmin@chromium.org Change-Id: I2aaceb5588030a1b14edf9b0c1d2da6165cbf8f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864467, 864465 Reviewed-on: https://chromium-review.googlesource.com/1140460Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#575865}
-
Yuri Wiitala authored
With no other screen capture implementations dependent upon media::ScreenCaptureDeviceCore, ThreadSafeCaptureOracle, etc.; this change merges this code into ScreenCaptureMachineAndroid. Unused functionality has been stripped-out, and minor callpoint- and lint- related clean-ups were made. No behavior/functional changes. Testing: Built monochrome_public_apk, installed it to my phone, and confirmed Android screen capture from that Chromium build still works by running a demo app: https://paulkinlan.github.io/screenrecord/. Bug: 806366,487935 Change-Id: I3edb2603261b6ed60e31edf795ac8da9a2a8525c Reviewed-on: https://chromium-review.googlesource.com/1137733 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575864}
-
Min Qin authored
DownloadManagerService may start too early before full browser is started. In this case, downloadItem doesn't have a BrowserContext object assocuated, BUG=695115 Change-Id: Ie7dcc88bb63cdfc8af0d0e4d4670e808e22f175e Reviewed-on: https://chromium-review.googlesource.com/1140519Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575863}
-
Jinho Bang authored
This is one of several patches that will remove the sequence version of supportedMethods member. This patch stops using it by removing the related code in browser side. - [1/2] https://crrev.com/c/1078687 - [2/2] This patch Intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/JAnUvBqXElU Bug: 754779 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia276a90240dc817e60ce8cf793454eb822e67a4e Reviewed-on: https://chromium-review.googlesource.com/1108057Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#575862}
-
- 17 Jul, 2018 34 commits
-
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed1bf6ade339..718bcd15ec60 Created with: gclient setdep -r src-internal@718bcd15ec60 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/79769347 TBR=mmoss@chromium.org Change-Id: Ib368183b3420bc4568814737cf57199b33937040 Reviewed-on: https://chromium-review.googlesource.com/1140538Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575861}
-
Kurt Horimoto authored
This CL updates ContentSuggestionsMostVisitedActionItem to support custom a11y labels that differ from their titles, and adds a custom label for the Reading List cell that states the number of unread articles. Bug: 862299 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I972b5996fb3398154f656b8ea056b9028d468af0 Reviewed-on: https://chromium-review.googlesource.com/1137027 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#575860}
-
Vaclav Brozek authored
ScopedLayoutPreventer was used to avoid detecting visibility of form elements in situations when it was believed to cause pre-mature layout (see https://crbug.com/595078). Visibility is approximated through calling IsFocusable on the WebNodes corresponding to forms and their fields. Looking at recent documentation, though, the WebNode-based API seems robust enough to prevent such dangerous calls: (1) The contract of Element::IsFocusable() only states the need to call Document::UpdateStyleAndLayoutTree() beforehand. (2) Document::UpdateStyleAndLayoutTree() does not cause the layout. (3) WebNode::IsFocusable() causes calling Document::UpdateStyleAndLayoutTree() as necessary before delegating to Element::IsFocusable(). See https://crbug.com/855598#c14 for more context. As a result, ScopedLayoutPreventer blocked visibility checks unnecessarily, leading to bugs like https://crbug.com/851808. Therefore this CL removes ScopedLayoutPreventer. Bug: 855598,851808,595078 Change-Id: Ic415919be5c40821dfa965eeb16372ae92ba92d5 Reviewed-on: https://chromium-review.googlesource.com/1136531Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#575859}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/40bacee96a94..e6ddf1942ca0 git log 40bacee96a94..e6ddf1942ca0 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 bratell@opera.com Stop gclient sync from scrolling during progress output 2018-07-17 ehmaldonado@chromium.org gclient: Start reporting metrics. Created with: gclient setdep -r src/third_party/depot_tools@e6ddf1942ca0 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:832386 TBR=agable@chromium.org Change-Id: I9f5a812dba6fa48f05ee1ec16a19065b3bc4e255 Reviewed-on: https://chromium-review.googlesource.com/1140536Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575858}
-
Dominick Ng authored
Some types of user interactions are used as a signal to ResourceDispatcherHostImpl. Prior to https://crrev.com/1735833002, scrolling was not one of them, and part of that CL's work explicitly filtered out MouseWheel events from being passed to ResourceDispatcherHostImpl. It also changed user-initiated navigations to call the new DidGetUserInteraction method with the blink::WebInputEvent::Undefined type. However, only a limited subset of user-initiated navigations were passed through this method: Ctrl-R/refresh button reloads, omnibox navigations, and NTP/bookmark navigations. Other user-initiated navigations such as back/forward buttons were omitted. https://crrev.com/1776843003 introduced wheel gesture events that generalised touch and mouse scrolling into one concept. https://crrev.com/1748553002 updated the user interaction code to use the new GestureScrollBegin event in place of MouseWheel events, but did not update the type check for forwarding to ResourceDispatcherHostImpl. https://crrev.com/1964863002 introduced NavigationHandle::IsRendererInitiated, which returns true if a navigation was initiated by the renderer process, and false if it was initiated by the browser process (i.e. it was user-initiated). This is a broader scope that the existing user-initiated navigations signaled through DidGetUserInteraction, namely including back/forward navigations. This CL improves on the user gesture handling in WebContentsImpl by: * removing user-initiated navigations from DidGetUserInteraction, and updating clients to listen to Did{Start/Finish}Navigation and check NavigationHandle::IsRendererInitiated. This includes more types of user-initiated navigations. * restoring the user gesture signal to ResourceDispatcherHostImpl back to how it was prior to https://crrev.com/1748553002 - listening to keydown, mouse click, taps, and certain user-initiated navigations. BUG=827659 Change-Id: I639270b21446104f22c8ae9b8b939eb96af3cabd Reviewed-on: https://chromium-review.googlesource.com/1125703Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#575857}
-
Alex Moshchuk authored
This should help investigate a theory that a message to create a RenderFrameProxy is sent when that proxy already exists in the renderer process. Bug: 794625 Change-Id: I2bf7dc1312dc3cbf8d307c8358ac64c8402fe875 Reviewed-on: https://chromium-review.googlesource.com/1139186Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#575856}
-
Chris Harrelson authored
This matches behavior already implemented in PaintLayerPainter, which was added to greatly simplify the problem of detecting clip property node invalidations upon change of clip (but not addition or removal of such clips). With the rollout of SPv175, invalidation under SVG transforms is also subject to this need. Before SPv175, non-composited transform mutations caused a forced subtree invalidation. Now there is an invalidation of the property on the PaintChunk under the transform, but the chunk itself is not re-painted. This requires the chunk to be complete and not partially culled out, which is why there is a requirement for an infinite cull rect. Note that this will increase performance of animations under SVG transform, which no longer need to paint the sub-content. (This same type of use case for CSS transform was another justification for the infinite cull rect in PaintLayerPainter). Bug: 862318 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibb65c7fd491b1be725a6aa05a33e9ba7cc03782d Reviewed-on: https://chromium-review.googlesource.com/1139583 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#575855}
-
Georges Khalil authored
Change-Id: I1bbeefa0bb68da658443e65ed1f9d63a510c4ed8 Bug: 826298 Reviewed-on: https://chromium-review.googlesource.com/1141050Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#575854}
-
Darren Shen authored
In the new UI, we have to draw the keyboard drop shadow manually in the extension because of the non-rectangular geometry of the new floating keyboard. So we just disable shadows. When shadows are added in the extension, the keyboard window should resize correctly. Change-Id: I8530779930c109c834f33c5f673dbcc553ced6a2 Reviewed-on: https://chromium-review.googlesource.com/1139948 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#575853}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3229e65886a0..21a99d42c34f git log 3229e65886a0..21a99d42c34f --date=short --no-merges --format='%ad %ae %s' 2018-07-17 junov@chromium.org Fix validity check in SkSurface::MakeFromBackendTextureAsRenderTarget 2018-07-17 ethannicholas@google.com fixed SPIR-V memory layout 2018-07-17 allanmac@google.com Use std::chrono for measuring timing 2018-07-17 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-17 ruiqimao@google.com fix MSAN dm failures Created with: gclient setdep -r src/third_party/skia@21a99d42c34f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:788439 TBR=bungeman@chromium.org Change-Id: I0d28ef2fa612e4d10cb0e778a4332769bba7aa49 Reviewed-on: https://chromium-review.googlesource.com/1140537Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575852}
-
Chris Lu authored
- Increases top spacing to 13px - Decreases bottom spacing to 0px so that the vertical spacing between footnote labels in Clear Browsing Data is not massive. Screenshots: https://drive.google.com/open?id=12DY7uMoFwu0qpy93N3nUEdsBPIDeaJlQ, https://drive.google.com/open?id=1XARsG_J1dvUu1gSDVBJW4qTfPVMTp8mN Bug: 863330 Change-Id: I92b7b4d09617353d6ccba088ea8fa3675b32c986 Reviewed-on: https://chromium-review.googlesource.com/1141056Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#575851}
-
Peter Collingbourne authored
We aren't currently building libc++ ourselves, which means that once we enable ThinLTO in official builds, libc++ won't be built with LTO, which is a violation of the LTO visibility rules, which require all classes with hidden visibility to be built with LTO when using the CFI or whole-program devirtualization features: https://clang.llvm.org/docs/LTOVisibility.html This hasn't caused any problems in practice as far as I know, but it could in theory, so it's probably best to disable it to be safe. We should be able to re-enable it on Android once issue 767901 is fixed and we create another GVR shim prebuilt compiled with ThinLTO. Bug: 469376, 767901 Change-Id: Ic5554c48c1d4a458a834b16b9f7bd20523871282 Reviewed-on: https://chromium-review.googlesource.com/1141108Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#575850}
-
danakj authored
RenderViewImpl should not be a RenderWidget, but it must be while it is a WebViewClient and RenderWidget, which is a WebWidgetClient. So this contributes to the separation of RenderViewImpl and RenderWidget. This also removes the diamond inheritance of WebWidgetClient by RenderWidget and RenderViewImpl: RenderWidget WebWidgetClient -< >- RenderViewImpl WebViewClient So RenderWidget no longer needs to use virtual inheritance of the WebWidgetClient. Previously WebViewClient was-a WebWidgetClient. Instead make them separate interfaces, and start to pass them both explictly when they are both used. Since WebViewClient has a method to return the WebWidgetClient, we can use that in cases where we only have one. We could pass them both explicitly to cover these cases too, as a path to migrate the method off WebViewClient and make them completely independent. Layout tests create a RenderWidget by creating a WebWidgetTestProxy which subclasses RenderWidget and overrides behaviour of WebWidgetClient methods that RenderWidget implements. This continues to work okay. But they also create a RenderViewImpl by creating a WebViewTestProxy which subclasses RenderViewImpl, and also try to override behaviour of the WebWidgetClient. However since RenderViewImpl is no longer visibly a WebWidgetClient, it does not by changing what WidgetClient() returns instead of overriding methods on RenderViewImpl. This means that production code in RenderViewImpl and RenderWidget trying to call methods on WebWidgetClient must not do so directly on |this| (ie on the RenderViewImpl-RenderWidget). Instead they must go through WidgetClient() which will point to the RenderWidget() in production but to an injected WebWidgetTestClient in layout tests. Before: WebViewTestProxy is-a RenderViewImpl (is-a WebViewClient is-a RenderWidget is-a WebWidgetClient *1*) WebViewTestProxy has-a WebViewTestClient (is-a WebViewClient is-a WebWidgetClient *2*) WebViewTestProxy is-a WebWidgetTestProxyBase WebWidgetTestProxyBase has-a WebWidgetTestClient (is-a WebWidgetClient *3) WebWidgetTestProxy overrides some methods from RenderWidget *1* and redirects them to the WebWidgetTestClient *3* After: WebViewTestProxy is-a RenderViewImpl (is-a WebViewClient is-a RenderWidget is-a WebWidgetClient *1*) WebViewTestProxy has-a WebViewTestClient (is-a WebViewClient has-a WebWidgetClient *2*) WebViewTestProxy is-a WebWidgetTestProxyBase WebWidgetTestProxyBase has-a WebWidgetTestClient (is-a WebWidgetClient *3) WebWidgetTestProxy has a ProxyWebWidgetClient which forwards most things to the RenderWidget *1* but ProxyWebWidgetClient redirects some methods to the WebWidgetTestClient *3* Note that *2* changes from inherited to ownership instead, though it's not clear that the WebWidgetTestClient ever is asked for its WebWidgetClient, since it is only used to capture some calls that would have gone to the RenderViewImpl. R=dcheng@chromium.org TBR=jochen Bug: 419087 Change-Id: I26ce181e8cf31d1fa9244d448a7e01f401081ac8 Reviewed-on: https://chromium-review.googlesource.com/1134427 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:danakj <danakj@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#575849}
-
Aidan Wolter authored
Internal CMA backends may need to be created lazily, because they depend on the initialization of other internal components. BUG=b:111465269 TEST=Build, play YT and GPMusic Change-Id: I781b028391e35e8c21b6a3e28e5d11ad891adad3 Reviewed-on: https://chromium-review.googlesource.com/1139099 Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#575848}
-
Alexander Alekseev authored
This Cl adds basic elements of the Discover App: DiscoverManager, DiscoverUI, DiscoverModule, etc... Bug: 828999 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I526032df033d68bfae4583e9872262ad8af79219 Reviewed-on: https://chromium-review.googlesource.com/1103457 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#575847}
-
Ben Pastene authored
Some tests are failing, so this adds them to a filter file and adds it in a la fuchsia. Bug: 860066, 840967 Change-Id: I6ebe67a0d4a5ab5e58c543524d36ada6ae55219f Reviewed-on: https://chromium-review.googlesource.com/1136884Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#575846}
-
Aidan Wolter authored
Just as media_service currently can access the multizone service, we are adding this capability to the content_browser service. CastAudioOutputStream runs in content_browser and requires this. BUG=b:111465269 TEST=Build, play to MZ group through CastAudioOutputStream Change-Id: I1ffad39d6c61a457f516960228e546462581bef6 Reviewed-on: https://chromium-review.googlesource.com/1139102Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#575845}
-
Koji Ishii authored
This patch adds NGLineInfo and NGInlineItemResults to the member field of NGLineBreaker. These are the output of the NGLineInfo, analogous to NGContainerFragmentBuilder to NGLayoutAlgorithm. Adding to the member fields makes NGLineBreaker closeer to NGLayoutAlgorithm. Note, NGInlineItemResults should be local and should std::move when the line is complete if we follow the existing pattern. It has inline buffer however, which makes std::move expensive. This patch keeps it as a pointer to the buffer in NGLineInfo. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ibc66fae8a8653196535dfa469b94a3255c0cd8e8 Reviewed-on: https://chromium-review.googlesource.com/1138136 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#575844}
-
Daniel Murphy authored
R=pwnall@chromium.org Bug: 857464 Change-Id: I36d154ddcbafd4592b0fb4e73e201c2ffdcdf197 Reviewed-on: https://chromium-review.googlesource.com/1141062 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#575843}
-
Xiaocheng Hu authored
This reverts commit 84c92630. Reason for revert: Suspected to cause compile failure at https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20Release%20%28Nexus%205X%29/8033 Original change's description: > Return unclipped bounds for get_characterExtents > > For get_characterExtents(): > - The x,y position should be unclipped (allowed to be negative or larger than the screen width/height). > - The width/height should not be changed to 1 for offscreen objects. > > Bug: 864195 > Change-Id: Ibea1f3ecb0b8f5f72c6fc967892ac9e6b1af135b > Reviewed-on: https://chromium-review.googlesource.com/1138800 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575831} TBR=dmazzoni@chromium.org,aleventhal@chromium.org Change-Id: I5efff2e628b9518039777b8317a581c4c0bc326e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864195 Reviewed-on: https://chromium-review.googlesource.com/1140459Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575842}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6896f144. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21502 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Ifae32de68d2d023835a42274ff10f86e39c089a0 Reviewed-on: https://chromium-review.googlesource.com/1141077 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575841}
-
Christian Fremerey authored
The struct media::VideoCaptureDeviceDescriptor contains a field for facing_mode. The corresponding mojo struct does not contain this field. Because of it, the information will be dropped when crossing a Mojo boundary, i.e. when the video capture service is used. Bug: 829114 Change-Id: I8193c3db125450e80dd9f30b7babee3063013ef9 Reviewed-on: https://chromium-review.googlesource.com/1140956Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#575840}
-
Tarun Bansal authored
Enable the experiment to schedule HTTP requests to SPDY proxies via resource scheduler. The experiment has been running on Stable M-67+ for some time. Results here: http://shortn/_xRuL16I5De, and they show slight page load performance improvement. With the experiment disabled, HTTP requests to SPDY proxies would bypass scheduling enforced by resource scheduler, and sunh requests would be immediately dispatched on the network. With the experiment enabled (as well as with this CL), the HTTP requests to SPDY proxies are also subject to scheduling. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8e11e454addde53a6196d8af728bc0e5a4ecc789 Bug: 838253 Reviewed-on: https://chromium-review.googlesource.com/1137982Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#575839}
-
Victor Costan authored
Bug: 851064 Change-Id: I7ffae296f903b14c3953019cd380b19a007e2471 Reviewed-on: https://chromium-review.googlesource.com/1137845Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#575838}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4597e0c46fc5..dbdb3a00797d git log 4597e0c46fc5..dbdb3a00797d --date=short --no-merges --format='%ad %ae %s' 2018-07-17 stefan@webrtc.org Refactoring PayloadRouter. 2018-07-17 yinwa@webrtc.org Implement congestion window direct pushback to encoders. (Without TaskQueue) 2018-07-17 buildbot@webrtc.org Roll chromium_revision c0988740..9ec8cfdb (575517:575625) 2018-07-17 sakal@webrtc.org Update CameraCapturer to use the new CapturerObserver. 2018-07-17 ilnik@webrtc.org Revert "Enable simulcast screenshare by default" 2018-07-17 oprypin@webrtc.org Replace accidental usages of source_set with rtc_source_set 2018-07-17 ilnik@webrtc.org Enable simulcast screenshare by default 2018-07-17 mbonadei@webrtc.org Enabling clang::find_bad_constructs for common_audio. 2018-07-17 aleloi@webrtc.org Fuzz more kinds of floats in the APM fuzzer. 2018-07-17 saza@webrtc.org Cap the number of fuzzed decoder packets to 200 2018-07-17 aleloi@webrtc.org Division by zero in RNN-VAD. 2018-07-17 mbonadei@webrtc.org Enabling clang:find_bad_constructs from modules/utility. 2018-07-17 mbonadei@webrtc.org Enabling clang::find_bad_constructs for AEC3. 2018-07-17 stefan@webrtc.org Reland "Move allocation and rtp conversion logic out of payload router." 2018-07-17 pitlicek@gmail.com Call callback in IDLE state Created with: gclient setdep -r src/third_party/webrtc@dbdb3a00797d The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:690537,chromium:None,chromium:690537,chromium:840115,chromium:861557 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3b5867a0365875ae906aea0d9929dd6529c31160 Reviewed-on: https://chromium-review.googlesource.com/1140903Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575837}
-
Mark Pilgrim authored
Change-Id: Icc9786d1f484687e9488bf565893afe023e2b40a Reviewed-on: https://chromium-review.googlesource.com/1135297 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#575836}
-
Fady Samuel authored
This test is no longer valid once surface synchronization is on. Bug: 855533 Change-Id: If8feae783911501b7962183b367b0c69d8371e62 Reviewed-on: https://chromium-review.googlesource.com/1141110 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#575835}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d691aeeb956f..252ec9191125 git log d691aeeb956f..252ec9191125 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 geofflang@chromium.org Vulkan: "Implement" EGL_ANGLE_display_texture_share_group Created with: gclient setdep -r src/third_party/angle@252ec9191125 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9175effb7895c44dfb94bea0ca46919cb32d3b10 Reviewed-on: https://chromium-review.googlesource.com/1140796Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575834}
-
CJ DiMeglio authored
This is a reland of 6be34509 TBR=dcheng@chromium.org,enne@chromium.org,fsamuel@chromium.org,junov@chromium.org,mlamouri@chromium.org,liberato@chromium.org Original change's description: > Prevents compositor frames from being sent when SurfaceLayer is not visible. > > This CL is 3/3 in effort to fix the regressions caused by sending > unneeded compositor frames. > > This CL provides a signal from the SurfaceLayerImpl to the VideoFrameSubmitter > to prevent compositor frames from being sent at undesired times (occlusion, not > being added into the layer tree). > > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I428860047eaf4c50abc2e662914a643158f1276b > Reviewed-on: https://chromium-review.googlesource.com/1101708 > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Justin Novosad <junov@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575462} Change-Id: Idba341813f1202991c8cb5da94ea72d234db56eb Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Bug: 864358 Reviewed-on: https://chromium-review.googlesource.com/1140458Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#575833}
-
chrome://conflictsPatrick Monette authored
- Add the state of the 2 third-party related feature at the top of the chrome://conflicts page. - Add a column to chrome://conflicts for the status of each module when one of the 2 features is active. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I633899f813aa03389239c1adf8f11bf1419ade0e Reviewed-on: https://chromium-review.googlesource.com/1133965 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#575832}
-
Aaron Leventhal authored
For get_characterExtents(): - The x,y position should be unclipped (allowed to be negative or larger than the screen width/height). - The width/height should not be changed to 1 for offscreen objects. Bug: 864195 Change-Id: Ibea1f3ecb0b8f5f72c6fc967892ac9e6b1af135b Reviewed-on: https://chromium-review.googlesource.com/1138800 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#575831}
-
Ryan Sturm authored
Only data saver users should see the capping heavy pages InfoBar. Bug: 864613 Change-Id: Id7a9c41ac0476b1df9a040e91865935440824162 Reviewed-on: https://chromium-review.googlesource.com/1140682 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Cr-Commit-Position: refs/heads/master@{#575830}
-
David Black authored
Previously, we opened the mic but failed to transition to voice input modality in response to the OnInteractionStarted event. This causes some latency as the input modality would not be updated until we received a SpeechRecognitionStarted event. Bug: b:80186902 Change-Id: I9cd58243fb47d1bcdaeb71736809ad7279376176 Reviewed-on: https://chromium-review.googlesource.com/1140777 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#575829}
-
Daniel Park authored
Sets tint for delete icon to default icon color Darkens help and feedback color to default icon color Picture in bug link Bug: 863796 Change-Id: I08c3a5a2a261d1725a96500919ea634b253636bd Reviewed-on: https://chromium-review.googlesource.com/1141059Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#575828}
-