- 17 Apr, 2018 40 commits
-
-
Simeon Anfinrud authored
No more detatchWebContentsIfAny() and similar helpers. This boils the presentation of WebContents into a simple state machine compatible with Observables. This refactor includes covering the business logic of CastWebContentsSurfaceHelper in unittests. The implementation details of CastWebContentsView are still not unit-tested, but are now better isolated from other logic. Bug: Internal b/36777136 Test: cast_shell_junit_tests Change-Id: Ia555b4d3ea9ee07607bf54cc339b950fe068d220 Reviewed-on: https://chromium-review.googlesource.com/1003412Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551464}
-
Patrick Noland authored
Change-Id: Id73ec54e7a4e66f75cb7f4c294b923f851f00ae9 Reviewed-on: https://chromium-review.googlesource.com/1014406Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#551463}
-
David Reveman authored
Bug: 833986 Test: No delays when using copy-and-paste in Crostini. Change-Id: I6722dbd81548b760db8e1ae9a4e3cd1d4c6bf645 Reviewed-on: https://chromium-review.googlesource.com/1015700Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551462}
-
https://chromium.googlesource.com/angle/angle.git/+log/aa8b3982aeeb..aed1b56aac8e $ git log aa8b3982a..aed1b56aa --date=short --no-merges --format='%ad %ae %s' 2018-04-17 jmadill Prerequisite code for simpler GlslangWrapper. 2018-04-13 lucferron Vulkan: Fix issue in GlslWrapper and maxVaryingVectors calculation 2018-04-17 lucferron Vulkan: clearRegionWithScissor did not determine the region correctly 2018-04-16 lfy GLES1: gl(Enable|Disable)ClientState 2018-04-17 jmadill Vulkan: Fix build after roll. 2018-04-17 jmadill Vulkan: Suppress ClearIssue test. 2018-04-16 jmadill Vulkan: Disable warning in Mock ICD. 2018-04-16 tobine Roll (2/2) to latest LVL as of 4/16/18 Created with: roll-dep src/third_party/angle BUG=chromium:833736 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I7c7f1fb47c5cde7e4552f40d084fcd9d1af2e9ee Reviewed-on: https://chromium-review.googlesource.com/1015624Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551461}
-
Dmitry Gozman authored
These are used across processes and should be in common. It also unblocks moving public manifest files to blink/public/common and later moving manifest implementation to blink. NOPRESUBMIT=true Bug: none TBR: oshima@chromium.org, dtrainor@chromium.org Change-Id: Ief909ae1d5f42cb6f4cb58c4119b17f79b6682a8 Reviewed-on: https://chromium-review.googlesource.com/1007899 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#551460}
-
David Bokan authored
Turns out we can have a focused Element that doesn't have a LayoutObject. Just early out in this case when we try to scroll it into view. Bug: 833746 Change-Id: Ia68492bf5cd4cbb538b5e9c53a75433a48ac5463 Reviewed-on: https://chromium-review.googlesource.com/1015533Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551459}
-
Sigurdur Asgeirsson authored
R=chrisha@chromium.org Bug: 755840 Change-Id: Ife8febb03b0fb8d48b864b9987488d90893c4bbf Reviewed-on: https://chromium-review.googlesource.com/1005408 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#551458}
-
Lei Zhang authored
Also add OWNERS for components/resources/printing_resources.grdp BUG=792294 Change-Id: If488698218b7a713db961d54c7a1cf811ab94a8b Reviewed-on: https://chromium-review.googlesource.com/989426Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jianzhou Feng <jzfeng@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#551457}
-
Erik Luo authored
Adds [Affects=Nothing] to common IDL methods/attributes with return types: short, long, double, int, boolean, DOMString, USVString. Followups will whitelist ones that use DOMWrapper and update style or layout. List of some common attributes: https://goo.gl/qGd2i7 Bug: 829571 Change-Id: I4c335b7eeac449bd7454df7f829f393469d84387 Reviewed-on: https://chromium-review.googlesource.com/1013126Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Artur Khachatryan authored
Change-Id: I4d720df1d47dd095a0cbfc65b774fedce244911d Reviewed-on: https://chromium-review.googlesource.com/1015085Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551455}
-
Hector Carmona authored
Bug: 821736 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I849ddd15a632309e09c8fec627832c41b0d39abb Reviewed-on: https://chromium-review.googlesource.com/1014623 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#551454}
-
Greg Thompson authored
The bg color is used in such places as the Notification Center and the start menu. This makes them look more like the Start Menu tile, which has a white background of its own. BUG=722573 Change-Id: I413b89340a34f5f2700528ff058c4432feb38883 Reviewed-on: https://chromium-review.googlesource.com/1013465Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#551453}
-
David Reveman authored
Bug: 833986 Test: No delay in arc++ when adding new gamepad. Change-Id: If314b5c7af90b7c308a13abf51bff5e5d27e9b77 Reviewed-on: https://chromium-review.googlesource.com/1015550Reviewed-by:
-
Dan Sanders authored
This enables VdaVideoDecoder to construct VDAs for all platforms except Android. Changes to enable VdaVideoDecoder on Mac are included; pass --enable-features=MojoVideoDecoder to test. Bug: 522298 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I99a37e43f7225bc11f134743b91c307f106cf7a3 Reviewed-on: https://chromium-review.googlesource.com/1011256 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#551451}
-
https://pdfium.googlesource.com/pdfium.git/+log/8cfcb7da3735..8b4a3c7ef32b $ git log 8cfcb7da3..8b4a3c7ef --date=short --no-merges --format='%ad %ae %s' 2018-04-17 tsepez Use span in CXFA_LocaleValue::GetDoubleNum() 2018-04-17 tsepez Re-land "Return pdfium::span<char> from ByteString::GetBuffer()."" 2018-04-17 thestig Add constants for PDF 1.7 spec, table 3.4. 2018-04-17 tsepez Reland "Return pdfium::span<wchar_t> from WideString::GetBuffer()."" Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I995bfe644deef92ae2e11caff4971e1606832783 Reviewed-on: https://chromium-review.googlesource.com/1015525 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551450}
-
Devlin Cronin authored
Instead of having ExtensionBrowserTest (and everything deriving from it) allow manifest v1 extensions, make ExtensionBrowserTest only allow these when the test class opts into it (via ExtensionBrowserTest::ShouldAllowLegacyExtensionManifests()). This will make it easier to chip away at these and remove usages. Bug: 816679 TBR=gab@chromium.org (trivial change in pref_hash_browsertest.cc) Change-Id: I771d5b96b96b49104cbcdd26e7b5f377c44153be Reviewed-on: https://chromium-review.googlesource.com/1014183 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551449}
-
Jay Civelli authored
Makes services/service_manager/sandbox/switches.h the only place for sandbox related switches, removing the dupped ones in content and changing all call sites. Tbr: bradnelson@chromium.org Bug: 831846 Change-Id: I08928c664e0e2340ac5168d6fd94a07bbeb81266 Reviewed-on: https://chromium-review.googlesource.com/1012986 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Veranika Liaukevich authored
Change-Id: Ie559fbf3eff5e7010b8ff0728a89a49aaa200731 Reviewed-on: https://chromium-review.googlesource.com/1015282 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#551447}
-
David Reveman authored
This is only a problem if the keymap changes while the client is running. Bug: 833986 Test: weston-eventdemo Change-Id: I239870812a9c971132c331b5f3c3f257cda72547 Reviewed-on: https://chromium-review.googlesource.com/1015507Reviewed-by:
-
dpapad authored
This is a reland of cdf4606b. Retrying to land this now that crbug.com/833656 is fixed. Original change's description: > Roll closure compiler > > Latest compiler version does not include Chrome's externs by default. They > need to be explicitly included. > > Change log: > https://github.com/google/closure-compiler/compare/8fc82299c45b0a33f19834222acda4850fd77bc0...5cae9b78a16a2655627733b66d1c686d5f547925 > chrome.js: 7ef3422e1e87480d560247d75fee181b4cac24d9 > chrome_extensions.js: 3a0b0052782af3f0bd3a5fe10bb568cdd769db4e -> 03c824e85e7b77bde4e7449ed3727608b05b2acc > polymer-1.0.js: 55e962227e676cd30f81439573771326933aae54 -> 8f3b8c9354813ae0e2f186bf2f504cf3f3182a66 > > BUG=831004 > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I0db559ee9a198dadd3b23e57b835cc6b985540a9 > Reviewed-on: https://chromium-review.googlesource.com/1006182 > Reviewed-by: calamity <calamity@chromium.org> > Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551058} TBR=calamity Bug: 831004 Change-Id: I0966b1a07da3b6318fb22a6bc6393eb499446743 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1015180Reviewed-by:
-
Robert Liao authored
This reverts commit 902d73ba. Reason for revert: This causes the ExtensionPopup to dismiss if it brings up a child dialog. See http://crbug.com/832623 Fixing this will require adding support to check for descendant NativeWidget activation, which is too big to merge. Original change's description: > Adjust ExtensionPopup Dismissal Behavior > > Before, dismissing the ExtensionPopup when the anchor window received > focus was an arbitrary decision (http://crbug.com/179786) that allowed > the ExtensionPopup to dismiss at most of the right times. However, if > the some other top-level window received activation, the ExtensionPopup > would not dismiss, unlike a typical menu. > > This change adjusts the ExtensionPopup to always dismiss when it loses > activation as long as devtools is not attached. > > When devtools is detached, activation is placed back on the > ExtensionPopup so that the normal dismissal behavior can continue to > work. Failure to receive activation means the ExtensionPopup will not > dismiss until it receives activation at least once. > > BUG=825867 > > Change-Id: I802af281616c66013c370e892953ad2805533728 > Reviewed-on: https://chromium-review.googlesource.com/984404 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547391} TBR=ellyjones@chromium.org,sky@chromium.org,robliao@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 825867, 832623 Change-Id: I69678b789fdbc56501e67b62dd41467e5f2f8cc9 Reviewed-on: https://chromium-review.googlesource.com/1015181 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551444}
-
Morten Stenshorne authored
The test was incorrect, which is why it failed in legacy layout. It passed in LayoutNG because of a bug there. Add an (invisible) top border on the outer DIV to prevent clearance on the child. Otherwise the outer DIV and the child with 'clear' would have adjacent margins, which in turn would enable the child with 'clear' to pull the float along with itself, which in turn would guarantee clearance, which is precisely what this test wanted to avoid. Still passes in LayoutNG. Change-Id: I6b36d8196b93720453d6e398509705d2cf32f8e4 Reviewed-on: https://chromium-review.googlesource.com/1014975Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#551443}
-
Xiaocheng Hu authored
This patch revises the cold mode idle time spellchecker that, it only checks the editable element that is currently focused, instead of checking the full document, so that the checker is less aggressive and less resource consuming. Bug: 824030, 716642 Change-Id: I1361b53b4dd3513252ef50d0356497c0a4054ecd Reviewed-on: https://chromium-review.googlesource.com/1014472 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551442}
-
Takumi Fujimoto authored
This is a reland of d37f3a32 This fixes the issue of attributes in UIMediaSink not being initialized at instantiation, which was breaking MSAN builds. TBR=estade@chromium.org,bsep@chromium.org Original change's description: > Implement sink list button for Harmony Cast dialog > > - Add CastDialogSinkButton, which will be used for sink list items in > the Harmony Cast dialog. It's a subclass of HoverButton that shows a > device icon and an optional status indicator (checkmark or throbber). > - Add UIMediaSink, a struct containing data used to populate the button > - Add Skia icons used by the button: Cast for EDU, input, speaker, > speaker group, and TV > > Screenshot of the button (two of them) in a WIP dialog: > https://drive.google.com/file/d/1M1R9jO-VHEO18aA3pTpoQBI4FHMU5MEf/view?usp=sharing > > Dimensions and colors are subject to change in later CLs. > > Bug: 826089, 826393 > Change-Id: I0eef58e1c0b9bf2cff3b3d146e911d3a18c7d23c > Reviewed-on: https://chromium-review.googlesource.com/996458 > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Adam Parker <amp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550722} Bug: 826089, 826393 Change-Id: Ib9343fc56a96f128c3b3d2bfa5e82542e94a4441 Reviewed-on: https://chromium-review.googlesource.com/1014540Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Adam Parker <amp@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#551441}
-
https://webrtc.googlesource.com/src.git/+log/6dfc8d6ef3b2..4478d9b7733d $ git log 6dfc8d6ef..4478d9b77 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0c840e576be99c817a3a422bace6b58d7eb6d749 Reviewed-on: https://chromium-review.googlesource.com/1014952Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551440}
-
Tommy Steimel authored
Bug: 809021 Change-Id: Ia8adffa5011fa6e2ae1d1aeef727f407eb9ccb2d Reviewed-on: https://chromium-review.googlesource.com/1014721Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Wez authored
Bug: 823529 Change-Id: I5620f741d815619bc91bdf60ad09fa2dd24ef79c Reviewed-on: https://chromium-review.googlesource.com/1013391Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#551438}
-
Tibor Goldschwendt authored
Change-Id: I7884167434cb9796aa5a7c9d9ac22180219466cb Reviewed-on: https://chromium-review.googlesource.com/998409Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551437}
-
Rohit Rao authored
BUG=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ied5177a665451fc1a50f1b79a0c5f2bc27f1eba6 Reviewed-on: https://chromium-review.googlesource.com/1015542Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551436}
-
Xianzhu Wang authored
For now partial raster invalidation of SPv175+ is buggy. Disable it first to fix regressions. Pinpoint job for smoothness.tough_canvas_cases benchmark doesn't show performance regressions of this CL: https://pinpoint-dot-chromeperf.appspot.com/job/14b05086c40000 Bug: 833338, 833598 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I52545c5cc757f045afa3df1c98221a28f25d5689 Reviewed-on: https://chromium-review.googlesource.com/1013298Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#551435}
-
Yang Guo authored
V8 introduced a new API that no longer requires the source string. Change-Id: If09c25a2892633a4aedadb62e963c50ffa291cbe Reviewed-on: https://chromium-review.googlesource.com/1013519 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Vaclav Brozek authored
password_form_conversion_utils.cc used the constructor of std::unique_ptr explicitly. This is to be avoided in Chromium's code (//PRESUBMIT.py has a check against introducing new instances) and nullptr and std::make_unique are preferred. form_autofill_util.cc used a raw owning pointer and base::WrapUnique to convert it to std::unique_ptr. Instead, the owned object should be wrapped in unique_ptr since construction, to avoid the risk of introducing a leak later. This CL fixes both issues mentioned above. Bug: 833838 Change-Id: Id62f146e69a659bd594678989310f2d212151572 Reviewed-on: https://chromium-review.googlesource.com/1013716 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#551433}
-
rbpotter authored
Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I01397a7c4b94a2a3d3f71ef80d0fb38abd7f29dd Reviewed-on: https://chromium-review.googlesource.com/1011324Reviewed-by:
-
Vaclav Brozek authored
SyntheticForm's data member fieldsets is only set and used once, in the same function. Therefore this CL reduces the size of SyntheticForm and extracts the fieldsets data member as a local variable in said function. Bug: 833838 Change-Id: Ie5970adf3b0a2c52c783e599b658d1d0f27473eb Reviewed-on: https://chromium-review.googlesource.com/1014043 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/130fd7666d42..30a2b933e3a0 $ git log 130fd7666..30a2b933e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icb5791b7c4cee1c7997ee59134506e426c08e836 Reviewed-on: https://chromium-review.googlesource.com/1015082 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551430}
-
Xiaocheng Hu authored
This patch deduplicates code in the function to improve code health, and also as a preparation for implementing NG version of bidi adjustment. Bug: 822575 Change-Id: Ia975338ff11d2e53d73f084e4b55419b03c2938c Reviewed-on: https://chromium-review.googlesource.com/997134 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Jennifer Apacible authored
BUG: 726619 Change-Id: I17314a2e1989cf2f2b760d9f931fd53272730440 Reviewed-on: https://chromium-review.googlesource.com/1013683Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#551428}
-
Daniel Erat authored
Enable mode-specific power button behavior by default. In short, tapping the power button turns the display off on devices that are in tablet mode but is ignored on devices that are in laptop mode. Bug: 819276, 783164 Change-Id: Ic658e034366a32066940c647a73b8c61ecec2840 Reviewed-on: https://chromium-review.googlesource.com/1014486 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#551427}
-
Steven Bennetts authored
Using a separate name div breaks dragging when the name is dragged and isn't necessary. Bug: 833036 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia9bcc8556018e9dd6d76e0dac6221ecbf85997c7 Reviewed-on: https://chromium-review.googlesource.com/1014624 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551426}
-
Vaclav Brozek authored
A SyntheticForm is an object created specifically for the GetPasswordForm function to consume. Yet, the function only takes a const reference of a SyntheticForm. This prevents the function from sparing some copies in moving data from a SyntheticForm to a PasswordForm. This CL changes the const reference to a plain value, moves the SyntheticForm via std::move on the callsites, and ensures that SyntheticForm has a move constructor. Bug: 833838 Change-Id: Iaee54b092c7f12b91b2afd35f4882b9d451ce668 Reviewed-on: https://chromium-review.googlesource.com/1013983 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
