- 13 Jan, 2021 40 commits
-
-
Yue Zhang authored
Old fallback icon: https://drive.google.com/file/d/1P4EuaMFbiwqBASNa_L4-ku7e8qDW9TUW/view?usp=sharing&resourcekey=0-zS83XcqbTFlFDFvdJYvLFg New fallback icon: https://drive.google.com/file/d/18EHhQzDu9MO2Xts_16F2tg4ldVDWWn8J/view?usp=sharing&resourcekey=0-HppUS-6Mru9nk35DgfGImQ Bug: 1157892 Change-Id: I1ca918ab039b6bf9a11befef118d46b8bc99ce5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627437 Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#843251}
-
Jesse Doherty authored
This action is logged at the same time as RenderViewContextMenu.Used::IDC_CONTENT_CONTEXT_SEARCHWEBFOR. The value is used as part of a high-level guiding metric. We're trying to consolidate these metrics as user actions to improve query speeds and enable new analysis. Bug: b/161525144 Change-Id: Id084907ea8b00954b7a235385c7b9ec75d4d642f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628149 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843250}
-
Sam Thorogood authored
This will control whether we document a Promise-ified version of an API. (Chrome's implementation CPP already pierces into the JSON directly to answer the support Q.) Bug: 1142991 Bug: 1143020 Change-Id: I1a3c29c7d1c21cc52b55b88db12478e4b1e14811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569130Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Sam Thorogood <thorogood@google.com> Cr-Commit-Position: refs/heads/master@{#843249}
-
Ben Mason authored
R=govind@google.com Change-Id: If1a77000b27fb1e818d46e66706cba92fb57fc61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625997 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#843248}
-
Tom Sepez authored
A DCHECK() here isn't sufficient to prevent the use of uninitialized memory should this someday return false. Bug: 1166091 Change-Id: I4cfd28653f2e6882f227299d68605be706b75b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628044Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#843247}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I81efe729e921c24db6662daa2c1f87f4d36c73c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626515Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843246}
-
Jeffrey Kardatzke authored
There are downscaling limitations on overlays. When we have reached this limit, rather than failing to promote to an overlay, we clip the content so that the scale factor is within the allowed range. This is more visually appealing than blacking out the quad instead. When doing this we track the range of the max value that worked and the min value that failed. When we first hit a failure, we iteratively increase the value until we have success to find the initial lower bound. Subsequent tests will almost always hit on the first retry. BUG=b:155511837,b:174174828 TEST=Protected content renders w/ clipping when downscaled too much Change-Id: Icf294de47e396fd760f77e9d93b18894c275a1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622762Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#843245}
-
David Roger authored
IDS_SIGNIN_DICE_WEB_INTERCEPT_CONSUMER_BUBBLE_DESC Elisa is already signed in to this Chrome profile. To keep your browsing separate, Chrome can create your own profile for you. https://storage.cloud.google.com/chromium-translation-screenshots/709329fd73bc8bf08cd9f56db998f47bf9afde56 IDS_SIGNIN_DICE_WEB_INTERCEPT_CREATE_BUBBLE_TITLE_V1 Continue in a new Chrome profile? https://storage.cloud.google.com/chromium-translation-screenshots/d1425d72f32531ab6ad2d1787e2a0c5e20837f91 IDS_SIGNIN_DICE_WEB_INTERCEPT_CREATE_BUBBLE_TITLE_V2 Move account to a new Chrome profile? https://storage.cloud.google.com/chromium-translation-screenshots/e1b3d8f599d8e554b4efa2b85e2289020e17f846 IDS_SIGNIN_DICE_WEB_INTERCEPT_CREATE_BUBBLE_TITLE_V3 Separate Chrome profile? https://storage.cloud.google.com/chromium-translation-screenshots/7d40a8bbb90c63280555096b5ddf7c3edda5e105 IDS_SIGNIN_DICE_WEB_INTERCEPT_SWITCH_BUBBLE_DESC A Chrome profile with this account already exists https://storage.cloud.google.com/chromium-translation-screenshots/88c3cc7489c08fffe78b92d0d10ffef32d9c88cf IDS_SIGNIN_DICE_WEB_INTERCEPT_SWITCH_BUBBLE_DESC_V2 Bob's profile is linked to bob@gmail.com https://storage.cloud.google.com/chromium-translation-screenshots/7b055dcacda680767b62c358a4fd5ffe2f913014 Note: not used in code now IDS_SIGNIN_DICE_WEB_INTERCEPT_SWITCH_BUBBLE_TITLE Switch to existing Chrome profile? https://storage.cloud.google.com/chromium-translation-screenshots/88c3cc7489c08fffe78b92d0d10ffef32d9c88cf IDS_SIGNIN_DICE_WEB_INTERCEPT_BUBBLE_NEW_PROFILE_BUTTON_LABEL_V2 Continue https://storage.cloud.google.com/chromium-translation-screenshots/fc87331e840b0ff507e4778b3cf5c0e870683270 Note: not used in the code for now. IDS_SIGNIN_DICE_WEB_INTERCEPT_BUBBLE_CONFIRM_SWITCH_BUTTON_LABEL_V2 Continue https://storage.cloud.google.com/chromium-translation-screenshots/7b055dcacda680767b62c358a4fd5ffe2f913014 Note: not used in the code for now. IDS_SIGNIN_DICE_WEB_INTERCEPT_BUBBLE_CONFIRM_SWITCH_BUTTON_LABEL Ok https://storage.cloud.google.com/chromium-translation-screenshots/709329fd73bc8bf08cd9f56db998f47bf9afde56 IDS_SIGNIN_DICE_WEB_INTERCEPT_BUBBLE_NEW_PROFILE_BUTTON_LABEL Ok https://storage.cloud.google.com/chromium-translation-screenshots/709329fd73bc8bf08cd9f56db998f47bf9afde56 IDS_SIGNIN_DICE_WEB_INTERCEPT_ENTERPRISE_BUBBLE_DESC This will separate your browsing from bob@example.com https://storage.cloud.google.com/chromium-translation-screenshots/d1425d72f32531ab6ad2d1787e2a0c5e20837f91 Change-Id: I7bbdaddb79084b42005e16c50b100c79f3b4ce3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626658 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#843244}
-
Robert Sesek authored
This will record the ARM CPU's implementer and part number values. Bug: 1164549 Change-Id: I09ea0d852fda6b05c50a16b64bfcde6f4f5f62b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615326 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#843243}
-
Hui Yingst authored
This CL changes BackgroundPart::location from pp::Rect to gfx::Rect so that `background_parts_` can be migrated to PdfViewPluginBase later. Bug: 1101101 Change-Id: Ib2ab5ab6cfb4c58bde3a2a4e71fd2886231a8a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625088 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#843242}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/111ba65a5e3d..8ba0a01d1e59 2021-01-13 enga@chromium.org Ensure all wire child objects are destroyed before their device 2021-01-13 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 395ec2c4aed8 to 313ae9e87f37 (1 revision) 2021-01-13 bclayton@google.com [wgsl]: s/texture_sampled_/texture_ 2021-01-13 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 57166264e01f to 395ec2c4aed8 (2 revisions) 2021-01-13 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 1c200cffd051 to 57166264e01f (4 revisions) 2021-01-13 enga@chromium.org Remove special-casing of device reference/release in the wire 2021-01-13 enga@chromium.org dawn_wire: Make all objects owned by the client 2021-01-13 enga@chromium.org Make the Device ref the Instance 2021-01-13 enga@chromium.org Don't forward device lost errors to the uncaptured error callback 2021-01-13 cwoffenden@gmail.com Further fixes to build with with VS2019 (end2end tests) Also rolling transitive DEPS: https://dawn.googlesource.com/tint from 1c200cffd051 to 313ae9e87f37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1160459 Tbr: dsinclair@google.com Change-Id: I454d4c075a8abb7a910a0d4043c35359db8b88f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843241}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4e3d4af7bd5f..20d3823787dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mpearson@google.com,fdoray@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mpearson@google.com,fdoray@google.com Change-Id: If5140533dff51315e5f24698e316c359d8735336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627292Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843240}
-
Sylvain Defresne authored
The code responsible for the creation of the regular and incognito Browsers was duplicated. Introduce an helper method that creates a Browser associated with a BrowserState and sets it up, then change BrowserViewWrangler to use this method for creating both Browsers. Bug: 1165798 Change-Id: I7a02f7fb8bc3e724ee9064a29956ecd316074e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627318 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#843239}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 742358cf. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, smcgruer@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I7dbe53f34a9d563adbc9195d0d268e102a50ba01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627249Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843238}
-
chrome://appsDaniel Murphy authored
The chrome://apps page can often be loaded / reloaded during WebApp uninstall. Since the event it listens to occurs before uninstall, it can miss this and still display stale apps. This change also has the site listen to OnWebAppUninstalled() to ensure this does not happen. R=cmp@chromium.org Bug: 1164590 Change-Id: I6f02363c3b3afd5ae396e680617de78f099eef13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625333 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#843237}
-
Caitlin Fischer authored
Bug: 1126640, 1166281 Change-Id: I40b983f90e542f84ce112491a01a58bce69decf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626179 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#843236}
-
Karandeep Bhatia authored
This is an unused manifest key which hasn't been used for years. It seems this was used for signature verification: https://codereview.chromium.org/118328/patch/1205/130 but at some point it's use was removed. TODO: Also remove this key from https://developer.chrome.com/docs/extensions/mv2/manifest/ and https://developer.chrome.com/docs/extensions/mv3/manifest/. BUG=None Change-Id: I4ed42510e169c2fca569362820ebb210a1082845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622572Reviewed-by:
-
Jeffrey Kardatzke authored
This sets HW secure codecs and and identifier as required if we are configured for the L1 ChromeOS Factory Daemon CDM. It then selects that CDM if the configuration specifies HW secure codecs and allows a distinct identifier. BUG=b:153111783 TEST=HW_SECURE_* use L1 CDM, otherwise L3 Change-Id: Ia2b4cfeace38755f1b823a8f15ff0cf325fde29b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625817Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#843234}
-
Prabir Pradhan authored
This reverts commit b89a947a. Reason for revert: The CTS failures caused by landing this change for P are being addressed in ag/13257099. For changes required for R, see b/176433665. Original change's description: > Revert "exo: Allow Pointer Capture when window is active" > > This reverts commit 43be36f0. > > Reason for revert: Multiple CTS failures > > Bug: b:175379280 > Bug: b:175514308 > Bug: b:175829322 > > Original change's description: > > exo: Allow Pointer Capture when window is active > > > > Pointer Capture was being rejected by chrome when an app came into > > focus using keyboard shortcuts (Alt-Tab), but was working as intended > > when an app came into focus using the mouse or touchscreen. It was being > > rejected because the capture_surface was the sub-surface of the current > > focused surface. > > > > Since the client is responsible for providing the capture surface > > through the wayland pointer constraints protocol, it is possible > > for the client to request capture on a sub-surface of the current > > active surface. Requesting capture on a sub-surface is a valid request > > for capture. Rather than ensuring that the capture surface is focused > > (used for directing key events), we verify that the active window > > contains the window of the capture surface in its hierarchy before we > > allow the pointer to be constrained to the surface. > > > > This also allows the client to change the cursor while the client has > > capture, even when the mouse cursor is not currently over a client > > window. > > > > BUG=b:153973515 > > TEST=manual: request pointer capture, leave app, return to app using > > Alt+Tab, verify app has pointer capture. > > TEST=exo_unittests > > > > Change-Id: I56e76469f35ea43100748ebe27966464e32805fc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559255 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > > Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> > > Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#832613} > > TBR=oshima@chromium.org,tetsui@chromium.org,prabirmsp@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: b:153973515 > Change-Id: I582f775f37c34149fb7f0c2a6b9162b5e72cbf78 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596065 > Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837908} TBR=oshima@chromium.org,tetsui@chromium.org,prabirmsp@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:175379280 Bug: b:175514308 Bug: b:175829322 Bug: b:153973515 Change-Id: I967663e2936a7d117ee2dce9edb8967ce922dd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605465Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Cr-Commit-Position: refs/heads/master@{#843233}
-
Karandeep Bhatia authored
Queue updateDynamicRules and updateSessionRules API calls to ensure: 1. They only execute once the initial rulesets are loaded from disk. 2. Successive API calls for the same extension execute in a FIFO order. 3. Only one of these calls for an extension executes at a time. Requirement #3 is needed to implement a shared rules limit for session and dynamic rules. The first requirement is needed for only dynamic rules to ensure the initial state for dynamic rules is first loaded up. This replaces the existing base::OneShot mechanism for fulfilling requirement #1. To ensure consistency, we also do the same for updateEnabledRulesets API calls. Doc=https://docs.google.com/document/d/1FZuuQkG8Tl4ee_K3Ls37iFhjynqStfDjApPvB1N8qsw/edit?usp=sharing&resourcekey=0-kZHQzo1D3pIDAFgYoTSV5g BUG=1043200 Change-Id: I4efef10c6d917c600f90f985c105164aa141610b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579716 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: -
Domenic Denicola authored
This was missed in 7dbd3d17. Bug: 751996, 1158853 Change-Id: Ia4c7a56eb397c2c3a40ce69e87f7d1a945940552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627091Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843231}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610538373-fd44620c77870a58d7cfe6c95cdad1d7eb2cbcb8.profdata to chrome-win32-master-1610560659-4ba340836b4bfcb3a336687b253f7e1b1055ef00.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I91e3366c29083d9cbd8ce2d68e7fa615b59027a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627812Reviewed-by:
-
Philip Rogers authored
This metric continues to be useful for ongoing projects and we will be using it for CompositeAfterPaint. Bug: 1165025 Change-Id: Id95574f1736bbaa4be3f2402a20a49e629b5b26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623419 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#843229}
-
Jeroen Dhollander authored
Bug: b/176851446 Test: chromeos_unittests and deployed Change-Id: I1463132c4e545a1ca8aa7b62880b6c6c4125b00f Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615504 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843228}
-
Fabrice de Gans-Riberi authored
Previously, the Cast Streaming Session would be ended after either the audio or video stream received no data for 15s. However, some Cast Streaming Senders sometimes do not send video data for longer than that when there is no video update to send, resulting in the session being prematurely ended. This changes the Cast Streaming Receiver behavior to only end the session if no audio and no video data is received for 15 seconds. As a result, the frame duration has been changed to 10 minutes to prevent a demuxer underflow in the Chrome media pipeline, resulting in delayed playback. Bug: 1166371, b/172139177 Change-Id: I2f66ca009bdedb00ae79ac8e9dda8cc2ebcd16af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617363 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843227}
-
Caroline Rising authored
Bug: 1109316 Change-Id: I67d5b3d69dedab79580370d7d5df9b6173a5a7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627693 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#843226}
-
Victor Costan authored
Bug: 1016065 Change-Id: Ibfdf962f7cba595e47d557556369b3868d9b69e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627430 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#843225}
-
Austin Sullivan authored
Currently uses raw pointers. Bug: N/A Change-Id: Ib1cfc799e349e54b3f931a27545c042a9f6137a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626096Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#843224}
-
Jiewei Qian authored
This test was disabled due to https://crrev.com/c/2602041 triggering a DCHECK in blink. https://crrev.com/c/2612357 fixed the CSS file triggering the DCHECK, thus re-enable the test. Fixed: 1162044 Change-Id: I83f3feea04c6092820f15160fc063a7566e4e701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623607Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#843223}
-
Hidehiko Abe authored
chromeos::ReadStartupData() can be called in the process at most once, and later calls will fail. That caused initialization error. This CL fixes it by removing the call from PolicyLoaderLacros. Instead, LacrosChromeServiceImpl is instantiated at earlier timing (the same timing as D-Bus for ash-chrome), so it should be available on PolicyLoaderLacros use. Bug: None Test: Ran locally on DUT. Made sure no error logs. Change-Id: I606348c2b1db72d237d05d5a485dfa4f0ae4492b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626670 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#843222}
-
Rachel Wong authored
The suggested content toggle is launched and enabled by default, so we can remove its flag. Bug: 1166057 Change-Id: I4bbbbf903ddb954a084b1c8e639888a3970c31e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626812Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#843221}
-
Mark Pearson authored
This reverts commit 3bd04812. Reason for revert: causes failures on Win 7 Tests x64 (1) Win7 Tests (dbg)(1) Win7 (32) Tests Example bot that failed: https://ci.chromium.org/ui/p/chromium/builders/ci/Win%207%20Tests%20x64%20(1)/76517/overview Top of failure message (it's long so I didn't paste the whole thing here): [ RUN ] PredictionManagerModelDownloadingBrowserTest.TestSuccessfulModelFileFlow ../../content/public/test/browser_test_base.cc(756): error: Failed RunLoop::Run() timed out. Stack trace: Backtrace: base::internal::Invoker<base::internal::BindState<`lambda at ../../base/test/scoped_run_loop_timeout.cc:49:9',base::Location,base::RepeatingCallback<std::basic_string<char> ()> >,void ()>::Run [0x0000000143A46C1D+157] (o:\base\bind_internal.h:692) base::`anonymous namespace'::OnRunLoopTimeout [0x00000001439B533E+46] (o:\base\run_loop.cc:44) base::internal::Invoker<base::internal::BindState<void (*)(base::RunLoop *, base::OnceCallback<void ()>),base::internal::UnretainedWrapper<base::RunLoop>,base::RepeatingCallback<void ()> >,void ()>::RunOnce [0x00000001439B6726+86] (o:\base\bind_internal.h:679) base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::ForwardOnce<> [0x0000000141157DE6+54] (o:\base\cancelable_callback.h:128) base::TaskAnnotator::RunTask [0x00000001439CD3DD+365] (o:\base\task\common\task_annotator.cc:163) base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl [0x0000000144EE8481+433] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:352) base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork [0x0000000144EE814C+204] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:266) base::MessagePumpForUI::DoRunLoop [0x0000000143A011BA+122] (o:\base\message_loop\message_pump_win.cc:225) base::MessagePumpWin::Run [0x0000000143A008DA+90] (o:\base\message_loop\message_pump_win.cc:82) base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run [0x0000000144EE8DF1+273] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:463) base::RunLoop::Run [0x00000001439B4DE1+433] (o:\base\run_loop.cc:133) optimization_guide::PredictionManagerModelDownloadingBrowserTest_TestSuccessfulModelFileFlow_Test::RunTestOnMainThread [0x000000013FDFF540+288] (o:\chrome\browser\optimization_guide\prediction\prediction_manager_browsertest.cc:1045) content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x0000000143C2BCB3+419] (o:\content\public\test\browser_test_base.cc:807) ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x0000000143A784EE+4582] (o:\chrome\browser\chrome_browser_main.cc:1688) ChromeBrowserMainParts::PreMainMessageLoopRun [0x0000000143A77241+65] (o:\chrome\browser\chrome_browser_main.cc:1044) content::BrowserMainLoop::PreMainMessageLoopRun [0x0000000141F3DFB9+73] (o:\content\browser\browser_main_loop.cc:946) content::StartupTaskRunner::RunAllTasksNow [0x00000001422F62C7+61] (o:\content\browser\startup_task_runner.cc:41) content::BrowserMainLoop::CreateStartupTasks [0x0000000141F3CD05+621] (o:\content\browser\browser_main_loop.cc:860) content::BrowserMainRunnerImpl::Initialize [0x0000000141F3FA1E+126] (o:\content\browser\browser_main_runner_impl.cc:130) content::BrowserMain [0x0000000141F3B579+161] (o:\content\browser\browser_main.cc:43) content::RunBrowserProcessMain [0x00000001428DCA39+169] (o:\content\app\content_main_runner_impl.cc:555) content::ContentMainRunnerImpl::RunBrowser [0x00000001428DD7F2+854] (o:\content\app\content_main_runner_impl.cc:1059) content::ContentMainRunnerImpl::Run [0x00000001428DD46F+335] (o:\content\app\content_main_runner_impl.cc:929) content::RunContentProcess [0x00000001428DC2D1+805] (o:\content\app\content_main.cc:372) content::ContentMain [0x00000001428DC64E+61] (o:\content\app\content_main.cc:398) content::BrowserTestBase::SetUp [0x0000000143C2B516+1894] (o:\content\public\test\browser_test_base.cc:683) InProcessBrowserTest::SetUp [0x00000001439630CE+398] (o:\chrome\test\base\in_process_browser_test.cc:351) optimization_guide::PredictionManagerBrowserTestBase::SetUp [0x000000013FDFF76A+266] (o:\chrome\browser\optimization_guide\prediction\prediction_manager_browsertest.cc:256) ../../base/test/metrics/histogram_tester.cc(43): error: Expected equality of these values: 0 expected_count Which is: 1 Zero samples found for Histogram "OptimizationGuide.PredictionModelDownloadManager.DownloadStatus". Original change's description: > Reenable PredictionManager and HintsFetcher browser tests that were > disabled on desktop platforms > > Change-Id: I173ac1025760f908042e64c7c8839fb90e41fc78 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626918 > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843180} TBR=sophiechang@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ia5e026dcfd3a0b0ccfb68c2baad18209222a02b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628258Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#843220}
-
Andre Le authored
In Nearby Share, we encounter a problem of an image notification not showing entirely. This happens because of this use case: - The popup notification A is showing and we hover over that notification. - Notification A is then removed automatically to show notification B with image. - Notification B with image is cut off because we accidentally enter hot mode. This CL added a check so that we only start hot mode when necessary (when a notification is closed by an actual user). Fixed: 1154741 Change-Id: I306e66e92d2e28ba11cb1526089789ad1eb9331b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591267 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#843219}
-
Jesse Schettler authored
Bug: 1059779 Change-Id: I71852964a000718a4d2db8ee3bd2c988ab0356ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628030 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#843218}
-
Richard Chui authored
Extend the expiry date of the Tabs.ScrubDuration histogram to a year later. Fixed: 1165198 Change-Id: I3073b92cf3b778c57c5a2ad8901a2537405e9a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625155Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Richard Chui <richui@chromium.org> Cr-Commit-Position: refs/heads/master@{#843217}
-
David Black authored
It is possible to open a context menu via two finger gesture tap. We previously didn't handle this gesture so selection state was empty. Bug: 1166274 Change-Id: I259082d7c41391a23ccabd99573343e77c68bc78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627440Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#843216}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610549866-1e248feef781fb0cfb48b77513413e45541eeb72.profdata to chrome-win64-master-1610560659-e96e8917fec116ef2a139db8416bd66f9188db27.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I51ad308ffbeb0501d1e4cd80dd8fb0b08d4e6d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627906Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fdd89469d681..4e0ef215f6da 2021-01-13 ddoman@chromium.org [resultdb] move the cipd pin of infra/tools/rdb in depot_tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1141153,chromium:1155298 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ieebe70ae1c149993a906f6d4dc35ff80d252076e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626106Reviewed-by:
-
David Black authored
Previously in RTL the ink drop was drawn outside of view bounds. Bug: 1166271 Change-Id: I454871125239d40b65ee2b2606ae0953562e51c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627438Reviewed-by:
-
Josiah K authored
Don't include focus following result "Magnifier follows keyboard focus" in Chrome OS Settings search results when screen magnifier is disabled. Before: https://screenshot.googleplex.com/7k4npcGDnBznceP After: https://screenshot.googleplex.com/5Gmmstz22u7Dcfi AX-Relnotes: N/A. Fixed: 1165652 Change-Id: Ibb7dd1c7b7e301c0322d09615765484205958d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623429 Commit-Queue: Josiah Krutz <josiahk@google.com> Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#843212}
-
