GitLab

Reland of Don't allow a widget to send close notifications more than once. (patchset #1 id:1 of https://codereview.chromium.org/2844933002/ )

Reason for revert:
We will disable the failing test on Mac.

Original issue's description:
> Revert of Don't allow a widget to send close notifications more than once. (patchset #3 id:40001 of https://codereview.chromium.org/2834943002/ )
>
> Reason for revert:
> The enabled WidgetObserverTest.ActivationChange test seems to be flaky
>
> https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/17210
>
> Original issue's description:
> > Don't allow a widget to send close notifications more than once.
> >
> > Add a test to make sure this works. Also fix a couple WidgetTests that
> > were disabled.
> >
> > BUG=714334
> >
> > Review-Url: https://codereview.chromium.org/2834943002
> > Cr-Commit-Position: refs/heads/master@{#467171}
> > Committed: https://chromium.googlesource.com/chromium/src/+/bf25b17bd99b5dbeff92e62f8dddd289c335dc0a
>
> TBR=sky@chromium.org,estade@chromium.org
> NOTRY=true
> BUG=714334
>
> Review-Url: https://codereview.chromium.org/2844933002
> Cr-Commit-Position: refs/heads/master@{#467528}
> Committed: https://chromium.googlesource.com/chromium/src/+/efd8268f95f1c7a212e5b6edd521761dd8a00e31

TBR=sky@chromium.org,alph@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=714334

Review-Url: https://codereview.chromium.org/2839403002
Cr-Commit-Position: refs/heads/master@{#467544}

In http://crrev.com/448816 I removed this on the observation it was
unused on the device I tried and provided no useful information.  Crash
reports are now showing the Galaxy Note 3 does use it, so add it back.
Unlike in the previous implementation, it's just stashed at time of
request instead of doing a round-trip to Blink and back.

BUG=714877

Review-Url: https://codereview.chromium.org/2842653004
Cr-Commit-Position: refs/heads/master@{#467543}

This patch stores the ComputedStyle to be passed between recalcStyle
and rebuildLayoutTree on NodeLayoutData instead of storing it on the
HashMap on Document.

This potentially fixes the perf regression in crbug.com/700093 as it
removes the HashMap lookup in SharedStyleFinder and making it a free
operation again.

BUG=595137, 700093

Review-Url: https://codereview.chromium.org/2821193003
Cr-Commit-Position: refs/heads/master@{#467542}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6858510487e6..8062a5765bb7

$ git log 685851048..8062a5765 --date=short --no-merges --format='%ad %ae %s'
2017-04-26 rnephew Rename WaitForTemperature to WaitForBatteryTemperature

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ieedf0c63fb0276c9dc2380174a9efabccbce07de
Reviewed-on: https://chromium-review.googlesource.com/487833
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467541}

LayerImpl::FixedContainerSizeDelta was only needed for tests and these
tests can be simplified to just access the appropriate container
viewport bounds directly off the property trees.

Layer::FixedContainerSizeDelta has been removed because it is not used.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2839533002
Cr-Commit-Position: refs/heads/master@{#467540}

This function just wrapped simple logic and we can explicitly
call SetViewportBoundsDelta on the correct layer instead. This
is similar to https://codereview.chromium.org/2839533002 which
removed FixedContainerSizeDelta.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2843253002
Cr-Commit-Position: refs/heads/master@{#467539}

Sometimes when a text selection ends with the last word on a line
(for instance when just one word is selected) the generated text
for the selection range contains an extra trailing space.
This happens when a text node is split into several InlineTextBoxes
(e.g. a <span> inside a narrow table) and the last selected word
happens to be the last one in such text box.

The TextIterator algorithm restores the spaces between the text boxes
and will add a trailing space for this word. For the SurroundingText,
however, we need the length that corresponds to the visible selection.

This CL introduces a new text iterator behavior that prevents that
extra space to be added. This behavior is used in combination with
DefaultRangeLengthBehavior() for the selection range calculation
in the SurroundingText.

BUG=708329

Review-Url: https://codereview.chromium.org/2832123002
Cr-Commit-Position: refs/heads/master@{#467538}

Restore the alphabetical order in javascript.

Saves around 100k when gzip is used, but only 2k for brotli.
Intention is to have android_webview to use the same copy
of about:credits in a follow-up, in which case this optimization
becomes relevant.

BUG=688077

Change-Id: I24d62a81c61c2c53f5740f90d0c8094d3b04352e
Reviewed-on: https://chromium-review.googlesource.com/487725Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Yipeng Wang <yipengw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467537}

Passing via command line is still supported, and has priority over the variations server parameter.

Bug=712331

Review-Url: https://codereview.chromium.org/2842363002
Cr-Commit-Position: refs/heads/master@{#467536}

R=waffles@chromium.org
BUG=687231

Review-Url: https://codereview.chromium.org/2835803002
Cr-Commit-Position: refs/heads/master@{#467535}

And update name for the experimental Windows recipe builder.

R=dpranke@chromium.org
TBR=dimu@google.com, dpranke@google.com
BUG=418185,685794,715782

Review-Url: https://codereview.chromium.org/2841253002 .
Cr-Commit-Position: refs/heads/master@{#467534}

https://skia.googlesource.com/skia.git/+log/f6d7eb158e41..b8a1392b021f

$ git log f6d7eb158..b8a1392b0 --date=short --no-merges --format='%ad %ae %s'
2017-04-26 brianosman Fix uncached getROPixels from GPU images

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I1b888cfafd2160c68ce07b5d37e46e80c29c3d25
Reviewed-on: https://chromium-review.googlesource.com/487909Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467533}

Cr-Commit-Position: refs/heads/master@{#467532}

The incoming "count" should not be negative.  If so, record that.  Take
special note if it causes the result to become negative (and clamp it).

BUG=682680

Review-Url: https://codereview.chromium.org/2841143002
Cr-Commit-Position: refs/heads/master@{#467531}

Enable test results presentation on all instrumentation tests in
chromium.linux.json.

BUG=605572

Review-Url: https://codereview.chromium.org/2842653006
Cr-Commit-Position: refs/heads/master@{#467530}

This CL addresses all of non-CrOS UI surfaces, and powerwash_dialog which is
CrOS only. Remaining CrOS UI will be addressed in follow up CL.

BUG=635633
TEST=Open chrome:md-settings, look at the DevTools console, no more warnings.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2840713002
Cr-Commit-Position: refs/heads/master@{#467529}

Revert of Don't allow a widget to send close notifications more than once. (patchset #3 id:40001 of https://codereview.chromium.org/2834943002/ )

Reason for revert:
The enabled WidgetObserverTest.ActivationChange test seems to be flaky

https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/17210

Original issue's description:
> Don't allow a widget to send close notifications more than once.
>
> Add a test to make sure this works. Also fix a couple WidgetTests that
> were disabled.
>
> BUG=714334
>
> Review-Url: https://codereview.chromium.org/2834943002
> Cr-Commit-Position: refs/heads/master@{#467171}
> Committed: https://chromium.googlesource.com/chromium/src/+/bf25b17bd99b5dbeff92e62f8dddd289c335dc0a

TBR=sky@chromium.org,estade@chromium.org
NOTRY=true
BUG=714334

Review-Url: https://codereview.chromium.org/2844933002
Cr-Commit-Position: refs/heads/master@{#467528}

https://pdfium.googlesource.com/pdfium.git/+log/2e2a4fcd4367..e47e0c96009b

$ git log 2e2a4fcd4..e47e0c960 --date=short --no-merges --format='%ad %ae %s'
2017-04-26 tsepez Avoid unordered_set and maps for the time being.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I151e465d118e9b361849e71404bd9bcec561ec6e
Reviewed-on: https://chromium-review.googlesource.com/487905
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467527}

ManifestHandler::Parse is called from within Extension::Create and may or may
not be called on a thread which supports IO. On the other hand,
ManifestHandler::ValidateExtension is called through
file_util::ValidateExtension and hence is always called on a thread supporting
IO. There are assumptions in the code relying on this as well. This CL documents
the same in the ManifestHandler header.

BUG=None.

Review-Url: https://codereview.chromium.org/2846553003
Cr-Commit-Position: refs/heads/master@{#467526}

BUG=674732

Review-Url: https://codereview.chromium.org/2846673002
Cr-Commit-Position: refs/heads/master@{#467525}

This is not always possible (for tests explicitly testing particular
production namespace behavior).  But some tests are just around general
namespace policy behavior.

BUG=705086

Review-Url: https://codereview.chromium.org/2841223003
Cr-Commit-Position: refs/heads/master@{#467524}

BUG=709274

Change-Id: I1557267de99e9f2fb82a3a26f24553fcc1e02a24
Reviewed-on: https://chromium-review.googlesource.com/487870
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#467523}

Reworks Tap gesture recognition and processing to use a new Internal
State Controller.  This controller drives the ContextualSearchManager
through its sequence of state transitions. Now the manager is just
a library of operations, and the overall flow of control is handled
exclusively by the new state controller.

Now text is extracted before showing any UI. This is needed so we
can apply ML to decide when to show the UI.

The Java Context now tracks a small section of content of the Context
around the Selection. Context now has a hack to figure out how the
content changed when a word is selected with SelectWordAroundCaret.
This should be fixed soon by adding an ACK to SelectWordAroundCaret.

Stopped using the GestureStateListener#onSingleTap override so we
should be able to remove that method from the interface in a future
CL.

The SelectionController no longer needs to have a delay for a possible
invalid tap because there's a state that waits for a possible tap
nearby a previous tap.

BUG=692824

Review-Url: https://codereview.chromium.org/2703473002
Cr-Commit-Position: refs/heads/master@{#467522}

BUG=712208
TBR=nednguyen@google.com

Review-Url: https://codereview.chromium.org/2844003003
Cr-Commit-Position: refs/heads/master@{#467521}

Tested with new WebGL conformance test being added in
https://github.com/KhronosGroup/WebGL/pull/2383 .

BUG=713127
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2837213003
Cr-Commit-Position: refs/heads/master@{#467520}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/83d9ade4..d4e9c7fe

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2846593002
Cr-Commit-Position: refs/heads/master@{#467519}

This CL adds a client policy bit that controls whether namespaces are
disabled when prefetching-related prefs are disabled.

Also fixes an incorrect policy bit for the NTP articles namespace, it
was set to be cleared on cache when it was in fact a user-requested
data type.

Added some diagnostic information to the policy controller tests.

Paquete #fixit
BUG=705082

Review-Url: https://codereview.chromium.org/2835193005
Cr-Commit-Position: refs/heads/master@{#467518}

Revert of Disabling flaky WebRtcCaptureFromElementBrowserTest.VerifyCanvasWebGLCaptureColor on android (patchset #1 id:1 of https://codereview.chromium.org/2835973002/ )

Reason for revert:
Can't reproduce this locally with ToT. Guess it may be affected by issue715069
or other bots failures.
Let's reenable it and check.

Original issue's description:
> Disabling flaky WebRtcCaptureFromElementBrowserTest.VerifyCanvasWebGLCaptureColor on android
>
> emircan and mcasas to TBR as taken from recent changes to the same tests.
>
> BUG=714549
> TBR=emircan@chromium.org,mcasas@chromium.org
>
> Review-Url: https://codereview.chromium.org/2835973002
> Cr-Commit-Position: refs/heads/master@{#466608}
> Committed: https://chromium.googlesource.com/chromium/src/+/5983d0ae0dc74c59f63c1851637ae2a8a13421d6

TBR=emircan@chromium.org,mcasas@chromium.org,mattcary@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=714549

Review-Url: https://codereview.chromium.org/2839303002
Cr-Commit-Position: refs/heads/master@{#467517}

This is a preparation of collapsed border optimization
(https://codereview.chromium.org/2805103003/)
and bug fixing (later).

BUG=626748

Review-Url: https://codereview.chromium.org/2842123003
Cr-Commit-Position: refs/heads/master@{#467516}

Before this patch, support for "basic-card" in 3rd party Android payment
apps was hard-coded. Adding support for a new short string payment
method name would require large changes in AndroidPaymentAppFinder.java.

This patch removes custom handling for "basic-card" and instead
introduces a list of supported short string payment method names. So
far, the list contains only "basic-card".

After this patch, adding support for a new short string payment method
name is done trivially by appending it to the list of supported names.
Note that, for short string payment method names, only the names that
are published by W3C should be supported.

3rd party Android payment apps are behind a flag:
  chrome://flags/#android-payment-apps

Design:
https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE

BUG=715577

Review-Url: https://codereview.chromium.org/2838403002
Cr-Commit-Position: refs/heads/master@{#467515}

This is a follow up to refs/heads/master@{#465155}. Android now always
calls OnChildProcessStarted on the launcher thread, which means the
complexity to deal with the call directly happening on the client thread
can be removed.

BUG=689758

Review-Url: https://codereview.chromium.org/2843063002
Cr-Original-Commit-Position: refs/heads/master@{#467463}
Committed: https://chromium.googlesource.com/chromium/src/+/213830d7d68eefddedc6199bf699dfac3d5481e8
Review-Url: https://codereview.chromium.org/2843063002
Cr-Commit-Position: refs/heads/master@{#467514}

Disabling it didn't fix http://crbug.com/706927, but caused a new regression in
http://crbug.com/715279, while http://crbug.com/712453 recovered for some other
reason.

BUG=606395, 706927, 712453, 715279
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2834393003
Cr-Commit-Position: refs/heads/master@{#467513}

The Windows build instructions mention that the 14393 SDK is needed but
now that 15063 has shipped the SDK is harder to find, leading some
developers to do problematic hacks. This adds a link to the archival
installer.

R=scottmg@chromium.org

Review-Url: https://codereview.chromium.org/2846643002
Cr-Commit-Position: refs/heads/master@{#467512}

BUG=714135

Review-Url: https://codereview.chromium.org/2844043003
Cr-Commit-Position: refs/heads/master@{#467511}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/abff3b4929c7..6858510487e6

$ git log abff3b492..685851048 --date=short --no-merges --format='%ad %ae %s'
2017-04-26 ssid Fix android_action_runner.InputSwipe and InputText

Created with:
  roll-dep src/third_party/catapult
BUG=708300,712590


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ic97851766db7f7a5b0d49cb2ee74b936220f1d34
Reviewed-on: https://chromium-review.googlesource.com/487731
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467510}

GetContainerBounds isn't a simple getter, avoid calling it more than
necessary.

Also, update setting unique_ptr-s to use MakeUnique instead of reset().

BUG=None
Test=None

Review-Url: https://codereview.chromium.org/2846443002
Cr-Commit-Position: refs/heads/master@{#467509}

Updates Mac tests to test both views and Cocoa versions of the Zoom Bubble.

BUG=662128, 177940
TEST=browser_tests --gtest_filter=*ZoomDecorationTest*
     unit_tests --gtest_filter=*ZoomDecorationTest*

Review-Url: https://codereview.chromium.org/2834493007
Cr-Commit-Position: refs/heads/master@{#467508}

We have several crash reports of NPEs when trying to get the activity
from the current tab while during BottomSheetContent creation. The
current tab currently shouldn't be null when the BottomSheet is opened,
but it's likely that the current tab will soon be null (NTP). Hold on to
a reference to the ChromeActivity passed in to
BottomSheetContentController#init() for use in creating
BottomSheetContents. The BottomSheet is per activity so the activity will
never change.

BUG=711098

Review-Url: https://codereview.chromium.org/2843203002
Cr-Commit-Position: refs/heads/master@{#467507}

This makes Modulator::ExecuteModule() to implement "run a module script"
https://html.spec.whatwg.org/#run-a-module-script, especially its Steps 1--5,
and calls it from ModuleScript::RunScript().

This CL doesn't change the behavior because ModuleScript::RunScript() is not
yet called from ScriptLoader.

BUG=594639

Review-Url: https://codereview.chromium.org/2819733002
Cr-Commit-Position: refs/heads/master@{#467506}

Currently when logdog binary doesn not exist, we are still trying to
upload logcats. Without logdog binary setting up, trying to upload
logcats will result in NotBootstrappedError. This error will then output
a stack which is confusing to engineers.

BUG=675666

Review-Url: https://codereview.chromium.org/2835203004
Cr-Commit-Position: refs/heads/master@{#467505}