- 19 Dec, 2019 40 commits
-
-
Ben Kelly authored
Previously there were many different places where CacheManager() was being called like this: if (CacheManager()) CacheManager()->DoSomething(); This is problematic for two reasons. First, CacheManager() can begin returning nullptr at any time if shutdown is initiated on a separate thread. Second, CacheManager() will return a new object every time its called from a separate sequence which is wasteful in this pattern. This CL corrects these call sites to only invoke CacheManager() once and to use the returned reference instead. Bug: 1033251 Change-Id: I61c24fd9bbf20c8ad7791fdc5bb1698ea8a4c5bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973998Reviewed-by:John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#726383}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c76ac8e325c7..77742c350371 git log c76ac8e325c7..77742c350371 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 brianosman@google.com Remove SkShader.Empty from CanvasKit Created with: gclient setdep -r src/third_party/skia@77742c350371 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Ia5c1cc9b61f2456b9daf28daf53558d55fa21ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726382}
-
Anand K. Mistry authored
Bug: 1007788 Change-Id: Id2118d76992100771ab28dbde2ff1c20d887e8e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974296 Auto-Submit: Anand Mistry <amistry@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#726381}
-
Bence Béky authored
Change-Id: I8b30e88ec94b0aa4eac8e78af0a8d21df95902de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966278 Auto-Submit: Bence Béky <bnc@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#726380}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/71befefb..121ebd03 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie826ee61bd4b2e049499847c5bb10426860c25c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975833Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726379}
-
Jonathan Backer authored
GLContext::IsCurrent can result in driver calls which have a non-zero cost, as evidenced by recent sampling profiles. This happens frequently with virtual contexts on Android in the following circumstance: - {GL,Skia}Renderer gets a PassthroughImageTransportSurface |wrapper| for the display, which is a GLSurfaceAdapter wrapping |surface| - GLSurfacePresentationHelper::OnMakeCurrent picks up the |surface| and subsequently uses it to make a context current in GLSurfacePresentationHelper::CheckPendingFrames As we draw frames, we alternately make current with |wrapper| and |surface|, leading to unnecessary driver calls in GLContext::MakeVirtuallyCurrent. This CLs eliminates that by so that both the |wrapper| and |surface| are considered current whenever either one of them are. Change-Id: I153aff272b966c42a5066fb2016c9d353a1b3f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974316Reviewed-by:Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#726378}
-
Yue Ru Sun authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1687059 to ensure that source ids are marked for deletion only if the navigation has succeeded, and that a same-document navigation committing does not mark the last full navigation source, which may still report events in the future. Bug: 1035493 Change-Id: Icd3af69fa28b809aac00459750e4c4b8fc43e0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935228 Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#726377}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1cc63223019c..860e0e564df9 git log 1cc63223019c..860e0e564df9 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 lalitm@google.com Merge "trace_processor: migrate cpu stack profile table to db tables" 2019-12-19 fmayer@google.com Merge changes Ie41293bc,I3169ebdd,Ib8ef09a0 Created with: gclient setdep -r src/third_party/perfetto@860e0e564df9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I85bfeda8962a5f3be49e761058ac29f203a78c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976092Reviewed-by:
-
Fredrik Söderquist authored
The pixel-snapping of the destination rectangle can end up distorting the geometry use for painting an SVG image preserveAspectRatio is used - the larger the aspect ratio, the larger the error. By passing the unsnapped rectangle to LayoutImageResource::GetImage, and using Image::SizeAsFloat() to compute the source rectangle of the image, e can minimize the error and allow the Image in question (an SVGImage) to perform compensation for the difference in aspect ratio between the snapped and unsnapped rectangles. This means that the painted result will better approximate the intended rendering. Also clean up accesses to the LayoutImageResource and ImageResourceContent by adding and using local variables for them. Bug: 812239 Change-Id: I0778648e7dd6fcca778a95123509f15b3519564c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969831Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#726375}
-
Francois Doray authored
This CL moves PageAlmostIdleDecorator from //chrome/browser/performance_manager to //components/performance_manager. The PageAlmostIdleDecorator doesn't depend on anything in //chrome. Additionally, this CL adds a function to create the PerformanceManager with default decorators. This allows the embedder to create a PerformanceManager with default decorators without knowing about these decorators. Bug: 1028291 Change-Id: I7115b5a7002585043d9905a440560cd82540b659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972612Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#726374}
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: If0743e13be2dbe515c75d149498b59f975fdb541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970316 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#726373}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/52cef46d51d3..451c28a14b36 git log 52cef46d51d3..451c28a14b36 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@451c28a14b36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I17f6e093f02aa07848b370400a4c9bead6414b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976091Reviewed-by:
-
Chih-Yu Huang authored
The Chromium smart pointer guidelines [1] says "don't pass or return a smart pointer by reference". This CL remove "const scoped_refptr<T>&" at H264DPB. [1] https://www.chromium.org/developers/smart-pointer-guidelines Bug: 1020668 Test: run vda_tests on kevin Change-Id: Ie42126e4957634c01fa78947d84a2fa98dd72acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974728 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#726371}
-
Igor authored
The class contains four types of tokens, but only one token can be used. This change makes the class to keep the data in a single token and have an easy way to find the token type. BUG=None Test=None Change-Id: If9a73b5c6c2a6a5a2f6c9a6c5c7bb672e7eac765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943244Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#726370}
-
Chih-Yu Huang authored
Bug: 1020668 Test: run vda_tests on kevin Change-Id: I5679d5ff65159f4f3bcb7dd62f5a3e1e09964739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974726 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
-
Bo Liu authored
Android 10 has a bug in the app zygote implementation when used under secondary user like work profile. Update the manifest so only the the 0th service enables app zygote. Then dynamically choose between 0th and 1st service depending on if app zygote needs to be disabled. Bug: 1035432 Change-Id: Ifa3c1cb02fbc86595c7ad15c7feca35bf8ab0abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974571Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726368}
-
Oleg Davydov authored
As most of installation failures for force-installed extensions are "failed to fetch CRX archive", we want to know whether these are extensions from Chrome Web Store (so we may ask Chrome Web Store to look at the problem from the server side), or self-hosted ones. This commit introduces two histograms instead of old ForceInstalledFailureReason2, one new for extensions from Chrome Web Store, second for all others. Bug: 1030224 Change-Id: Ifee902ae3ae15198ccf871a96eed59bf7579cf8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968980 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#726367}
-
Andreas Haas authored
lengthAsSizeT can be used there just so. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: Iae5c92d54ef410a390ae1ab4f7b302fe8c0fac3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975916Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#726366}
-
Chih-Yu Huang authored
The Chromium smart pointer guidelines [1] says "don't pass or return a smart pointer by reference". This CL remove "const scoped_refptr<T>&" at VaapiPicture. [1] https://www.chromium.org/developers/smart-pointer-guidelines Bug: 1020668 Test: run vda_tests on octopus Change-Id: I7b1c8d4066a6bba0d5ded4b1b584278168c49eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974725 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0643720ad76..c8519d85b8ea Created with: gclient setdep -r src-internal@c8519d85b8ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Id4009c2c1ca798c58f3a3d2dd2a8adfd27bf55c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976090Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726364}
-
Koji Ishii authored
Following bot results are included. 655 656 657 658 659 660 661 662 664 667 669 42 lines were removed and 29 lines were deflaked by consecutive results since 649. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ie067dfa6354db41f3ad2fda7a569df43334096c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973439Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#726363}
-
Andreas Haas authored
I changed the tests to use size_t instead of unsigned. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: Id1aff0ebd014ce0e601e860aca85da9c369c959c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975917Reviewed-by:
-
Olivier Li authored
The feature will soon be flipped to ENABLED_BY_DEFAULT. This will make HistoryServiceBackend's task runner dispatch to the ThreadPool instead of a dedicated base::Thread. The tests need to be prepared to stay functional when that happens. This is done as the last mile of the chrome-wide effort to coalesce as much work as possible to the ThreadPool. Bug: 661143 Change-Id: I7bdbdb5152edafc5394aeab187ea8a8602f5330e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972305 Commit-Queue: Oliver Li <olivierli@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#726361}
-
Gyuyoung Kim authored
This CL replaces .mojom.h with .mojom-forward.h in chrome/browser/chromeos/arc to reduce the pre-processed size of header files and shorter build time. This CL has no behavior changes. Bug: 1001360 Change-Id: Ib07d6179cbf72c1b35a042649f142f1dfa6e088e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974300Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#726360}
-
Stephane Zermatten authored
Before this change, it was possible to make prompt end when element appeared, but not when they disappeared. Yet, prompt is often used in interrupt to deal with dialog box and it is useful to detect when such a dialog box is gone. With this change, scripts can just ask for prompt to end when a specific element is gone. Bug: b/146311363 Change-Id: Ie52fe2b0216533ce92f298fd3b6369ac4af01716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969578 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726359}
-
Hirokazu Honda authored
This enables V4L2IP to work with GpuMemoryBuffer based VideoFrame on input and output. on kukui Bug: 1033799, 1011281 Test: IP test --gtest_filter=NV12DownScaling/ImageProcessorParamTest.* Test: VD tests on hana, kukui Change-Id: I3001c1bb4d782c448e7e45fa52f4be7ed58dd88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965789 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726358}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4de162fd4924..1cc63223019c git log 4de162fd4924..1cc63223019c --date=short --first-parent --format='%ad %ae %s' 2019-12-19 fmayer@google.com Merge "Show self_max in heap_profile_allocation." Created with: gclient setdep -r src/third_party/perfetto@1cc63223019c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia7b80ce3ab4fca34fc4ec7ab03f916241d6c9f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976031Reviewed-by:
-
Hirokazu Honda authored
This enables V4L2IP to read and write buffers with respect of offsets specified by VideoFrame. ConvertOneTime_GmbToGmb on kukui Bug: 1033799, 1011281 Test: IP test --gtest_filter=NV12DownScaling/ImageProcessorParamTest. Test: VD tests on hana, kukui Change-Id: I557a64533afd5e0f75c862d323fe392b179a51c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966804 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: -
Camille Lamy authored
Now that the reporting API is enabled by default, these tests can be enabled. Bug: 694525,704259,850170 Change-Id: I36b4e9cda576d48f3543e7bf265a0d9dff66e3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971917Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#726355}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3e618bf6..71befefb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia0d0688716cf12c4af275be284ed1b947b2389bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975832Reviewed-by:
-
Stephane Zermatten authored
Before this change, the set of updated script from GetActionsResponse.update_script_list was only applied at the end of a script. With this change, the set of updated scripts reported by GetActionsResponse.updated_script_list is applied right away. This limitation was put in place to avoid issues with pointers to scripts becoming invalid at any time. To avoid this issues, this change avoids storing Script* anywhere else than the list of scripts, preferring to reference scripts by their path, when necessary. This change also strictly separates scripts from interrupts, to avoid confusion and to keep things a bit simpler. It is not possible anymore to define a script that is both an interrupt and a normal script, that is proposed as a runnable script on the UI. This feature was never used. Bug: b/146314751 Change-Id: I466adb9c9ec3e79c659bac0798df46b5311739a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968992Reviewed-by:
-
Hirokazu Honda authored
media/gpu/V4L2Buffer: GetVideoFrame() returns VideoFrame whose number of fds are the same as the number of planes Dmabuf-backed VideoFrame and GpuMemoryBuffer-based VideoFrame created by using NativePixmap interface and GpuMemoryBuffer interface always has the same number of fds as the number of planes. So some code assumes that the condition is always true. V4L2Buffer::GetVideoFrame() returns Dmabuf-backed VideoFrame whose number of fds are the same as v4l2 planes. For example, the number of fds are one if the format is V4L2_PIX_FMT_NV12, and three if V4L2_PIX_FMT_NV12M. This breaks the assumption and thus causes an issue. We would rather make GetVideoFrame() return VideoFrame whose has the same number of fds as the number of planes, than handling this exception on several code places. Bug: 1033799 Test: VDA test on kukui Change-Id: If96551e2b9a70c3e49e4bff98ccbffad657d250d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967016 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Change-Id: Ife0f8850b452437aea01a4230d66c5cbc7c3b0ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971836 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ed56d990. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." fadf6027 "[css-pseudo] Recalculate viewport units in ::marker" 044ad8ad "[OT-PW] Make it work with OOP-R" 9899425d "[css-layout-api] IntrinsicSizes Implementation" 7d838af7 "[scroll-to-text-fragment] Apply :target CSS pseudo-class to match." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic4871dcc160a3fc64e4c616e90c1268fb04fe5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975831Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726350}
-
sandromaggi authored
The privacy notice is no longer required, removing it from tests where it was only added due to this requirement. Add new test for empty card network to make sure we don't exclude all cards in this case. Bug: b/146126954 Bug: b/146424039 Change-Id: I35ae536c00d8774efac23eb4a586fa53f472642a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975911Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#726349}
-
Antonio Gomes authored
... instead of static helper functions all over the place. BUG=787254 R=guidou@chromium.org Change-Id: Id6367e7818e9094129e2b9ee6978d79b575e1fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974002Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#726348}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/12d9cc3132f1..52cef46d51d3 git log 12d9cc3132f1..52cef46d51d3 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 janscheffler@chromium.org Refactor Cookie implementation 2019-12-19 szuend@chromium.org [cleanup] Remove unused method in DebuggerPlugin Created with: gclient setdep -r src/third_party/devtools-frontend/src@52cef46d51d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1030258 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1cc24760173e79b56efb284f6abe9c6c6378cf48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976032Reviewed-by:
-
Andreas Haas authored
Using byteLengthAsSizeT should not be a problem here, as the receivers are already either of type size_t or uint64_t. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I805e58ee5d42fc95fb2c3ab262796945b01264a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975874Reviewed-by:
-
Antonio Gomes authored
.. to use WTF counterparts. BUG=787254 R=haraken@chromium.org Change-Id: I849f0db979269268a7947562fa767615cb587ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973999Reviewed-by:
-
Chih-Yu Huang authored
The Chromium smart pointer guidelines [1] says "don't pass or return a smart pointer by reference". This CL remove "const scoped_refptr<T>&" at MailboxVideoFrameConverter. [1] https://www.chromium.org/developers/smart-pointer-guidelines Bug: 1020668 Test: ninja media/gpu/chromeos Change-Id: I09feb2e97e9528c23c8c3d92ecdc0fdea2478f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974724 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
-
