- 17 Jan, 2020 40 commits
-
-
Robbie McElrath authored
This moves a flag from CommandLineUtil to AwSwitches with the others, and removes the //aw:common_commandline_java build target, which isn't needed. Test: ninja -C out/aw system_webview_apk Bug: 1035235 Change-Id: Ib58d4269b8dc845948bc83a8ad788dc074376a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005609 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#733042}
-
Natalie Chouinard authored
TextScalePreference is the only SeekBarPreference used in Settings, so merge it with SeekBarPreference for more organized and readable logic. (Note: If a common SeekBarPreference widget is needed in future, the SeekBarPreference class now available in AndroidX is likely a better choice, although not suited to this particular usage.) Fixed: 977206 Change-Id: I4a4751ba96bd5b4f8d007546dd6db00884eeaf5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003215 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#733041}
-
Henrique Nakashima authored
Register it in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: I1c0bea6950d1a52d4213d11d421d89ce3b87ea01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003454 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#733040}
-
Klaus Weidner authored
It took me a while to figure out what was wrong with my valid-looking new IDL file, this diagnostic would have saved me some time. However, I don't know if it's potentially confusing for other errors people might make, or if there are better ways to address this. Bug: 1041101 Change-Id: Ifae76b7d77e558f1888be0b70ae52fd53fc7514a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995712Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#733039}
-
Adithya Srinivasan authored
This should fix an existing issue where a DCHECK is hit when the test runner/browser is being torn down. Also cleans up portals-create-orphaned.html. Bug: 1018940 Change-Id: I35d1a842923e7302b308b57856e4c165bd07bd6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007473Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#733038}
-
Jeroen Dhollander authored
If the on-screen keyboard is visible and we open the Assistant UI with "OK Google", the keyboard should be dismissed but it remains visible. Bug: b/147835595 Change-Id: I00050ce36c28f84c18cc8e6d8af0d157f22c1cd2 Tests: new ash_unittest AssistantPageViewTabletModeTest.ShouldDismissKeyboardWhenOpeningUiInVoiceMode Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006212 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#733037}
-
Matt Menke authored
The test makes sure that HostCache entries aren't shared between NetworkContexts. To do this, it does a DNS lookup in one NetworkContext, which succeeds, and then cache-only DNS lookups in other NetworkContexts, which should fail. At the end of the test, it does a cache-only lookup in the first NetworkContext, which should succeed. It's generally best to do this at the end of the test, since it makes sure that entries aren't only usable once, or somesuch. Unfortunately, sometimes the DNS cache entry is timing out before the last lookup. To fix that, this CL moves the final cache-only lookup to be right after the initial lookup that populates the cache. This does mean the test can still flakily pass, however, flaky successes are more tolerable than flaky failures, and the test currently passes often enough, even with the flake, that I think we can live with it. Bug: 1043084 Change-Id: Ibdcf77e7775943e18c21a9ddd2cd3d5bf127c248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008058 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#733036}
-
Robin Lewis authored
Uploads event viewer logs to cloud storage for easier debugging and auditing on every online login. The severity level of the logs that are exported can be controlled by a registry entry. Bug: 978691 Change-Id: Ibb1010eaea6d04e36bb07d06448d2b86a62f8a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990448 Commit-Queue: Robin Lewis <wrlewis@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#733035}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/44509036060c..100fe639b230 git log 44509036060c..100fe639b230 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 yvesg@webrtc.org Fix race condition around rtc::ScopedFakeClock. Created with: gclient setdep -r src/third_party/webrtc@100fe639b230 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If8fa56764d375ae2c26302587f68ef6d9d8f3c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008187Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733034}
-
Kyle Milka authored
Use a custom divider to correctly match the spec. http://screen/cGXhXz0KcAX.png Bug: 1009124 Change-Id: Idd4711681485cfa6d9ea0a77f6e3f6308f338e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008357Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#733033}
-
Alex Turner authored
Updates it to reflect that the speculative fix of handling ERR_CACHE_RACE in DoDoneHeadersAddToEntryComplete appears to have fixed the rare crashes observed. Bug: 959194 Change-Id: I68df784e286b3f667a0c5714f3dc881a209a2bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003406Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#733032}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e1b7afc8f3a1..bd5ee543633f git log e1b7afc8f3a1..bd5ee543633f --date=short --first-parent --format='%ad %ae %s' 2020-01-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@bd5ee543633f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: Ib7e9e11df6fdb4cb0a90bce3304ea93fdbced25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008186Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733031}
-
Eric Willigers authored
Web app windows, including 'Open in window' shortcuts, do not have their tabs discarded. Bug: 1041743 Change-Id: I4f055fb470d484896f0eba059f0525cef41aa75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999896 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#733030}
-
Nicolás Peña Moreno authored
Currently, the TimingAllowPassed() check is used regardless of whether the OutOfBlinkCors flag is enabled or not. However, the check is only computed when the flag is enabled, so in this CL we revert back to the old behavior from before when the flag is disabled. See related change: https://chromium-review.googlesource.com/c/chromium/src/+/1992590 Bug: 1003943, 1042580 Change-Id: Ifafbae93aaa58166fbb8007d30a3f18620029b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003754 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#733029}
-
David Trainor authored
These methods are baseline utilities for interacting with the Android OS and should be usable by all other targets/directories within Chrome. Bug: 1042967 Change-Id: I10afd77c25a98c2bd04295eca1a91fe6bb390565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008316Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#733028}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b0e33db0c16..516d0d786f27 Created with: gclient setdep -r src-internal@516d0d786f27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1042660,chromium:984162,chromium:989667 Tbr: jbudorick@google.com Change-Id: I041b825bc86a1ee195ae3a51b2084c69523949ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008183Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733027}
-
Annie Sullivan authored
Whenever we make a change to a metric, or see an unexpected regression, my team will make a change to this directory. This auto-ccs rviscomi so that he can update the corresponding CrUX documentation. Change-Id: I204e6a674fd1cb9e385605b0c1331965ccadfbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008352Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#733026}
-
Guillaume Jenkins authored
Just going over all spell check files and making sure they all have the necessary includes for using spell check build flags. I did not look at other includes; just "build/build_config.h" and "components/spellcheck/spellcheck_buildflags.h" Change-Id: Icf3becebcb9ef6186a9ffffbd5438742d41a8b15 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007518Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#733025}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/05b001c28df8..98cfac11bd02 git log 05b001c28df8..98cfac11bd02 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 ehmaldonado@google.com scm: Add GetAllFiles method. 2020-01-17 ehmaldonado@google.com presubmit_support: Use single quotes and convert to ArgumentParser. Created with: gclient setdep -r src/third_party/depot_tools@98cfac11bd02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042324 Tbr: agable@chromium.org Change-Id: Ib75d2eadaf2c601c2e70b14230c93f95ca18e1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008181Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733024}
-
Richard Knoll authored
This service will be used by Chrome to send messages between a users devices. Currently all communication is done via FCM in the browser process, but for WebRTC we want to run in a sandboxed utility process instead. Design doc: go/unido-webrtc-dd Security review: go/unido-webrtc-secrev Mojo/IPC review: go/unido-webrtc-ipc Bug: 1031147 Change-Id: I33e715c4a188de6962f886345e3a0e8d28c74f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967323Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#733023}
-
David Black authored
Bug: b:147820721 Change-Id: Id4aa59cdacd540a96462a25505e9612aa98b2dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004954Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#733022}
-
Mathew King authored
Some upcoming Chromebooks will have an electronic privacy screen which can be toggled on or off via a hotkey. When this key is pressed linux will emit a KEY_PRIVACY_SCREEN_TOGGLE keycode 0x279. There is not currently a USB HID usage for privacy screen control but there is a request in progress and is expected to be in the 0x300 range of the consumer page. We use the next available device DomKey 0x60C and the next unused VKEY 0x9B. BUG=b:146006851, b:138397511, 952051 Change-Id: Ia519c6227ca1acf3f352ef1d757b0ef3925dca05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979232 Commit-Queue: Mathew King <mathewk@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Gil Dekel <gildekel@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#733021}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4efa82edacaa..3cbeaba4eb9d git log 4efa82edacaa..3cbeaba4eb9d --date=short --first-parent --format='%ad %ae %s' 2020-01-17 syoussefi@chromium.org Remove suppression of passing test 2020-01-17 ianelliott@google.com Sort GLES 3.1 expectations to show conformance blockers Created with: gclient setdep -r src/third_party/angle@3cbeaba4eb9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jonahr@google.com Change-Id: I5f0336130746309c553070653bb90e5b4adece70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008179Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733020}
-
Jeremy Roman authored
Since this pathway is triggered by tab helpers, they are now registered in Chrome/Android much as they are already in Chrome/Desktop (by Browser). A test is included which works mostly the same way as the desktop browser test equivalent. Some plumbing was required to expose inner web contents to Java, via JNI. Bug: 1038584 Change-Id: I3127b0a392774c528f620220934283c4affe6643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986341Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#733019}
-
Sajjad Mirza authored
TabCapturePerformanceTest.Performance is flaky across multiple CQ builders. Bug: 1042457 Change-Id: I7fd59ac696c6bac0fcb27a860a06664016217749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003910 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Auto-Submit: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#733018}
-
Roger McFarlane authored
Bug: 978849 Change-Id: Ide816851b13c00fb5068174f86d2d21a674a6494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007971Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#733017}
-
Natalie Chouinard authored
LocationSettings is now a static-only class of helper methods for native, so make its constructor private and remove singleton logic. Bug: 1043229 Change-Id: I35fc673368ec7a2b510be0aa2eaaae4cbc054cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007869Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#733016}
-
Connie Wan authored
Part 1 of many. In this change: - Group headers become focusable in accessibility mode. - Group headers have rudimentary accessibility labeling. - Group headers have focus rings that match the shape of the title chip. - RETURN and SPACE trigger the group header editor bubble. Much of this is borrowed from Tab focus behavior, e.g. https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab.cc?l=226&rcl=5f3328931da554b037f7a9fd008d1d0216246a95 Still in progress: For group headers: - The focus order is wrong (group headers are ordered last, after the New Tab Button). - The voiceover readout is likely wrong (currently untested). - The keyboard controls for reordering groups is missing (TODO added inline). For tabs: - The voiceover readout does not include what group it is in. - The keyboard controls for reordering groups doesn't respect group boundaries. Almost all of the above efforts are non-trivial, unfortunately. I'll be breaking them up into separate CLs as much as possible. Bug: 1039921 Change-Id: I5a831c196dd51ede2a48b16ccf4ffc8acb0dd1de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998146 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#733015}
-
Alison Maher authored
In a previous change, we had ignored background images for all inlines to prevent background images from being painted on top of the readability backplate in forced colors mode. https://chromium-review.googlesource.com/c/chromium/src/+/1757685 However, it turns out that atomic inlines paint their backgrounds before the backplate is painted. As such, we do not want to ignore background images for these inlines in forced colors mode. Bug: 970285 Change-Id: Iee2463775e67a1661cbb85f0a51b5bb8f01566cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998976 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#733014}
-
Josh Nohle authored
Bug: 951969, 936273 Change-Id: Ia8e411383b7ee38914aeee1097f29282c614283c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987862 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#733013}
-
Miguel Casas authored
DmabufVideoFramePool::RequestFrames() does not request frames, but sets it up so that GetFrames() can allocate them later on, so s/RequestFrames/Initialize/ in bulk where applicable. Bug: 1040291 Change-Id: I327c9fdac308dcd3d0a52c1319f677df1e1ce74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002934Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#733012}
-
David Black authored
This CL: - Removes AssistantCardElement one-off logic from AssistantResponse so that it will scale to new AssisantUiElement types. - Moves private classes into .cc to clean up .h Bug: b:145003512 Change-Id: If6a9c79a7a6a49c10d903762ac9c1d82a8267c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006137 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#733011}
-
Scott Violet authored
This better matches the new names. BUG=1033924 TEST=none TBR=bcwhite@chromium.org Change-Id: I2341b6c1fcb680723d7794be5197ba70bb25b09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007651 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#733010}
-
Xianzhu Wang authored
Previously, when an <object> failed to load the remote frame content, and used fallback content, we still got the cc::Layer of the remote frame and set it as the contents layer of the GraphicsLayer of the fallback content. When the fallback content had multiple GraphicsLayers (e.g. when the object is inline containing block child), the GraphicsLayers would reference the same cc layer, causing duplicated cc layers in the layer list. Now get cc layer of the remote frame only if the LayoutObject is LayoutEmbeddedContent (i.e. not fallback). Bug: 1033459 Change-Id: I95c1eb1e1a22f57e6ac12a2a10339230e3f4c90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006970 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#733009}
-
jonross authored
A lot of work has been happening with SkiaRenderer, and the expectations files for blink_web_tests are out dated. This updates them to reflect tests that are now passing. TBR=backer@chromium.org TEST=blink_web_tests Bug:1027772, 1026375, 935970, 1002547, Change-Id: Ie75b76b507613350099052f8959ebfc1832a7bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006132Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#733008}
-
Thanh Nguyen authored
This CL enables fuzzy app search by default. Bug: 990684 Change-Id: I934aeb5f4290a4a4849936d53ba44567f2a69ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006988 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#733007}
-
Johannes Kron authored
Bug: chromium:1012063 Change-Id: Iacecd17733bfb8ee1673fc322964d2a95b1497fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007388 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#733006}
-
Saman Sami authored
During the pageflip operation, we only need the CRTC IDs. The CrtcController objects themselves aren't needed. Bug: 1034559 Change-Id: I0259e9440a72a8f4e26346e306d4f648d27387fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008324Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#733005}
-
Evan Stade authored
One functional change: the find bar border color is updated to modern grey 300, which is much lighter than the grey previously used. This value comes from go/clankcolors. Bug: 1038415 Change-Id: I171eda126a59f3057adb62e3033e9cbda4af344d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001289 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#733004}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c766f984..84710764 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6f981e951037ce5ca7a6fffbf140ccd303fbc540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007258Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733003}
-