GitLab

This mode is controlled via variations server. In this mode, cards a loaded, perhaps from some mock location, but the results are not shown (i.e. the view size is set to 0) to the user.

Bug=712331

Review-Url: https://codereview.chromium.org/2878503004
Cr-Commit-Position: refs/heads/master@{#471014}

The ID is generated in the downstream code based on the results
of the build configuration.

BUG=713952

Review-Url: https://codereview.chromium.org/2872453005
Cr-Commit-Position: refs/heads/master@{#471013}

This patch modifies how idle time spell checker decides checking range in
hot mode.

Before:
- If the total text length in the editable is at most 1024, check everything
- Otherwise, check a chunk of text of length 1024, expanded to sentence
  boundaries, centered at the reference position

After:
- If the total text length in the editable is at most 128, check everything
- Otherwise, if the reference position is in a paragraph of length at most
  1024, check the paragraph
- Otherwise, check a chunk of text of length 1024, expanded to sentence
  boundaries, centered at the reference position

BUG=517298

Review-Url: https://codereview.chromium.org/2867393003
Cr-Commit-Position: refs/heads/master@{#471012}

https://boringssl.googlesource.com/boringssl/+log/ddfcc6a60bec2040b4c3668d76c0f2455ecb5594..1e5cb820de99c754b57ab4321e1456ac6bdc1a78

BUG=none

Review-Url: https://codereview.chromium.org/2869243005
Cr-Commit-Position: refs/heads/master@{#471011}

Invert the command line guard flag, so that the apps on the login screen
are enabled by default now, but can be disabled using the
--disable-login-screen-apps flag. (The flag will be removed after some
time once this change is tested and verified.)

Also open up the corresponding policy DeviceLoginScreenAppInstallList,
with updating its supported range to M60+.

The policy description is extended to mention the security and privacy
constraints that are imposed on it.

BUG=576464

Review-Url: https://codereview.chromium.org/2801113002
Cr-Commit-Position: refs/heads/master@{#471010}

This indicates that "PageLoad" event conceptually only happens once per source.

BUG=

Review-Url: https://codereview.chromium.org/2870033002
Cr-Commit-Position: refs/heads/master@{#471009}

BUG=668549

Review-Url: https://codereview.chromium.org/2836333003
Cr-Commit-Position: refs/heads/master@{#471008}

BUG=711155

Review-Url: https://codereview.chromium.org/2870313002
Cr-Commit-Position: refs/heads/master@{#471007}

scrolling.

When wheel scroll latching is enabled, GSB occurs only once in the
beginning of a scroll sequence. So, it is possible to need to switch
to the main thread scroll handling in the middle of a scroll scroll
sequence (e.g. due to a change in main thread scrolling reasons).
To have a complete scroll sequence on main thread side and do the scroll
chain computation only while handling GSB, this cl sends a GSB to the main thread before sending the GSU that is not handled in the impl thread
side.

BUG=526463
TEST=AnimateInput/InputHandlerProxyTest.GestureScrollHandlingSwitchedToMainThread/*

Review-Url: https://codereview.chromium.org/2854683002
Cr-Commit-Position: refs/heads/master@{#471006}

* clean up and generalize PageLoadMetricsWaiter
* where possible, switch tests from calling NavigateToUntrackedUrl() to using PageLoadMetricsWaiter
* add support for monitoring both main and child frame updates
* fix broken DocumentWriteAsync test

BUG=720534

Review-Url: https://codereview.chromium.org/2868213003
Cr-Commit-Position: refs/heads/master@{#471005}

An interrupted download will automatically resume after network reconnection.
However, if the interruption is caused by switching active networks,
no reconnection event will happen.
For example, download may get interrupted if it is started on LTE and then OS decides to switch to WIFI.
In this case, we should immediately resume the download rather than waiting for reconnection.

BUG=707753

Review-Url: https://codereview.chromium.org/2864533004
Cr-Commit-Position: refs/heads/master@{#471004}

To unblock cq. See crbug for more details.

BUG=720511
TBR=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2874213003 .
Cr-Commit-Position: refs/heads/master@{#471003}

This is a mechanical change.

The component updater classes have dependencies on OutOfProcessPatcher.
Before this change, a client that needed to use the ComponentUnpacker
had to include component_patcher_operation.h.

With this change, the clients of ComponentUnpacker only need to include
component_unpacker.h

BUG=719751

Review-Url: https://codereview.chromium.org/2873513002
Cr-Commit-Position: refs/heads/master@{#471002}

BUG=717620
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2869303004
Cr-Commit-Position: refs/heads/master@{#471001}

Clean up expired verdicts when PasswordProtectionService is being destructed (typically, that's during browser shutdown).

BUG=719002

Review-Url: https://codereview.chromium.org/2870193002
Cr-Commit-Position: refs/heads/master@{#471000}

This directory is for creating a new blink_perf benchmark that allows users
to run arbitrary blink_perf test paths through Telemetry

BUG=chromium:720772

Review-Url: https://codereview.chromium.org/2875783002
Cr-Commit-Position: refs/heads/master@{#470999}

https://skia.googlesource.com/skia.git/+log/05fd8cf08970..a9d9ab368318

$ git log 05fd8cf08..a9d9ab368 --date=short --no-merges --format='%ad %ae %s'
2017-05-11 caryclark fix SkASSERT for Visual Studio
2017-05-10 mtklein Add a way to force raster pipeline blitter.
2017-05-11 egdaniel Add some swizzle checks to vulkan backend
2017-05-10 fmalita A8 fast path for raster clip masks
2017-05-10 recipe-roller Roll recipe dependencies (nontrivial).
2017-05-10 reed remove SK_SUPPORT_DEPRECATED_CLIPOPS from g3
2017-05-09 scroggo Remove comments referencing locked pixels
2017-05-10 mtklein Make SkCreateRasterPipelineBlitter() not fail.
2017-05-10 ethannicholas sksl support for static ifs & switches
2017-05-10 jvanverth Unify ShadowUtils interface
2017-05-10 mtklein use SkColorSpaceXformer in SkShader appendStages() fallback
2017-05-10 mtklein clean up SkShader friends
2017-05-10 reed add flag to hide deprecated clipops
2017-05-10 bungeman Fix alpha coverage for lerp_565 stage.
2017-05-09 stephana Experimental Go bindings for Skia

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: Idbb034ae7593dde5cd921a99ff22504addb8cfee
Reviewed-on: https://chromium-review.googlesource.com/502735Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#470998}

1. FrameView::SetTracksPaintInvalidations() may be called before
   FrameView::PrePaint(), so we need to create paint_controller_ if it
   is null, and check null paint_artifact_compositor_.

2. Previously when an old chunk is deleted, we still kept the tracked
   raster invalidations. When a new chunk was created at the same
   address, the new chunk inherited the old trackings.

BUG=644358
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
R=chrishtr@chromium.org

Review-Url: https://codereview.chromium.org/2874553002 .
Cr-Commit-Position: refs/heads/master@{#470997}

The sets of SurfaceIds will almost always be 0-3 elements and change
infrequently. Using flat_set should be faster and use less memory than
unordered_set.

Bug: none

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5576601ded162c741d758481e785fb7fba3c0205
Reviewed-on: https://chromium-review.googlesource.com/503188
Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#470996}

Review-Url: https://codereview.chromium.org/2872973002
Cr-Commit-Position: refs/heads/master@{#470995}

If a parallel request fails to when response starts, it will interrupt the download.
However, the failure may be recoverable by the main requst.
And this issue may cause a download to never finish even if user resumes it.
This change fixes the issue by allowing the failure to passthrough to DownloadFileImpl.
So that DownloadFileImpl can check whether the failure is recoverable.
A side effect of this change is more we will create received_slice vector even if all parallel requests fails.
This can be addressed in later changes.

BUG=720057

Review-Url: https://codereview.chromium.org/2872943003
Cr-Commit-Position: refs/heads/master@{#470994}

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie6560291d7d36a4078f4d846d4d022fe455ba21b
Reviewed-on: https://chromium-review.googlesource.com/502650Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#470993}

mojo::StrongBindingSet replaces the pattern of manually managing a list
of Mojo service implementations and registering connection error
handlers to remove entries from the list when their pipes are closed.

BUG=None

Review-Url: https://codereview.chromium.org/2842013002
Cr-Commit-Position: refs/heads/master@{#470992}

TBR=eyaich@chromium.org
BUG=715565

Review-Url: https://codereview.chromium.org/2879623002
Cr-Commit-Position: refs/heads/master@{#470991}

This CL unmap()s and close()s the handle after it has been used,
preventing the harmless but annoying Log [1]

05-10 12:05:23.985 30381 30389 W HandleImpl: Handle was not closed.

and optimising resource usage by not having to wait until
Handle finalize() to release them.

[1] https://cs.chromium.org/chromium/src/mojo/android/system/src/org/chromium/mojo/system/impl/HandleBase.java?type=cs&l=133

BUG=720234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2873093003
Cr-Commit-Position: refs/heads/master@{#470990}

When we destroy a memory dump manager (MDM is a singleton so this only
happens in tests) we attempt to stop the thread under the lock. This
can lead to a deadlock if there are outstanding tasks which also try to
take the lock. Instead we should get a pointer to the thread under the
lock, stop the thread, then finally reset the pointer which is what this
CL does.

BUG=721072

Review-Url: https://codereview.chromium.org/2881563002
Cr-Commit-Position: refs/heads/master@{#470989}

This setting should only show up if there is cached site activation,
which is determined via querying the associated website setting.

BUG=689487

Review-Url: https://codereview.chromium.org/2873313002
Cr-Commit-Position: refs/heads/master@{#470988}

This renames Receive() to GetAddressOf() to harmonize with
ComPtr::GetAddressOf().

Most replacements were performed automatically with clang-tidy.

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2870263002
Cr-Commit-Position: refs/heads/master@{#470987}

So that the same work is not done multiple times.

BUG=718614

Review-Url: https://codereview.chromium.org/2863353002
Cr-Commit-Position: refs/heads/master@{#470986}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/23c9f59f4c6b..59e58189c55d

$ git log 23c9f59f4..59e58189c --date=short --no-merges --format='%ad %ae %s'
2017-05-11 simonhatch Dashboard - Choose anomaly config which most specifically matches.

Created with:
  roll-dep src/third_party/catapult
BUG=718981


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Icf38804f7c158bfc919f3e72f124aa576f8f53f6
Reviewed-on: https://chromium-review.googlesource.com/502633
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#470985}

BUG=433009

Review-Url: https://codereview.chromium.org/2867223003
Cr-Commit-Position: refs/heads/master@{#470984}

Revert of SimpleCache: Add a test that covers recovery from missing index. (patchset #2 id:20001 of https://codereview.chromium.org/2878523002/ )

Reason for revert:
Seem to break (or maybe just flake?) on "Android Cronet KitKat Builder".

Need to figure out how to test it myself like that, I guess.

Original issue's description:
> SimpleCache: Add a test that covers recovery from missing index.
>
> (As I can't seem to find a preexisting one)
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2878523002
> Cr-Commit-Position: refs/heads/master@{#470947}
> Committed: https://chromium.googlesource.com/chromium/src/+/31a646c7268cb0957b681ede8332da9bdc513bd2

TBR=jkarlin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2879613002
Cr-Commit-Position: refs/heads/master@{#470983}

Bug: chromium:707149
Change-Id: I230d05a979831db068134a42818b30325f0512b9
Reviewed-on: https://chromium-review.googlesource.com/496788Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Mircea Trofin <mtrofin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#470982}

Currently, the software renderer always uses kReplace_deprecated when
applying clips. This is necessary, as we never save/restore around
clips, never cleaning up the previous clips we've used.

This change causes software renderer to avoid the replace behavior
by saving/restoring around clipping changes in DrawRenderPassQuad.

With this change, any clipped DrawRenderPassQuad will add a
save/restore. Additionally, calling EnsureScissorTestEnabled or
SetScissorTestRect has no immediate impact, instead it just queues
up the clip for the next DrawRenderPassQuad.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2867913002
Cr-Commit-Position: refs/heads/master@{#470981}

Width is now conformant to spec. See bug for screenshots.

Moved the billing address combobox to be handled by the base class now.
The credit card editor only adds the Add button as an extra view.
Modified the address combobox model to accept a default selected guid.

BUG=718548,720593
TEST=visual

Review-Url: https://codereview.chromium.org/2871873003
Cr-Commit-Position: refs/heads/master@{#470980}

Revert of [v8] Mark layout tests for automatic rebaseline. (patchset #1 id:1 of https://codereview.chromium.org/2865113006/ )

Reason for revert:
v8 got reverted and this is now one of the failing tests on https://crbug.com/720511

Original issue's description:
> [v8] Mark layout tests for automatic rebaseline.
>
> Now that a V8 version with the new asm.js validator has been rolled into
> Chromium, the affected layout tests can be automatically rebased. This
> feature is not yet enabled.
>
> R=machenbach@chromium.org
> BUG=chromium:718394
> NOTRY=true
>
> Review-Url: https://codereview.chromium.org/2865113006
> Cr-Commit-Position: refs/heads/master@{#470286}
> Committed: https://chromium.googlesource.com/chromium/src/+/1a0e41a86180a90bb523c9ae3b577b223f31aa87

TBR=machenbach@chromium.org,mstarzinger@chromium.org
NOTRY=true
BUG=chromium:718394

Review-Url: https://codereview.chromium.org/2870393004
Cr-Commit-Position: refs/heads/master@{#470979}

BUG=717714

Review-Url: https://codereview.chromium.org/2870203002
Cr-Commit-Position: refs/heads/master@{#470978}

Features an item similar to AutofillEditItem to be used in the
payments edit form for fields that have noneditable values (e.g.,
selector fields).

BUG=602666

TBR=jdonnelly@

Review-Url: https://codereview.chromium.org/2879433002
Cr-Commit-Position: refs/heads/master@{#470977}

Revert of Disable BottomSheetTest on pre-Lollipop MR1 (patchset #1 id:1 of https://codereview.chromium.org/2781093004/ )

Reason for revert:
android.support.v7.widget.RecyclerView is a support library class. It can be used regardless of the Android version.

Original issue's description:
> Disable BottomSheetTest on pre-Lollipop MR1
>
> BottomSheetTests have a hard dependency on RecyclerView,
> which is a class that was added in SDK level 22 (Lollipop
> MR 1).
> This change disables BottomSheetTests on all API levels
> which do not have RecyclerView.
>
> BUG=None
>
> Review-Url: https://codereview.chromium.org/2781093004
> Cr-Commit-Position: refs/heads/master@{#460554}
> Committed: https://chromium.googlesource.com/chromium/src/+/7038439b2c151c9dd0fcd1de0330f2785d11d09a

TBR=nyquist@chromium.org,kraush@amazon.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None

Review-Url: https://codereview.chromium.org/2871173003
Cr-Commit-Position: refs/heads/master@{#470976}

This fixes an issue where these inputs incorrectly cancel keyword search
mode.

BUG=513966

Review-Url: https://codereview.chromium.org/2858373002
Cr-Commit-Position: refs/heads/master@{#470975}