- 13 Dec, 2017 24 commits
-
-
Aleks Totic authored
Part 4 of 4 of inline containing block for OOF descendants https://chromium-review.googlesource.com/c/chromium/src/+/777707 Geometry of computing the containing block coordinates is complex. In the old code, all containing block geometry was stored as members of NGOutOfFlowLayoutPart. With inline containing blocks, each inline-cb can have a different geometry. Code was refactored so that cb geometry is configurable per descendant. Bug: 740993 Change-Id: I3dd392472081ac6b09dd6a2540d142ba9966f3a6 Reviewed-on: https://chromium-review.googlesource.com/818333 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#523635}
-
Stefan Zager authored
Add some calls to LayoutViewportScrollableArea and replace some faulty custom geometry logic with calls into LocalFrameView. BUG=711468 R=skobes@chromium.org,bokan@chromium.org Change-Id: Id937278809ed59710a76722d6219b98f539d6e06 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Reviewed-on: https://chromium-review.googlesource.com/822159Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#523634}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/aeff9eaa1903..106e17aa38c9 $ git log aeff9eaa1..106e17aa3 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 mtklein JUMPER_IS_AVX2 -> JUMPER_IS_HSW 2017-12-12 rmistry Store skiaserve binary in GS from Release Android compile bots 2017-12-11 herb Handle small sigma in one direction Created with: roll-dep src/third_party/skia BUG=793285 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I63b183b3cf074966faf9f803ef04b0465bb343af Reviewed-on: https://chromium-review.googlesource.com/823249Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523633}
-
Will Harris authored
BUG=786970 Change-Id: Ie1e99f9f82713fe5c0a9d2db6802a2576d3a60a6 Reviewed-on: https://chromium-review.googlesource.com/823213 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#523632}
-
Dmitry Gozman authored
Bug: none Change-Id: Id6123227f6532343b70a57fea7394be91d8cffac Reviewed-on: https://chromium-review.googlesource.com/786372Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523631}
-
Vadym Doroshenko authored
Bug: 554927 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I842e4949799fd70bf5abdae560e38041da1593a2 Reviewed-on: https://chromium-review.googlesource.com/822519Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#523630}
-
Sandra Sun authored
The original test is written using js-test and is using shouldBecomeEqual() to verify the scroll offset after the animation, which makes it flaky. This patch rewrites the patch using testharness and promise test, and only checks after the page no longer scrolls or has reached the specified destination, which would be independent from the platform's performance, making the test robust. We separate the waitForWindowScrollEnd into scroll-animation.js so that other tests can reuse the method. We also change the input-driven scroll from clicking at scrollbar to keyboard-left so that the test passes on Mac. Bug: 664858 Change-Id: I030392484489983453bf7a11b55b05c13fa4a470 Reviewed-on: https://chromium-review.googlesource.com/822988Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Alex Moshchuk authored
Bug: 794336, 793471 Change-Id: I035823fe6cf0f2f063e58707f3b8a4eba6748ee8 Reviewed-on: https://chromium-review.googlesource.com/823246 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523628}
-
Victor Costan authored
The default Apache configuration (used on Windows, Mac, and unknown Linux distributions) includes mod_autoindex, which generates directory listings. These are very useful when running tests in a browser (or content shell) via Tools/Scripts/run-blink-httpd, as they make it possible to navigate to the desired test from the HTTP server's root, instead of having to get the full path to a test in the browser's address bar. This CL updates the Debian configuration for Apache 2.4 to load mod_autoindex, so Debian users can get the same directory listing that is present on Windows and Mac. The CL also reorders some LoadModule statements to bring the order closer to the default configuration. This is intended to make it easier to compare the module lists in the future. Tested by running third_party/WebKit/Tools/Scripts/run-blink-httpd on Debian Testing. Bug: Change-Id: I6ddf8fb53e3b91157ff8c544fb1844d0487c8276 Reviewed-on: https://chromium-review.googlesource.com/817767Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#523627}
-
Peter Boström authored
Splits up some globals and makes this a stand-alone dialog instead of a child view to a catch-all password dialog. Uses a 6:4 ratio for username/password rows. These ratios are always fixed and will not vary based on content. This keeps the look consistent as the contents inside the dialog changes. Also fixes regression where additional padding is observed on the right-hand side of the manage-passwords dialog. TBR=vasilii@chromium.org Bug: chromium:654115, chromium:784754 Change-Id: Ic3bc8cee08be90e0f4973fb6752eae355ecd0bb1 Reviewed-on: https://chromium-review.googlesource.com/724126 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#523626}
-
W. James MacLean authored
This CL revises the calculations used by the child frame touch selection controller client when converting child-frame coordinates to the root frame coord space. The old calculations failed to take into account the page scale factor. This CL also removes RenderWidgetHostViewChildFrame::GetViewOriginInRoot(), which is now obsolete. Bug: 793363 Change-Id: I48766c396193b243d7336304bbf87734b5a41689 Reviewed-on: https://chromium-review.googlesource.com/820014Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#523625}
-
Wez authored
Bug: 789804 Change-Id: I58f9b55c85efd1e3dc6cca47798aa6e3b2aad1b7 Reviewed-on: https://chromium-review.googlesource.com/822732Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#523624}
-
Alexei Svitkine authored
Also, make the hash constants use constexpr. BUG=none Change-Id: I7abb633d8bfac35eda50f797a2bf88b1ac8f8584 Reviewed-on: https://chromium-review.googlesource.com/811527Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#523623}
-
Victor Costan authored
Recent versions of Fedora ship with PHP7, so the Apache configuration flavors for RedHat don't work on Fedora. Given that Fedora tends to change a lot quicker than RedHat, it makes sense to have a separate Apache configuration flavor that can be adapted to changes without worrying about breaking RedHat support. Tested by running third_party/WebKit/Tools/Script/run-blink-httpd and by running some LayoutTests. Bug: Change-Id: I0e468e99832498ad426e1e97852bd4927c874483 Reviewed-on: https://chromium-review.googlesource.com/818644Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
-
Dmitry Skiba authored
This CL refines TRACE_EVENTs added to generated mojo code: 1. "ns::Class::Method" event is emitted when client calls a mojo interface. 2. "(Impl)ns::Class::Method" event is emitted when mojo calls the implementation of an interface. 3. "(Impl)ns::Class::MethodCallback" event is emitted when an implementation calls the method's callback. 4. "ns::Class::MethodCallback" event is emitted for async methods when the method's callback is called on the client side. Additionally, this CL removes couple of redundant TRACE_EVENTs that are either contained in the events above, or are not useful for understanding mojo call flow. Bug: 792614 Change-Id: I03ac80729ff0e9d0c4ad9fb7fc98e962110a0518 Reviewed-on: https://chromium-review.googlesource.com/812104Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Cr-Commit-Position: refs/heads/master@{#523621}
-
Artur Khachatryan authored
This CL is a fix of the bug 2164. Chrome no longer allows navigate to the data URL we use in our tests as a startup page. We change in this test to open an empty page. Bug: chromedriver:2164 Change-Id: I922ee17e68086d631143e81fce794df99ed3840d Reviewed-on: https://chromium-review.googlesource.com/823256Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#523620}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/3c613c0d79fa..a98a28112b0e $ git log 3c613c0d7..a98a28112 --date=short --no-merges --format='%ad %ae %s' 2017-11-30 jiajia.qin ES31: Add support for GL_DISPATCH_INDIRECT_BUFFER_BINDING binding point Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I5a7d574774f57256d36a2b33a81108347992f10c Reviewed-on: https://chromium-review.googlesource.com/822459Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523619}
-
Mike Wasserman authored
Append mirrors to the list of displays in DisplaySynchronizer. (creates normal ws::Displays for ash to handle mirror content) Add & call aura::WindowTreeHostObserver::OnAcceleratedWidgetOverridden. (lets MirrorWindowController handle mus's async initialization) Support WindowTree::ProcessSetDisplayRoot use with existing displays. Remove WindowManagerState::DeleteWindowManagerDisplayRoot NOTREACHED. (now hit when re-using a display and switching mirror->extended) Allow ash/window_manager.cc to include ash/host/ash_window_tree_host.h Bug: 770243 Change-Id: I21ada68097cff001bb98b9a8a22482d59d0ac1c8 Reviewed-on: https://chromium-review.googlesource.com/806238Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#523618}
-
Scott Graham authored
c04c05564db1 linux: Fix gcc -Wparentheses error from 7a0daa6989a9 92e8bc4713e1 win: Fix ProcessInfo.OtherProcess test flake 0cc63d4a4558 android: Make run_tests.py work on Android versions before 7.0 (N) 13d0defbfb45 android, win: Enable colored test output when available 0924e567514f linux: Add PtraceBroker and PtraceClient Re-enables ProcessInfo.OtherProcess. Bug: chromium:792619 Change-Id: Ic1178674e6704b9c4560be52a9197c53930a5a9b Reviewed-on: https://chromium-review.googlesource.com/823218Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523617}
-
Mostyn Bramley-Moore authored
We can avoid the jumbo build error mentioned below, by replacing these (translation unit) global g_next_id variables with static class variables: ./../../cc/paint/raw_memory_transfer_cache_entry.cc:13:28: error: redefinition of 'g_next_id' base::AtomicSequenceNumber g_next_id; ^ ./../../cc/paint/image_transfer_cache_entry.cc:15:28: note: previous definition is here base::AtomicSequenceNumber g_next_id; Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I320f03d6147ca0d2e29ad75573735e9860c4ee99 Reviewed-on: https://chromium-review.googlesource.com/823032 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#523616}
-
Ian Vollick authored
Previously, we'd leave presentation but the timeouts would still be active. This could result in the timeout UI showing, even when using the 2D browsing UI. Bug: 794297 Change-Id: I89ba432f00cd27ae585f15a560d5212efca8798b Reviewed-on: https://chromium-review.googlesource.com/823155 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#523615}
-
Raymes Khoury authored
This changes the code such that when the DSE has been disabled by enterprise policy and is then re-enabled, we revert the DSE setting to BLOCK. We only do this if the origin that is becoming the DSE wasn't previously granted permission. Bug: 799534 Change-Id: I9a061262e6e2886ff04ffa97e487ff0eb200d892 Reviewed-on: https://chromium-review.googlesource.com/812588 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#523614}
-
Jacob Dufault authored
- Allow ChromeVox to navigate to dropdown arrow using Search+Arrow keys. - Fix accessibility label for dropdown arrow next to user label. - Fire alert when showing bubble so ChromeVox reads the contents. Bug: 757273 Change-Id: I7fc5cc8b730a2b3d796cf040679e0de549f8fc92 Reviewed-on: https://chromium-review.googlesource.com/822979Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#523613}
-
Klaus Weidner authored
If there's an outstanding presenting VSync request when presentation exits, it must be converted to a normal VSync request for magic window mode. This fixes a regression introduced by crrev.com/c/817545. BUG=794266 Change-Id: I93f0739facb702f68c29d8af7c77b669d6b54bda Reviewed-on: https://chromium-review.googlesource.com/822985Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
-
- 12 Dec, 2017 16 commits
-
-
Raymes Khoury authored
This adds features::kGrantNotificationsToDSE to about flags for easy toggling for testing purposes. Bug: 780344 Change-Id: Iffbfe175fbafea5aef368255a226a7780cc3ab44 Reviewed-on: https://chromium-review.googlesource.com/821991 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/d076c5980367..30c927c2b8f3 $ git log d076c5980..30c927c2b --date=short --no-merges --format='%ad %ae %s' 2017-12-12 simonhatch Dashboard - Fix find_anomalies and graph_revisions called with None Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I67368146f9866f3093f726ad3db37e87f53eaa74 Reviewed-on: https://chromium-review.googlesource.com/822216 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523610}
-
Lukasz Anforowicz authored
This reverts commit 1c950906. Reason for revert: Broke Hangouts Chrome App - see https://crbug.com/794079 Original change's description: > Improve granularity of window namespaces in Blink. > > This CL ensures that blink::FrameTree::Find(const AtomicString& name) > only looks for a match in the current set of related browsing contexts > (represented in the browser by content::BrowsingInstance). This CL > means that window.open's behavior won't change just because a renderer > process happens to host multiple unrelated browsing contexts (possible > for example after reusing a renderer process because of hitting the > process limit). > > This CL consists of 3 parts: > > - New browser tests. > - RenderFrameHostManagerTest.ProcessReuseVsBrowsingInstance > for verifying browsing instance boundaries when the > renderer processes get reused. > - ExtensionFunctionalTest.FindingUnrelatedExtensionFramesFromAboutBlank > for verifying that extensions can still lookup unrelated frames > from the same extension. > > - Having blink::Page maintain a set of related pages. > - Page::next_related_page_ and Page::prev_related_page_ form a > circular, double-linked list of related pages. > - Page::CreateOrdinary takes a new |opener| parameter and treats the > new page and the |opener| as related and puts them on the same list. > - |opener| is propagated from content::RenderViewImpl, through > blink::WebViewImpl into blink::Page. > > - Falling back to blink embedder when blink::FrameTree::Find finds no frame > with the given name. > - The fallback is needed to preserve the old behavior for extensions. > - The fallback goes through blink::LocalFrameClient, > blink::WebFrameClient / content::RenderFrameImpl, > content::ContentRendererClient / ::ChromeContentRendererClient, > ::ChromeExtensionsRendererClient and finally is implemented > by extensions::ExtensionFrameHelper. > - Currently the fallback iterates through all same-origin frames in > the given process, but requires that the |relative_to_frame| is an > extension frame. In the future we might want to restrict piercing > of browsing instances to specific scenarios where it is needed > (e.g. restrict it to background pages / contents only?). > > I've tested this CL via: > (all tests below pass before and after the CL, except for > ProcessReuseVsBrowsingInstance which is fixed by this CL) > > - New tests: > - RenderFrameHostManagerTest.ProcessReuseVsBrowsingInstance > (web -> web shouldn't violate browsing instance) > - ExtensionFunctionalTest.FindingUnrelatedExtensionFramesFromAboutBlank > (extension/about:blank -> extension can violate browsing instance) > > - Existing tests: > - ExtensionApiTest.WindowsCreate_WithOpener and _NoOpener > (chrome.windows.create stays in the same browsing instance depending > on the setSelfAsOpener parameter) > - AppBackgroundPageApiTest.Basic > (hosted app -> background page can violate browsing instance; > tests handling of mapping of web urls [full url, not just origin] > to extensions) > > - Manual testing: > - Hangouts Chrome *extension* continues to work (sufficient to > validate that sign-in works). Tested with version 2017.1019.418.1. > > Bug: 718489 > Test: See above. > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Tbr: tommycli@chromium.org > Change-Id: Icdc9ec7bef0e35b59e04fb12385045f22db80c3a > Reviewed-on: https://chromium-review.googlesource.com/764487 > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521917} TBR=dcheng@chromium.org,creis@chromium.org,thestig@chromium.org,wolenetz@chromium.org,tommycli@chromium.org,rdevlin.cronin@chromium.org,lukasza@chromium.org,rbpotter@chromium.org Bug: 718489, 794079 Change-Id: I7ee06ae1b8341044377d5e0ae975888c99d8f700 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/822756Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
-
Carlos Knippschild authored
This change takes into account the "limitless prefetching" feature flag to choose to ignore the daily download quota and increase the concurrent downloads limit when it is enabled. Bug: 793109 Change-Id: I6a3aea110976bcd1c2afac1dbfa86f06e0327b25 Reviewed-on: https://chromium-review.googlesource.com/817705 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#523608}
-
Nate Chapin authored
Bug: 793028 Change-Id: Ice4ec0acdd179f2a7e2b17a497ee3bdf6e91fff4 Reviewed-on: https://chromium-review.googlesource.com/822916Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#523607}
-
Raymes Khoury authored
This updates 2 UI surfaces to reflect notifications permissions set for the DSE. Specifically: 1) In android Site Details, when toggle the DSE permission for notififications, it will show the options "Allow/Block for the current search engine". 2 cases are handled here: one when that setting links directly into Notification Channels on Android O+ and the other in the case where the permission is handled directly in Chrome. 2) In Settings>Search Engines, underneath the currently selected search engine, it will display a link indicating whether notifications/geolocation are allowed. The link will take the user to the Site Details for the search engine. Several changes have been made to the behavior here: -The link used to indicate if location was disabled. Now, if notifications are location are disabled, nothing will be shown in the text for those permissions. -The link used to take users directly to Android Location Settings when the text indicated that system location was disabled. But now due to the link handling combined permissions, it always takes the user directly to Site Details for the search engine, where the user can follow a link into Android Location Settings. Bug: 780344 Change-Id: I41e0dd1028ad289141d1632875d30373b528f17c Reviewed-on: https://chromium-review.googlesource.com/799534 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523606}
-
Paul Jensen authored
Exposes a Tag(SocketTag) API on StreamSocket and DatagramClientSocket. Deduplication of tagging is done at the TcpClientSocket and UdpClientSocket layers, which includes avoiding applying the default tag to newly created sockets. This ensures that underlying TCPSocket::Tag() and UDPSocket::Tag() are never called on non-Android targets where tagging is not yet supported because it's not possible to create non-default SocketTags on these targets. Socket impls that wrap other sockets pass the tag down to the wrapped socket in cases where the wrapped socket only services the one wrapping socket. Retagging is disallowed when the wrapped socket services multiple wrapping sockets, though the underlying socket can be tagged before being wrapped. Bug: 520198 Change-Id: I53bf343409268a4c6a32f9a3f4f1a565bd44be0e Reviewed-on: https://chromium-review.googlesource.com/793986 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Le-Chun Wu <lcwu@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#523605}
-
Koji Ishii authored
This patch adds layout_ng try bots for following directories: - Source/core/paint/ng - LayoutTests/FlagExpectations/enable-blink-features=LayoutNG - LayoutTests/flag-specific/enable-blink-features=LayoutNG in the same way as slimming-paint does. Bug: 591099, 708452 Change-Id: I1d4f5d0655794837f6292f0030862cece6db4f55 Reviewed-on: https://chromium-review.googlesource.com/822553Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
-
dpapad authored
Bug: 781439 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2aff2f2096f6824ceffc05c2c94fcbf013166e5a Reviewed-on: https://chromium-review.googlesource.com/816354Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#523603}
-
Tom Anderson authored
BUG=793801 R=thestig@chromium.org Change-Id: I60ee6ec48d2686d0b42ca25311a9b76009ce9768 Reviewed-on: https://chromium-review.googlesource.com/823245Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#523602}
-
Andrey Lushnikov authored
This patch starts computing unique suffixes for file system projects. BUG=633305 R=dgozman Change-Id: I9e0cea72ccf7750b21d0708e079f69178e06650d Reviewed-on: https://chromium-review.googlesource.com/822603 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523601}
-
Robert Sesek authored
This also changes wherever possible from the old implicit value of READ_WRITE to READ_ONLY. Bug: 793503, 793519 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0ebafb2eb93af9718e71a303e239ecaa4e7d8f35 Reviewed-on: https://chromium-review.googlesource.com/820011Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523600}
-
Nate Chapin authored
* DocumentResource has one easy case to plumb a ResourceClient, and one very difficult case that's already friend'ed for ResourceClient::SetResource * ImageResource and LinkFetchResource never add clients, just always pass nullptr for the ResourceClient*. * FontResource will be correctly plumbed in https://chromium-review.googlesource.com/c/chromium/src/+/818304, just use nullptr in the meantime. Bug: 793028 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I49a20de543f4570ca2a8940a57bd22ff5c8f70cc Reviewed-on: https://chromium-review.googlesource.com/822162Reviewed-by:
-
Xianzhu Wang authored
This CL let the counts of category filters show the counts with text filter applied. I had hesitated which to choose: counts before text filter and after text filter and after tries both I feel the latter is more informative. Wdyt? Change-Id: I229fb0e49e628ffa1685f59f44b5ca848d3f410f Reviewed-on: https://chromium-review.googlesource.com/822754 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#523598}
-
Ted Choc authored
BUG= Change-Id: I776c0b5a9c25d3804e14ce922c8ac4905097f3a9 Reviewed-on: https://chromium-review.googlesource.com/822512Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523597}
-
Xiaohan Wang authored
Previously we always truncate logs from the beginning, but there could be important information there. This CL changes the behavior so that we always truncate the middle part of the log to preserve potentially important information in the top and bottom part of the log. BUG=793426 TEST=This improves test infrastructure. Change-Id: I058f735fbaedec324960b2c7a269d549b1a0178e Reviewed-on: https://chromium-review.googlesource.com/823191Reviewed-by:
-
