- 22 Nov, 2018 40 commits
-
-
Mikel Astiz authored
As discussed in recent code reviews, let's emphasize the distinction between network errors and HTTP status codes. Bug: 774180 Change-Id: Id9e38f5a340c887519d15d137f41facfc1f9dadb Reviewed-on: https://chromium-review.googlesource.com/c/1348057 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#610417}
-
Gabriel Charette authored
and follow-up on nits to https://chromium-review.googlesource.com/c/chromium/src/+/1261855 R=fdoray@chromium.org Change-Id: I2ca5305af71fa89e13be10e40779641362529a42 Reviewed-on: https://chromium-review.googlesource.com/c/1342770 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#610416}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f406080c7dee..eec675da4cad Created with: gclient setdep -r src-internal@eec675da4cad The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I157d7f1e212f90689f705193cd881d924b6016c0 Reviewed-on: https://chromium-review.googlesource.com/c/1348013Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610415}
-
Yi Su authored
PasswordDetailItem can display an uneditable string as plain text("abc") or masked text("XXX"). This CL add the same functionality in TableViewTextItem to avoid creating another class like TableViewPasswordItem. This is a preparation work for migrating Settings from MDC to UIKit. Bug: 894791 Change-Id: I34538659d6879246c66e9aafd4d88cb8d7822f3c Reviewed-on: https://chromium-review.googlesource.com/c/1346151 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:Eric Noyau <noyau@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#610414}
-
Andrew Grieve authored
Ran into this on a local O device, where the OS had created a file: /data/user/0/org.chromium.chrome.tests/incremental-install-files/optimized-dexes/third_party.google-truth.google_truth_java.dex.jar.arm.flock Not sure why the file was created, but this change ignores it. Change-Id: I8233396e911bcee272abc514eecc7d9baa0a7ffa Reviewed-on: https://chromium-review.googlesource.com/c/1347573Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610413}
-
Stephane Zermatten authored
When an interrupt script is run, it can modify anything, which makes the main script with allow_interrupt=true hard to write. This change propose to reset some state automatically after an interrupt to make this easier. It recovers the status message and attempts to set a reasonable scroll position. It sets it to either the element WaitForDom was waiting for, for a successful WaitForDom. For an unsuccessful WaitForDom, it scrolls to the last element focused on (if it still exists.) Change-Id: Ie9c0022eebc10e0711c82d83b943e0de152af1fd Reviewed-on: https://chromium-review.googlesource.com/c/1346451 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610412}
-
Tibor Goldschwendt authored
We are hitting dex method limit. This XL fixes that. NOTRY=true # Bots got passed failing build step. NOTREECHECKS=true Bug: 907888 Change-Id: Ic45f54e761b77fef45dcfe79ae1d0ddc8fea1544 Reviewed-on: https://chromium-review.googlesource.com/c/1347788 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610411}
-
Mugdha Lakhani authored
When we allow access to active background fetches, BackgroundFetchRecords for the fetch can be accessed from multiple places. It simplifies matters if we return the same record for a request whenever it's accessed. This CL adds a (private) list of BackgroundFetchRecords to the BackgroundFetchRegistration object, and updates it every time match and matchAll() are called. The second change introduced here is to not immediately resolve responseReady() if the fetch is active and a response for the request isn't yet available. Once the fetch has completed, or there's a response available for the request, we resolve pending promises. We also make sure to return the same promise (resolved or unresolved) for a given record, every time responseReady is called. For a more detailed discussion, see the following doc: https://docs.google.com/document/d/1CrbWrnnshhyp_SfiAeuODpnQX36GK3Bsi19rXQGez6Q/edit?usp=sharing Bug: 875201 Change-Id: I8cb386efd19086c0993ad2be2fb2691ad90597ec Reviewed-on: https://chromium-review.googlesource.com/c/1336151 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#610410}
-
Manu Cornet authored
Currently, most gestures on the overflow shelf are completely ignored. This causes (among other things) the two bugs linked from this CL because gestures trying to reorder icons, or after a long press event, are ignored. The main reason for the special casing is that we don't want gestures on the overflow shelf to cause showing the app list, or to drag the shelf itself when it's an autohide shelf. However, ignoring all gestures is overkill. This CL handles gestures in a more fine grained way: * The app list cannot be shown by swiping up from the shelf when the overflow shelf is shown. The change here is that one could initially swipe up from the main shelf even when the overflow shelf was shown. Now the overflow shelf needs to be hidden first. The previous behavior could arguably be seen as a bug because one could get a full screen app list while the overflow menu was still being shown, which looked quite strange. * The shelf cannot be dragged up or down (in the case of an autohide shelf) when the overflow shelf is shown. Previously, one could drag the shelf while overflow was open (just not by performing the gesture on the overflow shelf itself). This resulted in behaviors where the whole "shelf + overflow" could be dragged up or down. Now, the overflow shelf will be dismissed first. One could argue either way, but I would consider the change a good change. * All other gestures are handled in the overflow shelf in the same way as the main shelf. Bug: 882991, 905121 Change-Id: I9269b9a0943f4aa39aa26d4d339cbbfa80b51135 Reviewed-on: https://chromium-review.googlesource.com/c/1343659 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO till 11/26) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#610409}
-
Andreas Haas authored
With https://crrev.com/c/1336130 we can see more clearly why crashes happen in `SetSystemPagesAccess`. This CL adds special handling for crashes we now know are OOM crashes. R=haraken@chromium.org Bug: v8:8238 Change-Id: Ia050ee5887834ab8d4c4a80ba6ecf4cc2a5e8e50 Reviewed-on: https://chromium-review.googlesource.com/c/1348051Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#610408}
-
Olivier Robin authored
This is a reland of d15dd85f Original change's description: > [Reland] Block resources in FormStructureBrowserTest. > > The files used for FormStructureBrowserTest are snapshots of real web > sites. They can have link to online resources but should not need them > for the test to pass. > But if the network is really bad, the page can wait for the resource > loading to finish and timeout. > Preventing the resource loading will make the test faster and more > robust. > > Bug: 896173 > Change-Id: I16b02e1d7defd4d950e6ee4cd21bd0133b9ac957 > Reviewed-on: https://chromium-review.googlesource.com/c/1346462 > Commit-Queue: Olivier Robin <olivierrobin@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610366} Tbr: eugenebut@chromium.org Bug: 896173 Change-Id: I713942404ec5ab47fb653f4fc2c04214f66fa866 Reviewed-on: https://chromium-review.googlesource.com/c/1348032Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610407}
-
Anders Hartvoll Ruud authored
TBR=jamesr@chromium.org Bug: 907859 Change-Id: Ia9b893ce42f89121c12f52dc7b4cddc4b97dc635 Reviewed-on: https://chromium-review.googlesource.com/c/1348066Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#610406}
-
Javier Ernesto Flores Robles authored
Not setting this was causing a crash on iOS < 11.2 Bug: 878388 Change-Id: I6b5391a360e1f06e584352235a978273d704bd26 Reviewed-on: https://chromium-review.googlesource.com/c/1348034Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#610405}
-
Maks Orlovich authored
This is slower, but it's better than not loading pages at all since important resources got corrupted:( Bug: 899874 Change-Id: I19f7eccff0c8aa119e522aee9cf728934906b917 Reviewed-on: https://chromium-review.googlesource.com/c/1347109 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610404}
-
Hans Wennborg authored
Previous Clang versions would only error about a defaulted function being deleted when they're *used*. This warning highlights the problem up-front. ../../media/filters/fuchsia/fuchsia_video_decoder.cc:156:3: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted] InputBuffer(InputBuffer&& other) = default; ^ ../../media/filters/fuchsia/fuchsia_video_decoder.cc:202:15: note: move constructor of 'InputBuffer' is implicitly deleted because field 'buffer_' has a deleted move constructor CodecBuffer buffer_; ^ ../../media/filters/fuchsia/fuchsia_video_decoder.cc:147:28: note: 'CodecBuffer' has been explicitly marked deleted here DISALLOW_COPY_AND_ASSIGN(CodecBuffer); ^ ../../media/filters/fuchsia/fuchsia_video_decoder.cc:221:3: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted] OutputBuffer(OutputBuffer&& other) = default; ^ ../../media/filters/fuchsia/fuchsia_video_decoder.cc:217:22: note: move constructor of 'OutputBuffer' is implicitly deleted because base class 'base::RefCountedThreadSafe<OutputBuffer>' has a deleted move constructor class OutputBuffer : public base::RefCountedThreadSafe<OutputBuffer> { ^ ../../base/memory/ref_counted.h:425:28: note: 'RefCountedThreadSafe' has been explicitly marked deleted here DISALLOW_COPY_AND_ASSIGN(RefCountedThreadSafe); ^ Bug: 890307 Change-Id: I9f8751735e09cb3ec0f6f4c400f8964194bd8937 Reviewed-on: https://chromium-review.googlesource.com/c/1348031Reviewed-by:Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#610403}
-
Mikel Astiz authored
HttpResponse::ServerConnectionCode (poorly named, because it includes network status too) should not be exposed to the fake server (or any server). Instead, let the "client" construct that information based on the network error and http response code. Specifically, the logic is moved to LoopbackConnectionManager, which becomes more analogous to the "production" ServerConnectionManager. This removes some weirdness like FakeServer::SendToLoopbackServer() dropping |server_status| altogether. Bug: 774180 Change-Id: I52e51925a63a08e592c40d840a9319ff2244616a Reviewed-on: https://chromium-review.googlesource.com/c/1347286Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df6d992630bc..f406080c7dee Created with: gclient setdep -r src-internal@f406080c7dee The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibb871b4c5e54f2ea1161eb5c1695f42a6d8dd8f9 Reviewed-on: https://chromium-review.googlesource.com/c/1348009Reviewed-by:
-
Anders Hartvoll Ruud authored
TBR=scottmg@chromium.org Bug: 907862 Change-Id: I3fa8fbb2e75b4744cf47031f233bfd4ce613a38d Reviewed-on: https://chromium-review.googlesource.com/c/1348056Reviewed-by:
-
Peter E Conn authored
When a TWA leaves the verified origin, the Custom Tabs top bar is displayed and the user can see a close button. This close button would on a normal custom tab close the Activity. On Trusted Web Activities, this should return us to the verified origin instead. Bug: 907535 Change-Id: I9f652a3255afdd23072b32c44db5680172ea33f2 Reviewed-on: https://chromium-review.googlesource.com/c/1346463 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#610399}
-
Owen Min authored
Bug: 904983 Change-Id: I340ccaeaf679bf1d63276daa223b360e80daad2b Reviewed-on: https://chromium-review.googlesource.com/c/1345411Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610398}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 157ff273. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org: external/wpt/mediacapture-streams NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia1a06f523153ba570d0c2ba8ebfde12670770ecc Reviewed-on: https://chromium-review.googlesource.com/c/1347783 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610397}
-
DongJun Kim authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I902571315f77562eecb45dc641d15c03af9fc1fa Reviewed-on: https://chromium-review.googlesource.com/c/1343877 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Mikel Astiz authored
A server shouldn't be capable of returning network errors; that belongs some other layer that represents the network. This patch moves this support to FakeServerHttpPostProvider which is arguably an improvement already. Bug: 774180 Change-Id: I1e5ebae89ff82f2a1ece78555b79c9732a71ee02 Reviewed-on: https://chromium-review.googlesource.com/c/1348030 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Alex Clarke authored
This can lead to nested messageloops and it's working by accident currently due to the interactions with the way the SequenceManager and the MessageLoop work. Bug: 863341, 891670 Change-Id: I7b01059638e2ba8a136a7daac387467aab517a3c Reviewed-on: https://chromium-review.googlesource.com/c/1347353Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#610394}
-
Lowell Manners authored
This CL deletes unused includes of ProfileOAuth2TokenService from profiles_state.cc. This aids in the conversion of the codebase from ProfileOAuth2TokenService to IdentityManager. Bug: 904406 Change-Id: Ibb8f9ca0c7d27b51857ce5932600972db109682b Reviewed-on: https://chromium-review.googlesource.com/c/1346452Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#610393}
-
Esmael El-Moslimany authored
buttons wrap, show scroll Bug: 905991 Change-Id: I63668926091cb84a9ba11c2c4a8310f54883ccbf Reviewed-on: https://chromium-review.googlesource.com/c/1347200 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#610392}
-
Yutaka Hirano authored
IDL defined ReadableStream was not extendable because it didn't use provided |info.Holder()| as its wrapper. Instead, it creates a new wrapper in Create functions. This CL solves the issue by making the constructor "custom". The custom constructor creates a blink::ReadableStream first, then associates it to the wrapper, and then calls the appropriate Init function. Bug: 906476 Change-Id: I91a7fec1cf4ee5e08704a944b0af852584d1679e Reviewed-on: https://chromium-review.googlesource.com/c/1347643 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#610391}
-
Victor Costan authored
This CL should not introduce any behavior changes. Change-Id: Ia2555accf1b2b8ef48c52e79d915e69ba834e6e3 Reviewed-on: https://chromium-review.googlesource.com/c/1342860Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#610390}
-
Sergio Villar Senin authored
It was using the SigninManager API to check whether the primary account was authenticated and an authentication was in progress. We can use the IdentityManager and PrimaryAccountMutator APIs to perform the same operations. Bug: 890801 Change-Id: Ia2567a567481a4d67b68eee6b714aab72c537b5a Reviewed-on: https://chromium-review.googlesource.com/c/1346467Reviewed-by:
-
Jan Krcal authored
This CL makes it fully legal that bridges can call Delete() or UntrackEntityForStorageKey() of the processor for keys that are not in sync or are already deleted. This was the case even before but this CL removes misleading comments, unnecessary DLOGs and extends documentation in the interface. Bug: NONE Change-Id: I305c7301f35543908813ef6fa78b2d018222c594 Reviewed-on: https://chromium-review.googlesource.com/c/1347368Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#610388}
-
Vladislav Kuzkokov authored
Bug: 891174 Change-Id: I9418e996b6b9401f2c70403b2451c0fe40ab17ac Reviewed-on: https://chromium-review.googlesource.com/c/1343116 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#610387}
-
Sebastien Marchand authored
I'm making some changes to SystemMonitor in a separate CL that make it require that a TaskScheduler instance exists, and as some of these tests use SystemMonitor they need to be modified to use a ScopedTaskEnvironment. Change-Id: I900f8c999f8b16259299b6502145b11e348070ff Reviewed-on: https://chromium-review.googlesource.com/c/1346909Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#610386}
-
Mikel Astiz authored
They verify the very basic requirement of progress markers being peristed and loaded upon restart, which prevents clients to fetch all data from scratch from the server. This also surfaces a bug with USS bookmarks that should be addressed in a follow-up patch. Bug: 856696 Change-Id: I924249579f2d5790f25be6809b03f50d5c421ffc Reviewed-on: https://chromium-review.googlesource.com/c/1347366 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
SigninManager::Observer::GoogleSignedOut had two overload one taking a AccountInfo, and one taking two std::string. The latter is deprecated in favor of the former. As all overrides of the latter version are in components/signin or services/identity, convert them in one CL and remove the old method (that is now unused). Bug: none Change-Id: I1e65e9d182f7e48e75ed86f43647a57f65bf3d0e Reviewed-on: https://chromium-review.googlesource.com/c/1344094 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
The HTML spec requires SharedWorkerGlobalScope.name has [Replaceable]: https://html.spec.whatwg.org/multipage/workers.html#shared-workers-and-the-sharedworkerglobalscope-interface This CL also fixes a test expectation of wpt/workers/interfaces/SharedWorkerGlobalScope/name/setting.html. The name attribute is now replaceable, so the result should be replaced. Firefox fails the test because of this wrong expectation: https://wpt.fyi/results/workers/interfaces/SharedWorkerGlobalScope/name/setting.html?label=stable&aligned&q=%2Fname%2Fsetting.html Bug: 875714 Change-Id: Id04ae30895a2de4a07e30f49dc1189bb9742f6b9 Reviewed-on: https://chromium-review.googlesource.com/c/1347962Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#610383}
-
Stephane Zermatten authored
This change introduces support for interrupts. Interrupts can be run as part of wait_for_dom with allow_interrupts=true. Interrupts can also run manually, by clicking on a chip, but only if they have a name. Interrupts can run automatically if they have autostart=true. Autostart interrupts are handled differently from normal autostart, as they can happen at any time. Running an autostart interrupt does not prevent runnig a normal interrupt. I tried to keep changes to the main, non-interrupt, path and refactorings to a minimum in this change. The result puts all the complexity into the script executor. I'd like to get it to work, then find a good code split in a follow-up change. The code has resisted all my attempts at reorganization so far... Change to the main, non-interrupt path: - The responsibility for updating the script status is moved to ScriptExecutor, even though the script status map stays in ScriptTracker.This allows tracking script state changes caused by interrupts running. - The WaitForDom now uses the same wait code as ActionDelegate::WaitForElement instead of rolling up its own Limitations: - The payload from interrupts is never sent back to the server. This doesn't allow interrupts to change variables - If an interrupt fails, the failure of the main script is not reported to the server; from the server's point of view, the main script just never finishes. - There's no "prompt" action yet, so interrupts cannot ask questions. Bug: 806868 Change-Id: I12165965783ba479688c4c5b44ab72477ad4ae2b Reviewed-on: https://chromium-review.googlesource.com/c/1340309 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
I introduced skip_other_interceptors flag in crrev.com/c/1278433 to skip the service worker handling of the synthesized redirection of signed exchange. But this was wrong. We need to call ServiceWorkerProviderHost::SetDocumentUrl() and SetTopmostFrameUrl() even after SignedExchangeRequestHandler started handling the response to reject the service worker API calls from the page in the signed exchange correctly. And also we need to call SetControllerRegistration(null) to reset the controller state. Bug: 894755,907712 Change-Id: Iace762636982429c23ec24d9af6a466468e4b9fb Reviewed-on: https://chromium-review.googlesource.com/c/1347954Reviewed-by:
-
Kent Tamura authored
User-visible changes: - ElementInternals interface has |form| IDL attribute - form.elements and fieldset.elements contain form-associated custom elements Implementation: - ElementInternals inherits from ListedElement, which has logic and data for form-association. A form-associated custom element requires an ElementInternals instance regardless of calling HTMLElement.prototype.attachInternals(). ElementInternals is created on demand, and is stored in ElementRareData. - Hook CustomElementDefinition::Upgrade to handle form association and HTMLCollection invalidation. Bug: 905922 Bug: https://github.com/w3c/webcomponents/issues/187 Change-Id: Ic7828741c112c3c7339eee43b814d23ff706818b Reviewed-on: https://chromium-review.googlesource.com/c/1347950 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#610380}
-
Fredrik Söderquist authored
Per: https://drafts.fxtf.org/filter-effects/#InterfaceSVGFEBlendElement All other browsers expose these already. Bug: 906612 Change-Id: I4be6185d4832d980a5d7c6518dcb0b2ccca2ce82 Reviewed-on: https://chromium-review.googlesource.com/c/1341846Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#610379}
-
Friedrich Horschig authored
This CL ensures Infobars are listening to the keyboard when updating their visibility. Before this CL, they were only listening to layout changes (which is the indirect, less reliable way to achieve the same). Bug: 907062 Change-Id: Ide81fd0c1712b8f22f4de0b4e5a3f2a4203d90af Reviewed-on: https://chromium-review.googlesource.com/c/1346129 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#610378}
-
