- 21 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/662c01bba296..0a98cc54ea0d 2020-08-21 changhaohan@chromium.org Implements grouped Computed styles in the Computed tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1084673,chromium:1096230,chromium:1106251 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I69845514cd8b6a6e162d832f4cd10e4f6d3898c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369240Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800773}
-
Jenny Zhang authored
The simple lacros feedback report includes the following: 1. Lacros feedback reports are sent with ChromeOS product id, so that they will be found under ChromeOS product on Listnr. 2. Prefix the chrome version string with "Lacros ", so that lacros reports can be filtered by "Version" (for example "Lacros") on Listnr. 3. Attach lacros user log in the system log. Bug:1109387 TEST: 1. Open Lacros browser, send a feedback report by clicking "Report an issue" under Help menu. 2. Verify the report can be found at http://listnr site. The chrome version string should have a "Lacros " at the beginning, for example, "Lacros 86.0.4238.0". 3. Verify the report contains both system_logs.zip and histograms.zip. The system log should contain lacros log data from /home/chronos/user/lacros/lacros.log under "lacros_user_log" section. Change-Id: I98b381724866d163dc760147448a80e2249c0a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362977 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#800772}
-
adoneria authored
Bug: 1109373 Change-Id: I32b5295f0d6febf565543ec846d6456d622d2998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369675Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#800771}
-
Alexander Timin authored
Add OPTIONAL_TRACE_EVENT{0,1,2} macros. They are equivalent to regular TRACE_EVENTs, but they are disabled by default on the platforms where binary size is a significant factor. R=eseckler@chromium.org BUG=1043616 Change-Id: Ifb4265856826423c5079c5d412fc1234db19e820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359132 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:François Doray <fdoray@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#800770}
-
Zentaro Kavanagh authored
Used to track how frequently users are still using a shortcut planned for deprecation. Bug: 10840227 Change-Id: I59b94aa81d973595282ea9c7aebf79a9ad3c0e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364083 Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#800769}
-
Zarah Tesfai authored
Purpose: Move payment request UI logic of buildUI to PaymentUIsManager Change: * buildPaymentRequestUI() implemented in PaymentUIsManager * added PaymentUIsObserver interface * getShippingType() implemented in PaymentOptionsUtils Bug: 1112974 Change-Id: I7ce7e9193bdd3f368ee44bb7457a92275b340beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343155 Commit-Queue: Zarah Tesfai <ztesfai@google.com> Auto-Submit: Zarah Tesfai <ztesfai@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#800768}
-
Tommy Martino authored
This CL logs a successful cryptid rendering when the asset is successfully fetched and injected, and invokes writing the timestamp to the relevant pref. It also adds logging for failed asset fetches, and as a baseline logs instances where the conditions for rendering were not satisfied. I considered using a Histogram for this logging; however, I do intend to look at the action sequences following a successful render, so I thought a User Action was more appropriate. Bug: 1120348 Change-Id: Ib9a536aa928591a2105cdaaca4e054b2c2a01ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367642Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#800767}
-
James Hawkins authored
Bug: 1045266 Test: NetworkComponentsNetworkNameserversTest* Change-Id: I4d5de5f840c80aaf3ad5f57ec77db6ac6c94208a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369614 Commit-Queue: James Hawkins <jhawkins@chromium.org> Auto-Submit: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#800766}
-
Oksana Zhuravlova authored
This change moves throwing the exception if Router was not closed to the executor thread to make it crash instead of just logging. Bug: 1087098 Change-Id: I65c510bdbadedc3a0589807843c57e925c0351c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321345Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#800765}
-
chrome://settingsErik Chen authored
Lacros uses the chromeOS user-agent string but does not display ash-specific settings. Historically, webui relied on the user-agent to determine what platform the browser runs on. The combination of the two results in webUI settings trying to access ash-only private extension APIs, causing a crash. This CL updates the logic to explicitly check platform via gn args via grit, and plumbs through lacros as a new platform. This CL has one known problem: grit is not processed for js/cr.js for some webUI tests. This results on isLacros and isChromeOS returning the wrong values. This doesn't seem to affect any tests for now, but this is a problem that should be fixed. This is tracked in https://crbug.com/1118190. Bug: 1111985 Change-Id: I038a533ccbc5018cd125a49e70320a36b5aa4d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360816 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800764}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a2193f8a8b70..ea8d6a46aad5 2020-08-21 chonggu@google.com [Fuchsia] Add version and board type info to Fuchsia If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1084367 Tbr: zhanliang@google.com Change-Id: Ib21f66b7c7214391a44ee4a4c06e2f3bc7253af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369635Reviewed-by:
-
edchin authored
This CL: - Moves the snapshots storage into the BrowserState folder with the following path template: [BrowserState folder]/Sessions/[SceneSession ID]/Snapshots/ - Adds folder migration to the startup task. Migration is only performed once and the old snapshots folder is deleted. Change-Id: Ic5bf2fa0cd088e466084d72d408484ff949da17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354838 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#800762}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8bd6c9830dd4..13c4dbe2ef24 2020-08-21 fmalita@chromium.org [skottie] Add support for baseline shift If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I03f6b4d65e90977d343e8af2fa3ce85945ae073f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368115Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/aba65a8e1ce1..622558b02e1a 2020-08-21 srisser@google.com Revert "Add getPhysicalDeviceFeatures2" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I885fff5c383bcc598f280cee0960089c10b5443d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369416Reviewed-by:
-
Tom Anderson authored
BUG=1066670 Change-Id: I324c66b3848c4ef6dd40326ae08270c8f14c9eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354916 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#800759}
-
Yicheng Li authored
Cryptohome already supports starting/ending fingerprint auth session (i.e. preparing biometrics daemon for upcoming fingerprint scan / back to normal mode). This change enables ExtendedAuthenticator to start fingerprint auth session so that ExtendedAuthenticator can be used to do fingerprint auth. The reason why fingerprint auth needs starting/ending auth session is because it is expensive to switch mode of the fingerprint MCU. The client should only end fingerprint auth session when no more fingerprint retries are expected. The reason why we are doing this by calling cryptohome, instead of calling biometrics daemon, is that we want cryptohome to control all authentication mechanisms, and there's a generalized "auth session" project in cryptohome. Bug: b:156258540, b:144861739 Change-Id: I767b2aff9791c838674d8ace8ab8d4494f69e603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364894 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800758}
-
Josh Nohle authored
Fix heap-use-after-free error in Nearby Share unit tests caused by not reseting the testing factories after a unit test finishes. Also, reorder member variables in certificate manager unit tests in rough order of creation time. Change-Id: I9c17f467f388716b8f83fb59dceb47d80282da41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369498 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#800757}
-
Ana SollanoKim authored
The fieldset layout algorithm was able to handle breaks inside borders and padding, but since this is no longer supported, some code had to be removed. This change addresses the TODO that was proposed in https://chromium-review.googlesource.com/c/chromium/src/+/2263353 In a previous change where we had made the legends monolithic https://chromium-review.googlesource.com/c/chromium/src/+/2353354 additional TODOs were added as a result of the following open issue crbug.com/1097012. In this change, a missing TODO was added and comments have been updated. Bug: 1097012 Change-Id: I2087957b98681904606a4d6d780094c24a8e7ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367698 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#800756}
-
Sinan Sahin authored
Bug: 1120707 Change-Id: Ifd791aef0358e6a41d4ec58e2cf9d9fa214fa850 Tbr: peconn Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368320Reviewed-by:
Sinan Sahin <sinansahin@google.com> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#800755}
-
William Lin authored
Skipping the account chooser will require the GetAuthToken function to retrieve the gaia id of the account currently in use. Storing the CoreAccountInfo will allow the function to always be able to retrieve the gaia id for comparison in the scenario that CoreAccountId is an email. This CL replaces the CoreAccountId with CoreAccountInfo in the ExtensionTokenKey. Additionally, relevant locations of the existing code have been modified to use the CoreAccountId stored in CoreAccountInfo to account for this replacement. Bug: 1100535 Change-Id: Ie72f437aecdbfe6b98a1c5cf0caae3501f42baa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366033Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: William Lin <williamlin@google.com> Cr-Commit-Position: refs/heads/master@{#800754}
-
Xiaodan Zhu authored
Bug: 1116178 Change-Id: I86a0ee351e2202267b6c66e5c0689c223b1eba87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368042Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800753}
-
Sophie Chang authored
This was potentially falling back to hint still being fetched if URL hint hadn't arrived yet Bug: 1112500 Change-Id: I0307f41f1b49a6901eef48b522dfefe0546f6139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369264Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#800752}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib90ddfee2c684b099ba3279051ce414f6559a3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368116Reviewed-by:
-
Leonid Baraz authored
Fake-* is removed, as well as virtual interface: we are using openssl and AEAD directly. Also, decryption is moved out from Chrome, since for now we only use it in test. Once we add it to the server, it will be placed elsewhere and probably wrapped in Java class. Bug: b:153649905 Change-Id: Ib6383efa8f6b1e993e351e03f2f747043c6cb521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363868 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#800750}
-
Chris Lu authored
Adds LogUserInteractionWithFullscreenPromo and HasUserInteractedWithFullscreenPromoBefore to be able to set and get the NSUserDefault config to keep track of user interaction history with the fullscreen default browser promo. Adds calls to LogUserInteractionWithFullscreenPromo. Bug: 1107489 Change-Id: I5d73e6e93d8dd20682e65dfe9eb68ef10ca63632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363660 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#800749}
-
Kyle Horimoto authored
This class exposes Instant Tethering functionality to the Phone Hub UI. For now, TetherControllerImpl does not actually do anything, but landing it in its current state unblocks UI code from depending on it. Bug: 1106937 Change-Id: I70ee9dd2d241e9784fac04ba227477435f407473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369656 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800748}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I299f547d8b1430ff3237e3e8c306cf715a6acb72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369574Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800747}
-
Mike Wasserman authored
Fullscreen is exited when a related frame opens a popup window. See security-based motivations for that behavior in these issues: crbug.com/1042210 crbug.com/1020026 crbug.com/1037730 crbug.com/752003 Window Placement experimentally permits multi-screen window features: See https://github.com/webscreens/window-placement Sites want to open a popup on Screen X while fullscreen on Screen Y. Allow user-permitted sites to open a popup and retain fullscreen. Followup work must prevent interference with fullscreen security UI. (e.g. exit related-frame fullscreen if a popup targets that display) See crbug.com/1120746 for details and work-item tracking. Do not default-allow window-placement in content_browsertests. (that misrepresents the default capabilities of sites in tests) Disable getScreens content_browsertests for now (crbug.com/1119974): - They need per-test-fixture permission controls - WPT test coverage is adequate in the mean time Bug: 1040297, 1119974 Change-Id: Ib2a40e87f7b92fa36d7745ffec41090837bcfea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366088Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#800746}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bce19cd0eefc..fbb49b4f7f86 2020-08-21 ilnik@webrtc.org Enable Vp8VariableFramerateScreenshare by default If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:949112 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie1851db87ce87c1557d45db5510026f9522f6fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369417Reviewed-by:
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkIpConfigTest* Change-Id: Ie94e86efab513c315fff2edf1da9b29b27de19e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368468 Auto-Submit: James Hawkins <jhawkins@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6733ced7..1ca34252 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If83ddde54e5b06ba7884e0d72d1ce706b0eeb75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369005Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800743}
-
Mustafa Emre Acer authored
This CL expands the PhishGuard ping proto and adds a new field to LoginReputationClientRequest containing information about the Delayed Warnings experiment and Simplified URL Display experiments. Note that the presubmit gives a reminder to update chrome/common/extensions/api/safe_browsing_private.idl. Since this isn't an API change, this CL doesn't modify this file. Bug: 1114922 Change-Id: I118c74c2b7ef2b0bd1ea18c091575540cc464dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347975 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#800742}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a0cf0214eefa..6821f818e6f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,nektar@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1115220,chromium:1116650,chromium:1117663 Tbr: xhwang@google.com,nektar@google.com Change-Id: I51bc0b4d22b336ccc222ea8b8b410ce190618cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369553Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800741}
-
Tiancong Wang authored
This patches removes old hugepage mechanism that works without orderfiles. So now, enabling orderfile == enabling THP. Bug: 1100803 Test: Build chrome os locally Change-Id: Ib4ff215b10ccc4c3c51347357a0cba7f51ec6793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369335 Commit-Queue: Tiancong Wang <tcwang@google.com> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#800740}
-
Jeff Yoon authored
ios-simulator-noncq to compile with xc12b5 as well. Running iOS 14.0 simulators for our test suites on xc12b5. Change-Id: I7ca5f763174c296278401ae3563894a4f5210379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367792 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
-
Jun Kokatsu authored
This change enables Trusted Types mitigation on WebUI by default. It enforces use of safe API by default, and any use of unsafe API (e.g. innerHTML, document.write, etc) has to overwrite Trusted Types directives in the CSP header. Therefore this change makes security review or audit of JavaScript code on WebUI a lot easier. Because JavaScript could introduce XSS only by using `trustedTypes.createPolicy` to generate untrusted html or script as Trusted Types, or removing Trusted Types mitigation. And all of those has to be carefully reviewed going forward. Bug: 41905 Change-Id: Iba7b8f617bc00c27b22386e2f632402209c47549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353547Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
-
Hung Vu authored
This CL adds the flag for handling smart suggestion for large downloads Bug: 1118207 Change-Id: I695757bef4119d97fc594d08945406a14a36723c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368154 Commit-Queue: Hung Vu <vuhung@google.com> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800737}
-
Richard Knoll authored
Obfuscation is needed as the text is shown as a preview on the remote device before accepting the transfer. Bug: 1085067 Change-Id: I100d369685c5aec2b7bcb97058df68f6c94c4c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368594 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#800736}
-
Victor Costan authored
When Chrome receives a 304 for a resource stored in AppCache, we do not update the cache's headers with the 304 headers. We had a fix for this issue under development, gated by a feature flag. While the fix was very close to the finish line, AppCache's deprecation and removal means we can't justify finishing the fix. This CL removes the feature flag and the code gated by it. This is intended to make it easier to maintain our AppCache implementation until we're ready to delete it from the tree. This CL should not cause any behavior changes for Chrome instances without manually modified feature flags. Bug: 989611 Change-Id: I9f0c98fbbc59dab527db8159eb6f691398480c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360556Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#800735}
-
chromium-internal-autoroll authored
Release_Notes:http://go/media_app-x20/relnotes/Nightly/media_app_202008210800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/nPjEGC7iC_JZPS-2t6OXpyqtoD_uxii0UigGyO6p6ToC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/158654343,b/165394926,b/165748389,b/165878563 Tbr: media-app@grotations.appspotmail.com Change-Id: If707950d26252fa151c73089f6efdbc1dc5893c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369167Reviewed-by:
-
