- 17 Oct, 2018 40 commits
-
-
Alexander Hendrich authored
This CL handles the scenario of DMServer reporting a 410 status code (missing/unknown/purged client ID) by trying background re-registration. If this fails, the user is marked as requiring an online sign-in. DD: go/handle-purged-user-sessions Bug: 870616 Change-Id: I4a4c2370c36f5464752029d755d23221cd064b0e Reviewed-on: https://chromium-review.googlesource.com/c/1227939 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#600359}
-
Pin-chih Lin authored
InitializeDeprecated should be removed after ToT of ARC-P and ARC-N have upreved to use new Initialize API. BUG=867799 TEST=build and deploy chrome on Grunt Change-Id: I6d2215b9fe735fbb4e1dd4aa179a55187ec908db Reviewed-on: https://chromium-review.googlesource.com/c/1282518Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Pin-chih Lin <johnylin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600358}
-
Sam McNally authored
DriveIntegrationService calls Unmount in its implementation of DriveFsHost::MountObserver::OnMountFailed(). DriveFsHost isn't prepared for this re-entrancy, causing a use-after-free. Unmount first to avoid this problem. Bug: 891197 Change-Id: I61056193847dfdd1dc1ca4c91ccdc80566815744 Reviewed-on: https://chromium-review.googlesource.com/c/1286105Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#600357}
-
Colin Blundell authored
This CL augments IdentityTestEnvironmentProfileAdaptor with a static method that creates and returns a TestingProfile that is configured with the factories that IdentityTestEnvironment requires. This API can be used to convert unittests that use TestingProfile::Builder. It is preferable to use this API if possible rather than the lower-level AppendIdentityTestEnvironmentFactories() as this API is less fragile. That API is still required for tests that do not create the TestingProfile internally but simply supply the list of TestingFactories to configure it (e.g., to some common superclass). This CL converts one unittest as an example and validation. Bug: 882865 Change-Id: Ia7cfa648e0086385f4d1506ca4afda80866240b2 Reviewed-on: https://chromium-review.googlesource.com/c/1280764 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#600356}
-
David Turner authored
This reverts commit da688ad0. Reason for revert: test is flaky. See bug for details. BUG=896198 Original change's description: > [Feed] Add FeedNewTabPageTest#testClickSuggestion > > + Add test on Feed NTP to simulate click on a test card > > Bug: 860055 > Change-Id: Ibf8f4b1ab46ed34dc77346dd19680df876c2d6aa > Reviewed-on: https://chromium-review.googlesource.com/c/1260485 > Commit-Queue: Becky Zhou <huayinz@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600166} TBR=twellington@chromium.org,huayinz@chromium.org Change-Id: I4db05a0448e12ef2c09d296dc9411dd0c83496a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860055 Reviewed-on: https://chromium-review.googlesource.com/c/1286650Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#600355}
-
Guido Urdaneta authored
This CL: - Removes the restriction of frame rates to no less than 1Hz. This limit is a remnant from the old constraints processing algorithm. There is no reason to keep this restriction, especially because applyConstraints did not have any lower limit. - Use a new minimum frame rate of numeric_limits<float>::min(), equivalent to allowing any positive value and enforce it in both getUserMedia() and applyConstraints(). Prior to this, applyConstraints allowed zero and ideal negative values. Zero was interpreted by VideoTrackAdapter to mean the native frame rate of the source, and negative values caused a renderer crash due to a CHECK in VideoTrackAdapter. This CL also serves as preparation for support for the frameRate constrainable property. Bug: 814131,854980 Change-Id: I7f45fe2862f636100d408a136fe5038fe0994afb Reviewed-on: https://chromium-review.googlesource.com/c/1276506Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#600354}
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/71e256c..847fc0b BUG=chromium:881334 TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I04a81f1daaa962a3a2510d76784dcb3e0f704e17 Reviewed-on: https://chromium-review.googlesource.com/c/1285480 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#600353}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7740403f4852..4e423c45bcbb Created with: gclient setdep -r src-internal@4e423c45bcbb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie6eeb576a9c5cd85daf93ccd2c84da732fb24502 Reviewed-on: https://chromium-review.googlesource.com/c/1286291Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600352}
-
Christos Froussios authored
This reverts commit 530a1ad5. Reason for revert: Suspected for breaking http/.../slow-loading-image-in-pattern.html on Mac bots Bug: 896205 Original change's description: > Stop using color space xform canvas in Skia's picture backed images > > Change-Id: Ia77210022ac412d00be1fc2f8831eb973e07de62 > Reviewed-on: https://chromium-review.googlesource.com/c/1280786 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Brian Osman <brianosman@google.com> > Cr-Commit-Position: refs/heads/master@{#599979} TBR=fmalita@chromium.org,brianosman@google.com,mtklein@chromium.org Change-Id: I5d1b47b5d15aae0a02058e5b046df32c0a59a00f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1286465Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#600351}
-
Colin Blundell authored
Currently IdentityTestEnvironment only works if it can internally construct the IdentityManager instance that it uses. This is definitely the cleanest mode of operation (and long-term the only targeted one) However, it prevents IdentityTestEnvironment's usage in //chrome-level unittests wherein the IdentityManager instance that the test interacts with must the one constructed via the Profile (i.e., because the production code being tested obtains IdentityManager from the Profile). This CL adds support for using IdentityTestEnvironment in this context. Specifically, it adds a new IdentityTestEnvironment constructor that takes in an IdentityManager instance as well as its dependencies and a //chrome-level adaptor that configures Profile to build the necessary fakes and wraps an IdentityTestEnvironment instance using this new constructor. Bug: 882865 Change-Id: If45f29643fc5a2cacf357ac159c709b068443e9c Reviewed-on: https://chromium-review.googlesource.com/c/1280264 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Jonas Olsson authored
This is part of the onion soup efforts. Bug: chromium:787254 Change-Id: Ic813f3da59aa4621e89fc0802fa779165c4a67d8 Reviewed-on: https://chromium-review.googlesource.com/c/1276565 Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/28b6d1d238b8..dbb47b8f7685 git log 28b6d1d238b8..dbb47b8f7685 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d06a979d..c5242283 (600199:600305) 2018-10-17 steveanton@webrtc.org Reland: Modernize rtc::SSLCertificate Created with: gclient setdep -r src/third_party/webrtc@dbb47b8f7685 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic299769db23cc5fb07d57d042554003d9b4517e8 Reviewed-on: https://chromium-review.googlesource.com/c/1286471Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600348}
-
Koji Ishii authored
Text failures that appear in build 10762 were due to the change in the base expectations, but LayoutNG has a separate set of expectations for the space differences. This patch rebaselines them. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic1a0f4b0feb71d91b299225a1aa61d4f961c43ea Reviewed-on: https://chromium-review.googlesource.com/c/1286026 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#600347}
-
Arthur Sonzogni authored
Current state: ============== After a cross-process navigation, content/ swaps the old and the new RenderFrameHost. The old RenderFrameHost goes into pending deletion. Its subframe are immediately deleted. So after a RenderFrameHost swap, WebNavigationAPI stops tracking: * the navigating frame in RenderFrameHostChanged(). * its subframe in FrameDeleted() Future: ====== In a near future, the subframe of |old_host| will go into pending deletion as well. As a result, FrameDeleted() will not be immediately called. See: https://chromium-review.googlesource.com/1122629 What this CL does: ================== Stop tracking the subframes of |old_host| when it goes into pending deletion. Bug: 609963 Change-Id: Ifba038af87a74f3b8e68794b62d3d44055efecad Reviewed-on: https://chromium-review.googlesource.com/c/1278170 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#600346}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f0988af921fb..91f54792a979 git log f0988af921fb..91f54792a979 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 hjd@google.com Merge "perfetto-ui: Fix permalinks" Created with: gclient setdep -r src/third_party/perfetto@91f54792a979 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I6d648b7aae912523d3a6de242a0d7fcaadf05301 Reviewed-on: https://chromium-review.googlesource.com/c/1286472Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 10748 10756 10762 2 lines were removed and 1 lines were deflaked by consecutive results since 10686. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I38f37274c9c777dbec7c11190175121ecda19f7c Reviewed-on: https://chromium-review.googlesource.com/c/1286229 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Sam Zackrisson authored
Bug: webrtc::9535 Change-Id: I5511b6eda21b86028c722b93192f5bcda19e2314 Reviewed-on: https://chromium-review.googlesource.com/c/1286449Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#600343}
-
Javier Fernandez authored
The MoveParagraph function doesn't guarantee the paragraph's style is preserved when the insertOrderedList/insertOnordered list commands are used. Instead, we should use MoveParagraphWithClones. This change implies rebaseline a few tests, since the result tree is different than the one created with MoveParagraph. Bug: 149901 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I01e5a9ade28d3c16e8dc5423bf16dcf0d7e60976 Reviewed-on: https://chromium-review.googlesource.com/c/1216282 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600342}
-
Scott Wu authored
Bug: 865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0a7d78359724a4e4cdca350145b55b65e5d4f184 Reviewed-on: https://chromium-review.googlesource.com/c/1250503 Commit-Queue: Scott Wu <scottwu@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#600341}
-
Rune Lillesveen authored
Bug: 895894 Change-Id: I6111fc26cb21ddc3a6db5702cb382fce1e623632 Reviewed-on: https://chromium-review.googlesource.com/c/1286413 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#600340}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a8faf3f557d..483536c242f3 git log 0a8faf3f557d..483536c242f3 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d633b1569a21..1d8a783c9db2 (2 commits) 2018-10-17 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-10-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@483536c242f3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: Ib0d7f210d7f9a9f1f4e776bc9ef0e56e61cc56c9 Reviewed-on: https://chromium-review.googlesource.com/c/1286290Reviewed-by:
-
Hazem Ashmawy authored
loadUrl(String) has an early return if url == null, this is just adding the same early return to loadUrl(String, Map<String,String>). This should prevent sending null values to AwContents::SetExtraHeadersForUrl and then to ConvertJavaStringToUTF8. Bug: 864708 Change-Id: If169dbc89dfdf745e7fa27921fa7624abed40a84 Reviewed-on: https://chromium-review.googlesource.com/c/1283449Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#600338}
-
Matt Falkenhagen authored
Bug: 715640, 846235 Change-Id: I49ed8a5a3bc5962cd52e24ab734b00fdfdd7b32d Reviewed-on: https://chromium-review.googlesource.com/c/1286238 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#600337}
-
Matt Falkenhagen authored
This fixes ServiceWorkerRequestHandlerTest.InitializeForNavigation_ExternalFileScheme when ServiceWorkerServicification or NetworkService is enabled. It's the same fix as the non-servicification path, done in r528590. Bug: 895187,896157 Change-Id: I8949c0bf002b329a01b1755913d16634dd80e7cd Reviewed-on: https://chromium-review.googlesource.com/c/1286021Reviewed-by:
-
Jan Wilken Doerrie authored
This change makes use of the updated semantics of PasswordUiEntry.id to simplify the update list behavior of passwords_section.js. Bug: 892260 Change-Id: Icfde6048049edd6e418580660b34928db798764d Reviewed-on: https://chromium-review.googlesource.com/c/1283013 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#600335}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/gcm. This CL was uploaded by git cl split. R=jianli@chromium.org Bug: 809610 Change-Id: I2467157d104d74299ab12f1ced3bbe0245a48b68 Reviewed-on: https://chromium-review.googlesource.com/c/1258905Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600334}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/safe_browsing. This CL was uploaded by git cl split. R=nparker@chromium.org Bug: 809610 Change-Id: I95c33ffc6a6d7699e0c1813ea7f760b7a9654d83 Reviewed-on: https://chromium-review.googlesource.com/c/1259043 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#600333}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/chrome_content_browser_client_unittest.cc. This CL was uploaded by git cl split. R=<anyone> Bug: 809610 Change-Id: I845dacbc5ee28e89ab69bf2bebaf5700f931b6fb Reviewed-on: https://chromium-review.googlesource.com/c/1258170Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600332}
-
A Olsen authored
Get rid of CrosSettings::Get()->Set...() usage in tests. This CL changes all such calls to ScopedCrosSettingsTestHelper::Set. This call does the same thing as before, but it means there is only one call to CrosSettings->Set that will need to be changed in order to separate the read and write APIs. This is part of an ancient bug to make CrosSettings read-only - the equivalent API for writing is OwnerSettingsService. It will also be useful for moving CrosSettings out of chrome/browser without having to move all of OwnerSettingsService. Another minor clean up: There are two different ways to have a test setup CrosSettings - one way is to use ScopedCrosSettingsTestHelper, which sets up InstallAttributes, DeviceSettings, and CrosSettings. The other way to set them all up using individual helper classes, including ScopedDeviceSettingsTestHelper. What is not obvious, is that the first way sets up a real session manager, but the second way sets up a fake session manager. This CL also changes existing_user_controller_auto_login_unittest.cc to use the first way for consistency, and adds the call "SetFakeSessionManager()" which is more explicit, instead of having different helper classes set things up in subtly different ways. BUG=433840 Change-Id: I0c84af93d446ce8f82d1aabbf070195abea24dd4 Reviewed-on: https://chromium-review.googlesource.com/c/1256966 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#600331}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c4d25f5b. With Chromium commits locally applied on WPT: 612705b6 "Only update intrinsic_content_logical_height_ if we don't have an override height" a7da8836 "Convert 'Sec-Metadata' dictionary values to identifiers." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26351 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Iffc5c7ee944e2e1dbbbd35af91033dfd9816c564 Reviewed-on: https://chromium-review.googlesource.com/c/1286430 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#600330}
-
Sergio Villar Senin authored
It's currently using the SigninManager API to retrieve the currently authenticated account's email. Replaced by the IdentityManager equivalent API so it could eventually use the identity service. Bug: 890777 Change-Id: Ib2b8b46f529424dd413d843fb89deb5a493a599c Reviewed-on: https://chromium-review.googlesource.com/c/1280426Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#600329}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//extensions/browser/api/idle. This CL was uploaded by git cl split. R=dcheng@chromium.org Bug: 809610 Change-Id: I6799d0c1c8e61ccfa4fb5c07155deb4258a22e85 Reviewed-on: https://chromium-review.googlesource.com/c/1259045Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600328}
-
Christos Froussios authored
This reverts commit b9f37385. Reason for revert: Suspected of breaking performance_test_suite on Win7 Tests (dbg) Bug: 896178 Original change's description: > [Perf] Delete dummy_benchmark.histogram_benchmark_1 > > No longer needed. > > Change-Id: I48e7073aba7861d7265337996c3ce6146d972f50 > Reviewed-on: https://chromium-review.googlesource.com/c/1282220 > Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#600169} TBR=eakuefner@chromium.org,nednguyen@google.com Change-Id: I0358e9aaf36257b7a6f43d900361d75d04b95c21 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1286457Reviewed-by:
-
Andy Paicu authored
Bug: 174301 Change-Id: Ifc0618729a545d6b45ccfc9c339b656e065efa22 Reviewed-on: https://chromium-review.googlesource.com/c/1282951 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#600326}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/ash/multi_user. This CL was uploaded by git cl split. R=skuhne@chromium.org Bug: 809610 Change-Id: Iee592c3978d52e0f213f2cb752cd4317bcd65b21 Reviewed-on: https://chromium-review.googlesource.com/c/1258764 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600325}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/networking_private/networking_private_apitest.cc. This CL was uploaded by git cl split. R=tbarzic@chromium.org Bug: 809610 Change-Id: Id109a7d2bf008951e3a1ad9bf6370a281523c515 Reviewed-on: https://chromium-review.googlesource.com/c/1258354Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600324}
-
Trent Apted authored
Analytics is disabled in these CrOS apps, and isn't going to be re-enabled. Generally, "metrics.js" is analytics. Restrict dependencies on it to the files app only. "metrics_base.js" is UMA and is fine to depend on, but it needs an attached file that provides a UMA prefix. Add missing methods, which were incorrectly using the files app UMA config. Remove metrics.js AND metrics_base from the shared, background_common_scripts.js. audio_player doesn't use metrics_base (UMA) and doesn't declare the API permission in its manifest. Audit things still in background_common_scripts.js to ensure they don't use analytics/metrics. There's just one: volumeManagerUtil.reportMountError. Delete it. Note the file_manager/foreground/js/directory_model.js still uses getFileSystemProviderName from metrics_events.js. Other notes: - Remove the single analytics call in image_loader - Remove metricsPrivate from the image_loader extension manifest (only the image_loader_client depends on this, which is loaded into other component apps - not the image loader) - Remove unused dependencies from manifest files. - Bump manifest versions to update cached extension permissions. Bug: 847729 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ifb5d306b38ba8bc0759ac56080855abe78f09b88 Reviewed-on: https://chromium-review.googlesource.com/c/1280064 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#600323}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/63bc5891e49e..0a8faf3f557d git log 63bc5891e49e..0a8faf3f557d --date=short --no-merges --format='%ad %ae %s' 2018-10-17 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@0a8faf3f557d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I4aee0232ba23f6e9430b5056e5d7d395085c79e9 Reviewed-on: https://chromium-review.googlesource.com/c/1286070Reviewed-by:
-
Hiroki Nakagawa authored
Off-the-main-thread WebSocket was enabled by default in M68, so this flag is no longer necessary. Bug: 825740 Change-Id: I87615e7c7687f92252914221b077ea5cadd7ddec Reviewed-on: https://chromium-review.googlesource.com/c/1286095Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#600321}
-
Michael Lippautz authored
Bug: 843903 Change-Id: Ia1b60e3a4ee2aa239e3fad7bea198c38484b2840 Reviewed-on: https://chromium-review.googlesource.com/c/1282953Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#600320}
-
