GitLab

Revert of Improve performance of Character::isCJKIdeographOrSymbol by using trie tree (patchset #24 id:460001 of https://codereview.chromium.org/1541393003/ )

Reason for revert:
GN asan and tsan are broken, wasn't aware bots are running GYP only. Reverting until we can figure out what to do with GN asan/tsan and probably msan.

Original issue's description:
> Improve performance of Character::isCJKIdeographOrSymbol by using trie tree
>
> This patch is another effort to make Character::isCJKIdeographOrSymbol
> faster.
>
> The previous CL[1] made it faster by ~90% for codepoints below U+2020,
> but codepoints abvoe U+2020 were not as fast. This CL makes all
> codepoints faster, as fast as ICU functions.
>
>       Before  After Improve ICU
> All    2569 => 292    88%   298
> ASCII    68 =>  68     0%   160
> Han    2958 => 263    91%   344
> Hira    258 =>  11    95%    14
> Arabic   37 =>  32    13%    44
> * # of code points and iterations vary by rows.
>
> The previous CL[1] clarified that binary search is not as fast as ICU
> functions such as uscript_getScript(). This patch changes to use
> UTrie2, which is the data structure ICU property functions use.
>
> In addition in this patch:
> * U+2763 and U+2764 are added as requested by drott@.
> * Character::isUprightInMixedVertical() was switched to UTrie2 too.
> * Character::isCJKIdeograph() was removed because it is no longer used.
>
> [1] https://codereview.chromium.org/1545073002
>
> BUG=571943
>
> Committed: https://crrev.com/e6dc3f425137021f39eddbbeb2035273ce36f986
> Cr-Commit-Position: refs/heads/master@{#371917}

TBR=eae@chromium.org,drott@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=571943

Review URL: https://codereview.chromium.org/1644893002

Cr-Commit-Position: refs/heads/master@{#372004}

Review URL: https://codereview.chromium.org/1647493003

Cr-Commit-Position: refs/heads/master@{#372003}

Cr-Commit-Position: refs/heads/master@{#372002}

This CL changes the Downloads settings to more closely match
the mocks.  An option to disconnect Google Drive account has
been added for chromeos.

BUG=546847

Review URL: https://codereview.chromium.org/1632403003

Cr-Commit-Position: refs/heads/master@{#372001}

https://codereview.chromium.org/1421423005 caused this regression. We never
handled aspect ratio correctly in flexbox (that's bug 249112), but that patch
made our handling worse because we now distort and enlarge images when
a cross axis size is specified that's bigger than the image's intrinsic size.

This was tested by
imported/csswg-test/css-flexbox-1/flex-minimum-height-flex-items-008.xht which
we now pass. I didn't realize the significance of failing that test at the time :(

BUG=581361,581535
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1639723003

Cr-Commit-Position: refs/heads/master@{#372000}

https://chromium.googlesource.com/skia.git/+log/1c971faab7b2..62358e77c2b8

$ git log 1c971faab..62358e77c --date=short --no-merges --format='%ad %ae %s'
2016-01-27 mtklein SkPngFilters: guard with libpng >= 1.5.7

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1647823002

Cr-Commit-Position: refs/heads/master@{#371999}

When EGL_ANGLE_keyed_mutex is available, DXVAVideoDecodeAccelerator will create the picture buffer with D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX and use that instead of a fence to synchronize between the decoder context and GPU context. This has saved up to 0.2W in my testing (out of 5W), though the number is not entirely consistent.

Chrome will create the texture itself and share it into ANGLE (rather than vice versa) so it can choose whether or not to use a keyed mutex. This helps in particular with D3D9Ex, which is incompatible with keyed mutexes.

EGL_ANGLE_keyed_mutex is not yet enabled in ANGLE for chrome, so this won't do anything yet.

BUG=337606

Review URL: https://codereview.chromium.org/1553603002

Cr-Commit-Position: refs/heads/master@{#371998}

FileSelectHelper subjects suggested filenames to the safe browsing
white/black lists prior to showing the file picker. However, if the list
of accepted file types passed in to the file picker is not empty, and
the suggested filename doesn't match the accepted file types, the file
picker may append an accpeted file extension to the suggested filename.

In order to prevent this from being abused, this CL causes
FileSelectHelper to also verify that the list of accepted file types is
also safe.

R=sky,nparker,bbudge,holte
BUG=575849

Review URL: https://codereview.chromium.org/1613483003

Cr-Commit-Position: refs/heads/master@{#371997}

The WI.SASSWorkspaceAdapter sits atop workspaces and CSSModel and provides
a consise and sufficient API for SASS processor operations.

Methods of WI.SASSWorkspaceAdapter:
- trackSources(sourceMap): WI.SASSWorkspaceAdapter.Client

Methods of The WI.SASSWorkspaceAdapter.Client:
- content(url): Promise<string>
- setCSSText(text, cssEdits): boolean
- setSASSText(url, text): boolean
- isOutdated(): boolean - wheather any sourceMap source has changed
    since last content inquiry.
- dispose()

Events of WI.SASSWorkspaceAdapter.Client:
- SourceChanged(url) - whenever any source of source map gets changed
- TrackingStopped() - whenever the client gets disposed

BUG=527993
R=dgozman

Review URL: https://codereview.chromium.org/1641893002

Cr-Commit-Position: refs/heads/master@{#371996}

BUG=580514

Review URL: https://codereview.chromium.org/1640273004

Cr-Commit-Position: refs/heads/master@{#371995}

Regression:[Devtools]Unable to close 'This script is blackboxed..' warning message without closing 'pretty print' infobar.

BUG=581606

Review URL: https://codereview.chromium.org/1641573005

Cr-Commit-Position: refs/heads/master@{#371994}

BUG=546731
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1536553002

Cr-Commit-Position: refs/heads/master@{#371993}

We used to incorrectly allow content settings to be persisted in the guest
profile. This CL prevents them from being persisted and ensures that any
existing settings are deleted.

BUG=578130
TBR=asanka@chromium.org,bzanotti@chromium.org,droger@chromium.org

Review URL: https://codereview.chromium.org/1605453003

Cr-Commit-Position: refs/heads/master@{#371992}

As is, the bots cannot finish running the tests in time.

BUG=581583

Review URL: https://codereview.chromium.org/1647713003

Cr-Commit-Position: refs/heads/master@{#371991}

The location bar, omnibox, and find in page bar should look the same in
incognito and normal windows if we're using a custom theme. Since
changing to or from a custom theme can now affect the window's decision
of which NativeTheme to use, we have to make GetNativeTheme()
overrideable as well as propagate NativeTheme changes when the browser
theme changes.

BUG=581559
depends on http://crrev.com/1638063003#ps1

Review URL: https://codereview.chromium.org/1637203002

Cr-Commit-Position: refs/heads/master@{#371990}

BUG=581793
TEST=Extended GaiaAuthFetcherTest passes
TEST=Tested together https://codereview.chromium.org/1618193003/.
     Auth code is returned for GMS Core client id and is consumed
     at Android.

Review URL: https://codereview.chromium.org/1644713002

Cr-Commit-Position: refs/heads/master@{#371989}

BUG=

Review URL: https://codereview.chromium.org/1645823002

Cr-Commit-Position: refs/heads/master@{#371988}

This CL waits until the web page has loaded before
adding the startup pages handler as an observer
of the startup pages preferences.

BUG=581503

Review URL: https://codereview.chromium.org/1634353002

Cr-Commit-Position: refs/heads/master@{#371987}

These bots won't exist temporarily as "NextGen" builders. They also
won't use swarming.

Remove the "swarming" dictionary from tab_capture_end2end_tests on the
non-swarmed testers on this waterfall.

BUG=542370
NOTRY=true

Review URL: https://codereview.chromium.org/1646793002

Cr-Commit-Position: refs/heads/master@{#371986}

Turns out gitiles doesn't support markdown tables. Changed to just be
pre-formated code block.

Horizontal rules aren't supported either, but aren't needed as there
is ample spacing.

R=ortuno@chromium.org

Review URL: https://codereview.chromium.org/1644453003

Cr-Commit-Position: refs/heads/master@{#371985}

Should work now that https://codereview.chromium.org/1642553003/ is in.

BUG=580129

Review URL: https://codereview.chromium.org/1639333003

Cr-Commit-Position: refs/heads/master@{#371984}

BUG=525873

Review URL: https://codereview.chromium.org/1631153002

Cr-Commit-Position: refs/heads/master@{#371983}

BUG=341082
R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/1648513002

Cr-Commit-Position: refs/heads/master@{#371982}

Requested by Benjamin Vaughn of United Airlines via email.

BUG=
TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/1640123003

Cr-Commit-Position: refs/heads/master@{#371981}

Previously FakePortAllocator didn't keep reference to TransportContext
which was causing it to be destructed prematurely and crashing
remoting_perftests.

Review URL: https://codereview.chromium.org/1644593003

Cr-Commit-Position: refs/heads/master@{#371980}

Improve InspectorTest.TestFileSystem to support Entry.remove method.

BUG=None
R=pfeldman

Review URL: https://codereview.chromium.org/1641063002

Cr-Commit-Position: refs/heads/master@{#371979}

Add BT.601 and BT.709 video color profiles as static data to
Blink Platform. The data was extracted from the golden files
in issue 570150 entries #24 and #25 with a script [1].

This data will be used in subsequent changes so no change in
behavior, no new tests.

[1] #!/bin/bash -v
# create an array from static data
(echo "const unsigned char data[] = {"; od -txC -v $1 | \
 sed -e "s/^[0-9]*//" -e s"/ \([0-9a-f][0-9a-f]\)/0x\1,/g" \
   -e "\$d" | sed -e"\$s/,$/};/") > data.c
cat data.c

BUG=570150

Review URL: https://codereview.chromium.org/1645443002

Cr-Commit-Position: refs/heads/master@{#371978}

BUG=540864

Review URL: https://codereview.chromium.org/1647653003

Cr-Commit-Position: refs/heads/master@{#371977}

This bug was exposed in https://codereview.chromium.org/1611783002

BUG=581909

Review URL: https://codereview.chromium.org/1643833002

Cr-Commit-Position: refs/heads/master@{#371976}

The old tests simply hardcoded various size strings.  This was brittle against
changes, and did not work correctly in material design.

The new tests basically compute the important aspects of various bounds, without
simply calling into the real OBFVL positioning functions (which would make the
tests vacuous).  These are sufficiently parameterized to handle not only
material design but a variety of other state changes (maximized vs. restored,
hidden caption buttons, caption buttons on left, etc.).  This unfortunately
results in fairly complicated math, but frame positioning is complex, so there's
not much for it.

Many of these states were tested in sort of a one-off fashion, but the tests
have now been expanded to run a significantly more complete set of tests, in
particular testing just about everything in both restored and maximized mode.

As part of this rewrite, the tests now make use of some of the constants from
opaque_browser_frame_view_layout.cc, which have been exposed in the header for
this purpose.  Along the way, some of these were simplified a bit when we had
several constants that had the same value and served similar purposes.

BUG=575257
TEST=Unittests pass even with --top-chrome-md=material[-hybrid]

Review URL: https://codereview.chromium.org/1643453002

Cr-Commit-Position: refs/heads/master@{#371975}

BUG=581807

Review URL: https://codereview.chromium.org/1646703002

Cr-Commit-Position: refs/heads/master@{#371974}

BUG=581753
TEST=manual

Review URL: https://codereview.chromium.org/1646543002

Cr-Commit-Position: refs/heads/master@{#371973}

BUG=574938
TEST=PaintLayerPaintTest.PaintPhaseFloat

Review URL: https://codereview.chromium.org/1581593003

Cr-Commit-Position: refs/heads/master@{#371972}

Nothing uses these on Mac.

They're used a lot on ChromeOS. On Windows, it shows a default browser
selection dialog. On Linux it shows the certificate viewer. On Mac I
think it was once used for a webui task manager.

BUG=None

Review URL: https://codereview.chromium.org/1640043002

Cr-Commit-Position: refs/heads/master@{#371971}

Unconditionally requesting the browser's toolbar view causes a null deref.  Try
to guard by checking if the toolbar is visible first.  This should fix the crash
unless at this point the toolbar feature is turned on but the toolbar view
itself has not been created.  Hopefully that's not the case.

BUG=581673
TEST=none
TBR=sky

Review URL: https://codereview.chromium.org/1649493003

Cr-Commit-Position: refs/heads/master@{#371970}

BUG=575234,578828
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1629013002

Cr-Commit-Position: refs/heads/master@{#371969}

For extended desktop (non mirrored) layouts, |displays_| should only
provide input parameters to the UI. Iteration over display layouts
should occur in DisplayLayoutManager. This is necessary to support
fake display layouts for testing (and provides a cleaner abstraction
in general).

This also fixes a couple of bugs related to changing the number of displays introduced in other recent re-factoring.

BUG=576375

Review URL: https://codereview.chromium.org/1648493002

Cr-Commit-Position: refs/heads/master@{#371968}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/497b8970..e85d78f6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1641793005

Cr-Commit-Position: refs/heads/master@{#371967}

Otherwise, ACK buffer will buildup in BlimpMessageOutputBuffer.

Review URL: https://codereview.chromium.org/1643813002

Cr-Commit-Position: refs/heads/master@{#371966}

This change alters SdkMediaCodecBridgeTest.DoNormal in
order to not have it assume that the AudioOutput will
get dequeued in three batches. While this is the maximum
number, some devices batch output (e.g. MT 8127 and MT 8135
chipsets), thus reducing the total number of dequeues required.

Since we also know the expected size of the output, this
test now also verifies the full expected output stream
has been dequeued.

BUG=578881

Review URL: https://codereview.chromium.org/1601863002

Cr-Commit-Position: refs/heads/master@{#371965}