- 16 Aug, 2018 40 commits
-
-
Chris Lu authored
Removes the date for sync times that occur within the same calendar day. Replaces date with "Yesterday" for sync times that occur in the previous calendar day. Screenshot: https://drive.google.com/open?id=1uFZHxOgHytaARm97MWONgekuymVxRBvJ, https://drive.google.com/open?id=1ZZr5HR___1y_CuQKcoNP-5Umd2Lz5K3n Bug: 870043 Change-Id: Id6d4ecb424d5e709e66e48cd57d0c4add5683b1c Reviewed-on: https://chromium-review.googlesource.com/1177891Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#583871}
-
Kent Tamura authored
A FileSelectHelper instance handles at most one directory enumeration during its lifetime. - FileSelectHelper doesn't need to have |std::map<int, ActiveDirectoryEnumeration*>|. One |std::unique_ptr< ActiveDirectoryEnumeration>| and one |int request_id_| are enough. - We don't need DirectoryListerDispatchDelegate. FileSelectHelper implements net::DirectoryLister::DirectoryListerDelegate. This CL has no behavior changes. This CL is a preparation to mojoify FileChooser IPC. Bug: 869257 Change-Id: I19ecfbb49b54c2430f7f0358ca787e831c493e29 Reviewed-on: https://chromium-review.googlesource.com/1177082 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#583870}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f956badf3dd2..d5e282648a08 git log f956badf3dd2..d5e282648a08 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 tsepez@chromium.org Remove optional bool bType from GetFillArgb() 2018-08-16 tsepez@chromium.org Replace optional bool bNotify with enum type. 2018-08-16 tsepez@chromium.org Remove default arg from CFX_BinaryBuf::EstimateSize(). 2018-08-16 hnakashima@chromium.org Allow PDF417 barcodes to reduce modules by shaving off padding. 2018-08-16 hnakashima@chromium.org If rows need to overflow in a PDF417 barcode, keep it to a minimum. Created with: gclient setdep -r src/third_party/pdfium@d5e282648a08 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7f2d03150bdcb0883ecdbb8ca18f84cba538ee2e Reviewed-on: https://chromium-review.googlesource.com/1178902Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583869}
-
Zhongyi Shi authored
Migrate back to the default network after handshake has been confirmed and the connection is originally created on the non-default network. Bug: 790547 Change-Id: Ia991d49e5c8197fca0a98224239e1bc412ca9005 Reviewed-on: https://chromium-review.googlesource.com/1176656 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#583868}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/efb38bb3d729..95fb6dc81034 git log efb38bb3d729..95fb6dc81034 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 vadimsh@chromium.org [cipd] Check CIPD client hash during updates on Windows. Created with: gclient setdep -r src/third_party/depot_tools@95fb6dc81034 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:870166 TBR=agable@chromium.org Change-Id: Ie559e2b70ec74632248a8cefe5d7646d471fd1bf Reviewed-on: https://chromium-review.googlesource.com/1178542Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583867}
-
Lei Zhang authored
- Use a ThreadChecker member instead of inheriting from ThreadChecker. - Switch from a leaky Singleton to base::NoDestructor. Change-Id: I86f8f50f7776ceefa62ab3586314c5af3bacf7e7 Reviewed-on: https://chromium-review.googlesource.com/1178468Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583866}
-
Ted Choc authored
BUG=873593 Change-Id: Ia8cf2340978bac68730a642e74977eac290edc16 Reviewed-on: https://chromium-review.googlesource.com/1178745Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#583865}
-
Marijn Kruisselbrink authored
Not hooked up yet, but implements the mojo interface in terms of the old implementation. Bug: 872460 Change-Id: Id33e4a8f732f4bda0a2ad866e85e210962b45a05 Reviewed-on: https://chromium-review.googlesource.com/1171518Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#583864}
-
David Black authored
Previously, Assistant cards (WebViews) would consume any event that they processed. This prevented our container from scrolling effectively, because scroll gestures would be consumed. Now, we prevent the WebView from receiving anything other than mouse click related events. We need to give it those events because Assistant cards contain links. To also support link taps via gesture, we need to route taps back to the WebView's manually. We do this by converting tap gestures into mouse events. Bug: b:110039692 Change-Id: Id0d44af0651490ddf58b6e0e0c70c41fec3fa654 Reviewed-on: https://chromium-review.googlesource.com/1174961 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#583863}
-
Kim Paulhamus authored
Bug: 678885 Change-Id: If95f75082e1ad44be008540aa93b59ec1f687cf8 Reviewed-on: https://chromium-review.googlesource.com/1176736Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#583862}
-
Paul Irish authored
Bug: 874982 Change-Id: I463cd1a8ea61407501732425a8dcb6363010bb87 Reviewed-on: https://chromium-review.googlesource.com/1178401 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Patrick Hulce <phulce@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#583861}
-
Greg Thompson authored
The data pointed to by a PE image's debug directory entries need not be contained in the sections that are mapped into memory. In such cases, the AddressOfRawData field of the debug directory entry is null. GetDebugId now handles this by skipping over such entries in its search for debug info. Additionally, PEImage::GetDebugId now returns the string length of the pdb_filename, with proper bounds checking. (Note: StringPiece would have been a nice fit, but pe_image.{cc,h} does not depend on other parts of base.) This change also adds some extra sanity checking to GetImageDirectoryEntrySize and GetImageDirectoryEntryAddr so that they return 0/null in case the desired directory entry is not present in the image. This should never be the case for well-formed images, but we should be cautious regardless. BUG=874044 R=brucedawson@chromium.org TBR=jwd@chromium.org,alph@chromium.org,hjd@chromium.org Change-Id: I45f8024054c0e3a998dd46bf1d4e9db345138865 Reviewed-on: https://chromium-review.googlesource.com/1175705 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#583860}
-
Matthew Jones authored
This reverts commit 0cdc1458. Reason for revert: Breaks ToastHWATest* on Marshmallow 64 bit Tester: [FATAL:persistent_histogram_allocator.cc(893)] Check failed: !subtle::NoBarrier_Load(&g_histogram_allocator). https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester/23305 Original change's description: > metrics: Initialize persistent metric allocator early. > > The PersistentMemoryAllocator in the gpu (and other) process is created > asynchronously. If any uma-histogram is reported before that time, then > those Histograms are not stored in the shared memory. This has some > implications: > . If the process crashes (which is common for the gpu process on > android), then these metrics are lost. > . If the process stays alive, then the metrics are reported > periodically, but because it is buffered, it doesn't match up > correctly with the other metrics that are reported in the shared > memory. > > The allocator is created in response to a message from the browser, > which includes the handle for the shared memory to use for the allocator. > The browser waits until the process has been launched and connected. > So this happens much later, compared to other messages which are sent > from browser over mojo without waiting for the connection to have > been established first. Therefore, change this so that the browser > immediately shares the shared-memory segment with the gpu process. mojo > takes care of waiting for the process-launch etc. > > BUG=865179, 778749 > > Change-Id: Iccd3d4422de3e22ead4bc6510afc5ea207bf6b6e > Reviewed-on: https://chromium-review.googlesource.com/1174709 > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583673} TBR=avi@chromium.org,sadrul@chromium.org,bcwhite@chromium.org Change-Id: I65e9ad62e6613d0eaf08e834def5a988a60c4a19 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865179, 778749 Reviewed-on: https://chromium-review.googlesource.com/1179041Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#583859}
-
Daniel Zhang authored
More testing of autocomplete behavior is needed. Placing AppList autocomplete behind a flag and updating tests to reflect this. Bug: 874133 Change-Id: I35f78089045efc65da3a4f524d7e0b613b854705 Reviewed-on: https://chromium-review.googlesource.com/1178577Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Commit-Position: refs/heads/master@{#583858}
-
Xi Cheng authored
Bug: 851163 Change-Id: Ic2d0c573867b9c1e08e52febcd5211afe08c9e84 Reviewed-on: https://chromium-review.googlesource.com/1178758Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#583857}
-
John Budorick authored
This reverts commit 99255887. Reason for revert: added more machines, going to try out warm caching Original change's description: > cr-buildbucket-dev: use auto_builder_dimension for luci.chromium.ci. > > Bug: 868525 > Change-Id: I65aabb60d4823423d7f0bd4d5b51ea145c665658 > Reviewed-on: https://chromium-review.googlesource.com/1176471 > Reviewed-by: Nodir Turakulov <nodir@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583450} TBR=nodir@chromium.org,jbudorick@chromium.org Change-Id: If807d179cf51089c8332a627ae4d2de78468e79a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868525 Reviewed-on: https://chromium-review.googlesource.com/1178993Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#583856}
-
Ned Nguyen authored
This reverts commit 520ce5d7. Reason for revert: breaking blink_perf.image_decoder/* tests BUG:chromium:874810 Original change's description: > Hold pre-decoded images until use or 250ms rather than 2 frames > > We currently unlock pre-decoded images after 2 frames of any type. This > doesn't always give callers a chance to use their images (if main thread > is a bit backed up). Instead we should wait for the caller to actually > use the image. Additionally, we drop images after 250ms to prevent > excessive growth if a user fails to use images in a timely manner. > > See the linked bug for example traces which show the benefits. > > R=khushalsagar > > Bug: 869491 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Icd94709aad5c076b1ba295495eaab24dc893ebdb > Reviewed-on: https://chromium-review.googlesource.com/1159203 > Commit-Queue: Eric Karl <ericrk@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583171} TBR=khushalsagar@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869491 Change-Id: Ia80ab26563bf1ccc0556d5638a483337acee972d Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1178841Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#583855}
-
Jacob Dufault authored
Caused by uninitialized memory so the color would be random. Change-Id: I49a306a426d723f2f75283b973c1b91e105f12c5 Reviewed-on: https://chromium-review.googlesource.com/1178896Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#583854}
-
Balazs Engedy authored
Screenshots for strings will be uploaded in a follow-up CL. This CL also improves the naming of some string constants, as well as deduplicates the two USB activation sheets (register/sign) into just one. Bug: 849323 Change-Id: I37709d65c6fe980dff18d1b98d070a66f4d90115 TBR: jcivelli@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1178285Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583853}
-
Dirk Pranke authored
When we added LASTCHANGE.committime in r583420, we missed a case where we might not write it in the hook, and in that situation the build would fail due to the file being missing. TBR=thakis@chromium.org BUG=875039 Change-Id: I5c596f55fe90bc5f5175c74ba27e218f108f843b Reviewed-on: https://chromium-review.googlesource.com/1178892Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#583852}
-
John Chen authored
Currently, GetElementRect command expects all returned values (x, y, width, height) to be integers, but in reality they can be non-integer numbers. This CL fixes the implementation, and improves error messages. Bug: chromedriver:2545 Change-Id: I8c01f0d7f3de530e5e54b7e698a5583b050b68a3 Reviewed-on: https://chromium-review.googlesource.com/1178759Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583851}
-
Steven Bennetts authored
ShellDelegate::PreInit is now only used by WindowTreeHostManagerStartupTest.Startup which can effectively be tested by other means. Bug: 705713 Change-Id: Ieaa394db7603ab14ccaa79059303aff4011af5d0 Reviewed-on: https://chromium-review.googlesource.com/1169432 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#583850}
-
Ben Kelly authored
This reverts commit 74fd352e. Reason for revert: Moving behind experimental feature flag until web compat can be assessed. Original change's description: > Cache Storage: Check for duplicate entries in Cache.addAll(). > > This implements step 4.2.3 of the BatchCacheOperations algorithm: > > https://w3c.github.io/ServiceWorker/#batch-cache-operations-algorithm > > Bug: 720919 > Change-Id: I679f786441b813ed816a183522021c417f4ab7b8 > Reviewed-on: https://chromium-review.googlesource.com/1162362 > Commit-Queue: Ben Kelly <wanderview@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582738} TBR=jsbell@chromium.org,kinuko@chromium.org,pwnall@chromium.org,wanderview@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 720919 Change-Id: I08736e4ec638a65c48f329966f378698a6d9b045 Reviewed-on: https://chromium-review.googlesource.com/1178502Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#583849}
-
Fabio Tirelo authored
Bug: 874094 Change-Id: I246b33a817bb87357acb9b9426add41323cb2711 Reviewed-on: https://chromium-review.googlesource.com/1178748Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#583848}
-
Christian Fremerey authored
Adds a new secondary base::Feature for controlling whether or not the video capture service is enabled. This gets enabled by default and serves as a kill switch for groups of devices that force the primary switch enabled via command-line argument. Design Doc: https://docs.google.com/document/d/1n9I_DfuNGIA7PUWHOX2O2HVnI1d87q7W7lNTqVZkm0Y/edit?usp=sharing Bug: 870819 Change-Id: Idd861e838f12a72b54e1140bc3fc613ee5b53018 Reviewed-on: https://chromium-review.googlesource.com/1168001 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#583847}
-
Matt Menke authored
Looks the CookieStore isn't flushed on browser exit, by default. BUG=847555 Change-Id: I2596f8ea3d62a5d5e71e0514ba8e7caa6049605d Reviewed-on: https://chromium-review.googlesource.com/1178803 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#583846}
-
Torne (Richard Coles) authored
Android apps must declare the android.software.leanback feature to indicate that they are compatible with Android TV (and can specify required="false" to indicate that they are also compatible with non-TV devices). Declare this for WebView, which is used on TV devices. https://developer.android.com/training/tv/start/start#leanback-req describes this requirement in detail. Silence the MissingLeanbackLauncher lint warning; WebView doesn't have a launcher on non-TVs either, so this is expected. Bug: 870010 Change-Id: Id07ecf06f50d1247639e4e32ea0128d68376a633 Reviewed-on: https://chromium-review.googlesource.com/1178801 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583845}
-
kylechar authored
1. Call reset() instead of assigning nullptr for scoped_refptrs. 2. Don't reset |worker_context_provider_| if |main_context_provider_| fails to get created. Bug: 791660 Change-Id: Ib9610981ed165b220ae2129a2ebd11e52464f693 Reviewed-on: https://chromium-review.googlesource.com/1176343 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583844}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia1199785d91120d49c08e46c85e0bc730709ee3d Reviewed-on: https://chromium-review.googlesource.com/1178884 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583843}
-
Jacob Dufault authored
By merging the two separate methods, the control flow is simplified, which will help prevent any possible animation glitches if, for example, both PIN and public session are animating at the same time. Bug: 873328 Change-Id: Ia3faa9d60aba91996804fc1ee3f64030467a4a1a Reviewed-on: https://chromium-review.googlesource.com/1173393 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#583842}
-
Scott Little authored
This CL implements support for the "lazyload" attribute on frames, according to https://github.com/whatwg/html/pull/3752, and as part of the LazyLoad feature. The accepted values are: "on", which causes the browser to lazily load a frame even if it's same-origin or nested inside another lazyloaded frame, "off", which causes the browser to avoid lazily loading this frame or any of it's children (unless those children are marked with lazyload="on"), "auto", which activates the default behavior, and is therefore not explicitly handled in code. Bug: 873358 Change-Id: I2fde65adb15216260291b08e39888a2363f44d4a Reviewed-on: https://chromium-review.googlesource.com/1176293 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#583841}
-
Xiaocheng Hu authored
Bug: 699017 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I88f9753576e67f1ed5ff4f6ca8fbf52cac4bcda2 Reviewed-on: https://chromium-review.googlesource.com/1178755 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#583840}
-
Kyle Horimoto authored
This allows the settings page to request that multi-device features be enabled or disabled via clicks on a toggle. Bug: 824568 Change-Id: I7edf3991036d5119a1bed8cf67f82b2138594b13 Reviewed-on: https://chromium-review.googlesource.com/1176870 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#583839}
-
Adrienne Walker authored
The renderer doesn't use these flags, so this is just a temporary mechanism for crash visibility. Right now there are some number of crashes that are happening on platforms where OOP-R is not turned on (e.g. Windows), and it would be helpful to verify in the short term that OOP-R is being turned on deliberately via a command line flag vs accidentally. These should be removed once OOP-R is shipping by default everywhere. Bug: 757605 Change-Id: Ib5a1a1d49939851b71563762409ac0fc0ba05ede Reviewed-on: https://chromium-review.googlesource.com/1178570Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#583838}
-
siyua authored
After this change, the offer-dialog should be properly shown if a user clicks the continue button in the migration bubble. 1) Made changes related to Autofill Client and wires things up. 2) Changed method names of showing local card migration bubble from ShowLocalCardMigrationMainPrompt to ShowLocalCardMigrationDialog. The flow will be enabled only on desktops for now. Bug: 852904 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id5ee55156eb1e8615e955716836cfecd677ff456 Reviewed-on: https://chromium-review.googlesource.com/1173551Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#583837}
-
Timothy Gu authored
The removed test fast/loader/document-destruction-within-unload.html was originally added in 8809405d, to make sure that a document.write() call that blows away the current page still works in unload event listeners and blocks any current attempt to navigate. Since we no longer allow that to happen, the test is obsolete. In fact, it can be seen as contradictory to external/wpt/html/browsers/browsing-the-web/unloading-documents/005.html, which tests that document.open() in an unload event doesn't block navigation. Bug: 583586, 866274 Change-Id: I99b35dd28c97e8603455805b31d49644bc7b23a5 Reviewed-on: https://chromium-review.googlesource.com/1169320 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#583836}
-
Robbie McElrath authored
This migrates NetworkStatusListenerImpl from using net::NetworkChangeNotifier to content::NetworkConnectionTracker, which works with the network service enabled. Bug: 868011 Change-Id: I98d8644c128174b7b887c76dc40ad2725f052182 Reviewed-on: https://chromium-review.googlesource.com/1161200Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#583835}
-
inglorion authored
This test was re-enabled in crrev.com/c/1110151, but creates noise on the bots because it is flaky. Disabling it for now to stop the noise. Bug: 873792 Change-Id: I4c136a36d916bc8096ebba6d8d5839dea22533cf Reviewed-on: https://chromium-review.googlesource.com/1173406Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#583834}
-
BUG=762641 TBR=michaelpg@google.com Change-Id: I67360a75937b38fde2a636e6c759949ffb84cf97 Reviewed-on: https://chromium-review.googlesource.com/1178756Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583833}
-
Eric Willigers authored
FeaturePolicyForPermissions has been retired from runtime enabled features. We don't need to mention it in VirtualTestSuites. BUG=788390 Change-Id: I22e05513852fcc17c2eea514fd5c54b3c0051b37 Reviewed-on: https://chromium-review.googlesource.com/1176882Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#583832}
-