- 03 Jan, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7e4c1e7ba062..8ce9f47088e8 Created with: gclient setdep -r src-internal@8ce9f47088e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Idc4641e4cace9f61b45a611379f9acfe35419e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986196Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728125}
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on both HALv1 and v3 devices. Change-Id: I05c044164fabdd021c2a6f17ba2ab853fd2ebddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985629 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#728124}
-
dalyk authored
These histograms are still being used in an experiment. Bug: 985589 Change-Id: Idbdf42e0f44c531ce65dab93d27751fd216fc169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984659Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#728123}
-
tby authored
Bug: 1025834 Change-Id: I606153536d44c2dacbb73d8b8984bb45d1b22096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983107Reviewed-by:
-
Toni Barzic authored
The animating background is shown during hotseat animation, and might cause double blur (for example, navigation control, or hotseat blur might be active at the same time). BUG=1034045 Change-Id: I9ef8e06cdcd2b9662ba91eb4728ac4f1cef4f19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986328Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#728121}
-
Leon Han authored
NDEFMessageInit#records is the only field of the dictionary NDEFMessageInit, it's required, and being empty makes no sense for constructing an NDEFMessage object. BUG=520391 Change-Id: I87fd3fae3bbbba449d9068c0992ded2080e435b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983435 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#728120}
-
Ben Wells authored
Bug: 1037086, 1037088, 1037100 Change-Id: Ifc40ca7a3b96668501f3befdbb022826f7ed6a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985624Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#728119}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6c428fce..2de68515 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifda32981e957a627c126bcb3c0406416221d01d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986128Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728118}
-
sangwoo authored
ViewModelBase::entries() was introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1954988 . This CL is a follow-up for it. Bug: 982579 Change-Id: Ie5bb541ba9baa8e6af415efae2aa7e4d53f077c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959226Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#728117}
-
Dan Beam authored
Screenshot: https://crbug.com/719764#c17 Bug: 719764 Change-Id: I1a25b71da5165946a37de5c7366fd7c1465fbf90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963147 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#728116}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79df1292b2aa..7e4c1e7ba062 Created with: gclient setdep -r src-internal@7e4c1e7ba062 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6b68385d9f03faf7e49d58af5439b94827e7c5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986193Reviewed-by:
-
Leon Han authored
The spec issue and PR: https://github.com/w3c/web-nfc/issues/497 https://github.com/w3c/web-nfc/pull/498 BUG=520391 Change-Id: Ie6e3af86f0441bad03b7454b3b7285c6824d34fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983433 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1bc1181e9d9d..5f98f046f97c git log 1bc1181e9d9d..5f98f046f97c --date=short --first-parent --format='%ad %ae %s' 2020-01-03 chonggu@google.com [Telemetry] Add Fuchsia backend support Created with: gclient setdep -r src/third_party/catapult@5f98f046f97c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1014642 Tbr: sadrul@google.com Change-Id: Ic4c8bdc2216a5e11c420e72cda421e1949c4a3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986195Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728113}
-
Andrew Grieve authored
The source paths for these should point at the .aar file rather than the extracted location of its contents. Bug: 978310 Change-Id: Id3447a96589bce079b7351304a3e2098b33e8f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984820 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#728112}
-
Evan Stade authored
This was added at a time when there was interest in exploring more animated transitions between icon states, but never had a client that wasn't gated on a feature flag, and currently is dead code. Bug: 718549 Change-Id: Idaf4667930e68feac92daafcab7c5778355546ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986109 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Dan Beam authored
Fixed: 988634 Change-Id: Iff0038305fabb7d835dc8454c14af99e754710d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949644 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
This code is basically lifted from LayoutFlexibleBox::RemoveChild. Bug: 845235 Change-Id: Icdda90143d896cb9678cab3cde1bfc4554471701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982619Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#728109}
-
Devlin Cronin authored
Some histograms are useful for the indefinite future. Mark the following as never expiring: Extensions.InstallSource Extensions.Events.DispatchWithSuspendedEventPage Extensions.Events.DispatchWithRunningEventPage Extensions.Events.DispatchWithPersistentBackgroundPage Extensions.Events.Dispatch Extensions.EventPageActiveTime2 Extensions.EventPageLoadTime2 Extensions.UninstallSource Bug: 1037101, 1037091, 1037090, 1037106 Change-Id: Ie160a546a989655ea9adfa706b198043feeb078a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981142Reviewed-by:
-
Kurt Horimoto authored
OverlayDispatchCallbacks were previously a typedef of base::RepeatingCalback that was stored in OverlayDispatchCallbackStorage, which used a templatized API in order to ensure that the provided callbacks were only ever executed with a specific type of OverlayResponse. This added additional complexity that could not be hidden because C++ class templates need to be defined entirely within header files since they are not linked. This CL instead defines an OverlayDispatchCallback class that allows for the specification of a subset of allowed OverlayResponses, removing the need for a templatized storage class. Bug: none Change-Id: Ia7bbc2dc90ebf8941e12126104b076a98a6feffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984177 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#728107}
-
Devlin Cronin authored
ExtensionIdList is typedef'd to a std::vector<ExtensionId>. Move the declaration from extension.h to extension_id.h, where the ExtensionId typedef is. Bug: 1038392 Change-Id: I0007ffe8fad399d9c66c33c3c7b38fe2ce9fec4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983590Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#728106}
-
Doug Arnett authored
Previews.Triggered.EffectiveConnectionType2* Previews.CacheControlNoTransform.BlockedPreview* Bug: 1037205,1037208 Change-Id: I70711cdc7ecb1cc87c4e7d85c914bd5743bc572b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984818 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#728105}
-
kylechar authored
We no longer need to support the case where VizDisplayCompositor is disabled. Bug: 936425 Change-Id: I7118a44740959a4fed14a8f4befebe295762d2a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985815 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#728104}
-
Eric Karl authored
This is a reland of 6adf67f0 The reland addresses two issues: - AHB test was not setting representation to cleared after clearing it. - AHB backing was not marking itself as cleared when performing initial data upload. Original change's description: > Prevent access to uninitialized SharedImages > > This CL prevents read access to uninitialized SharedImages. For cases > where read/write access is reqeusted, the CL requires that the caller > specifically request uninitialized access if required. > > Bug: 1003686 > Change-Id: I52230217cd7f17e0cd9d4a82036ae6c72d3b1ea2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974630 > Commit-Queue: Eric Karl <ericrk@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727827} Bug: 1003686 Change-Id: Iae7748a768b654f8585c139a02cd32d3bfea8790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985128Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#728103}
-
Rachel Wong authored
Change-Id: I2be2d444af6fa2256035b55be77fa1ca9d36724f Bug: 1036928 Bug: 1036929 Bug: 1036927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980668 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
-
Azeem Arshad authored
This CL removes FTP proxy fields from manual proxy configuration UI. FTP over HTTP proxy is no longer supported. Bug: 1032168 Change-Id: I524cc2f34af8c21bdfa04d389b65fefa29732066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984715Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#728101}
-
Theresa Wellington authored
Remove Android.Activity.ChromeTabbedActivity.StopReason and Android.Activity.ChromeTabbedActivity.SystemBackAction as they are not currently being used. BUG=1034564,1036909 Change-Id: Iba79048bd9b3096640c7df2446860ae38c1b7ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982586Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#728100}
-
Joey Arhar authored
These tests will run on Android, which will give us test coverage of the form controls refresh on android, and add coverage to the untested NativeThemeAndroid and WebThemeEngineAndroid classes. Original patch: http://crrev.com/c/1940880 Revert: http://crrev.com/c/1968769 TBR=avi@chromium.org Bug: 1029102 Change-Id: I74ce99782bc0e2f813e2567d447960f495715c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969772 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#728099}
-
James Cook authored
SplitSettings has been on-by-default since M78. The flag has already been removed, so delete this utility function as well. Bug: 1026455 Change-Id: I579ccc6b2362271b91cab2bcdb0d3b2deb60ad1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985818Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#728098}
-
Karan Bhatia authored
Extend the expiry of - Extensions.WebRequestCount - Extensions.WebRequestBlockingCount to end of 2020. These will be useful to monitor how the usage of the web request api changes going forward. BUG=1037108, 1037107 Change-Id: I69f51e77c4aafb531dd2c26c0053e0bbdcf18ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983263 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
WTF::String (and the underlying StringImpl) is tied to a particular platform thread as opposed to a sequence. As such it is not safe to own one on a SequencedTaskRunner. So change to using a SingleThreadTaskRunner for background work instead. Bug: 1038444 Change-Id: If4391d476ab181a7adeefcf734d96a1802a28626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986210Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#728096}
-
Andrew Grieve authored
Eliminates the need to manually run "grit update_resource_ids" Bug: 979886 Change-Id: Ifa89368bfe6f8ba36750536a42d2a308c2555604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980793 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#728095}
-
Ben Wells authored
This change adds consistent owners and expiry for all the Crostini metrics. Bug: 1037009, 1037010 Change-Id: I97ff20e010eb770969c2c042a23728344c5cb9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985622Reviewed-by:
-
Dana Fried authored
This is the cause of the attached bug. Animations in the toolbar mean that some buttons which are being hidden are visible briefly as they fade out, which previously created the situation that some tests which closed the browser window while the fade-out animation was happening would fail. This solves the problem by having a default tooltip during fade-out. Bug: 1038567 Change-Id: Ia24f3493e8b5d062b5ab67e2a8950e2fcf58b49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985171 Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728093}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2eca5b1e..6c428fce Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I551d63519f219b5143789d9b8f6b43e528dafb85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986127Reviewed-by:
-
Simon Pelchat authored
Bug: 1038769 Change-Id: I2a53fcddd9c64eb949b08ac3c4e563192be702eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986254 Commit-Queue: Simon Pelchat <spelchat@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: Simon Pelchat <spelchat@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#728091}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7c4300cb193f..1bc1181e9d9d git log 7c4300cb193f..1bc1181e9d9d --date=short --first-parent --format='%ad %ae %s' 2020-01-02 behdadb@chromium.org Revert "Reland "Reland "[Telemetry] Make proto trace format the default""" Created with: gclient setdep -r src/third_party/catapult@1bc1181e9d9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1028612 Tbr: sadrul@google.com Change-Id: If421275978752def2a310e074ee4859b235fd101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986177Reviewed-by:
-
Kurt Horimoto authored
This CL creates OverlayResponseSupport, which allows objects to specify support for a subset of OverlayResponse types. This will allow for the removal of OverlayDispatchCallbackStorage, which uses templated container objects to associate callbacks with their required response info types. Support for a variety of responses can be specified by constructing OverlayResponseSupports with a vector of support instances to aggregate. OverlayRequestSupport was also updated to use a similar constructor for consistency, and AggregateOverlayRequestSupport was deleted. This CL also adds OverlayResponseInfo, a template to be specialized for OverlayUserData used to configure OverlayResponses. This template declares a static ResponseSupport() that returns a support for responses created with that info type. Bug: none Change-Id: I7d1cd13f9a05511c3dc95739055347284e7f7060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984464 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
The arguments that the run_performance_tests.py script does not recognize are by default passed through to the Telemetry executable. Now that we have gtest on the same shard, those passthrough arguments are confusing the gtest perf tests. Example: https://chrome-isolated.appspot.com/browse?namespace=default-gzip&digest=0e33146297150a5de344790520644a01710927c7&as=benchmark_log.txt is broken because of the added arguments -v --browser=android-chromium --upload-results --assert-gpu-compositing . For Gtest you can instead add flags to the shard itself. In the future, we should figure out how to put the passthrough arguments onto the shard map for Telemetry as well, but for now this will fix the immediate problem. Bug: 921353 Change-Id: Ie5d853aa402fc84e21a4f2f3cf180cb150f7e428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981100 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#728088}
-
Theresa Wellington authored
Move some classes out of widgets and into more feature-specific packages: - prefeditor/ is used for autofill/payments pref/profile editing and has depenencies on the autofill package, so it moved to org.chromium.chrome.browser.autofill.prefeditor. - tile/ is used for most visited tiles on the NTP and explore sites and moved to org.chromium.chrome.browser.suggestions.tile. Most of the tile code already lived in this package. - RoundedIconGenerator is used to create fallbacks when a favicon/site icon is not available. It moved to org.chromium.chrome.browser.favicon. BUG=951455,1010192,1010196 Change-Id: I038707fe908a42cd8b15aa06bfdde355b0dc0474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986225Reviewed-by:
-
David Bertoni authored
When the Web Request API was moved to the UI thread, there was a fair amount clean up to do be done. This CL cleans up a bit more. Bug: 980774 Change-Id: I6a4ab52eda0508aa14c677a6fd5fddc393d3e570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982687Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#728086}
-
